dmaengine: owl-dma: Add missing IRQ check in owl_dma_probe
Subsystems (2)
PATCH 1/1 dmaengine: owl-dma: Add missing IRQ check in owl_dma_probe
This func misses checking for platform_get_irq()'s call and may passes the negative error codes to request_threaded_irq(), which takes unsigned IRQ #, causing it to fail with -EINVAL, overriding an original error code. Stop calling request_threaded_irq() with invalid IRQ #s.
Fixes 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/dma/owl-dma.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/dma/owl-dma.c +5 -0
@@ -1160,6 +1160,11 @@ static int owl_dma_probe(struct platform_device *pdev)* simplification. */ od->irq =platform_get_irq (pdev,0 ); +if (od->irq <0 ) { +dev_err (&pdev->dev,"unable to get IRQ\n" ); +return od->irq; + } + ret =devm_request_irq (&pdev->dev, od->irq, owl_dma_interrupt,0 ,dev_name (&pdev->dev), od);if (ret) {
Signature · 1 line
2.17.1