Skip to contentSkip to conversation

ARM: dts: stm32: Add USB OTG pinctrl and regulator nodes into SPL DT on DHCOR

PATCH In review Marek Vasut 2 participants 5 messages Jan 28, 2022 – Mar 15, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Add USB OTG pinctrl and regulator nodes into SPL DT on DHCOR

Fix the following warning in SPL and make sure that even DTs which enforce Vbus detection using u-boot,force-vbus-detection;, the DFU in SPL will work.

dwc2-udc-otg usb-otg@49000000: prop pinctrl-0 index 0 invalid phandle

Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
---
 arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +8 -0
index 71375510b4a..ff9ca625bf5 100644
@@ -171,6 +171,14 @@
 	u-boot,dm-spl;
 };
 
+&usb33 {
+	u-boot,dm-spl;
+};
+
+&usbotg_hs_pins_a {
+	u-boot,dm-spl;
+};
+
 &usbotg_hs {
 	u-boot,dm-spl;
 };
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Marek

Quoted 22 lines · Marek Vasut

Fix the following warning in SPL and make sure that even DTs which enforce Vbus detection using u-boot,force-vbus-detection;, the DFU in SPL will work.

dwc2-udc-otg usb-otg@49000000: prop pinctrl-0 index 0 invalid phandle

Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
---
 arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +1 -0
index 71375510b4a..ff9ca625bf5 100644
@@ -171,6 +171,14 @@
 	u-boot,dm-spl;
 };
 
+&usb33 {

arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi line 184

Quoted 10 lines
arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +7 -0
+	u-boot,dm-spl;
+};
+
+&usbotg_hs_pins_a {
+	u-boot,dm-spl;
+};
+
 &usbotg_hs {
 	u-boot,dm-spl;
 };

Thanks
Patrice

#2 lore raw
Quoted 1 line · Patrice CHOTARD

Hi Marek

Hi,

Quoted 22 lines · Marek Vasut
Quoted 21 lines

Fix the following warning in SPL and make sure that even DTs which enforce Vbus detection using u-boot,force-vbus-detection;, the DFU in SPL will work.

dwc2-udc-otg usb-otg@49000000: prop pinctrl-0 index 0 invalid phandle

Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
---
  arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 8 ++++++++
  1 file changed, 8 insertions(+)
arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +0 -0
index 71375510b4a..ff9ca625bf5 100644
@@ -171,6 +171,14 @@
  	u-boot,dm-spl;
  };
 
Quoted 12 lines

arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi line 184

Quoted 11 lines
arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +8 -0
+&usb33 {
+	u-boot,dm-spl;
+};
+
+&usbotg_hs_pins_a {
+	u-boot,dm-spl;
+};
+
  &usbotg_hs {
  	u-boot,dm-spl;
  };

This seems to have been missed and should be part of this upcoming release.

#3 lore raw
In reply to Patrice CHOTARD

Hi Marek

Quoted 37 lines · Patrice CHOTARD

Hi Marek

Quoted 22 lines · Marek Vasut

Fix the following warning in SPL and make sure that even DTs which enforce Vbus detection using u-boot,force-vbus-detection;, the DFU in SPL will work.

dwc2-udc-otg usb-otg@49000000: prop pinctrl-0 index 0 invalid phandle

Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
---
 arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +1 -0
index 71375510b4a..ff9ca625bf5 100644
@@ -171,6 +171,14 @@
 	u-boot,dm-spl;
 };
 
+&usb33 {

arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi line 184

Quoted 10 lines
arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +7 -0
+	u-boot,dm-spl;
+};
+
+&usbotg_hs_pins_a {
+	u-boot,dm-spl;
+};
+
 &usbotg_hs {
 	u-boot,dm-spl;
 };
Quoted 2 lines

Thanks
Patrice

Applied to u-boot-stm32

Thanks
Patrice

#4 lore raw
Quoted 40 lines · Patrice CHOTARD

Hi Marek

Quoted 37 lines · Patrice CHOTARD

Hi Marek

Quoted 22 lines · Marek Vasut

Fix the following warning in SPL and make sure that even DTs which enforce Vbus detection using u-boot,force-vbus-detection;, the DFU in SPL will work.

dwc2-udc-otg usb-otg@49000000: prop pinctrl-0 index 0 invalid phandle

Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>
---
  arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 8 ++++++++
  1 file changed, 8 insertions(+)
arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +1 -0
index 71375510b4a..ff9ca625bf5 100644
@@ -171,6 +171,14 @@
  	u-boot,dm-spl;
  };
 
+&usb33 {

arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi line 184

Quoted 10 lines
arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi +7 -0
+	u-boot,dm-spl;
+};
+
+&usbotg_hs_pins_a {
+	u-boot,dm-spl;
+};
+
  &usbotg_hs {
  	u-boot,dm-spl;
  };
Quoted 4 lines
Quoted 2 lines

Thanks
Patrice

Applied to u-boot-stm32

This is for current release.