Skip to contentSkip to conversation

Support PL2303 on AST2600

PATCH In review Eddie James 2 participants 7 messages Jan 28, 2022 – Jan 31, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover Support PL2303 on AST2600

This series provides support for the PL2303 serial-to-USB converter on the AST2600-based systems, Everest and Rainier.

Eddie James (3):
USB: serial: pl2303: Add IBM device IDs
USB: uhci: Add ast2600 compatible
arm: dts: Aspeed: Rainier and Everest: Enable UHCI

 arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 4 ++++
 drivers/usb/host/uhci-platform.c             | 3 ++-
 drivers/usb/serial/pl2303.c                  | 1 +
 drivers/usb/serial/pl2303.h                  | 3 +++
 5 files changed, 14 insertions(+), 1 deletion(-)
Signature · 1 line
2.27.0
#5 lore raw

PATCH 3/3 arm: dts: Aspeed: Rainier and Everest: Enable UHCI

The UHCI controller is necessary to talk to slower, USB1.1 devices, so enable the UHCI controller in the device tree.

---
 arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 4 ++++
 2 files changed, 8 insertions(+)
arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts +4 -0
index 7256b8cbd552..547c71bfdfa7 100644
@@ -2394,6 +2394,10 @@ &ehci1 {
 	status = "okay";
 };
 
+&uhci {
+	status = "okay";
+};
+
 &emmc_controller {
 	status = "okay";
 };
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts +4 -0
index 652c866c14dc..b0fad1153e76 100644
@@ -239,6 +239,10 @@ &ehci1 {
 	status = "okay";
 };
 
+&uhci {
+	status = "okay";
+};
+
 &gpio0 {
 	gpio-line-names =
 	/*A0-A7*/	"","","","","","","","",
Signature · 1 line
2.27.0
#3 lore raw

PATCH 2/3 USB: uhci: Add ast2600 compatible

In reply to Eddie James

Add the ast2600 compatible string to enable the Aspeed workarounds on the UHCI.

---
 drivers/usb/host/uhci-platform.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/host/uhci-platform.c +2 -1
index 70dbd95c3f06..be9e9db7cad1 100644
@@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
 				num_ports);
 		}
 		if (of_device_is_compatible(np, "aspeed,ast2400-uhci") ||
-		    of_device_is_compatible(np, "aspeed,ast2500-uhci")) {
+		    of_device_is_compatible(np, "aspeed,ast2500-uhci") ||
+		    of_device_is_compatible(np, "aspeed,ast2600-uhci")) {
 			uhci->is_aspeed = 1;
 			dev_info(&pdev->dev,
 				 "Enabled Aspeed implementation workarounds\n");
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/3 USB: serial: pl2303: Add IBM device IDs

In reply to Eddie James

IBM manufactures a PL2303 device for UPS communications. Add the vendor and product IDs so that the PL2303 driver binds to the device.

---
 drivers/usb/serial/pl2303.c | 1 +
 drivers/usb/serial/pl2303.h | 3 +++
 2 files changed, 4 insertions(+)
drivers/usb/serial/pl2303.c +1 -0
index a70fd86f735c..e2ef761ed39c 100644
@@ -116,6 +116,7 @@ static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(ADLINK_VENDOR_ID, ADLINK_ND6530GC_PRODUCT_ID) },
 	{ USB_DEVICE(SMART_VENDOR_ID, SMART_PRODUCT_ID) },
 	{ USB_DEVICE(AT_VENDOR_ID, AT_VTKIT3_PRODUCT_ID) },
+	{ USB_DEVICE(IBM_VENDOR_ID, IBM_PRODUCT_ID) },
 	{ }					/* Terminating entry */
 };
 
drivers/usb/serial/pl2303.h +3 -0
index 6097ee8fccb2..c5406452b774 100644
@@ -35,6 +35,9 @@
 #define ATEN_PRODUCT_UC232B	0x2022
 #define ATEN_PRODUCT_ID2	0x2118
 
+#define IBM_VENDOR_ID		0x04b3
+#define IBM_PRODUCT_ID		0x4016
+
 #define IODATA_VENDOR_ID	0x04bb
 #define IODATA_PRODUCT_ID	0x0a03
 #define IODATA_PRODUCT_ID_RSAQ5	0x0a0e
Signature · 1 line
2.27.0
maintainer
#4 lore raw

Re: [PATCH linux dev-5.15 2/3] USB: uhci: Add ast2600 compatible

In reply to Eddie James
Quoted 5 lines · Eddie James

Add the ast2600 compatible string to enable the Aspeed workarounds on the UHCI.

This one has just popped up in the stable backports (v5.15.18) so I will skip it.

Quoted 21 lines
---
 drivers/usb/host/uhci-platform.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/host/uhci-platform.c +2 -2
index 70dbd95c3f06..be9e9db7cad1 100644
@@ -113,7 +113,8 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
                                num_ports);
                }
                if (of_device_is_compatible(np, "aspeed,ast2400-uhci") ||
-                   of_device_is_compatible(np, "aspeed,ast2500-uhci")) {
+                   of_device_is_compatible(np, "aspeed,ast2500-uhci") ||
+                   of_device_is_compatible(np, "aspeed,ast2600-uhci")) {
                        uhci->is_aspeed = 1;
                        dev_info(&pdev->dev,
                                 "Enabled Aspeed implementation workarounds\n");
--

2.27.0

maintainer
#2 lore raw

Re: [PATCH linux dev-5.15 1/3] USB: serial: pl2303: Add IBM device IDs

In reply to Eddie James
Quoted 5 lines · Eddie James

IBM manufactures a PL2303 device for UPS communications. Add the vendor and product IDs so that the PL2303 driver binds to the device.

Please send this one upstream.

Quoted 34 lines
---
 drivers/usb/serial/pl2303.c | 1 +
 drivers/usb/serial/pl2303.h | 3 +++
 2 files changed, 4 insertions(+)
drivers/usb/serial/pl2303.c +1 -0
index a70fd86f735c..e2ef761ed39c 100644
@@ -116,6 +116,7 @@ static const struct usb_device_id id_table[] = {
        { USB_DEVICE(ADLINK_VENDOR_ID, ADLINK_ND6530GC_PRODUCT_ID) },
        { USB_DEVICE(SMART_VENDOR_ID, SMART_PRODUCT_ID) },
        { USB_DEVICE(AT_VENDOR_ID, AT_VTKIT3_PRODUCT_ID) },
+       { USB_DEVICE(IBM_VENDOR_ID, IBM_PRODUCT_ID) },
        { }                                     /* Terminating entry */
 };
 
drivers/usb/serial/pl2303.h +3 -1
index 6097ee8fccb2..c5406452b774 100644
@@ -35,6 +35,9 @@
 #define ATEN_PRODUCT_UC232B    0x2022
 #define ATEN_PRODUCT_ID2       0x2118
 
+#define IBM_VENDOR_ID          0x04b3
+#define IBM_PRODUCT_ID         0x4016
+
 #define IODATA_VENDOR_ID       0x04bb
 #define IODATA_PRODUCT_ID      0x0a03
 #define IODATA_PRODUCT_ID_RSAQ5        0x0a0e
--

2.27.0

maintainer
#6 lore raw
In reply to Eddie James
Quoted 8 lines · Eddie James

This series provides support for the PL2303 serial-to-USB converter on the AST2600-based systems, Everest and Rainier.

Eddie James (3):
USB: serial: pl2303: Add IBM device IDs
USB: uhci: Add ast2600 compatible
arm: dts: Aspeed: Rainier and Everest: Enable UHCI

I merged the device ID and the device tree change, and added the driver to the defconfig.

Cheers,

Joel

Quoted 11 lines
 arch/arm/boot/dts/aspeed-bmc-ibm-everest.dts | 4 ++++
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 4 ++++
 drivers/usb/host/uhci-platform.c             | 3 ++-
 drivers/usb/serial/pl2303.c                  | 1 +
 drivers/usb/serial/pl2303.h                  | 3 +++
 5 files changed, 14 insertions(+), 1 deletion(-)

--
2.27.0