Skip to contentSkip to conversation

drm/amd/display: Update watermark values for DCN301

PATCH In review Agustin Gutierrez 2 participants 2 messages Jan 28, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/display: Update watermark values for DCN301

[Why]
There is underflow / visual corruption DCN301, for high bandwidth MST DSC configurations such as 2x1440p144 or 2x4k60.

[How]
Use up-to-date watermark values for DCN301.

---
 .../amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c   | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c +8 -8
index 48005def1164..bc4ddc36fe58 100644
@@ -570,32 +570,32 @@ static struct wm_table lpddr5_wm_table = {
 			.wm_inst = WM_A,
 			.wm_type = WM_TYPE_PSTATE_CHG,
 			.pstate_latency_us = 11.65333,
-			.sr_exit_time_us = 7.95,
-			.sr_enter_plus_exit_time_us = 9,
+			.sr_exit_time_us = 13.5,
+			.sr_enter_plus_exit_time_us = 16.5,
 			.valid = true,
 		},
 		{
 			.wm_inst = WM_B,
 			.wm_type = WM_TYPE_PSTATE_CHG,
 			.pstate_latency_us = 11.65333,
-			.sr_exit_time_us = 9.82,
-			.sr_enter_plus_exit_time_us = 11.196,
+			.sr_exit_time_us = 13.5,
+			.sr_enter_plus_exit_time_us = 16.5,
 			.valid = true,
 		},
 		{
 			.wm_inst = WM_C,
 			.wm_type = WM_TYPE_PSTATE_CHG,
 			.pstate_latency_us = 11.65333,
-			.sr_exit_time_us = 9.89,
-			.sr_enter_plus_exit_time_us = 11.24,
+			.sr_exit_time_us = 13.5,
+			.sr_enter_plus_exit_time_us = 16.5,
 			.valid = true,
 		},
 		{
 			.wm_inst = WM_D,
 			.wm_type = WM_TYPE_PSTATE_CHG,
 			.pstate_latency_us = 11.65333,
-			.sr_exit_time_us = 9.748,
-			.sr_enter_plus_exit_time_us = 11.102,
+			.sr_exit_time_us = 13.5,
+			.sr_enter_plus_exit_time_us = 16.5,
 			.valid = true,
 		},
 	}
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw

[Public]

Quoted 9 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Agustin Gutierrez
Sent: 2022/January/28, Friday 6:07 PM
To: [email protected]; Gutierrez, Agustin <[email protected]>
Cc: Gutierrez, Agustin <[email protected]>
Subject: [PATCH] drm/amd/display: Update watermark values for DCN301

Quoted 8 lines

[Why]
There is underflow / visual corruption DCN301, for high bandwidth MST DSC configurations such as 2x1440p144 or 2x4k60.

[How]
Use up-to-date watermark values for DCN301.

Looks good to me.

Quoted 52 lines
---
 .../amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c   | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c +8 -9
index 48005def1164..bc4ddc36fe58 100644
@@ -570,32 +570,32 @@ static struct wm_table lpddr5_wm_table = {
                      .wm_inst = WM_A,
                      .wm_type = WM_TYPE_PSTATE_CHG,
                      .pstate_latency_us = 11.65333,
-                     .sr_exit_time_us = 7.95,
-                     .sr_enter_plus_exit_time_us = 9,
+                     .sr_exit_time_us = 13.5,
+                     .sr_enter_plus_exit_time_us = 16.5,
                      .valid = true,
              },
              {
                      .wm_inst = WM_B,
                      .wm_type = WM_TYPE_PSTATE_CHG,
                      .pstate_latency_us = 11.65333,
-                     .sr_exit_time_us = 9.82,
-                     .sr_enter_plus_exit_time_us = 11.196,
+                     .sr_exit_time_us = 13.5,
+                     .sr_enter_plus_exit_time_us = 16.5,
                      .valid = true,
              },
              {
                      .wm_inst = WM_C,
                      .wm_type = WM_TYPE_PSTATE_CHG,
                      .pstate_latency_us = 11.65333,
-                     .sr_exit_time_us = 9.89,
-                     .sr_enter_plus_exit_time_us = 11.24,
+                     .sr_exit_time_us = 13.5,
+                     .sr_enter_plus_exit_time_us = 16.5,
                      .valid = true,
              },
              {
                      .wm_inst = WM_D,
                      .wm_type = WM_TYPE_PSTATE_CHG,
                      .pstate_latency_us = 11.65333,
-                     .sr_exit_time_us = 9.748,
-                     .sr_enter_plus_exit_time_us = 11.102,
+                     .sr_exit_time_us = 13.5,
+                     .sr_enter_plus_exit_time_us = 16.5,
                      .valid = true,
              },
      }
--

2.25.1