Skip to contentSkip to conversation

or1k: Define PI_STATIC_AND_HIDDEN

PATCH New Stafford Horne 2 participants 2 messages Jan 28, 2022 – Feb 21, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 or1k: Define PI_STATIC_AND_HIDDEN

PI_STATIC_AND_HIDDEN means that references to static functions, data and symbols with hidden visibility do not need any run-time relocations after the final link, with the build flags used by glibc.

OpenRISC follows this so enabled PI_STATIC_AND_HIDDEN by adding configure.ac and generating configure.

---
This was discussed on the mailing list:
https://sourceware.org/pipermail/libc-alpha/2022-January/135620.html

I thought to get this out as I start to test 2.35 we want this change in.

 sysdeps/or1k/configure    | 5 +++++
 sysdeps/or1k/configure.ac | 4 ++++
 2 files changed, 9 insertions(+)
 create mode 100644 sysdeps/or1k/configure
 create mode 100644 sysdeps/or1k/configure.ac
sysdeps/or1k/configure new file +5 -0
new file mode 100644
index 0000000000..d73db4ddbe
@@ -0,0 +1,5 @@
+# This file is generated from configure.ac by Autoconf.  DO NOT EDIT!
+ # Local configure fragment for sysdeps/or1k/elf.
+
+$as_echo "#define PI_STATIC_AND_HIDDEN 1" >>confdefs.h
+
sysdeps/or1k/configure.ac new file +4 -0
new file mode 100644
index 0000000000..db6a6087e1
@@ -0,0 +1,4 @@
+GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.
+# Local configure fragment for sysdeps/or1k/elf.
+
+AC_DEFINE(PI_STATIC_AND_HIDDEN)
Signature · 1 line
2.31.1
#1 lore raw

PATCH 1/1 or1k: Define PI_STATIC_AND_HIDDEN

Quoted 8 lines · Stafford Horne

PI_STATIC_AND_HIDDEN means that references to static functions, data and symbols with hidden visibility do not need any run-time relocations after the final link, with the build flags used by glibc.

OpenRISC follows this so enabled PI_STATIC_AND_HIDDEN by adding configure.ac and generating configure.

LGTM, thanks. Stafford, you are the or1k maintainer and most likely the one with a setup to actually test it. For such arch specific changes, you can push it without require other maintainer ack.

Quoted 33 lines

---
This was discussed on the mailing list:
https://sourceware.org/pipermail/libc-alpha/2022-January/135620.html

I thought to get this out as I start to test 2.35 we want this change in.

 sysdeps/or1k/configure    | 5 +++++
 sysdeps/or1k/configure.ac | 4 ++++
 2 files changed, 9 insertions(+)
 create mode 100644 sysdeps/or1k/configure
 create mode 100644 sysdeps/or1k/configure.ac
sysdeps/or1k/configure new file +5 -0
new file mode 100644
index 0000000000..d73db4ddbe
@@ -0,0 +1,5 @@
+# This file is generated from configure.ac by Autoconf.  DO NOT EDIT!
+ # Local configure fragment for sysdeps/or1k/elf.
+
+$as_echo "#define PI_STATIC_AND_HIDDEN 1" >>confdefs.h
+
sysdeps/or1k/configure.ac new file +4 -0
new file mode 100644
index 0000000000..db6a6087e1
@@ -0,0 +1,4 @@
+GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.
+# Local configure fragment for sysdeps/or1k/elf.
+
+AC_DEFINE(PI_STATIC_AND_HIDDEN)