Skip to contentSkip to conversation

fsx: disable allocsp_calls if -F is specified

PATCH In review Zorro Lang 2 participants 2 messages Jan 29, 2022 – Jan 30, 2022

lore
Share & tools
lore

Zorro Lang

author
#0 lore raw

PATCH 1/1 fsx: disable allocsp_calls if -F is specified

As the fsx.c source code says:

  int     fallocate_calls = 1;            /* -F flag disables */
  int     allocsp_calls = 1;              /* -F flag disables */

The allocsp_calls and fallocate_calls should be disabled, if the -F option is specified. But current fsx forgets to disable allocsp_calls as is documented.

---

Hi Darrick,

Please help to take a look. I'm not sure if you'd like to disable allocsp_calls by -F flag, or just copied that line then forgot to change the F to another ?

Thanks,
Zorro

 ltp/fsx.c | 1 +
 1 file changed, 1 insertion(+)
ltp/fsx.c +1 -0
index 520e53a2..3ee37fe8 100644
@@ -2835,6 +2835,7 @@ main(int argc, char **argv)
 			break;
 		case 'F':
 			fallocate_calls = 0;
+			allocsp_calls = 0;
 			break;
 		case 'K':
 			keep_size_calls = 0;
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Zorro Lang

As the fsx.c source code says:

  int     fallocate_calls = 1;            /* -F flag disables */
  int     allocsp_calls = 1;              /* -F flag disables */

The allocsp_calls and fallocate_calls should be disabled, if the -F option is specified. But current fsx forgets to disable allocsp_calls as is documented.

Quoted 8 lines

---

Hi Darrick,

Please help to take a look. I'm not sure if you'd like to disable allocsp_calls by -F flag, or just copied that line then forgot to change the F to another ?

Nah, that's ... fine. Thanks for fixing this. I hate ALLOCSP. :)

--D

Quoted 21 lines

Thanks,
Zorro

 ltp/fsx.c | 1 +
 1 file changed, 1 insertion(+)
ltp/fsx.c +1 -0
index 520e53a2..3ee37fe8 100644
@@ -2835,6 +2835,7 @@ main(int argc, char **argv)
 			break;
 		case 'F':
 			fallocate_calls = 0;
+			allocsp_calls = 0;
 			break;
 		case 'K':
 			keep_size_calls = 0;
Signature · 1 line
2.31.1