hda/realtek: Add/Improve several Gigabyte X570(S) audio quirks

PATCH Applied Christian Lachner 2 participants 5 messages Jan 29, 2022 – Jan 31, 2022 Sound

Share & tools

Christian Lachner

author

2022-01-29 11:33 UTC #0 lore raw

cover hda/realtek: Add/Improve several Gigabyte X570(S) audio quirks

This patch series cleans up and improves my previous work for the Gigabyte X570 audio quirks and adds more mainboards to make use of it.

Christian Lachner (3):
hda/realtek: Add missing fixup-model for Gigabyte X570 ALC1220 quirks hda/realtek: Fix silent output on Gigabyte X570S Aorus Master (newer
chipset)
hda/realtek: Fix silent output on Gigabyte X570 Aorus Xtreme after
reboot from Windows

 sound/pci/hda/patch_realtek.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Signature · 1 line

2.34.1

Christian Lachner

author

2022-01-29 11:33 UTC #1 lore raw

PATCH 1/3 hda/realtek: Add missing fixup-model entry for Gigabyte X570 ALC1220 quirks

The initial commit of the new Gigabyte X570 ALC1220 quirks lacked the fixup-model entry in alc882_fixup_models[]. It seemed not to cause any ill effects but for completeness sake this commit makes up for that.

Signed-off-by Christian Lachner <[email protected]>

---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

sound/pci/hda/patch_realtek.c +1 -0

index 668274e52674..48af182f87e4 100644
@@ -2626,6 +2626,7 @@ static const struct hda_model_fixup alc882_fixup_models[] = {
 	{.id = ALC882_FIXUP_NO_PRIMARY_HP, .name = "no-primary-hp"},
 	{.id = ALC887_FIXUP_ASUS_BASS, .name = "asus-bass"},
 	{.id = ALC1220_FIXUP_GB_DUAL_CODECS, .name = "dual-codecs"},
+	{.id = ALC1220_FIXUP_GB_X570, .name = "gb-x570"},
 	{.id = ALC1220_FIXUP_CLEVO_P950, .name = "clevo-p950"},
 	{}
 };

Signature · 1 line

2.34.1

Christian Lachner

author

2022-01-29 11:33 UTC #2 lore raw

PATCH 2/3 hda/realtek: Fix silent output on Gigabyte X570S Aorus Master (newer chipset)

In reply to Christian Lachner

Newer versions of the X570 Master come with a newer revision of the mainboard chipset - the X570S. These boards have the same ALC1220 codec but seem to initialize the codec with a different parameter in Coef 0x7 which causes the output audio to be very low. We therefore write a known-good value to Coef 0x7 to fix that. As the value is the exact same as on the other X570(non-S) boards the same quirk-function can be shared between both generations.

This commit adds the Gigabyte X570S Aorus Master to the list of boards using the ALC1220_FIXUP_GB_X570 quirk. This fixes both, the silent output and the no-audio after reboot from windows problems.

This work has been tested by the folks over at the level1techs forum here:
https://forum.level1techs.com/t/has-anybody-gotten-audio-working-in-linux-on-aorus-x570-master/154072

Signed-off-by Christian Lachner <[email protected]>

---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

sound/pci/hda/patch_realtek.c +2 -0

index 48af182f87e4..ca8475c24187 100644
@@ -2125,6 +2125,7 @@ static void alc1220_fixup_gb_x570(struct hda_codec *codec,
 {
 	static const hda_nid_t conn1[] = { 0x0c };
 	static const struct coef_fw gb_x570_coefs[] = {
+		WRITE_COEF(0x07, 0x03c0),
 		WRITE_COEF(0x1a, 0x01c1),
 		WRITE_COEF(0x1b, 0x0202),
 		WRITE_COEF(0x43, 0x3005),

@@ -2552,6 +2553,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
 	SND_PCI_QUIRK(0x1458, 0xa0cd, "Gigabyte X570 Aorus Master", ALC1220_FIXUP_GB_X570),
 	SND_PCI_QUIRK(0x1458, 0xa0ce, "Gigabyte X570 Aorus Xtreme", ALC1220_FIXUP_CLEVO_P950),
+	SND_PCI_QUIRK(0x1458, 0xa0d5, "Gigabyte X570S Aorus Master", ALC1220_FIXUP_GB_X570),
 	SND_PCI_QUIRK(0x1462, 0x11f7, "MSI-GE63", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1462, 0x1228, "MSI-GP63", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1462, 0x1229, "MSI-GP73", ALC1220_FIXUP_CLEVO_P950),

Signature · 1 line

2.34.1

Christian Lachner

author

2022-01-29 11:33 UTC #3 lore raw

PATCH 3/3 hda/realtek: Fix silent output on Gigabyte X570 Aorus Xtreme after reboot from Windows

In reply to Christian Lachner

This commit switches the Gigabyte X570 Aorus Xtreme from using the ALC1220_FIXUP_CLEVO_P950 to the ALC1220_FIXUP_GB_X570 quirk. This fixes the no-audio after reboot from windows problem.

BugLink https://bugzilla.kernel.org/show_bug.cgi?id=205275

Signed-off-by Christian Lachner <[email protected]>

---
 sound/pci/hda/patch_realtek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

sound/pci/hda/patch_realtek.c +1 -1

index ca8475c24187..a2e36bf0f25e 100644
@@ -2552,7 +2552,7 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte EP45-DS3/Z87X-UD3H", ALC889_FIXUP_FRONT_HP_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1458, 0xa0b8, "Gigabyte AZ370-Gaming", ALC1220_FIXUP_GB_DUAL_CODECS),
 	SND_PCI_QUIRK(0x1458, 0xa0cd, "Gigabyte X570 Aorus Master", ALC1220_FIXUP_GB_X570),
-	SND_PCI_QUIRK(0x1458, 0xa0ce, "Gigabyte X570 Aorus Xtreme", ALC1220_FIXUP_CLEVO_P950),
+	SND_PCI_QUIRK(0x1458, 0xa0ce, "Gigabyte X570 Aorus Xtreme", ALC1220_FIXUP_GB_X570),
 	SND_PCI_QUIRK(0x1458, 0xa0d5, "Gigabyte X570S Aorus Master", ALC1220_FIXUP_GB_X570),
 	SND_PCI_QUIRK(0x1462, 0x11f7, "MSI-GE63", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1462, 0x1228, "MSI-GP63", ALC1220_FIXUP_CLEVO_P950),

Signature · 1 line

2.34.1

Takashi Iwai

Applied

2022-01-31 08:01 UTC #4 lore raw

In reply to Christian Lachner

Quoted 10 lines · Christian Lachner

This patch series cleans up and improves my previous work for the Gigabyte X570 audio quirks and adds more mainboards to make use of it.
Christian Lachner (3):
hda/realtek: Add missing fixup-model for Gigabyte X570 ALC1220 quirks hda/realtek: Fix silent output on Gigabyte X570S Aorus Master (newer
chipset)
hda/realtek: Fix silent output on Gigabyte X570 Aorus Xtreme after
reboot from Windows

Applied all three patches now. Thanks.

Takashi