ARM: dts: add 533 MHz step to p4note GPU opp table
Subsystems (2)
PATCH 1/1 ARM: dts: add 533 MHz step to p4note GPU opp table
The p4note devices support 533 MHz GPU speed, so let's make use of it.
--- arch/arm/boot/dts/exynos4412-p4note.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)
arch/arm/boot/dts/exynos4412-p4note.dtsi +7 -0
@@ -355,6 +355,13 @@ &gpu { status = "okay"; }; +&gpu_opp_table { + opp-533000000 { + opp-hz = /bits/ 64 <533000000>; + opp-microvolt = <1075000>; + }; +}; + &hsotg { vusb_a-supply = <&ldo12_reg>; dr_mode = "peripheral";
Signature · 1 line
2.25.1
Quoted 2 lines · Martin Jücker
The p4note devices support 533 MHz GPU speed, so let's make use of it.
If there is going to be resend, please add prefix "exynos:" in subject. Just like other commits (git log --oneline arch/arm/boot/dts/exynos*).
Quoted 10 lines
Signed-off-by Martin Jücker <[email protected]>--- arch/arm/boot/dts/exynos4412-p4note.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm/boot/dts/exynos4412-p4note.dtsi +0
-0
arch/arm/boot/dts/exynos4412-p4note.dtsi &gpu { · line 363
Quoted 9 lines
arch/arm/boot/dts/exynos4412-p4note.dtsi +6
-0@@ -355,6 +355,13 @@ &gpu { status = "okay"; }; +&gpu_opp_table { + opp-533000000 { + opp-hz = /bits/ 64 <533000000>; + opp-microvolt = <1075000>; + }; +};
This looks like Exynos4412 Prime. Please check also CPU frequencies and if they match, just include exynos4412-prime.dtsi (like Odroid U3).
arch/arm/boot/dts/exynos4412-p4note.dtsi &gpu { · line 367
Quoted 4 lines
arch/arm/boot/dts/exynos4412-p4note.dtsi +1
-0+ &hsotg { vusb_a-supply = <&ldo12_reg>; dr_mode = "peripheral";
Best regards,
Krzysztof
Quoted 7 lines · Krzysztof Kozlowski
Quoted 2 lines · Martin Jücker
The p4note devices support 533 MHz GPU speed, so let's make use of it.
If there is going to be resend, please add prefix "exynos:" in subject. Just like other commits (git log --oneline
arch/arm/boot/dts/exynos*).
Okay.
Quoted 13 lines
Quoted 13 lines
Signed-off-by Martin Jücker <[email protected]>--- arch/arm/boot/dts/exynos4412-p4note.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm/boot/dts/exynos4412-p4note.dtsi +0
-0@@ -355,6 +355,13 @@ &gpu { status = "okay"; };
Quoted 10 lines
arch/arm/boot/dts/exynos4412-p4note.dtsi &gpu { · line 363
Quoted 6 lines
arch/arm/boot/dts/exynos4412-p4note.dtsi +6
-0+&gpu_opp_table { + opp-533000000 { + opp-hz = /bits/ 64 <533000000>; + opp-microvolt = <1075000>; + }; +};This looks like Exynos4412 Prime. Please check also CPU frequencies and if they match, just include
exynos4412-prime.dtsi(like Odroid U3).
I thought so as well, but unfortunately it's not. The chip id is 0xe4412211 and according to the vendor kernel, the prime version would need to have the last two digits being 0x20 or higher. See:
On the other hand, this kernel has the 533 MHz step unlocked for all versions:
Quoted 8 lines
arch/arm/boot/dts/exynos4412-p4note.dtsi &gpu { · line 367
Quoted 4 lines
arch/arm/boot/dts/exynos4412-p4note.dtsi +1
-0+ &hsotg { vusb_a-supply = <&ldo12_reg>; dr_mode = "peripheral";Best regards,
Krzysztof
Kind Regards
Martin
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 30 lines · Krzysztof Kozlowski
Quoted 2 lines · Martin Jücker
The p4note devices support 533 MHz GPU speed, so let's make use of it.
If there is going to be resend, please add prefix "exynos:" in subject. Just like other commits (git log --oneline
arch/arm/boot/dts/exynos*).Quoted 10 lines
Signed-off-by Martin Jücker <[email protected]>--- arch/arm/boot/dts/exynos4412-p4note.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm/boot/dts/exynos4412-p4note.dtsi +0
-0arch/arm/boot/dts/exynos4412-p4note.dtsi &gpu { · line 363
Quoted 9 lines
arch/arm/boot/dts/exynos4412-p4note.dtsi +6
-0@@ -355,6 +355,13 @@ &gpu { status = "okay"; }; +&gpu_opp_table { + opp-533000000 { + opp-hz = /bits/ 64 <533000000>; + opp-microvolt = <1075000>; + }; +};This looks like Exynos4412 Prime. Please check also CPU frequencies and if they match, just include
exynos4412-prime.dtsi(like Odroid U3).
Quoted 8 lines
arch/arm/boot/dts/exynos4412-p4note.dtsi &gpu { · line 367
Quoted 4 lines
arch/arm/boot/dts/exynos4412-p4note.dtsi +1
-0+ &hsotg { vusb_a-supply = <&ldo12_reg>; dr_mode = "peripheral";Best regards,
Krzysztof
I just noticed, that I overlooked a condition in the code which decreases the step count by one which eliminates the 533 MHz step. Please ignore this patch.
Kind Regards
Martin
Quoted 37 lines · Martin Jücker
Quoted 36 lines · Krzysztof Kozlowski
Quoted 2 lines · Martin Jücker
The p4note devices support 533 MHz GPU speed, so let's make use of it.
If there is going to be resend, please add prefix "exynos:" in subject. Just like other commits (git log --oneline
arch/arm/boot/dts/exynos*).Quoted 10 lines
Signed-off-by Martin Jücker <[email protected]>--- arch/arm/boot/dts/exynos4412-p4note.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm/boot/dts/exynos4412-p4note.dtsi +0
-0arch/arm/boot/dts/exynos4412-p4note.dtsi &gpu { · line 363
Quoted 9 lines
arch/arm/boot/dts/exynos4412-p4note.dtsi +6
-0@@ -355,6 +355,13 @@ &gpu { status = "okay"; }; +&gpu_opp_table { + opp-533000000 { + opp-hz = /bits/ 64 <533000000>; + opp-microvolt = <1075000>; + }; +};This looks like Exynos4412 Prime. Please check also CPU frequencies and if they match, just include
exynos4412-prime.dtsi(like Odroid U3).Quoted 4 lines
arch/arm/boot/dts/exynos4412-p4note.dtsi +1
-0+ &hsotg { vusb_a-supply = <&ldo12_reg>; dr_mode = "peripheral";
Quoted 6 lines
Quoted 2 lines
Best regards,
KrzysztofI just noticed, that I overlooked a condition in the code which decreases the step count by one which eliminates the 533 MHz step. Please ignore this patch.
Yeah:
if(samsung_rev() < EXYNOS4412_REV_2_0) step_num = MALI_DVFS_STEPS - 1;
Your case, although possible, would be unlikely.
Best regards,
Krzysztof