Skip to contentSkip to conversation

pinctrl: samsung: improve wake irq info on console

PATCH Applied Martin Jücker 3 participants 3 messages Jan 30, 2022 – Feb 1, 2022

Subsystems (4)
GPIO Arm Samsung Exynos Pin control Pin controller - Samsung
lore
Share & tools
lore

Martin Jücker

author
#0 lore raw

PATCH 1/1 pinctrl: samsung: improve wake irq info on console

Improve the wake irq message by also printing the bank name and hwirq number that matches this irq number.

Signed-off-by Martin Jücker <[email protected]>
---
 drivers/pinctrl/samsung/pinctrl-exynos.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/pinctrl/samsung/pinctrl-exynos.c +2 -1
index 0489c899b401..30293fc23354 100644
@@ -344,7 +344,8 @@ static int exynos_wkup_irq_set_wake(struct irq_data *irqd, unsigned int on)
 	struct samsung_pin_bank *bank = irq_data_get_irq_chip_data(irqd);
 	unsigned long bit = 1UL << (2 * bank->eint_offset + irqd->hwirq);
 
-	pr_info("wake %s for irq %d\n", on ? "enabled" : "disabled", irqd->irq);
+	pr_info("wake %s for irq %u (%s-%lu)\n", on ? "enabled" : "disabled",
+		irqd->irq, bank->name, irqd->hwirq);
 
 	if (!on)
 		*our_chip->eint_wake_mask_value |= bit;
Signature · 1 line
2.25.1
Applied
#1 lore raw
Quoted 4 lines · Martin Jücker

Improve the wake irq message by also printing the bank name and hwirq number that matches this irq number.

Applied, thanks!

[1/1] pinctrl: samsung: improve wake irq info on console

      commit: 3652dc070bad335d6feb31402bb4ab1ad58d5cb6

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>
#2 lore raw
In reply to Martin Jücker
Quoted 3 lines · Martin Jücker

Improve the wake irq message by also printing the bank name and hwirq number that matches this irq number.

Perhaps wait a bit and replace the first argument with str_enabled_disabled()?

Signature · 2 lines
With Best Regards,
Andy Shevchenko