net: kbuild: Don't default net vendor configs to y
Subsystems (29)
PATCH 1/1 net: kbuild: Don't default net vendor configs to y
From: Saeed Mahameed <[email protected]>
NET_VENDOR_XYZ were defaulted to 'y' for no technical reason.
Since all drivers belonging to a vendor are supposed to default to 'n', defaulting all vendors to 'n' shouldn't be an issue, and aligns well with the 'no new drivers' by default mentality.
--- drivers/net/ethernet/3com/Kconfig | 1 - drivers/net/ethernet/8390/Kconfig | 1 - drivers/net/ethernet/adaptec/Kconfig | 1 - drivers/net/ethernet/agere/Kconfig | 1 - drivers/net/ethernet/alacritech/Kconfig | 1 - drivers/net/ethernet/allwinner/Kconfig | 1 - drivers/net/ethernet/alteon/Kconfig | 1 - drivers/net/ethernet/amazon/Kconfig | 1 - drivers/net/ethernet/amd/Kconfig | 1 - drivers/net/ethernet/apple/Kconfig | 1 - drivers/net/ethernet/aquantia/Kconfig | 1 - drivers/net/ethernet/arc/Kconfig | 1 - drivers/net/ethernet/asix/Kconfig | 1 - drivers/net/ethernet/atheros/Kconfig | 1 - drivers/net/ethernet/broadcom/Kconfig | 1 - drivers/net/ethernet/brocade/Kconfig | 1 - drivers/net/ethernet/cadence/Kconfig | 1 - drivers/net/ethernet/cavium/Kconfig | 1 - drivers/net/ethernet/chelsio/Kconfig | 1 - drivers/net/ethernet/cirrus/Kconfig | 1 - drivers/net/ethernet/cisco/Kconfig | 1 - drivers/net/ethernet/cortina/Kconfig | 1 - drivers/net/ethernet/dec/Kconfig | 1 - drivers/net/ethernet/dlink/Kconfig | 1 - drivers/net/ethernet/emulex/Kconfig | 1 - drivers/net/ethernet/engleder/Kconfig | 1 - drivers/net/ethernet/ezchip/Kconfig | 1 - drivers/net/ethernet/faraday/Kconfig | 1 - drivers/net/ethernet/freescale/Kconfig | 1 - drivers/net/ethernet/fujitsu/Kconfig | 1 - drivers/net/ethernet/google/Kconfig | 1 - drivers/net/ethernet/hisilicon/Kconfig | 1 - drivers/net/ethernet/huawei/Kconfig | 1 - drivers/net/ethernet/i825xx/Kconfig | 1 - drivers/net/ethernet/ibm/Kconfig | 1 - drivers/net/ethernet/intel/Kconfig | 1 - drivers/net/ethernet/litex/Kconfig | 1 - drivers/net/ethernet/marvell/Kconfig | 1 - drivers/net/ethernet/mellanox/Kconfig | 1 - drivers/net/ethernet/micrel/Kconfig | 1 - drivers/net/ethernet/microchip/Kconfig | 1 - drivers/net/ethernet/microsoft/Kconfig | 1 - drivers/net/ethernet/moxa/Kconfig | 1 - drivers/net/ethernet/mscc/Kconfig | 1 - drivers/net/ethernet/myricom/Kconfig | 1 - drivers/net/ethernet/natsemi/Kconfig | 1 - drivers/net/ethernet/neterion/Kconfig | 1 - drivers/net/ethernet/netronome/Kconfig | 1 - drivers/net/ethernet/ni/Kconfig | 1 - drivers/net/ethernet/nvidia/Kconfig | 1 - drivers/net/ethernet/oki-semi/Kconfig | 1 - drivers/net/ethernet/packetengines/Kconfig | 1 - drivers/net/ethernet/pasemi/Kconfig | 1 - drivers/net/ethernet/pensando/Kconfig | 1 - drivers/net/ethernet/qlogic/Kconfig | 1 - drivers/net/ethernet/qualcomm/Kconfig | 1 - drivers/net/ethernet/rdc/Kconfig | 1 - drivers/net/ethernet/realtek/Kconfig | 1 - drivers/net/ethernet/renesas/Kconfig | 1 - drivers/net/ethernet/rocker/Kconfig | 1 - drivers/net/ethernet/samsung/Kconfig | 1 - drivers/net/ethernet/seeq/Kconfig | 1 - drivers/net/ethernet/sfc/Kconfig | 1 - drivers/net/ethernet/sgi/Kconfig | 1 - drivers/net/ethernet/silan/Kconfig | 1 - drivers/net/ethernet/sis/Kconfig | 1 - drivers/net/ethernet/smsc/Kconfig | 1 - drivers/net/ethernet/socionext/Kconfig | 1 - drivers/net/ethernet/stmicro/Kconfig | 1 - drivers/net/ethernet/sun/Kconfig | 1 - drivers/net/ethernet/synopsys/Kconfig | 1 - drivers/net/ethernet/tehuti/Kconfig | 1 - drivers/net/ethernet/ti/Kconfig | 1 - drivers/net/ethernet/toshiba/Kconfig | 1 - drivers/net/ethernet/tundra/Kconfig | 1 - drivers/net/ethernet/vertexcom/Kconfig | 1 - drivers/net/ethernet/via/Kconfig | 1 - drivers/net/ethernet/wiznet/Kconfig | 1 - drivers/net/ethernet/xilinx/Kconfig | 1 - drivers/net/ethernet/xircom/Kconfig | 1 - drivers/net/ethernet/xscale/Kconfig | 1 - 81 files changed, 81 deletions(-)
drivers/net/ethernet/3com/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_3COM bool "3Com devices" - default y depends on ISA || EISA || PCI || PCMCIA help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/8390/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_8390 bool "National Semiconductor 8390 devices" - default y depends on NET_VENDOR_NATSEMI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/adaptec/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_ADAPTEC bool "Adaptec devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/agere/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_AGERE bool "Agere devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/alacritech/Kconfig +0 -1
@@ -1,7 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only config NET_VENDOR_ALACRITECH bool "Alacritech devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/allwinner/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_ALLWINNER bool "Allwinner devices" - default y depends on ARCH_SUNXI help
drivers/net/ethernet/alteon/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_ALTEON bool "Alteon devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/amazon/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_AMAZON bool "Amazon Devices" - default y help If you have a network (Ethernet) device belonging to this class, say Y.
drivers/net/ethernet/amd/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_AMD bool "AMD devices" - default y depends on DIO || MACH_DECSTATION || MVME147 || ATARI || SUN3 || \ SUN3X || SBUS || PCI || ZORRO || (ISA && ISA_DMA_API) || \ ISA || EISA || PCMCIA || ARM64
drivers/net/ethernet/apple/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_APPLE bool "Apple devices" - default y depends on (PPC_PMAC && PPC32) || MAC help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/aquantia/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_AQUANTIA bool "aQuantia devices" - default y help Set this to y if you have an Ethernet network cards that uses the aQuantia AQC107/AQC108 chipset.
drivers/net/ethernet/arc/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_ARC bool "ARC devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/asix/Kconfig +0 -1
@@ -4,7 +4,6 @@ config NET_VENDOR_ASIX bool "Asix devices" - default y help If you have a network (Ethernet, non-USB, not NE2000 compatible) interface based on a chip from ASIX, say Y.
drivers/net/ethernet/atheros/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_ATHEROS bool "Atheros devices" - default y depends on (PCI || ATH79) help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/broadcom/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_BROADCOM bool "Broadcom devices" - default y depends on (SSB_POSSIBLE && HAS_DMA) || PCI || BCM63XX || \ SIBYTE_SB1xxx_SOC help
drivers/net/ethernet/brocade/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_BROCADE bool "QLogic BR-series devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/cadence/Kconfig +0 -1
@@ -6,7 +6,6 @@ config NET_VENDOR_CADENCE bool "Cadence devices" depends on HAS_IOMEM - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/cavium/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_CAVIUM bool "Cavium ethernet drivers" - default y help Select this option if you want enable Cavium network support.
drivers/net/ethernet/chelsio/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_CHELSIO bool "Chelsio devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/cirrus/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_CIRRUS bool "Cirrus devices" - default y depends on ISA || EISA || ARM || MAC || COMPILE_TEST help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/cisco/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_CISCO bool "Cisco devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/cortina/Kconfig +0 -1
@@ -3,7 +3,6 @@ config NET_VENDOR_CORTINA bool "Cortina Gemini devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y and read the Ethernet-HOWTO, available from
drivers/net/ethernet/dec/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_DEC bool "Digital Equipment devices" - default y depends on PCI || EISA || CARDBUS help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/dlink/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_DLINK bool "D-Link devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/emulex/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_EMULEX bool "Emulex devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/engleder/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_ENGLEDER bool "Engleder devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/ezchip/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_EZCHIP bool "EZchip devices" - default y help If you have a network (Ethernet) device belonging to this class, say Y.
drivers/net/ethernet/faraday/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_FARADAY bool "Faraday devices" - default y depends on ARM || NDS32 || COMPILE_TEST help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/freescale/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_FREESCALE bool "Freescale devices" - default y depends on FSL_SOC || QUICC_ENGINE || CPM1 || CPM2 || PPC_MPC512x || \ M523x || M527x || M5272 || M528x || M520x || M532x || \ ARCH_MXC || ARCH_MXS || (PPC_MPC52xx && PPC_BESTCOMM) || \
drivers/net/ethernet/fujitsu/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_FUJITSU bool "Fujitsu devices" - default y depends on PCMCIA help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/google/Kconfig +0 -1
@@ -4,7 +4,6 @@ config NET_VENDOR_GOOGLE bool "Google Devices" - default y help If you have a network (Ethernet) device belonging to this class, say Y.
drivers/net/ethernet/hisilicon/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_HISILICON bool "Hisilicon devices" - default y depends on OF || ACPI depends on ARM || ARM64 || COMPILE_TEST help
drivers/net/ethernet/huawei/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_HUAWEI bool "Huawei devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y. Note that the answer to this question doesn't directly affect the
drivers/net/ethernet/i825xx/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_I825XX bool "Intel (82586/82593/82596) devices" - default y depends on NET_VENDOR_INTEL help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/ibm/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_IBM bool "IBM devices" - default y depends on PPC_PSERIES || PPC_DCR || (IBMEBUS && SPARSEMEM) help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/intel/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_INTEL bool "Intel devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/litex/Kconfig +0 -1
@@ -4,7 +4,6 @@ config NET_VENDOR_LITEX bool "LiteX devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/marvell/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_MARVELL bool "Marvell devices" - default y depends on PCI || CPU_PXA168 || PPC32 || PLAT_ORION || INET || COMPILE_TEST help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/mellanox/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_MELLANOX bool "Mellanox devices" - default y depends on PCI || I2C help If you have a network (Ethernet or RDMA) device belonging to this
drivers/net/ethernet/micrel/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_MICREL bool "Micrel devices" - default y depends on (HAS_IOMEM && DMA_ENGINE) || SPI || PCI || HAS_IOMEM help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/microchip/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_MICROCHIP bool "Microchip devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/microsoft/Kconfig +0 -1
@@ -4,7 +4,6 @@ config NET_VENDOR_MICROSOFT bool "Microsoft Network Devices" - default y help If you have a network (Ethernet) device belonging to this class, say Y.
drivers/net/ethernet/moxa/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_MOXART bool "MOXA ART devices" - default y depends on (ARM && ARCH_MOXART) help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/mscc/Kconfig +0 -1
@@ -1,7 +1,6 @@ # SPDX-License-Identifier: (GPL-2.0 OR MIT) config NET_VENDOR_MICROSEMI bool "Microsemi devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/myricom/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_MYRI bool "Myricom devices" - default y depends on PCI && INET help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/natsemi/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_NATSEMI bool "National Semiconductor devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/neterion/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_NETERION bool "Neterion (Exar) devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/netronome/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_NETRONOME bool "Netronome(R) devices" - default y help If you have a Netronome(R) network (Ethernet) card or device, say Y.
drivers/net/ethernet/ni/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_NI bool "National Instruments Devices" - default y help If you have a network (Ethernet) device belonging to this class, say Y.
drivers/net/ethernet/nvidia/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_NVIDIA bool "NVIDIA devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/oki-semi/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_OKI bool "OKI Semiconductor devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/packetengines/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_PACKET_ENGINES bool "Packet Engines devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/pasemi/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_PASEMI bool "PA Semi devices" - default y depends on PPC_PASEMI && PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/pensando/Kconfig +0 -1
@@ -6,7 +6,6 @@ config NET_VENDOR_PENSANDO bool "Pensando devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/qlogic/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_QLOGIC bool "QLogic devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/qualcomm/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_QUALCOMM bool "Qualcomm devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/rdc/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_RDC bool "RDC devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/realtek/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_REALTEK bool "Realtek devices" - default y depends on PCI || (PARPORT && X86) help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/renesas/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_RENESAS bool "Renesas devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/rocker/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_ROCKER bool "Rocker devices" - default y help If you have a network device belonging to this class, say Y.
drivers/net/ethernet/samsung/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_SAMSUNG bool "Samsung Ethernet devices" - default y help If you have a network (Ethernet) chipset belonging to this class, say Y.
drivers/net/ethernet/seeq/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_SEEQ bool "SEEQ devices" - default y depends on HAS_IOMEM help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/sfc/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_SOLARFLARE bool "Solarflare devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/sgi/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_SGI bool "SGI devices" - default y depends on (PCI && SGI_MFD_IOC3) || SGI_IP32 help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/silan/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_SILAN bool "Silan devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/sis/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_SIS bool "Silicon Integrated Systems (SiS) devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/smsc/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_SMSC bool "SMC (SMSC)/Western Digital devices" - default y depends on ARM || ARM64 || ATARI_ETHERNAT || COLDFIRE || \ ISA || MAC || MIPS || NIOS2 || PCI || \ PCMCIA || SUPERH || XTENSA || H8300 || COMPILE_TEST
drivers/net/ethernet/socionext/Kconfig +0 -1
@@ -1,7 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only config NET_VENDOR_SOCIONEXT bool "Socionext ethernet drivers" - default y help Option to select ethernet drivers for Socionext platforms.
drivers/net/ethernet/stmicro/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_STMICRO bool "STMicroelectronics devices" - default y depends on HAS_IOMEM help If you have a network (Ethernet) card based on Synopsys Ethernet IP
drivers/net/ethernet/sun/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_SUN bool "Sun devices" - default y depends on SUN3 || SBUS || PCI || SUN_LDOMS help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/synopsys/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_SYNOPSYS bool "Synopsys devices" - default y help If you have a network (Ethernet) device belonging to this class, say Y.
drivers/net/ethernet/tehuti/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_TEHUTI bool "Tehuti devices" - default y depends on PCI help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/ti/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_TI bool "Texas Instruments (TI) devices" - default y depends on PCI || EISA || AR7 || ARCH_DAVINCI || ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/toshiba/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_TOSHIBA bool "Toshiba devices" - default y depends on PCI && (PPC_IBM_CELL_BLADE || MIPS) || PPC_PS3 help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/tundra/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_TUNDRA bool "Tundra devices" - default y depends on TSI108_BRIDGE help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/vertexcom/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_VERTEXCOM bool "Vertexcom devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/via/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_VIA bool "VIA devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/wiznet/Kconfig +0 -1
@@ -6,7 +6,6 @@ config NET_VENDOR_WIZNET bool "WIZnet devices" depends on HAS_IOMEM - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/xilinx/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_XILINX bool "Xilinx devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/xircom/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_XIRCOM bool "Xircom devices" - default y depends on PCMCIA help If you have a network (Ethernet) card belonging to this class, say Y.
drivers/net/ethernet/xscale/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_XSCALE bool "Intel XScale IXP devices" - default y depends on NET_VENDOR_INTEL && (ARM && ARCH_IXP4XX && \ IXP4XX_NPE && IXP4XX_QMGR) help
Signature · 1 line
2.34.1
Quoted 9 lines · On Mon, 31 Jan 2022 09:24:50 -0800 Saeed Mahameed <[email protected]> wrote:
From: Saeed Mahameed <[email protected]>
NET_VENDOR_XYZwere defaulted to 'y' for no technical reason.Since all drivers belonging to a vendor are supposed to default to 'n', defaulting all vendors to 'n' shouldn't be an issue, and aligns well with the 'no new drivers' by default mentality.
Signed-off-by Saeed Mahameed <[email protected]>
This was done back when vendors were introduced in the network drivers tree. The default of Y allowed older configurations to just work.
So there was a reason, not sure if it matters anymore. But it seems like useless repainting to change it now.
Quoted 10 lines · Saeed Mahameed
From: Saeed Mahameed <[email protected]>
NET_VENDOR_XYZwere defaulted to 'y' for no technical reason.Since all drivers belonging to a vendor are supposed to default to 'n', defaulting all vendors to 'n' shouldn't be an issue, and aligns well with the 'no new drivers' by default mentality.
Signed-off-by Saeed Mahameed <[email protected]>
Is there a particular reason to change this? Broken compiles?? Bad drivers?? Over-sized output?
sln
Quoted 7 lines · Stephen Hemminger
Quoted 4 lines · On Mon, 31 Jan 2022 09:24:50 -0800 Saeed Mahameed <[email protected]> wrote:
From: Saeed Mahameed <[email protected]>
NET_VENDOR_XYZwere defaulted to 'y' for no technical reason.
Quoted 8 lines
Quoted 5 lines
Since all drivers belonging to a vendor are supposed to default to 'n', defaulting all vendors to 'n' shouldn't be an issue, and aligns well with the 'no new drivers' by default mentality.
Signed-off-by Saeed Mahameed <[email protected]>This was done back when vendors were introduced in the network drivers tree. The default of Y allowed older configurations to just work.
And changing the defaults means all defconfigs must be updated first, else the user's configs will end up without drivers needed.
Quoted 2 lines
So there was a reason, not sure if it matters anymore. But it seems like useless repainting to change it now.
It might make sense to tune some of the defaults (i.e. change to "default y if ARCH_*") for drivers with clear platform dependencies.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 11 lines · Stephen Hemminger
Quoted 8 lines · On Mon, 31 Jan 2022 09:24:50 -0800 Saeed Mahameed <[email protected]> wrote:
From: Saeed Mahameed <[email protected]>
NET_VENDOR_XYZwere defaulted to 'y' for no technical reason.Since all drivers belonging to a vendor are supposed to default to 'n', defaulting all vendors to 'n' shouldn't be an issue, and aligns well with the 'no new drivers' by default mentality.
Quoted 7 lines
Quoted 1 line
Signed-off-by Saeed Mahameed <[email protected]>This was done back when vendors were introduced in the network drivers tree. The default of Y allowed older configurations to just work.
So there was a reason, not sure if it matters anymore. But it seems like useless repainting to change it now.
it sounds like it's useless to have it in first place, and it was and still confusing to me why vendors need to by Y by default, can you explain what are those "older configurations" ?
The idea of this patch is to set a better example for new vendors and to have a leaner .config
Quoted 13 lines · Geert Uytterhoeven
Quoted 11 lines · Stephen Hemminger
Quoted 8 lines · On Mon, 31 Jan 2022 09:24:50 -0800 Saeed Mahameed <[email protected]> wrote:
From: Saeed Mahameed <[email protected]>
NET_VENDOR_XYZwere defaulted to 'y' for no technical reason.Since all drivers belonging to a vendor are supposed to default to 'n', defaulting all vendors to 'n' shouldn't be an issue, and aligns well with the 'no new drivers' by default mentality.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Saeed Mahameed <[email protected]>This was done back when vendors were introduced in the network drivers tree. The default of Y allowed older configurations to just work.
And changing the defaults means all defconfigs must be updated first, else the user's configs will end up without drivers needed.
As I understand correctly, at least for most common net drivers, having NET_VENDOR_XYZ=y doesn't actually build anything, we have flags per module for each vendor and those are defaulted to N.
Quoted 6 lines
Quoted 2 lines
So there was a reason, not sure if it matters anymore. But it seems like useless repainting to change it now.
It might make sense to tune some of the defaults (i.e. change to "default y if ARCH_*") for drivers with clear platform dependencies.
either set hard default to 'n' or just keep it as is, anything else is just more confusion.
Quoted 10 lines
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.orgIn personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 21 lines · Saeed Mahameed
Quoted 20 lines · Geert Uytterhoeven
Quoted 17 lines · Stephen Hemminger
Quoted 5 lines · On Mon, 31 Jan 2022 09:24:50 -0800 Saeed Mahameed <[email protected]> wrote:
From: Saeed Mahameed <[email protected]>
NET_VENDOR_XYZwere defaulted to 'y' for no technical reason.Since all drivers belonging to a vendor are supposed to default to
'n',
Quoted 4 lines
defaulting all vendors to 'n' shouldn't be an issue, and aligns well with the 'no new drivers' by default mentality.
Signed-off-by Saeed Mahameed <[email protected]>This was done back when vendors were introduced in the network drivers tree.
The default of Y allowed older configurations to just work.
Quoted 7 lines
Quoted 3 lines
And changing the defaults means all defconfigs must be updated first, else the user's configs will end up without drivers needed.
As I understand correctly, at least for most common net drivers, having NET_VENDOR_XYZ=y doesn't actually build anything, we have flags per module for each vendor and those are defaulted to N.
Right, but once you start hiding NET_VENDOR_DRIVER_XYZ under a NET_VENDOR_XYZ Kconfig symbol dependency, if NET_VENDOR_XYZ is not set to Y, then you have no way to select NET_VENDOR_DRIVER_XYZ and so your old defconfig breaks.
Quoted 10 lines
Quoted 7 lines
Quoted 3 lines
So there was a reason, not sure if it matters anymore. But it seems like useless repainting to change it now.
It might make sense to tune some of the defaults (i.e. change to "default y if ARCH_*") for drivers with clear platform dependencies.
either set hard default to 'n' or just keep it as is, anything else is just more confusion.
Maybe the rule should go like this: any new driver vendor defaults to n, and existing ones remain set to y, until we deprecate doing that and switching them all off to n by 5.18?
Signature · 1 line
Florian
Quoted 41 lines · Florian Fainelli
Quoted 20 lines · Saeed Mahameed
Quoted 19 lines · Geert Uytterhoeven
Quoted 16 lines · Stephen Hemminger
Quoted 9 lines · On Mon, 31 Jan 2022 09:24:50 -0800 Saeed Mahameed <[email protected]> wrote:
From: Saeed Mahameed <[email protected]>
NET_VENDOR_XYZwere defaulted to 'y' for no technical reason.Since all drivers belonging to a vendor are supposed to default to 'n', defaulting all vendors to 'n' shouldn't be an issue, and aligns well with the 'no new drivers' by default mentality.
Signed-off-by Saeed Mahameed <[email protected]>This was done back when vendors were introduced in the network drivers tree.
The default of Y allowed older configurations to just work.Quoted 7 lines
Quoted 3 lines
And changing the defaults means all defconfigs must be updated first, else the user's configs will end up without drivers needed.
As I understand correctly, at least for most common net drivers, having NET_VENDOR_XYZ=y doesn't actually build anything, we have flags per module for each vendor and those are defaulted to N.
Right, but once you start hiding
NET_VENDOR_DRIVER_XYZunder aNET_VENDOR_XYZKconfigsymbol dependency, ifNET_VENDOR_XYZis not set to Y, then you have no way to selectNET_VENDOR_DRIVER_XYZand so your old defconfig breaks.Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
So there was a reason, not sure if it matters anymore. But it seems like useless repainting to change it now.
It might make sense to tune some of the defaults (i.e. change to "default y if ARCH_*") for drivers with clear platform dependencies.
Quoted 6 lines
Quoted 2 lines
either set hard default to 'n' or just keep it as is, anything else is just more confusion.
Maybe the rule should go like this: any new driver vendor defaults to n, and existing ones remain set to y, until we deprecate doing that and switching them all off to n by 5.18?
Forgive my ignorance, but isn't it a regression if things quit working even if it's just a configuration change?
From a user perspective I like having everything turned on initially so it just works. Pruning things down is a lot easier than trying to figure out what all to turn on. Especially in graphics.
Signature · 1 line
Hisashi T Fujinaka - htodd at twofifty.com
Quoted 2 lines · Shannon Nelson
Is there a particular reason to change this? Broken compiles?? Bad drivers?? Over-sized output?
Having default Y is a PITA to people working on an embedded design that has just one working MAC. It means having to scroll through tons of empty stuff when doing make menuconfig
Thanks,
Richard
Quoted 3 lines · Florian Fainelli
Maybe the rule should go like this: any new driver vendor defaults to n, and existing ones remain set to y, until we deprecate doing that and switching them all off to n by 5.18?
+1
Actually, I wouldn't mind breaking old configs. Why? Because never once have MY configs ever survived a kernel upgrade. Manual fix ups are always needed.
Nobody cares about my configs, so why should I care about theirs?
Thanks,
Richard
Jakub Kicinski
maintainerQuoted 4 lines · On Mon, 31 Jan 2022 10:40:38 -0800 Florian Fainelli wrote:
Quoted 4 lines
Quoted 3 lines
And changing the defaults means all defconfigs must be updated first, else the user's configs will end up without drivers needed.
Quoted 8 lines
Quoted 3 lines
As I understand correctly, at least for most common net drivers, having NET_VENDOR_XYZ=y doesn't actually build anything, we have flags per module for each vendor and those are defaulted to N.
Right, but once you start hiding
NET_VENDOR_DRIVER_XYZunder aNET_VENDOR_XYZKconfigsymbol dependency, ifNET_VENDOR_XYZis not set to Y, then you have no way to selectNET_VENDOR_DRIVER_XYZand so your old defconfig breaks.
To be clear do we actually care about *old* configs or *def* configs?
Breaking defconfigs seems bad, but I don't think we can break reasonable oldconfigs at this point?
Quoted 10 lines
Quoted 6 lines
Quoted 3 lines
It might make sense to tune some of the defaults (i.e. change to "default y if ARCH_*") for drivers with clear platform dependencies.
either set hard default to 'n' or just keep it as is, anything else is just more confusion.
Maybe the rule should go like this: any new driver vendor defaults to n, and existing ones remain set to y, until we deprecate doing that and switching them all off to n by 5.18?
I'd be afraid that given the work of fixing up defconfigs is non-trivial we may end up never switching old drivers. And then we'd have a semi-random soup of defaults :(
Quoted 9 lines · Jakub Kicinski
Quoted 8 lines · On Mon, 31 Jan 2022 10:40:38 -0800 Florian Fainelli wrote:
Quoted 7 lines
Quoted 3 lines
And changing the defaults means all defconfigs must be updated first, else the user's configs will end up without drivers needed.
As I understand correctly, at least for most common net drivers, having NET_VENDOR_XYZ=y doesn't actually build anything, we have flags per module for each vendor and those are defaulted to N.
Quoted 6 lines
Quoted 4 lines
Right, but once you start hiding
NET_VENDOR_DRIVER_XYZunder aNET_VENDOR_XYZKconfigsymbol dependency, ifNET_VENDOR_XYZis not set to Y, then you have no way to selectNET_VENDOR_DRIVER_XYZand so your old defconfig breaks.To be clear do we actually care about *old* configs or *def* configs?
I think we care about oldconfig but maybe less so about defconfigs which are in tree and can be updated.
Quoted 3 lines
Breaking defconfigs seems bad, but I don't think we can break reasonable oldconfigs at this point?
No preference either way for me, just like Richard, all of the systems I typically work with either require a carefully curated configuration file to strip out unwanted features. I do like Geert's suggestion of adding default ARCH_ for slightly esoteric controllers that are not found in off the shelf hardware.
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
It might make sense to tune some of the defaults (i.e. change to "default y if ARCH_*") for drivers with clear platform dependencies.
either set hard default to 'n' or just keep it as is, anything else is just more confusion.
Quoted 7 lines
Quoted 3 lines
Maybe the rule should go like this: any new driver vendor defaults to n, and existing ones remain set to y, until we deprecate doing that and switching them all off to n by 5.18?
I'd be afraid that given the work of fixing up defconfigs is non-trivial we may end up never switching old drivers. And then we'd have a semi-random soup of defaults :(
Fair enough.
Signature · 1 line
Florian
Jakub Kicinski
maintainerQuoted 9 lines · On Mon, 31 Jan 2022 15:06:01 -0800 Florian Fainelli wrote:
Quoted 6 lines
Quoted 4 lines
Right, but once you start hiding
NET_VENDOR_DRIVER_XYZunder aNET_VENDOR_XYZKconfigsymbol dependency, ifNET_VENDOR_XYZis not set to Y, then you have no way to selectNET_VENDOR_DRIVER_XYZand so your old defconfig breaks.To be clear do we actually care about *old* configs or *def* configs?
I think we care about oldconfig but maybe less so about defconfigs which are in tree and can be updated.
The oldconfigs would have to not be updated on any intervening kernel in the last 10+ years to break, right? Or is there another way that an oldconfig would not have the vendor config set to y at this point?
Quoted 6 lines · Jakub Kicinski
Quoted 5 lines · On Mon, 31 Jan 2022 15:06:01 -0800 Florian Fainelli wrote:
Quoted 5 lines
Quoted 4 lines
Right, but once you start hiding
NET_VENDOR_DRIVER_XYZunder aNET_VENDOR_XYZKconfigsymbol dependency, ifNET_VENDOR_XYZis not set to Y, then you have no way to selectNET_VENDOR_DRIVER_XYZand so your old defconfig breaks.
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
To be clear do we actually care about *old* configs or *def* configs?
I think we care about oldconfig but maybe less so about defconfigs which are in tree and can be updated.
The oldconfigs would have to not be updated on any intervening kernel in the last 10+ years to break, right? Or is there another way that an oldconfig would not have the vendor config set to y at this point?
That sounds very unrealistic, so yes, I don't think at this point that would happen. Even if you had your 15 year old .config file and ran make oldconfig today, you would have some work to do to make sure it still runs on your hardware.
Signature · 1 line
Florian
Quoted 48 lines · Hisashi T Fujinaka
Quoted 46 lines · Florian Fainelli
Quoted 20 lines · Saeed Mahameed
Quoted 19 lines · Geert Uytterhoeven
Quoted 16 lines · Stephen Hemminger
Quoted 9 lines · On Mon, 31 Jan 2022 09:24:50 -0800 Saeed Mahameed <[email protected]> wrote:
From: Saeed Mahameed <[email protected]>
NET_VENDOR_XYZwere defaulted to 'y' for no technical reason.Since all drivers belonging to a vendor are supposed to default to 'n', defaulting all vendors to 'n' shouldn't be an issue, and aligns well with the 'no new drivers' by default mentality.
Signed-off-by Saeed Mahameed <[email protected]>This was done back when vendors were introduced in the network drivers tree.
The default of Y allowed older configurations to just work.Quoted 8 lines
Quoted 3 lines
And changing the defaults means all defconfigs must be updated first, else the user's configs will end up without drivers needed.
As I understand correctly, at least for most common net drivers, having NET_VENDOR_XYZ=y doesn't actually build anything, we have flags per
module for each vendor and those are defaulted to N.Right, but once you start hiding
NET_VENDOR_DRIVER_XYZunder aNET_VENDOR_XYZKconfigsymbol dependency, ifNET_VENDOR_XYZis not set to Y, then you have no way to selectNET_VENDOR_DRIVER_XYZand so your old defconfig breaks.Quoted 10 lines
Quoted 7 lines
Quoted 3 lines
So there was a reason, not sure if it matters anymore. But it seems like useless repainting to change it now.
It might make sense to tune some of the defaults (i.e. change to "default y if ARCH_*") for drivers with clear platform dependencies.
either set hard default to 'n' or just keep it as is, anything else is just more confusion.
Quoted 6 lines
Quoted 3 lines
Maybe the rule should go like this: any new driver vendor defaults to n, and existing ones remain set to y, until we deprecate doing that and switching them all off to n by 5.18?
Forgive my ignorance, but isn't it a regression if things quit working even if it's just a configuration change?
No, kernel configs never were declared as ABI as "regular" users are not supposed to touch it. They use something provided by the distro.
Quoted 4 lines
From a user perspective I like having everything turned on initially so it just works. Pruning things down is a lot easier than trying to figure out what all to turn on. Especially in graphics.
I have completely opposite view here and prefer to have minimal config for my CI, and for my working machines as well.
Thanks
Quoted 3 lines
Signature · 2 lines
-- Hisashi T Fujinaka - htodd at twofifty.com
Quoted 2 lines · Leon Romanovsky
No, kernel configs never were declared as ABI as "regular" users are not supposed to touch it. They use something provided by the distro.
+1
Quoted 14 lines · Florian Fainelli
Quoted 11 lines · Jakub Kicinski
Quoted 9 lines · On Mon, 31 Jan 2022 15:06:01 -0800 Florian Fainelli wrote:
Quoted 6 lines
Quoted 4 lines
Right, but once you start hiding
NET_VENDOR_DRIVER_XYZunder aNET_VENDOR_XYZKconfigsymbol dependency, ifNET_VENDOR_XYZis not set to Y, then you have no way to selectNET_VENDOR_DRIVER_XYZand so your old defconfig breaks.To be clear do we actually care about *old* configs or *def* configs?
I think we care about oldconfig but maybe less so about defconfigs which are in tree and can be updated.
Quoted 8 lines
Quoted 3 lines
The oldconfigs would have to not be updated on any intervening kernel in the last 10+ years to break, right? Or is there another way that an oldconfig would not have the vendor config set to y at this point?
That sounds very unrealistic, so yes, I don't think at this point that would happen. Even if you had your 15 year old .config file and ran make oldconfig today, you would have some work to do to make sure it still runs on your hardware.
I am getting mixed messages here, on one hand we know that this patch might break some old or def configs, but on the other hand people claim that they have to manually fixup their own configs every time "something in configs" changes and they are fine with that.
Obviously I belong to the 2nd camp, hence this patch..
I can sum it up with "it's fine to controllably break *some* .configs for the greater good" .. that's my .2cent.
Thanks,
Saeed.
Jakub Kicinski
maintainerQuoted 9 lines · On Tue, 1 Feb 2022 20:46:03 -0800 Saeed Mahameed wrote:
I am getting mixed messages here, on one hand we know that this patch might break some old or def configs, but on the other hand people claim that they have to manually fixup their own configs every time "something in configs" changes and they are fine with that.
Obviously I belong to the 2nd camp, hence this patch..
I can sum it up with "it's fine to controllably break *some* .configs for the greater good" .. that's my .2cent.
I think we agree that we don't care about oldconfigs IOW someone's random config.
But we do care about defconfigs in the tree, if those indeed include ethernet drivers which would get masked out by vendor=n - they need fixin':
$ find arch/ | grep defconfig arch/x86/configs/i386_defconfig arch/x86/configs/x86_64_defconfig arch/ia64/configs/generic_defconfig arch/ia64/configs/gensparse_defconfig ...
First one from the top:
$ make O=build_tmp/ i386_defconfig $ $EDITOR drivers/net/ethernet/intel/Kconfig $ git diff
drivers/net/ethernet/intel/Kconfig +0 -1
@@ -5,7 +5,6 @@ config NET_VENDOR_INTEL bool "Intel devices" - default y help If you have a network (Ethernet) card belonging to this class, say Y.
$ make O=build_tmp/ i386_defconfig $ diff -urpb build_tmp/.config.old build_tmp/.config --- build_tmp/.config.old 2022-02-01 20:55:37.087373905 -0800 +++ build_tmp/.config 2022-02-01 20:56:32.126044628 -0800 @@ -1784,22 +1784,7 @@ CONFIG_NET_VENDOR_GOOGLE=y # CONFIG_GVE is not set CONFIG_NET_VENDOR_HUAWEI=y # CONFIG_HINIC is not set -CONFIG_NET_VENDOR_I825XX=y -CONFIG_NET_VENDOR_INTEL=y -CONFIG_E100=y -CONFIG_E1000=y -CONFIG_E1000E=y -CONFIG_E1000E_HWTS=y -# CONFIG_IGB is not set -# CONFIG_IGBVF is not set -# CONFIG_IXGB is not set -# CONFIG_IXGBE is not set -# CONFIG_IXGBEVF is not set -# CONFIG_I40E is not set -# CONFIG_I40EVF is not set -# CONFIG_ICE is not set -# CONFIG_FM10K is not set -# CONFIG_IGC is not set +# CONFIG_NET_VENDOR_INTEL is not set CONFIG_NET_VENDOR_MICROSOFT=y # CONFIG_JME is not set CONFIG_NET_VENDOR_LITEX=y
Quoted 57 lines · Jakub Kicinski
Quoted 9 lines · On Tue, 1 Feb 2022 20:46:03 -0800 Saeed Mahameed wrote:
I am getting mixed messages here, on one hand we know that this patch might break some old or def configs, but on the other hand people claim that they have to manually fixup their own configs every time "something in configs" changes and they are fine with that.
Obviously I belong to the 2nd camp, hence this patch..
I can sum it up with "it's fine to controllably break *some* .configs for the greater good" .. that's my .2cent.
I think we agree that we don't care about oldconfigs IOW someone's random config.
But we do care about defconfigs in the tree, if those indeed include ethernet drivers which would get masked out by vendor=n - they need fixin':
$ find arch/ | grep defconfig arch/x86/configs/i386_defconfig arch/x86/configs/x86_64_defconfig arch/ia64/configs/generic_defconfig arch/ia64/configs/gensparse_defconfig ...First one from the top:
$ make O=build_tmp/ i386_defconfig $ $EDITOR drivers/net/ethernet/intel/Kconfig $ git diffdrivers/net/ethernet/intel/Kconfig +0
-0@@ -5,7 +5,6 @@config
NET_VENDOR_INTEL
bool "Intel devices"
- default y
help
If you have a network (Ethernet) card belonging to this class, say Y.$ make O=build_tmp/ i386_defconfig $ diff -urpb build_tmp/.config.old build_tmp/.config.config renamed from .config.old +0
-0@@ -1784,22 +1784,7 @@ CONFIG_NET_VENDOR_GOOGLE=y # CONFIG_GVE is not set
CONFIG_NET_VENDOR_HUAWEI=y
#CONFIG_HINICis not set.config renamed from .config.old +0
-7-CONFIG_NET_VENDOR_I825XX=y -CONFIG_NET_VENDOR_INTEL=y -CONFIG_E100=y -CONFIG_E1000=y -CONFIG_E1000E=y -CONFIG_E1000E_HWTS=y -# CONFIG_IGB is not set
.config
Quoted 10 lines
.config renamed from .config.old +1
-9-# CONFIG_IGBVF is not set -# CONFIG_IXGB is not set -# CONFIG_IXGBE is not set -# CONFIG_IXGBEVF is not set -# CONFIG_I40E is not set -# CONFIG_I40EVF is not set -# CONFIG_ICE is not set -# CONFIG_FM10K is not set -# CONFIG_IGC is not set +# CONFIG_NET_VENDOR_INTEL is not set
We can introduce CONFIG_NET_LEGACY_VENDOR that selects all current vendors. it will be off by default but will be added where needed in the defconfigs
Le 02/02/2022 ? 06:16, Saeed Mahameed a ?crit?:
Quoted 66 lines · Jakub Kicinski
Quoted 65 lines · On Tue, 1 Feb 2022 20:46:03 -0800 Saeed Mahameed wrote:
Quoted 10 lines
I am getting mixed messages here, on one hand we know that this patch might break some old or def configs, but on the other hand people claim that they have to manually fixup their own configs every time "something in configs" changes and they are fine with that.
Obviously I belong to the 2nd camp, hence this patch..
I can sum it up with "it's fine to controllably break *some* .configs for
the greater good" .. that's my .2cent.I think we agree that we don't care about oldconfigs IOW someone's random config.
But we do care about defconfigs in the tree, if those indeed include ethernet drivers which would get masked out by vendor=n - they need fixin':
$ find arch/ | grep defconfig arch/x86/configs/i386_defconfig arch/x86/configs/x86_64_defconfig arch/ia64/configs/generic_defconfig arch/ia64/configs/gensparse_defconfig ...First one from the top:
$ make O=build_tmp/ i386_defconfig $ $EDITOR drivers/net/ethernet/intel/Kconfig $ git diffdrivers/net/ethernet/intel/Kconfig +0
-0@@ -5,7 +5,6 @@config
NET_VENDOR_INTEL
?????? bool "Intel devices"
-?????? default y
?????? help
???????? If you have a network (Ethernet) card belonging to this class, say Y.$ make O=build_tmp/ i386_defconfig $ diff -urpb build_tmp/.config.old build_tmp/.config.config??? 2022-02-01 20:56:32.126044628 -0800 renamed from .config.old??? 2022-02-01 20:55:37.087373905 -0800 +0
-0@@ -1784,22 +1784,7 @@ CONFIG_NET_VENDOR_GOOGLE=y # CONFIG_GVE is not set
CONFIG_NET_VENDOR_HUAWEI=y
#CONFIG_HINICis not set.config??? 2022-02-01 20:56:32.126044628 -0800 renamed from .config.old??? 2022-02-01 20:55:37.087373905 -0800 +0
-12-CONFIG_NET_VENDOR_I825XX=y -CONFIG_NET_VENDOR_INTEL=y -CONFIG_E100=y -CONFIG_E1000=y -CONFIG_E1000E=y -CONFIG_E1000E_HWTS=y -# CONFIG_IGB is not set -# CONFIG_IGBVF is not set -# CONFIG_IXGB is not set -# CONFIG_IXGBE is not set -# CONFIG_IXGBEVF is not set -# CONFIG_I40E is not set
Quoted 8 lines
.config??? 2022-02-01 20:56:32.126044628 -0800
Quoted 5 lines
.config??? 2022-02-01 20:56:32.126044628 -0800 renamed from .config.old??? 2022-02-01 20:55:37.087373905 -0800 +1
-4-# CONFIG_I40EVF is not set -# CONFIG_ICE is not set -# CONFIG_FM10K is not set -# CONFIG_IGC is not set +# CONFIG_NET_VENDOR_INTEL is not setWe can introduce
CONFIG_NET_LEGACY_VENDORthat selects all current vendors. it will be off by default but will be added where needed in the defconfigs
Why such a hack ?
I think we can fix all defconfig with some scripting, all you have to do it to add the relevant CONFIG_NET_VENDOR_SOMEONE=y wherever you find one of its boards in the defconfig.
Christophe
Quoted 78 lines · Christophe Leroy
Le 02/02/2022 ? 06:16, Saeed Mahameed a ?crit?:
Quoted 66 lines · Jakub Kicinski
Quoted 65 lines · On Tue, 1 Feb 2022 20:46:03 -0800 Saeed Mahameed wrote:
Quoted 10 lines
I am getting mixed messages here, on one hand we know that this patch might break some old or def configs, but on the other hand people claim that they have to manually fixup their own configs every time "something in configs" changes and they are fine with that.
Obviously I belong to the 2nd camp, hence this patch..
I can sum it up with "it's fine to controllably break *some* .configs for
the greater good" .. that's my .2cent.I think we agree that we don't care about oldconfigs IOW someone's random config.
But we do care about defconfigs in the tree, if those indeed include ethernet drivers which would get masked out by vendor=n - they need fixin':
$ find arch/ | grep defconfig arch/x86/configs/i386_defconfig arch/x86/configs/x86_64_defconfig arch/ia64/configs/generic_defconfig arch/ia64/configs/gensparse_defconfig ...First one from the top:
$ make O=build_tmp/ i386_defconfig $ $EDITOR drivers/net/ethernet/intel/Kconfig $ git diffdrivers/net/ethernet/intel/Kconfig +0
-0@@ -5,7 +5,6 @@config
NET_VENDOR_INTEL
?????? bool "Intel devices"
-?????? default y
?????? help
???????? If you have a network (Ethernet) card belonging to this class, say Y.$ make O=build_tmp/ i386_defconfig $ diff -urpb build_tmp/.config.old build_tmp/.config.config??? 2022-02-01 20:56:32.126044628 -0800 renamed from .config.old??? 2022-02-01 20:55:37.087373905 -0800 +0
-0@@ -1784,22 +1784,7 @@ CONFIG_NET_VENDOR_GOOGLE=y # CONFIG_GVE is not set
CONFIG_NET_VENDOR_HUAWEI=y
#CONFIG_HINICis not set.config??? 2022-02-01 20:56:32.126044628 -0800 renamed from .config.old??? 2022-02-01 20:55:37.087373905 -0800 +0
-12-CONFIG_NET_VENDOR_I825XX=y -CONFIG_NET_VENDOR_INTEL=y -CONFIG_E100=y -CONFIG_E1000=y -CONFIG_E1000E=y -CONFIG_E1000E_HWTS=y -# CONFIG_IGB is not set -# CONFIG_IGBVF is not set -# CONFIG_IXGB is not set -# CONFIG_IXGBE is not set -# CONFIG_IXGBEVF is not set -# CONFIG_I40E is not setQuoted 8 lines
.config??? 2022-02-01 20:56:32.126044628 -0800
Quoted 5 lines
.config??? 2022-02-01 20:56:32.126044628 -0800 renamed from .config.old??? 2022-02-01 20:55:37.087373905 -0800 +1
-4-# CONFIG_I40EVF is not set -# CONFIG_ICE is not set -# CONFIG_FM10K is not set -# CONFIG_IGC is not set +# CONFIG_NET_VENDOR_INTEL is not setWe can introduce
CONFIG_NET_LEGACY_VENDORthat selects all current vendors. it will be off by default but will be added where needed in the defconfigs
Quoted 2 lines
Why such a hack ?
Reduced chance of error.
Quoted 4 lines
I think we can fix all defconfig with some scripting, all you have to do it to add the relevant
CONFIG_NET_VENDOR_SOMEONE=ywherever you find one of its boards in the defconfig.
Such a script could easily mess up!
I can't think of a clever easily verifiable way to map boards to their VENDORS. Add to that dispersing the VENDORS configs accurately.
I might be just tired though, i will give it a shot in the morning :)
Quoted 1 line
Christophe
Quoted 78 lines · Christophe Leroy
Le 02/02/2022 ? 06:16, Saeed Mahameed a ?crit?:
Quoted 74 lines · Jakub Kicinski
Quoted 60 lines · On Tue, 1 Feb 2022 20:46:03 -0800 Saeed Mahameed wrote:
Quoted 10 lines
I am getting mixed messages here, on one hand we know that this patch might break some old or def configs, but on the other hand people claim that they have to manually fixup their own configs every time "something in configs" changes and they are fine with that.
Obviously I belong to the 2nd camp, hence this patch..
I can sum it up with "it's fine to controllably break *some* .configs for
the greater good" .. that's my .2cent.I think we agree that we don't care about oldconfigs IOW someone's random config.
But we do care about defconfigs in the tree, if those indeed include ethernet drivers which would get masked out by vendor=n - they need fixin':
$ find arch/ | grep defconfig arch/x86/configs/i386_defconfig arch/x86/configs/x86_64_defconfig arch/ia64/configs/generic_defconfig arch/ia64/configs/gensparse_defconfig ...First one from the top:
$ make O=build_tmp/ i386_defconfig $ $EDITOR drivers/net/ethernet/intel/Kconfig $ git diffdrivers/net/ethernet/intel/Kconfig +0
-0@@ -5,7 +5,6 @@config
NET_VENDOR_INTEL
?????? bool "Intel devices"
-?????? default y
?????? help
???????? If you have a network (Ethernet) card belonging to this class, say Y.$ make O=build_tmp/ i386_defconfig $ diff -urpb build_tmp/.config.old build_tmp/.config.config??? 2022-02-01 20:56:32.126044628 -0800 renamed from .config.old??? 2022-02-01 20:55:37.087373905 -0800 +0
-0@@ -1784,22 +1784,7 @@ CONFIG_NET_VENDOR_GOOGLE=y # CONFIG_GVE is not set
CONFIG_NET_VENDOR_HUAWEI=y
#CONFIG_HINICis not set.config??? 2022-02-01 20:56:32.126044628 -0800 renamed from .config.old??? 2022-02-01 20:55:37.087373905 -0800 +0
-7-CONFIG_NET_VENDOR_I825XX=y -CONFIG_NET_VENDOR_INTEL=y -CONFIG_E100=y -CONFIG_E1000=y -CONFIG_E1000E=y -CONFIG_E1000E_HWTS=y -# CONFIG_IGB is not set.config??? 2022-02-01 20:56:32.126044628 -0800
Quoted 10 lines
.config??? 2022-02-01 20:56:32.126044628 -0800 renamed from .config.old??? 2022-02-01 20:55:37.087373905 -0800 +1
-9-# CONFIG_IGBVF is not set -# CONFIG_IXGB is not set -# CONFIG_IXGBE is not set -# CONFIG_IXGBEVF is not set -# CONFIG_I40E is not set -# CONFIG_I40EVF is not set -# CONFIG_ICE is not set -# CONFIG_FM10K is not set -# CONFIG_IGC is not set +# CONFIG_NET_VENDOR_INTEL is not setWe can introduce
CONFIG_NET_LEGACY_VENDORthat selects all current vendors. it will be off by default but will be added where needed in the defconfigs
Sorry I think i messed up my previous reply, here it's again just in case.
Quoted 2 lines
Why such a hack ?
Reduced chance of error.
Quoted 4 lines
I think we can fix all defconfig with some scripting, all you have to do it to add the relevant
CONFIG_NET_VENDOR_SOMEONE=ywherever you find one of its boards in the defconfig.
Such a script could easily mess up!
I can't think of a clever easily verifiable way to map boards to their VENDORS. Add to that dispersing the VENDORS configs accurately.
I might be just tired though, i will give it a shot in the morning :)
Quoted 1 line
Christophe
Quoted 2 lines · Saeed Mahameed
I can't think of a clever easily verifiable way to map boards to their VENDORS. Add to that dispersing the VENDORS configs accurately.
Just an idea...
1. make foo_defconfig
2. for each vendor, do scripts/config --disable vendor
3. make savedefconfig
4. compare defconfig with foo_defconfig difference means some MAC was removed
HTH,
Richard
Quoted 5 lines · Richard Cochran
Quoted 2 lines · Saeed Mahameed
I can't think of a clever easily verifiable way to map boards to their VENDORS. Add to that dispersing the VENDORS configs accurately.
Quoted 7 lines
Just an idea...
1. make
foo_defconfig
2. for each vendor, doscripts/config--disable vendor
3. make savedefconfig
4. compare defconfig withfoo_defconfigdifference means some MAC was removed
This needs an extra 'savedefconfig' step in the beginning, as a lot of the defconfig
files are already different from what you get after savedefconfig, both in the order of options, and in options that got renamed or removed over time.
Arnd