Skip to contentSkip to conversation

acd: remove 'No target or source conflict' print

PATCH Applied James Prestwood 2 participants 2 messages Jan 31, 2022

lore
Share & tools
lore

James Prestwood

author
#0 lore raw

PATCH 1/1 acd: remove 'No target or source conflict' print

This is quite common and expected with ACD, and printing it serves no useful purpose. The kind of debugging that is important is when a conflict is detected.

---
 ell/acd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
ell/acd.c +1 -4
index 4216898..3c8e7fe 100644
@@ -281,11 +281,8 @@ static bool acd_read_handler(struct l_io *io, void *user_data)
 	target_conflict = probe &&
 		!memcmp(arp.arp_tpa, &acd->ip, sizeof(uint32_t));
 
-	if (!source_conflict && !target_conflict) {
-		ACD_DEBUG("No target or source conflict detected for "NIPQUAD_FMT,
-				NIPQUAD(acd->ip));
+	if (!source_conflict && !target_conflict)
 		return true;
-	}
 
 	switch (acd->state) {
 	case ACD_STATE_PROBE:
Signature · 1 line
2.31.1
Applied
#1 lore raw

Hi James,

Quoted 7 lines · James Prestwood

This is quite common and expected with ACD, and printing it serves no useful purpose. The kind of debugging that is important is when a conflict is detected.

---
  ell/acd.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

Applied, thanks.

Regards,
-Denis