Skip to contentSkip to conversation

hwmon: Fix possible NULL pointer

PATCH Guenter Roeck 1 participant 1 message Jan 31, 2022 Hardware monitoring

lore
Share & tools
lore

Guenter Roeck

author maintainer Applied
#0 lore raw
Quoted 7 lines · Paul Cercueil

The recent addition of the label attribute added some code that read the "label" device property, without checking first that "dev" was non-NULL.

Fix this issue by first checking that "dev" is non-NULL.

Fixes ccd98cba6a18 ("hwmon: Add "label" attribute")

Applied.

Thanks,
Guenter

Quoted 20 lines
---
 drivers/hwmon/hwmon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/hwmon.c +1 -1
index e36ea82da147..5915fedee69b 100644
@@ -807,7 +807,7 @@ __hwmon_device_register(struct device *dev, const char *name, void *drvdata,
 		hdev->groups = groups;
 	}
 
-	if (device_property_present(dev, "label")) {
+	if (dev && device_property_present(dev, "label")) {
 		err = device_property_read_string(dev, "label", &label);
 		if (err < 0)
 			goto free_hwmon;
Signature · 1 line
2.34.1