mtd: spi-nor: Init xtx flash xt25f32b, xt25f128b
Subsystems (2)
PATCH 1/1 mtd: spi-nor: Init xtx flash xt25f32b, xt25f128b
Add the JEDEC identifiers for xt25f32b and xt25f128b. Based on the referenced previous patch from microcai.
Only xt25f32b was verified in hardware (On both Radxa RockPi 4A and 4C), but the ID of the xt25f128b can also be found in u-boot patches from Armbian.
--- drivers/mtd/spi-nor/Makefile | 1 + drivers/mtd/spi-nor/core.c | 1 + drivers/mtd/spi-nor/core.h | 1 + drivers/mtd/spi-nor/xtx.c | 25 +++++++++++++++++++++++++ 4 files changed, 28 insertions(+) create mode 100644 drivers/mtd/spi-nor/xtx.c
drivers/mtd/spi-nor/Makefile +1 -0
@@ -17,6 +17,7 @@ spi-nor-objs += sst.o spi-nor-objs += winbond.o spi-nor-objs += xilinx.o spi-nor-objs += xmc.o +spi-nor-objs += xtx.o obj-$(CONFIG_MTD_SPI_NOR) += spi-nor.o obj-$(CONFIG_MTD_SPI_NOR) += controllers/
drivers/mtd/spi-nor/core.c +1 -0
@@ -1846,6 +1846,7 @@ static const struct spi_nor_manufacturer *manufacturers[] = { &spi_nor_winbond, &spi_nor_xilinx, &spi_nor_xmc, + &spi_nor_xtx, }; static const struct flash_info *
drivers/mtd/spi-nor/core.h +1 -0
@@ -536,6 +536,7 @@ extern const struct spi_nor_manufacturer spi_nor_sst;extern const struct spi_nor_manufacturer spi_nor_winbond;extern const struct spi_nor_manufacturer spi_nor_xilinx;extern const struct spi_nor_manufacturer spi_nor_xmc; +extern const struct spi_nor_manufacturer spi_nor_xtx;extern const struct attribute_group *spi_nor_sysfs_groups[];
drivers/mtd/spi-nor/xtx.c new file +25 -0
@@ -0,0 +1,25 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (C) 2005, Intec Automation Inc. +* Copyright (C) 2014, Freescale Semiconductor, Inc. +*/ + +#include <linux/mtd/spi-nor.h> + +#include "core.h" + +static const struct flash_info xtx_parts[] = { +/* XTX (Shenzhen Xin Tian Xia Tech) */ + { "xt25f32b", INFO(0x0b4016, 0, 64 * 1024, 64) +NO_SFDP_FLAGS (SECT_4K |SPI_NOR_DUAL_READ | +SPI_NOR_QUAD_READ ) }, + { "xt25f128b", INFO(0x0b4018, 0, 64 * 1024, 256) +NO_SFDP_FLAGS (SECT_4K |SPI_NOR_DUAL_READ | +SPI_NOR_QUAD_READ ) }, +}; + +const struct spi_nor_manufacturer spi_nor_xtx = { + .name ="xtx" , + .parts = xtx_parts, + .nparts =ARRAY_SIZE (xtx_parts), +};
Signature · 6 lines
2.34.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi,
Am 2022-02-01 01:25, schrieb Carl Richard Theodor Schneider:
Quoted 6 lines
Add the JEDEC identifiers for xt25f32b and xt25f128b. Based on the referenced previous patch from microcai.
Only xt25f32b was verified in hardware (On both Radxa RockPi 4A and 4C), but the ID of the xt25f128b can also be found in u-boot patches from Armbian.
We require SFDP dumps of new flashes. Therefore, you can only add flashes which you actually have (and have tested). See [1] how to provide such a dump.
Quoted 62 lines
Link:
https://lore.kernel.org/lkml/CAMgqO2y9MYDj6antOaWLBRKU8vGEwqCB-Y1TkXTSWsmsed+W6A@mail.gmail.com/
Link:
https://datasheet.lcsc.com/szlcsc/2005251035_XTX-XT25F32BSOIGU-S_C558851.pdf
Link:
https://datasheet.lcsc.com/szlcsc/2005251034_XTX-XT25F128BSSIGT_C558844.pdf
Link:
https://github.com/armbian/build/blob/master/patch/u-boot/u-boot-rockchip64/general-add-xtx-spi-nor-chips.patchSigned-off-by Carl Richard Theodor Schneider <[email protected]>--- drivers/mtd/spi-nor/Makefile | 1 + drivers/mtd/spi-nor/core.c | 1 + drivers/mtd/spi-nor/core.h | 1 + drivers/mtd/spi-nor/xtx.c | 25 +++++++++++++++++++++++++ 4 files changed, 28 insertions(+) create mode 100644 drivers/mtd/spi-nor/xtx.cdrivers/mtd/spi-nor/Makefile +1
-0@@ -17,6 +17,7 @@ spi-nor-objs += sst.o spi-nor-objs += winbond.o spi-nor-objs += xilinx.o spi-nor-objs += xmc.o +spi-nor-objs += xtx.o obj-$(CONFIG_MTD_SPI_NOR) += spi-nor.o obj-$(CONFIG_MTD_SPI_NOR) += controllers/drivers/mtd/spi-nor/core.c +1
-0@@ -1846,6 +1846,7 @@ static const struct spi_nor_manufacturer *manufacturers[] = { &spi_nor_winbond, &spi_nor_xilinx, &spi_nor_xmc, + &spi_nor_xtx, };static const struct
flash_info*drivers/mtd/spi-nor/core.h +1
-0@@ -536,6 +536,7 @@ extern const struct spi_nor_manufacturer spi_nor_sst;extern const struct spi_nor_manufacturer spi_nor_winbond;extern const struct spi_nor_manufacturer spi_nor_xilinx;extern const struct spi_nor_manufacturer spi_nor_xmc; +extern const struct spi_nor_manufacturer spi_nor_xtx;extern const struct attribute_group *spi_nor_sysfs_groups[];drivers/mtd/spi-nor/xtx.c new file +0
-0
drivers/mtd/spi-nor/xtx.c line 5
Quoted 5 lines
drivers/mtd/spi-nor/xtx.c new file +5
-0@@ -0,0 +1,25 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* Copyright (C) 2005, Intec Automation Inc. +* Copyright (C) 2014, Freescale Semiconductor, Inc. +*/
Can this be dropped? I don't think there is any of the original code left here. no?
drivers/mtd/spi-nor/xtx.c line 15
Quoted 10 lines
drivers/mtd/spi-nor/xtx.c new file +10
-0+ +#include <linux/mtd/spi-nor.h> + +#include "core.h" + +static const struct flash_info xtx_parts[] = { +/* XTX (Shenzhen Xin Tian Xia Tech) */ + { "xt25f32b", INFO(0x0b4016, 0, 64 * 1024, 64) +NO_SFDP_FLAGS (SECT_4K |SPI_NOR_DUAL_READ | +SPI_NOR_QUAD_READ ) },
You'd either need to specify SPI_NOR_SKIP_SFDP or PARSE_SFDP and drop the NO_SFDP_FLAGS if there is SFDP support.
But more importantly, xtx is missing the continuation bytes and is probably reusing the manufacturer id from another vendor. So, this would have to be rebased on Tudors id collision patchset [2]. There is already support for the xt25f128b btw.
drivers/mtd/spi-nor/xtx.c line 25
Quoted 10 lines
drivers/mtd/spi-nor/xtx.c new file +10
-0+ { "xt25f128b", INFO(0x0b4018, 0, 64 * 1024, 256) +NO_SFDP_FLAGS (SECT_4K |SPI_NOR_DUAL_READ | + SPI_NOR_QUAD_READ) }, +}; + +const struct spi_nor_manufacturer spi_nor_xtx = { + .name ="xtx" , + .parts = xtx_parts, + .nparts =ARRAY_SIZE (xtx_parts), +};
[1] https://lore.kernel.org/linux-mtd/[email protected]/
[2] https://patchwork.ozlabs.org/project/linux-mtd/list/?series=270725
Signature · 1 line
-michael