Skip to contentSkip to conversation

ksmbd: reduce smb direct max read/write size

PATCH In review Namjae Jeon 2 participants 2 messages Feb 1, 2022

Subsystems (2)
lore
Share & tools
lore

Namjae Jeon

author maintainer
#0 lore raw

PATCH v2 1/1 ksmbd: reduce smb direct max read/write size

ksmbd does not support more than one Buffer Descriptor V1 element in an smbdirect protocol request. Reducing the maximum read/write size to about 512KB allows interoperability with Windows over a wider variety of RDMA NICs, as an interim workaround.

---
v2:
- update patch description (Written by Tom Talpey).

 fs/ksmbd/transport_rdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ksmbd/transport_rdma.c +1 -1
index 3c1ec1ac0b27..ba5a22bc2e6d 100644
@@ -80,7 +80,7 @@ static int smb_direct_max_fragmented_recv_size = 1024 * 1024;
 /*  The maximum single-message size which can be received */
 static int smb_direct_max_receive_size = 8192;
 
-static int smb_direct_max_read_write_size = 1048512;
+static int smb_direct_max_read_write_size = 524224;
 
 static int smb_direct_max_outstanding_rw_ops = 8;
 
Signature · 1 line
2.25.1
reviewer Reviewed-by on v2 1/1
#1 lore raw

Thanks for walking me through the explanation.

Feb 1, 2022 4:16:59 AM Namjae Jeon <[email protected]>:

Quoted 29 lines

ksmbd does not support more than one Buffer Descriptor V1 element in an smbdirect protocol request. Reducing the maximum read/write size to about 512KB allows interoperability with Windows over a wider variety of RDMA NICs, as an interim workaround.

---
v2:
   - update patch description (Written by Tom Talpey).

fs/ksmbd/transport_rdma.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
fs/ksmbd/transport_rdma.c +1 -1
index 3c1ec1ac0b27..ba5a22bc2e6d 100644
@@ -80,7 +80,7 @@ static int smb_direct_max_fragmented_recv_size = 1024 * 1024;
 /*  The maximum single-message size which can be received */
 static int smb_direct_max_receive_size = 8192;
 
-static int smb_direct_max_read_write_size = 1048512;
+static int smb_direct_max_read_write_size = 524224;
 
 static int smb_direct_max_outstanding_rw_ops = 8;
 
Signature · 1 line
2.25.1