Skip to contentSkip to conversation

linux-next: build warning after merge of the akpm-current tree

DISCUSSION Stephen Rothwell 3 participants 3 messages Feb 2, 2022 – Feb 3, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the akpm-current tree, today's linux-next build (htmldocs) produced this warning:

Documentation/admin-guide/sysctl/kernel.rst:603: WARNING: Malformed table. Text in column margin in table line 2.

= =================================
0x0 NUMA_BALANCING_DISABLED
0x1 NUMA_BALANCING_NORMAL
0x2 NUMA_BALANCING_MEMORY_TIERING
= =================================

Introduced by commit

49ec6eb41c49 ("NUMA balancing: optimize page placement for memory tiering system")

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 14 lines · On Wed, 2 Feb 2022 14:54:37 +1100 Stephen Rothwell <[email protected]> wrote:

Hi all,

After merging the akpm-current tree, today's linux-next build (htmldocs) produced this warning:

Documentation/admin-guide/sysctl/kernel.rst:603: WARNING: Malformed table. Text in column margin in table line 2.

= =================================
0x0 NUMA_BALANCING_DISABLED
0x1 NUMA_BALANCING_NORMAL
0x2 NUMA_BALANCING_MEMORY_TIERING
= =================================

Quoted 3 lines

Introduced by commit

49ec6eb41c49 ("NUMA balancing: optimize page placement for memory tiering system")

I assume this fixes? (With gratuitous grammar fixes)

Documentation/admin-guide/sysctl/kernel.rst renamed from Documentation/admin-guide/sysctl/kernel.rst~numa-balancing-optimize-page-placement-for-memory-tiering-system-fix +6 -6
@@ -595,14 +595,14 @@ Documentation/admin-guide/kernel-paramet
 numa_balancing
 ==============
 
-Enables/disables and configure automatic page fault based NUMA memory
-balancing.  Memory is moved automatically to nodes that access it
-often.  The value to set can be the result to OR the following,
+Enables/disables and configures automatic page fault based NUMA memory
+balancing.  Memory is moved automatically to nodes that access it often. 
+The value to set can be the result of ORing the following,
 
 = =================================
-0x0 NUMA_BALANCING_DISABLED
-0x1 NUMA_BALANCING_NORMAL
-0x2 NUMA_BALANCING_MEMORY_TIERING
+0 NUMA_BALANCING_DISABLED
+1 NUMA_BALANCING_NORMAL
+2 NUMA_BALANCING_MEMORY_TIERING
 = =================================
 
 Or NUMA_BALANCING_NORMAL to optimize page placement among different

_

reviewer
#2 lore raw
Quoted 16 lines · Andrew Morton
Quoted 14 lines · On Wed, 2 Feb 2022 14:54:37 +1100 Stephen Rothwell <[email protected]> wrote:

Hi all,

After merging the akpm-current tree, today's linux-next build (htmldocs) produced this warning:

Documentation/admin-guide/sysctl/kernel.rst:603: WARNING: Malformed table. Text in column margin in table line 2.

= =================================
0x0 NUMA_BALANCING_DISABLED
0x1 NUMA_BALANCING_NORMAL
0x2 NUMA_BALANCING_MEMORY_TIERING
= =================================

Quoted 6 lines
Quoted 3 lines

Introduced by commit

49ec6eb41c49 ("NUMA balancing: optimize page placement for memory tiering system")

I assume this fixes? (With gratuitous grammar fixes)

Looks good.

--- a/Documentation/admin-guide/sysctl/kernel.rst~numa-balancing-optimize-page-placement-for-memory-tiering-system-fix

Documentation/admin-guide/sysctl/kernel.rst Documentation/admin-guide/kernel-paramet · line 600

Quoted 11 lines

+++ a/Documentation/admin-guide/sysctl/kernel.rst

Documentation/admin-guide/sysctl/kernel.rst renamed from Documentation/admin-guide/sysctl/kernel.rst~numa-balancing-optimize-page-placement-for-memory-tiering-system-fix +3 -3
@@ -595,14 +595,14 @@ Documentation/admin-guide/kernel-paramet
 numa_balancing
 ==============
 
-Enables/disables and configure automatic page fault based NUMA memory
-balancing.  Memory is moved automatically to nodes that access it
-often.  The value to set can be the result to OR the following,
+Enables/disables and configures automatic page fault based NUMA memory
+balancing.  Memory is moved automatically to nodes that access it often. 
+The value to set can be the result of ORing the following,

except for that ending comma...

Quoted 11 lines
Documentation/admin-guide/sysctl/kernel.rst renamed from Documentation/admin-guide/sysctl/kernel.rst~numa-balancing-optimize-page-placement-for-memory-tiering-system-fix +3 -3
 = =================================
-0x0 NUMA_BALANCING_DISABLED
-0x1 NUMA_BALANCING_NORMAL
-0x2 NUMA_BALANCING_MEMORY_TIERING
+0 NUMA_BALANCING_DISABLED
+1 NUMA_BALANCING_NORMAL
+2 NUMA_BALANCING_MEMORY_TIERING
 = =================================
 
 Or NUMA_BALANCING_NORMAL to optimize page placement among different
Quoted 2 lines

_

Thanks.

Signature · 1 line
~Randy