Skip to contentSkip to conversation

drm/tiny: Ensure DT compatibles have SPI device IDs

PATCH In review Mark Brown 2 participants 4 messages Feb 2, 2022 – Feb 3, 2022

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

v2 cover drm/tiny: Ensure DT compatibles have SPI device IDs

Currently autoloading for SPI devices does not use the DT ID table, it uses SPI modalises. Supporting OF modalises is going to be difficult if not impractical, an attempt was made but has been reverted, so this series adds SPI IDs where they aren't provided for a given modalias.

v2:
- Rebase onto v5.17-rc1.

Mark Brown (2):
drm/ili9486: Add SPI ID table
drm/st7735r: Add SPI ID table

 drivers/gpu/drm/tiny/ili9486.c | 2 ++
 drivers/gpu/drm/tiny/st7735r.c | 1 +
 2 files changed, 3 insertions(+)

base-commit: e783362eb54cd99b2cac8b3a9aeac942e6f6ac07

Signature · 1 line
2.30.2
author
#1 lore raw

PATCH v2 1/2 drm/ili9486: Add SPI ID table

Currently autoloading for SPI devices does not use the DT ID table, it uses SPI modalises. Supporting OF modalises is going to be difficult if not impractical, an attempt was made but has been reverted, so ensure that module autoloading works for this driver by ensuring that there are SPI IDs for all OF IDs.

Fixes 96c8395e2166 ("spi: Revert modalias changes")
Cc Kamlesh Gurudasani <[email protected]>
---
 drivers/gpu/drm/tiny/ili9486.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/tiny/ili9486.c +2 -0
index e9a63f4b2993..da4dc48db030 100644
@@ -182,6 +182,8 @@ MODULE_DEVICE_TABLE(of, ili9486_of_match);
 
 static const struct spi_device_id ili9486_id[] = {
 	{ "ili9486", 0 },
+	{ "rpi-lcd-35", 0 },
+	{ "piscreen", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, ili9486_id);
Signature · 1 line
2.30.2
author
#2 lore raw

PATCH v2 2/2 drm/st7735r: Add SPI ID table

In reply to Mark Brown

Currently autoloading for SPI devices does not use the DT ID table, it uses SPI modalises. Supporting OF modalises is going to be difficult if not impractical, an attempt was made but has been reverted, so ensure that module autoloading works for this driver by ensuring that there are SPI IDs for all OF IDs.

Fixes 96c8395e2166 ("spi: Revert modalias changes")
Cc David Lechner <[email protected]>
---
 drivers/gpu/drm/tiny/st7735r.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/tiny/st7735r.c +1 -0
index fc40dd10efa8..713e4b286210 100644
@@ -174,6 +174,7 @@ MODULE_DEVICE_TABLE(of, st7735r_of_match);
 
 static const struct spi_device_id st7735r_id[] = {
 	{ "jd-t18003-t01", (uintptr_t)&jd_t18003_t01_cfg },
+	{ "rh128128t", (uintptr_t)&rh128128t_cfg },
 	{ },
 };
 MODULE_DEVICE_TABLE(spi, st7735r_id);
Signature · 1 line
2.30.2
Reviewed-by on the v2 series
#3 lore raw
In reply to Mark Brown
Quoted 8 lines · Mark Brown

Currently autoloading for SPI devices does not use the DT ID table, it uses SPI modalises. Supporting OF modalises is going to be difficult if not impractical, an attempt was made but has been reverted, so this series adds SPI IDs where they aren't provided for a given modalias.

v2:
- Rebase onto v5.17-rc1.

Quoted 8 lines

Mark Brown (2):
drm/ili9486: Add SPI ID table
drm/st7735r: Add SPI ID table

 drivers/gpu/drm/tiny/ili9486.c | 2 ++
 drivers/gpu/drm/tiny/st7735r.c | 1 +
 2 files changed, 3 insertions(+)

Best regards,

Signature · 3 lines
Javier Martinez Canillas
Linux Engineering
Red Hat