HyperV: Synthetic Debugging device
cover HyperV: Synthetic Debugging device
This patchset adds support for the synthetic debugging device.
HyperV supports a special transport layer for the kernel debugger when running in HyperV.
This patchset add supports for this device so you could have a setup fast windows kernel debugging.
At this point of time, DHCP is not implmeneted so to set this up few things need to be noted.
The scenario I used to test is having 2 VMs in the same virtual network
i.e a Debugger VM with the NIC:
-nic tap,model=virtio,mac=02:ca:01:01:01:01,script=/etc/qemu-ifup
And it's IP is going to be static 192.168.53.12
And the VM we want to debug, to which we need to have the englightments
and vmbus configured:
-cpu host,hv-relaxed,hv_spinlocks=0x1fff,hv_time,+vmx,invtsc,hv-vapic,hv-vpindex,hv-synic,hv-syndbg \
-device vmbus-bridge \
-device hv-syndbg,host_ip=192.168.53.12,host_port=50000,use_hcalls=false \
-nic tap,model=virtio,mac=02:ca:01:01:01:02,script=/etc/qemu-ifup \
Then in the debuggee VM we would setup the kernel debugging in the following way:
If the VM is older than Win8:
* Copy the proper platform kdvm.dll (make sure it's called kdvm.dll even if platform is 32bit) bcdedit /set {GUID} dbgtransport kdvm.dll
bcdedit /set {GUID} loadoptions host_ip="1.2.3.4",host_port="50000",nodhcp bcdedit /set {GUID} debug on
bcdedit /set {GUID} halbreakpoint on
Win8 and late:
bcdedit /dbgsettings net hostip:7.7.7.7 port:50000 nodhcp
This is all the setup that is required to get the synthetic debugger configured correctly.
Jon Doron (4):
hyperv: SControl is optional to enable SynIc
hyperv: Add definitions for syndbg
hyperv: Add support to process syndbg commands
hw: hyperv: Initial commit for Synthetic Debugging device
docs/hyperv.txt | 15 + hw/hyperv/Kconfig | 5 + hw/hyperv/hyperv.c | 475 +++++++++++++++++++++++++------ hw/hyperv/meson.build | 1 + hw/hyperv/syndbg.c | 407 ++++++++++++++++++++++++++ include/hw/hyperv/hyperv-proto.h | 52 ++++ include/hw/hyperv/hyperv.h | 60 ++++ target/i386/cpu.c | 2 + target/i386/cpu.h | 7 + target/i386/kvm/hyperv-proto.h | 37 +++ target/i386/kvm/hyperv-stub.c | 6 + target/i386/kvm/hyperv.c | 52 +++- target/i386/kvm/kvm.c | 76 ++++- 13 files changed, 1105 insertions(+), 90 deletions(-) create mode 100644 hw/hyperv/syndbg.c
Signature · 1 line
2.34.1
PATCH 3/4 hyperv: Add support to process syndbg commands
SynDbg commands can come from two different flows:
1. Hypercalls, in this mode the data being sent is fully encapsulated network packets.
2. SynDbg specific MSRs, in this mode only the data that needs to be transfered is passed.
--- docs/hyperv.txt | 15 +++ hw/hyperv/hyperv.c | 242 ++++++++++++++++++++++++++++++++++ include/hw/hyperv/hyperv.h | 58 ++++++++ target/i386/cpu.c | 2 + target/i386/cpu.h | 7 + target/i386/kvm/hyperv-stub.c | 6 + target/i386/kvm/hyperv.c | 52 +++++++- target/i386/kvm/kvm.c | 76 ++++++++++- 8 files changed, 450 insertions(+), 8 deletions(-)
docs/hyperv.txt +15 -0
@@ -225,6 +225,21 @@ default (WS2016). Note: hv-version-id-* are not enlightenments and thus don't enable Hyper-V identification when specified without any other enlightenments. +3.21. hv-syndbg +=============== +Enables Hyper-V synthetic debugger interface, this is a special interface used +by Windows Kernel debugger to send the packets through, rather than sending +them via serial/network . +Whe enabled, this enlightenment provides additional communication facilities +to the guest: SynDbg messages. +This new communication is used by Windows Kernel debugger rather than sending +packets via serial/network, adding significant performance boost over the other +comm channels. +This enlightenment requires a VMBus device (-device vmbus-bridge,irq=15) +and the follow enlightenments to work: +hv-relaxed,hv_time,hv-vapic,hv-vpindex,hv-synic,hv-runtime,hv-stimer + + 4. Supplementary features =========================
hw/hyperv/hyperv.c +242 -0
245 lines not on this page · raw message
include/hw/hyperv/hyperv.h +58 -0
62 lines not on this page · raw message
target/i386/cpu.c +2 -0
@@ -6841,6 +6841,8 @@ static Property x86_cpu_properties[] = { HYPERV_FEAT_AVIC, 0),DEFINE_PROP_ON_OFF_AUTO ("hv-no-nonarch-coresharing" ,X86CPU , hyperv_no_nonarch_cs,ON_OFF_AUTO_OFF ), +DEFINE_PROP_BIT64 ("hv-syndbg" ,X86CPU , hyperv_features, +HYPERV_FEAT_SYNDBG ,0 ),DEFINE_PROP_BOOL ("hv-passthrough" ,X86CPU , hyperv_passthrough, false), DEFINE_PROP_BOOL("hv-enforce-cpuid", X86CPU, hyperv_enforce_cpuid, false),
target/i386/cpu.h +7 -0
@@ -1060,6 +1060,7 @@ typedef uint64_t FeatureWordArray[FEATURE_WORDS];#define HYPERV_FEAT_IPI 13#define HYPERV_FEAT_STIMER_DIRECT 14#define HYPERV_FEAT_AVIC 15 +#define HYPERV_FEAT_SYNDBG 16#ifndef HYPERV_SPINLOCK_NEVER_NOTIFY #define HYPERV_SPINLOCK_NEVER_NOTIFY 0xFFFFFFFF
@@ -1560,6 +1561,12 @@ typedef struct CPUX86State {uint64_t msr_hv_hypercall;uint64_t msr_hv_guest_os_id;uint64_t msr_hv_tsc; +uint64_t msr_hv_syndbg_control; +uint64_t msr_hv_syndbg_status; +uint64_t msr_hv_syndbg_send_page; +uint64_t msr_hv_syndbg_recv_page; +uint64_t msr_hv_syndbg_pending_page; +uint64_t msr_hv_syndbg_options;/* Per-VCPU HV MSRs */ uint64_t msr_hv_vapic;
target/i386/kvm/hyperv-stub.c +6 -0
@@ -27,6 +27,12 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit)return 0 ;case KVM_EXIT_HYPERV_HCALL : exit->u.hcall.result =HV_STATUS_INVALID_HYPERCALL_CODE ; +return 0 ; +case KVM_EXIT_HYPERV_SYNDBG : +if (!hyperv_feat_enabled (cpu,HYPERV_FEAT_SYNDBG )) { +return -1 ; + } +return 0 ;default :return -1 ;
target/i386/kvm/hyperv.c +49 -3
69 lines not on this page · raw message
target/i386/kvm/kvm.c +71 -5
139 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH 1/4 hyperv: SControl is optional to enable SynIc
In reply to Jon DoronSynIc can be enabled regardless of the SControl mechanisim which can register a GSI for a given SintRoute.
This behaviour can achived by setting enabling SIMP and then the guest will poll on the message slot.
Once there is another message pending the host will set the message slot with the pending flag.
When the guest polls from the message slot, incase the pending flag is set it will write to the HV_X64_MSR_EOM indicating it has cleared the slow and we can try and push our message again.
--- hw/hyperv/hyperv.c | 233 ++++++++++++++++++++++++------------- include/hw/hyperv/hyperv.h | 2 + 2 files changed, 153 insertions(+), 82 deletions(-)
hw/hyperv/hyperv.c +151 -82
@@ -27,18 +27,70 @@ struct SynICState {CPUState *cs; -bool enabled; +bool sctl_enabled;hwaddr msg_page_addr;hwaddr event_page_addr;MemoryRegion msg_page_mr;MemoryRegion event_page_mr;struct hyperv_message_page *msg_page;struct hyperv_event_flags_page *event_page; + +QemuMutex sint_routes_mutex; + QLIST_HEAD(, HvSintRoute) sint_routes; };#define TYPE_SYNIC "hyperv-synic"OBJECT_DECLARE_SIMPLE_TYPE (SynICState,SYNIC ) +/* +* KVM has its own message producers (SynIC timers). To guarantee +* serialization with both KVM vcpu and the guest cpu, the messages are first +* staged in an intermediate area and then posted to the SynIC message page in +* the vcpu thread. + */ +typedef struct HvSintStagedMessage { +/* message content staged by hyperv_post_msg */ +struct hyperv_message msg; +/* callback + data (r/o) to complete the processing in a BH */ +HvSintMsgCb cb; +void *cb_data; +/* message posting status filled by cpu_post_msg */ +int status; +/* passing the buck: */ +enum { +/* initial state */ +HV_STAGED_MSG_FREE , +/* +* hyperv_post_msg (e.g. in main loop) grabs the staged area (FREE -> +* BUSY), copies msg, and schedules cpu_post_msg on the assigned cpu +*/ +HV_STAGED_MSG_BUSY , +/* +* cpu_post_msg (vcpu thread) tries to copy staged msg to msg slot, +* notify the guest, records the status, marks the posting done (BUSY +* -> POSTED), and schedules sint_msg_bh BH +*/ +HV_STAGED_MSG_POSTED , +/* +* sint_msg_bh (BH) verifies that the posting is done, runs the +* callback, and starts over (POSTED -> FREE) +*/ + } state; +}HvSintStagedMessage ; + +struct HvSintRoute { +uint32_t sint; +SynICState *synic; +int gsi; +EventNotifier sint_set_notifier; +EventNotifier sint_ack_notifier; + +HvSintStagedMessage *staged_msg; + +unsigned refcount; +QLIST_ENTRY (HvSintRoute) link; +}; +static bool synic_enabled;bool hyperv_is_synic_enabled (void )
@@ -51,11 +103,11 @@ static SynICState *get_synic(CPUState *cs)return SYNIC (object_resolve_path_component (OBJECT (cs),"synic" )); } -static void synic_update (SynICState *synic,bool enable, +static void synic_update (SynICState *synic,bool sctl_enable,hwaddr msg_page_addr,hwaddr event_page_addr) { - synic->enabled = enable; + synic->sctl_enabled = sctl_enable;if (synic->msg_page_addr != msg_page_addr) {if (synic->msg_page_addr) { memory_region_del_subregion(get_system_memory(),
@@ -80,7 +132,7 @@ static void synic_update(SynICState *synic, bool enable, } } -void hyperv_synic_update (CPUState *cs,bool enable, +void hyperv_synic_update (CPUState *cs,bool sctl_enable,hwaddr msg_page_addr,hwaddr event_page_addr) {SynICState *synic =get_synic (cs);
@@ -89,7 +141,7 @@ void hyperv_synic_update(CPUState *cs, bool enable,return ; } -synic_update (synic, enable, msg_page_addr, event_page_addr); +synic_update (synic, sctl_enable, msg_page_addr, event_page_addr); }static void synic_realize (DeviceState *dev,Error **errp)
@@ -110,16 +162,20 @@ static void synic_realize(DeviceState *dev, Error **errp) sizeof(*synic->event_page), &error_abort); synic->msg_page =memory_region_get_ram_ptr (&synic->msg_page_mr); synic->event_page =memory_region_get_ram_ptr (&synic->event_page_mr); +qemu_mutex_init (&synic->sint_routes_mutex); +QLIST_INIT (&synic->sint_routes);g_free (msgp_name);g_free (eventp_name); } +static void synic_reset (DeviceState *dev) {SynICState *synic =SYNIC (dev);memset (synic->msg_page,0 ,sizeof (*synic->msg_page));memset (synic->event_page,0 ,sizeof (*synic->event_page));synic_update (synic, false,0 ,0 ); +assert (QLIST_EMPTY (&synic->sint_routes)); }static void synic_class_init (ObjectClass *klass,void *data)
@@ -168,54 +224,6 @@ static void synic_register_types(void)type_init (synic_register_types) -/* -* KVM has its own message producers (SynIC timers). To guarantee -* serialization with both KVM vcpu and the guest cpu, the messages are first -* staged in an intermediate area and then posted to the SynIC message page in -* the vcpu thread. -*/ -typedef struct HvSintStagedMessage { -/* message content staged by hyperv_post_msg */ -struct hyperv_message msg; -/* callback + data (r/o) to complete the processing in a BH */ -HvSintMsgCb cb; -void *cb_data; -/* message posting status filled by cpu_post_msg */ -int status; -/* passing the buck: */ -enum { -/* initial state */ -HV_STAGED_MSG_FREE , -/* -* hyperv_post_msg (e.g. in main loop) grabs the staged area (FREE -> -* BUSY), copies msg, and schedules cpu_post_msg on the assigned cpu -*/ -HV_STAGED_MSG_BUSY , -/* -* cpu_post_msg (vcpu thread) tries to copy staged msg to msg slot, -* notify the guest, records the status, marks the posting done (BUSY -* -> POSTED), and schedules sint_msg_bh BH -*/ -HV_STAGED_MSG_POSTED , -/* -* sint_msg_bh (BH) verifies that the posting is done, runs the -* callback, and starts over (POSTED -> FREE) -*/ - } state; -} HvSintStagedMessage; - -struct HvSintRoute { -uint32_t sint; -SynICState *synic; -int gsi; -EventNotifier sint_set_notifier; -EventNotifier sint_ack_notifier; - -HvSintStagedMessage *staged_msg; - -unsigned refcount; -}; - static CPUState *hyperv_find_vcpu(uint32_t vp_index) {CPUState *cs =qemu_get_cpu (vp_index);
@@ -259,7 +267,7 @@ static void cpu_post_msg(CPUState *cs, run_on_cpu_data data)assert (staged_msg->state ==HV_STAGED_MSG_BUSY ); -if (!synic->enabled || !synic->msg_page_addr) { +if (!synic->msg_page_addr) { staged_msg->status = -ENXIO ; goto posted; }
@@ -343,7 +351,7 @@ int hyperv_set_event_flag(HvSintRoute *sint_route, unsigned eventno)if (eventno >HV_EVENT_FLAGS_COUNT ) {return -EINVAL ; } -if (!synic->enabled || !synic->event_page_addr) { +if (!synic->sctl_enabled || !synic->event_page_addr) {return -ENXIO ; }
@@ -364,11 +372,13 @@ int hyperv_set_event_flag(HvSintRoute *sint_route, unsigned eventno)HvSintRoute *hyperv_sint_route_new (uint32_t vp_index,uint32_t sint,HvSintMsgCb cb,void *cb_data) { -HvSintRoute *sint_route; -EventNotifier *ack_notifier; +HvSintRoute *sint_route =NULL ; +EventNotifier *ack_notifier =NULL ;int r, gsi;CPUState *cs;SynICState *synic; +bool ack_event_initialized = false, sint_notifier_initialized = false, + irqfd_initialized = false; cs =hyperv_find_vcpu (vp_index);if (!cs) {
@@ -381,57 +391,82 @@ HvSintRoute *hyperv_sint_route_new(uint32_t vp_index, uint32_t sint, } sint_route =g_new0 (HvSintRoute,1 ); - r =event_notifier_init (&sint_route->sint_set_notifier, false); -if (r) { - goto err; +if (!sint_route) { + goto cleanup_err; } + sint_route->gsi =0 ; + sint_route->synic = synic; + sint_route->sint = sint; + sint_route->refcount =1 ; ack_notifier = cb ? &sint_route->sint_ack_notifier :NULL ;if (ack_notifier) { sint_route->staged_msg =g_new0 (HvSintStagedMessage,1 ); +if (!sint_route->staged_msg) { + goto cleanup_err; + } sint_route->staged_msg->cb = cb; sint_route->staged_msg->cb_data = cb_data; r =event_notifier_init (ack_notifier, false);if (r) { - goto err_sint_set_notifier; + goto cleanup_err; } -event_notifier_set_handler (ack_notifier, sint_ack_handler); + ack_event_initialized = true; + } + +/* See if we are done or we need to setup a GSI for this SintRoute */ +if (!synic->sctl_enabled) { + goto cleanup; } +/* We need to setup a GSI for this SintRoute */ + r =event_notifier_init (&sint_route->sint_set_notifier, false); +if (r) { + goto cleanup_err; + } + sint_notifier_initialized = true; + gsi =kvm_irqchip_add_hv_sint_route (kvm_state, vp_index, sint);if (gsi <0 ) { - goto err_gsi; + goto cleanup_err; } + irqfd_initialized = true; r =kvm_irqchip_add_irqfd_notifier_gsi (kvm_state, &sint_route->sint_set_notifier, ack_notifier, gsi);if (r) { - goto err_irqfd; + goto cleanup_err; } sint_route->gsi = gsi; - sint_route->synic = synic; - sint_route->sint = sint; - sint_route->refcount =1 ; - +cleanup: +qemu_mutex_lock (&synic->sint_routes_mutex); +QLIST_INSERT_HEAD_RCU (&synic->sint_routes, sint_route, link); +qemu_mutex_unlock (&synic->sint_routes_mutex);return sint_route; -err_irqfd: -kvm_irqchip_release_virq (kvm_state, gsi); -err_gsi: +cleanup_err: +if (irqfd_initialized) { +kvm_irqchip_release_virq (kvm_state, gsi); + } + +if (sint_notifier_initialized) { +event_notifier_cleanup (&sint_route->sint_set_notifier); + } +if (ack_notifier) { -event_notifier_set_handler (ack_notifier,NULL ); -event_notifier_cleanup (ack_notifier); +if (ack_event_initialized) { +event_notifier_set_handler (ack_notifier,NULL ); +event_notifier_cleanup (ack_notifier); + } +g_free (sint_route->staged_msg); } -err_sint_set_notifier: -event_notifier_cleanup (&sint_route->sint_set_notifier); -err: -g_free (sint_route); +g_free (sint_route);return NULL ; }
@@ -442,6 +477,8 @@ void hyperv_sint_route_ref(HvSintRoute *sint_route)void hyperv_sint_route_unref (HvSintRoute *sint_route) { +SynICState *synic; +if (!sint_route) {return ; }
@@ -452,21 +489,33 @@ void hyperv_sint_route_unref(HvSintRoute *sint_route)return ; } -kvm_irqchip_remove_irqfd_notifier_gsi (kvm_state, - &sint_route->sint_set_notifier, - sint_route->gsi); -kvm_irqchip_release_virq (kvm_state, sint_route->gsi); + synic = sint_route->synic; +qemu_mutex_lock (&synic->sint_routes_mutex); +QLIST_REMOVE_RCU (sint_route, link); +qemu_mutex_unlock (&synic->sint_routes_mutex); + +if (sint_route->gsi) { +kvm_irqchip_remove_irqfd_notifier_gsi (kvm_state, + &sint_route->sint_set_notifier, + sint_route->gsi); +kvm_irqchip_release_virq (kvm_state, sint_route->gsi); +event_notifier_cleanup (&sint_route->sint_set_notifier); + } +if (sint_route->staged_msg) {event_notifier_set_handler (&sint_route->sint_ack_notifier,NULL );event_notifier_cleanup (&sint_route->sint_ack_notifier);g_free (sint_route->staged_msg); } -event_notifier_cleanup (&sint_route->sint_set_notifier);g_free (sint_route); }int hyperv_sint_route_set_sint (HvSintRoute *sint_route) { +if (!sint_route->gsi) { +return 0 ; + } +return event_notifier_set (&sint_route->sint_set_notifier); }
@@ -529,6 +578,26 @@ int hyperv_set_msg_handler(uint32_t conn_id, HvMsgHandler handler, void *data)return ret; } +int hyperv_synic_eom (CPUState *cs) +{ +SynICState *synic =get_synic (cs); +HvSintRoute *sint_route; + +if (!synic) { +return -1 ; + } + +qemu_mutex_lock (&synic->sint_routes_mutex); + QLIST_FOREACH(sint_route, &synic->sint_routes, link) { +/* Try to complete every SintRoute */ +aio_bh_schedule_oneshot (qemu_get_aio_context (), sint_msg_bh, + sint_route); + } +qemu_mutex_unlock (&synic->sint_routes_mutex); + +return 0 ; +} +uint16_t hyperv_hcall_post_message (uint64_t param,bool fast) {uint16_t ret;
include/hw/hyperv/hyperv.h +2 -0
@@ -28,6 +28,8 @@ void hyperv_sint_route_unref(HvSintRoute *sint_route);int hyperv_sint_route_set_sint (HvSintRoute *sint_route); +int hyperv_synic_eom (CPUState *cs); +/* * Submit a message to be posted in vcpu context. If the submission succeeds, * the status of posting the message is reported via the callback associated
Signature · 1 line
2.34.1
PATCH 2/4 hyperv: Add definitions for syndbg
In reply to Jon DoronAdd all required definitions for hyperv synthetic debugger interface.
--- include/hw/hyperv/hyperv-proto.h | 52 ++++++++++++++++++++++++++++++++ target/i386/kvm/hyperv-proto.h | 37 +++++++++++++++++++++++ 2 files changed, 89 insertions(+)
include/hw/hyperv/hyperv-proto.h +52 -0
@@ -24,12 +24,17 @@#define HV_STATUS_INVALID_PORT_ID 17#define HV_STATUS_INVALID_CONNECTION_ID 18#define HV_STATUS_INSUFFICIENT_BUFFERS 19 +#define HV_STATUS_NOT_ACKNOWLEDGED 20 +#define HV_STATUS_NO_DATA 27/* * Hypercall numbers */ #define HV_POST_MESSAGE 0x005c#define HV_SIGNAL_EVENT 0x005d +#define HV_POST_DEBUG_DATA 0x0069 +#define HV_RETREIVE_DEBUG_DATA 0x006a +#define HV_RESET_DEBUG_SESSION 0x006b#define HV_HYPERCALL_FAST (1u << 16)/*
@@ -127,4 +132,51 @@ struct hyperv_event_flags_page { struct hyperv_event_flags slot[HV_SINT_COUNT]; }; +/* +* Kernel debugger structures +*/ + +/* Options flags for hyperv_reset_debug_session */ +#define HV_DEBUG_PURGE_INCOMING_DATA 0x00000001 +#define HV_DEBUG_PURGE_OUTGOING_DATA 0x00000002 +struct hyperv_reset_debug_session_input { +uint32_t options; +} __attribute__ ((__packed__ )); + +struct hyperv_reset_debug_session_output { +uint32_t host_ip; +uint32_t target_ip; +uint16_t host_port; +uint16_t target_port; +uint8_t host_mac[6 ]; +uint8_t target_mac[6 ]; +} __attribute__ ((__packed__ )); + +/* Options for hyperv_post_debug_data */ +#define HV_DEBUG_POST_LOOP 0x00000001 + +struct hyperv_post_debug_data_input { +uint32_t count; +uint32_t options; +/*uint8_t data[HV_HYP_PAGE_SIZE - 2 * sizeof(uint32_t)];*/ +} __attribute__ ((__packed__ )); + +struct hyperv_post_debug_data_output { +uint32_t pending_count; +} __attribute__ ((__packed__ )); + +/* Options for hyperv_retrieve_debug_data */ +#define HV_DEBUG_RETRIEVE_LOOP 0x00000001 +#define HV_DEBUG_RETRIEVE_TEST_ACTIVITY 0x00000002 + +struct hyperv_retrieve_debug_data_input { +uint32_t count; +uint32_t options; +uint64_t timeout; +} __attribute__ ((__packed__ )); + +struct hyperv_retrieve_debug_data_output { +uint32_t retrieved_count; +uint32_t remaining_count; +} __attribute__ ((__packed__ ));#endif
target/i386/kvm/hyperv-proto.h +37 -0
@@ -19,6 +19,9 @@#define HV_CPUID_ENLIGHTMENT_INFO 0x40000004#define HV_CPUID_IMPLEMENT_LIMITS 0x40000005#define HV_CPUID_NESTED_FEATURES 0x4000000A +#define HV_CPUID_SYNDBG_VENDOR_AND_MAX_FUNCTIONS 0x40000080 +#define HV_CPUID_SYNDBG_INTERFACE 0x40000081 +#define HV_CPUID_SYNDBG_PLATFORM_CAPABILITIES 0x40000082#define HV_CPUID_MIN 0x40000005#define HV_CPUID_MAX 0x4000ffff#define HV_HYPERVISOR_PRESENT_BIT 0x80000000
@@ -55,8 +58,14 @@#define HV_GUEST_IDLE_STATE_AVAILABLE (1u << 5)#define HV_FREQUENCY_MSRS_AVAILABLE (1u << 8)#define HV_GUEST_CRASH_MSR_AVAILABLE (1u << 10) +#define HV_FEATURE_DEBUG_MSRS_AVAILABLE (1u << 11)#define HV_STIMER_DIRECT_MODE_AVAILABLE (1u << 19) +/* +* HV_CPUID_FEATURES.EBX bits +*/ +#define HV_PARTITION_DEUBGGING_ALLOWED (1u << 12) +/* * HV_CPUID_ENLIGHTMENT_INFO.EAX bits */
@@ -72,6 +81,11 @@#define HV_ENLIGHTENED_VMCS_RECOMMENDED (1u << 14)#define HV_NO_NONARCH_CORESHARING (1u << 18) +/* +* HV_CPUID_SYNDBG_PLATFORM_CAPABILITIES.EAX bits +*/ +#define HV_SYNDBG_CAP_ALLOW_KERNEL_DEBUGGING (1u << 1) +/* * Basic virtualized MSRs */
@@ -130,6 +144,18 @@#define HV_X64_MSR_STIMER3_CONFIG 0x400000B6#define HV_X64_MSR_STIMER3_COUNT 0x400000B7 +/* +* Hyper-V Synthetic debug options MSR +*/ +#define HV_X64_MSR_SYNDBG_CONTROL 0x400000F1 +#define HV_X64_MSR_SYNDBG_STATUS 0x400000F2 +#define HV_X64_MSR_SYNDBG_SEND_BUFFER 0x400000F3 +#define HV_X64_MSR_SYNDBG_RECV_BUFFER 0x400000F4 +#define HV_X64_MSR_SYNDBG_PENDING_BUFFER 0x400000F5 +#define HV_X64_MSR_SYNDBG_OPTIONS 0x400000FF + +#define HV_X64_SYNDBG_OPTION_USE_HCALLS BIT(2) +/* * Guest crash notification MSRs */
@@ -168,5 +194,16 @@#define HV_STIMER_COUNT 4 +/* +* Synthetic debugger control definitions +*/ +#define HV_SYNDBG_CONTROL_SEND (1u << 0) +#define HV_SYNDBG_CONTROL_RECV (1u << 1) +#define HV_SYNDBG_CONTROL_SEND_SIZE (ctl) ((ctl >> 16) & 0xffff) +#define HV_SYNDBG_STATUS_INVALID (0) +#define HV_SYNDBG_STATUS_SEND_SUCCESS (1u << 0) +#define HV_SYNDBG_STATUS_RECV_SUCCESS (1u << 2) +#define HV_SYNDBG_STATUS_RESET (1u << 3) +#define HV_SYNDBG_STATUS_SET_SIZE (st, sz) (st | (sz << 16))#endif
Signature · 1 line
2.34.1
PATCH 4/4 hw: hyperv: Initial commit for Synthetic Debugging device
In reply to Jon Doron--- hw/hyperv/Kconfig | 5 + hw/hyperv/meson.build | 1 + hw/hyperv/syndbg.c | 407 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 413 insertions(+) create mode 100644 hw/hyperv/syndbg.c
hw/hyperv/Kconfig +5 -0
@@ -11,3 +11,8 @@ config VMBUS bool default y depends on HYPERV + +config SYNDBG + bool + default y + depends on VMBUS
hw/hyperv/meson.build +1 -0
@@ -1,3 +1,4 @@ specific_ss.add(when: 'CONFIG_HYPERV', if_true: files('hyperv.c')) specific_ss.add(when: 'CONFIG_HYPERV_TESTDEV', if_true: files('hyperv_testdev.c')) specific_ss.add(when: 'CONFIG_VMBUS', if_true: files('vmbus.c')) +specific_ss.add(when: 'CONFIG_SYNDBG', if_true: files('syndbg.c'))
hw/hyperv/syndbg.c new file +407 -0
407 lines not on this page · raw message
Signature · 1 line
2.34.1
On 04/02/2022, Jon Doron wrote:
Ping
Quoted 63 lines
This patchset adds support for the synthetic debugging device.
HyperV supports a special transport layer for the kernel debugger when running in HyperV.
This patchset add supports for this device so you could have a setup fast windows kernel debugging.
At this point of time, DHCP is not implmeneted so to set this up few things need to be noted.
The scenario I used to test is having 2 VMs in the same virtual network i.e a Debugger VM with the NIC:
-nic tap,model=virtio,mac=02:ca:01:01:01:01,script=/etc/qemu-ifup And it's IP is going to be static 192.168.53.12
And the VM we want to debug, to which we need to have the englightments and vmbus configured:(quoted diff) +0
-4-cpu host,hv-relaxed,hv_spinlocks=0x1fff,hv_time,+vmx,invtsc,hv-vapic,hv-vpindex,hv-synic,hv-syndbg \ -device vmbus-bridge \ -device hv-syndbg,host_ip=192.168.53.12,host_port=50000,use_hcalls=false \ -nic tap,model=virtio,mac=02:ca:01:01:01:02,script=/etc/qemu-ifup \Then in the debuggee VM we would setup the kernel debugging in the following way:
If the VM is older than Win8:
* Copy the proper platform kdvm.dll (make sure it's called kdvm.dll even if platform is 32bit) bcdedit /set {GUID} dbgtransport kdvm.dll
bcdedit /set {GUID} loadoptions host_ip="1.2.3.4",host_port="50000",nodhcp bcdedit /set {GUID} debug on
bcdedit /set {GUID} halbreakpoint onWin8 and late:
bcdedit /dbgsettings net hostip:7.7.7.7 port:50000 nodhcpThis is all the setup that is required to get the synthetic debugger configured correctly.
Jon Doron (4):
hyperv: SControl is optional to enable SynIc
hyperv: Add definitions for syndbg
hyperv: Add support to process syndbg commands
hw: hyperv: Initial commit for Synthetic Debugging devicedocs/hyperv.txt | 15 + hw/hyperv/Kconfig | 5 + hw/hyperv/hyperv.c | 475 +++++++++++++++++++++++++------ hw/hyperv/meson.build | 1 + hw/hyperv/syndbg.c | 407 ++++++++++++++++++++++++++ include/hw/hyperv/hyperv-proto.h | 52 ++++ include/hw/hyperv/hyperv.h | 60 ++++ target/i386/cpu.c | 2 + target/i386/cpu.h | 7 + target/i386/kvm/hyperv-proto.h | 37 +++ target/i386/kvm/hyperv-stub.c | 6 + target/i386/kvm/hyperv.c | 52 +++- target/i386/kvm/kvm.c | 76 ++++- 13 files changed, 1105 insertions(+), 90 deletions(-)create mode 100644
hw/hyperv/syndbg.cSignature · 1 line
2.34.1
Re: [PATCH v1 1/4] hyperv: SControl is optional to enable SynIc
In reply to Jon DoronQuoted 9 lines · Jon Doron
SynIc can be enabled regardless of the SControl mechanisim which can register a GSI for a given SintRoute.
This behaviour can achived by setting enabling SIMP and then the guest will poll on the message slot.
Once there is another message pending the host will set the message slot with the pending flag.
When the guest polls from the message slot, incase the pending flag is
s/incase/in case
Quoted 2 lines
set it will write to the
HV_X64_MSR_EOMindicating it has cleared the slow and we can try and push our message again.
what do you mean by "the slow"?
Quoted 71 lines
Signed-off-by Jon Doron <[email protected]>--- hw/hyperv/hyperv.c | 233 ++++++++++++++++++++++++------------- include/hw/hyperv/hyperv.h | 2 + 2 files changed, 153 insertions(+), 82 deletions(-)hw/hyperv/hyperv.c +44
-1@@ -27,18 +27,70 @@ struct SynICState {CPUState *cs; -bool enabled; +bool sctl_enabled;hwaddr msg_page_addr;hwaddr event_page_addr;MemoryRegion msg_page_mr;MemoryRegion event_page_mr;struct hyperv_message_page *msg_page;struct hyperv_event_flags_page *event_page; + +QemuMutex sint_routes_mutex; + QLIST_HEAD(, HvSintRoute) sint_routes; };#define TYPE_SYNIC "hyperv-synic"OBJECT_DECLARE_SIMPLE_TYPE (SynICState,SYNIC ) +/* +* KVM has its own message producers (SynIC timers). To guarantee +* serialization with both KVM vcpu and the guest cpu, the messages are first +* staged in an intermediate area and then posted to the SynIC message page in +* the vcpu thread. + */ +typedef struct HvSintStagedMessage { +/* message content staged by hyperv_post_msg */ +struct hyperv_message msg; +/* callback + data (r/o) to complete the processing in a BH */ +HvSintMsgCb cb; +void *cb_data; +/* message posting status filled by cpu_post_msg */ +int status; +/* passing the buck: */ +enum { +/* initial state */ +HV_STAGED_MSG_FREE , +/* +* hyperv_post_msg (e.g. in main loop) grabs the staged area (FREE -> +* BUSY), copies msg, and schedules cpu_post_msg on the assigned cpu +*/ +HV_STAGED_MSG_BUSY , +/* +* cpu_post_msg (vcpu thread) tries to copy staged msg to msg slot, +* notify the guest, records the status, marks the posting done (BUSY +* -> POSTED), and schedules sint_msg_bh BH +*/ +HV_STAGED_MSG_POSTED , +/* +* sint_msg_bh (BH) verifies that the posting is done, runs the +* callback, and starts over (POSTED -> FREE) +*/ + } state; +}HvSintStagedMessage ; + +struct HvSintRoute { +uint32_t sint; +SynICState *synic; +int gsi;
hw/hyperv/hyperv.c struct SynICState { · line 94
Quoted 10 lines
hw/hyperv/hyperv.c +9
-0+EventNotifier sint_set_notifier; +EventNotifier sint_ack_notifier; + +HvSintStagedMessage *staged_msg; + +unsigned refcount; +QLIST_ENTRY (HvSintRoute) link; +}; +static bool synic_enabled;
Why did you move this struct above?
I think it was done purposefully to separate synic_* functions from the others below (sint_*).
Quoted 111 lines
hw/hyperv/hyperv.c +8
-52bool hyperv_is_synic_enabled (void )@@ -51,11 +103,11 @@ static SynICState *get_synic(CPUState *cs)return SYNIC (object_resolve_path_component (OBJECT (cs),"synic" )); } -static void synic_update (SynICState *synic,bool enable, +static void synic_update (SynICState *synic,bool sctl_enable,hwaddr msg_page_addr,hwaddr event_page_addr) { - synic->enabled = enable; + synic->sctl_enabled = sctl_enable;if (synic->msg_page_addr != msg_page_addr) {if (synic->msg_page_addr) { memory_region_del_subregion(get_system_memory(),@@ -80,7 +132,7 @@ static void synic_update(SynICState *synic, bool enable, } } -void hyperv_synic_update (CPUState *cs,bool enable, +void hyperv_synic_update (CPUState *cs,bool sctl_enable,hwaddr msg_page_addr,hwaddr event_page_addr) {SynICState *synic =get_synic (cs);@@ -89,7 +141,7 @@ void hyperv_synic_update(CPUState *cs, bool enable,return ; } -synic_update (synic, enable, msg_page_addr, event_page_addr); +synic_update (synic, sctl_enable, msg_page_addr, event_page_addr); }static void synic_realize (DeviceState *dev,Error **errp)@@ -110,16 +162,20 @@ static void synic_realize(DeviceState *dev, Error **errp) sizeof(*synic->event_page), &error_abort); synic->msg_page =memory_region_get_ram_ptr (&synic->msg_page_mr); synic->event_page =memory_region_get_ram_ptr (&synic->event_page_mr); +qemu_mutex_init (&synic->sint_routes_mutex); +QLIST_INIT (&synic->sint_routes);g_free (msgp_name);g_free (eventp_name); } +static void synic_reset (DeviceState *dev) {SynICState *synic =SYNIC (dev);memset (synic->msg_page,0 ,sizeof (*synic->msg_page));memset (synic->event_page,0 ,sizeof (*synic->event_page));synic_update (synic, false,0 ,0 ); +assert (QLIST_EMPTY (&synic->sint_routes)); }static void synic_class_init (ObjectClass *klass,void *data)@@ -168,54 +224,6 @@ static void synic_register_types(void)type_init (synic_register_types) -/* -* KVM has its own message producers (SynIC timers). To guarantee -* serialization with both KVM vcpu and the guest cpu, the messages are first -* staged in an intermediate area and then posted to the SynIC message page in -* the vcpu thread. -*/ -typedef struct HvSintStagedMessage { -/* message content staged by hyperv_post_msg */ -struct hyperv_message msg; -/* callback + data (r/o) to complete the processing in a BH */ -HvSintMsgCb cb; -void *cb_data; -/* message posting status filled by cpu_post_msg */ -int status; -/* passing the buck: */ -enum { -/* initial state */ -HV_STAGED_MSG_FREE , -/* -* hyperv_post_msg (e.g. in main loop) grabs the staged area (FREE -> -* BUSY), copies msg, and schedules cpu_post_msg on the assigned cpu -*/ -HV_STAGED_MSG_BUSY , -/* -* cpu_post_msg (vcpu thread) tries to copy staged msg to msg slot, -* notify the guest, records the status, marks the posting done (BUSY -* -> POSTED), and schedules sint_msg_bh BH -*/ -HV_STAGED_MSG_POSTED , -/* -* sint_msg_bh (BH) verifies that the posting is done, runs the -* callback, and starts over (POSTED -> FREE) -*/ - } state; -} HvSintStagedMessage; - -struct HvSintRoute { -uint32_t sint; -SynICState *synic; -int gsi; -EventNotifier sint_set_notifier; -EventNotifier sint_ack_notifier; - -HvSintStagedMessage *staged_msg; - -unsigned refcount; -}; - static CPUState *hyperv_find_vcpu(uint32_t vp_index) {CPUState *cs =qemu_get_cpu (vp_index);
hw/hyperv/hyperv.c static void cpu_post_msg(CPUState *cs, run_on_cpu_data data) · line 270
Quoted 5 lines
hw/hyperv/hyperv.c +1
-1@@ -259,7 +267,7 @@ static void cpu_post_msg(CPUState *cs, run_on_cpu_data data)assert (staged_msg->state ==HV_STAGED_MSG_BUSY ); -if (!synic->enabled || !synic->msg_page_addr) { +if (!synic->msg_page_addr) {
Not sure if this is important, but why don't you check for !synic->sctl_enabled anymore here? You do it below.
Quoted 30 lines
hw/hyperv/hyperv.c +5
-3staged_msg->status = -ENXIO ; goto posted; }@@ -343,7 +351,7 @@ int hyperv_set_event_flag(HvSintRoute *sint_route, unsigned eventno)if (eventno >HV_EVENT_FLAGS_COUNT ) {return -EINVAL ; } -if (!synic->enabled || !synic->event_page_addr) { +if (!synic->sctl_enabled || !synic->event_page_addr) {return -ENXIO ; }@@ -364,11 +372,13 @@ int hyperv_set_event_flag(HvSintRoute *sint_route, unsigned eventno)HvSintRoute *hyperv_sint_route_new (uint32_t vp_index,uint32_t sint,HvSintMsgCb cb,void *cb_data) { -HvSintRoute *sint_route; -EventNotifier *ack_notifier; +HvSintRoute *sint_route =NULL ; +EventNotifier *ack_notifier =NULL ;int r, gsi;CPUState *cs;SynICState *synic; +bool ack_event_initialized = false, sint_notifier_initialized = false, + irqfd_initialized = false; cs =hyperv_find_vcpu (vp_index);if (!cs) {@@ -381,57 +391,82 @@ HvSintRoute *hyperv_sint_route_new(uint32_t vp_index, uint32_t sint, }
hw/hyperv/hyperv.c HvSintRoute *hyperv_sint_route_new(uint32_t vp_index, uint32_t sint, · line 398
Quoted 10 lines
hw/hyperv/hyperv.c +3
-3sint_route =g_new0 (HvSintRoute,1 ); - r =event_notifier_init (&sint_route->sint_set_notifier, false); -if (r) { - goto err; +if (!sint_route) { + goto cleanup_err; } + sint_route->gsi =0 ;
useless, as g_new0 zeroes all fields
Quoted 80 lines
hw/hyperv/hyperv.c +41
-13+ sint_route->synic = synic; + sint_route->sint = sint; + sint_route->refcount =1 ; ack_notifier = cb ? &sint_route->sint_ack_notifier :NULL ;if (ack_notifier) { sint_route->staged_msg =g_new0 (HvSintStagedMessage,1 ); +if (!sint_route->staged_msg) { + goto cleanup_err; + } sint_route->staged_msg->cb = cb; sint_route->staged_msg->cb_data = cb_data; r =event_notifier_init (ack_notifier, false);if (r) { - goto err_sint_set_notifier; + goto cleanup_err; } -event_notifier_set_handler (ack_notifier, sint_ack_handler); + ack_event_initialized = true; + } + +/* See if we are done or we need to setup a GSI for this SintRoute */ +if (!synic->sctl_enabled) { + goto cleanup; } +/* We need to setup a GSI for this SintRoute */ + r =event_notifier_init (&sint_route->sint_set_notifier, false); +if (r) { + goto cleanup_err; + } + sint_notifier_initialized = true; + gsi =kvm_irqchip_add_hv_sint_route (kvm_state, vp_index, sint);if (gsi <0 ) { - goto err_gsi; + goto cleanup_err; } + irqfd_initialized = true; r =kvm_irqchip_add_irqfd_notifier_gsi (kvm_state, &sint_route->sint_set_notifier, ack_notifier, gsi);if (r) { - goto err_irqfd; + goto cleanup_err; } sint_route->gsi = gsi; - sint_route->synic = synic; - sint_route->sint = sint; - sint_route->refcount =1 ; - +cleanup: +qemu_mutex_lock (&synic->sint_routes_mutex); +QLIST_INSERT_HEAD_RCU (&synic->sint_routes, sint_route, link); +qemu_mutex_unlock (&synic->sint_routes_mutex);return sint_route; -err_irqfd: -kvm_irqchip_release_virq (kvm_state, gsi); -err_gsi: +cleanup_err: +if (irqfd_initialized) { +kvm_irqchip_release_virq (kvm_state, gsi); + } + +if (sint_notifier_initialized) { +event_notifier_cleanup (&sint_route->sint_set_notifier); + } +if (ack_notifier) { -event_notifier_set_handler (ack_notifier,NULL ); -event_notifier_cleanup (ack_notifier); +if (ack_event_initialized) { +event_notifier_set_handler (ack_notifier,NULL ); +event_notifier_cleanup (ack_notifier); + } +
hw/hyperv/hyperv.c HvSintRoute *hyperv_sint_route_new(uint32_t vp_index, uint32_t sint, · line 471
Quoted 10 lines
hw/hyperv/hyperv.c +1
-4g_free (sint_route->staged_msg); } -err_sint_set_notifier: -event_notifier_cleanup (&sint_route->sint_set_notifier); -err: -g_free (sint_route); +g_free (sint_route);return NULL ; }
It is good that you check that sint_route is not NULL, but I don't find it easy to read nor a common practice to have one single goto label and multiple booleans to distinguish various error cases.
I think you should do as it was done before, with a specific label for each type of error, and not always use cleanup_err.
Quoted 12 lines
hw/hyperv/hyperv.c +2
-0@@ -442,6 +477,8 @@ void hyperv_sint_route_ref(HvSintRoute *sint_route)void hyperv_sint_route_unref (HvSintRoute *sint_route) { +SynICState *synic; +if (!sint_route) {return ; }@@ -452,21 +489,33 @@ void hyperv_sint_route_unref(HvSintRoute *sint_route)return ;
hw/hyperv/hyperv.c void hyperv_sint_route_unref(HvSintRoute *sint_route) · line 495
Quoted 10 lines
hw/hyperv/hyperv.c +4
-4} -kvm_irqchip_remove_irqfd_notifier_gsi (kvm_state, - &sint_route->sint_set_notifier, - sint_route->gsi); -kvm_irqchip_release_virq (kvm_state, sint_route->gsi); + synic = sint_route->synic; +qemu_mutex_lock (&synic->sint_routes_mutex); +QLIST_REMOVE_RCU (sint_route, link); +qemu_mutex_unlock (&synic->sint_routes_mutex);
Not really important, but you can use WITH_QEMU_LOCK_GUARD instead of doing lock/unlock.
Quoted 29 lines
hw/hyperv/hyperv.c +13
-1+ +if (sint_route->gsi) { +kvm_irqchip_remove_irqfd_notifier_gsi (kvm_state, + &sint_route->sint_set_notifier, + sint_route->gsi); +kvm_irqchip_release_virq (kvm_state, sint_route->gsi); +event_notifier_cleanup (&sint_route->sint_set_notifier); + } +if (sint_route->staged_msg) {event_notifier_set_handler (&sint_route->sint_ack_notifier,NULL );event_notifier_cleanup (&sint_route->sint_ack_notifier);g_free (sint_route->staged_msg); } -event_notifier_cleanup (&sint_route->sint_set_notifier);g_free (sint_route); }int hyperv_sint_route_set_sint (HvSintRoute *sint_route) { +if (!sint_route->gsi) { +return 0 ; + } +return event_notifier_set (&sint_route->sint_set_notifier); }@@ -529,6 +578,26 @@ int hyperv_set_msg_handler(uint32_t conn_id, HvMsgHandler handler, void *data)return ret;
hw/hyperv/hyperv.c int hyperv_set_msg_handler(uint32_t conn_id, HvMsgHandler handler, void *data) · line 588
Quoted 10 lines
hw/hyperv/hyperv.c +8
-0} +int hyperv_synic_eom (CPUState *cs) +{ +SynICState *synic =get_synic (cs); +HvSintRoute *sint_route; + +if (!synic) { +return -1 ; + }
use hereQEMU_LOCK_GUARD(&synic->sint_routes_mutex);
instead of lock/unlock
Quoted 18 lines
hw/hyperv/hyperv.c +10
-0+ +qemu_mutex_lock (&synic->sint_routes_mutex); + QLIST_FOREACH(sint_route, &synic->sint_routes, link) { +/* Try to complete every SintRoute */ +aio_bh_schedule_oneshot (qemu_get_aio_context (), sint_msg_bh, + sint_route); + } + qemu_mutex_unlock(&synic->sint_routes_mutex);> + return 0; +} +uint16_t hyperv_hcall_post_message (uint64_t param,bool fast) {uint16_t ret;include/hw/hyperv/hyperv.h +0
-0
include/hw/hyperv/hyperv.h void hyperv_sint_route_unref(HvSintRoute *sint_route); · line 32
Quoted 5 lines
include/hw/hyperv/hyperv.h +2
-0@@ -28,6 +28,8 @@ void hyperv_sint_route_unref(HvSintRoute *sint_route);int hyperv_sint_route_set_sint (HvSintRoute *sint_route); +int hyperv_synic_eom (CPUState *cs); +
Documentation here? Where is this function used?
Quoted 4 lines
include/hw/hyperv/hyperv.h +0
-0/* * Submit a message to be posted in vcpu context. If the submission succeeds, * the status of posting the message is reported via the callback associated
Re: [PATCH v1 2/4] hyperv: Add definitions for syndbg
In reply to Jon DoronQuoted 16 lines · Jon Doron
Add all required definitions for hyperv synthetic debugger interface.
Signed-off-by Jon Doron <[email protected]>--- include/hw/hyperv/hyperv-proto.h | 52 ++++++++++++++++++++++++++++++++ target/i386/kvm/hyperv-proto.h | 37 +++++++++++++++++++++++ 2 files changed, 89 insertions(+)include/hw/hyperv/hyperv-proto.h +0
-0@@ -24,12 +24,17 @@#define HV_STATUS_INVALID_PORT_ID 17#define HV_STATUS_INVALID_CONNECTION_ID 18#define HV_STATUS_INSUFFICIENT_BUFFERS 19
include/hw/hyperv/hyperv-proto.h line 36
Quoted 10 lines
include/hw/hyperv/hyperv-proto.h +4
-0+#define HV_STATUS_NOT_ACKNOWLEDGED 20 +#define HV_STATUS_NO_DATA 27/* * Hypercall numbers */ #define HV_POST_MESSAGE 0x005c#define HV_SIGNAL_EVENT 0x005d +#define HV_POST_DEBUG_DATA 0x0069 +#define HV_RETREIVE_DEBUG_DATA 0x006a
s/RETREIVE/RETRIEVE?
Quoted 26 lines
include/hw/hyperv/hyperv-proto.h +19
-0+#define HV_RESET_DEBUG_SESSION 0x006b#define HV_HYPERCALL_FAST (1u << 16)/* @@ -127,4 +132,51 @@ struct hyperv_event_flags_page {struct hyperv_event_flags slot[HV_SINT_COUNT ]; }; +/* +* Kernel debugger structures +*/ + +/* Options flags for hyperv_reset_debug_session */ +#define HV_DEBUG_PURGE_INCOMING_DATA 0x00000001 +#define HV_DEBUG_PURGE_OUTGOING_DATA 0x00000002 +struct hyperv_reset_debug_session_input { +uint32_t options; +} __attribute__ ((__packed__ )); + +struct hyperv_reset_debug_session_output { +uint32_t host_ip; +uint32_t target_ip; +uint16_t host_port; +uint16_t target_port; +uint8_t host_mac[6 ]; +uint8_t target_mac[6 ];
include/hw/hyperv/hyperv-proto.h struct hyperv_event_flags_page { · line 162
Quoted 10 lines
include/hw/hyperv/hyperv-proto.h +9
-0+} __attribute__ ((__packed__)); + +/* Options for hyperv_post_debug_data */ +#define HV_DEBUG_POST_LOOP 0x00000001 + +struct hyperv_post_debug_data_input { +uint32_t count; +uint32_t options; +/*uint8_t data[HV_HYP_PAGE_SIZE - 2 * sizeof(uint32_t)];*/
What is this comment for?
Quoted 36 lines
include/hw/hyperv/hyperv-proto.h +20
-0+} __attribute__ ((__packed__)); + +struct hyperv_post_debug_data_output { +uint32_t pending_count; +} __attribute__ ((__packed__ )); + +/* Options for hyperv_retrieve_debug_data */ +#define HV_DEBUG_RETRIEVE_LOOP 0x00000001 +#define HV_DEBUG_RETRIEVE_TEST_ACTIVITY 0x00000002 + +struct hyperv_retrieve_debug_data_input { +uint32_t count; +uint32_t options; +uint64_t timeout; +} __attribute__ ((__packed__ )); + +struct hyperv_retrieve_debug_data_output { +uint32_t retrieved_count; +uint32_t remaining_count; +} __attribute__ ((__packed__ ));#endif
target/i386/kvm/hyperv-proto.h +3
-0@@ -19,6 +19,9 @@#define HV_CPUID_ENLIGHTMENT_INFO 0x40000004#define HV_CPUID_IMPLEMENT_LIMITS 0x40000005#define HV_CPUID_NESTED_FEATURES 0x4000000A +#define HV_CPUID_SYNDBG_VENDOR_AND_MAX_FUNCTIONS 0x40000080 +#define HV_CPUID_SYNDBG_INTERFACE 0x40000081 +#define HV_CPUID_SYNDBG_PLATFORM_CAPABILITIES 0x40000082#define HV_CPUID_MIN 0x40000005#define HV_CPUID_MAX 0x4000ffff#define HV_HYPERVISOR_PRESENT_BIT 0x80000000
target/i386/kvm/hyperv-proto.h line 67
Quoted 10 lines
target/i386/kvm/hyperv-proto.h +5
-0@@ -55,8 +58,14 @@#define HV_GUEST_IDLE_STATE_AVAILABLE (1u << 5)#define HV_FREQUENCY_MSRS_AVAILABLE (1u << 8)#define HV_GUEST_CRASH_MSR_AVAILABLE (1u << 10) +#define HV_FEATURE_DEBUG_MSRS_AVAILABLE (1u << 11)#define HV_STIMER_DIRECT_MODE_AVAILABLE (1u << 19) +/* +* HV_CPUID_FEATURES.EBX bits +*/ +#define HV_PARTITION_DEUBGGING_ALLOWED (1u << 12)
s/DEUBGGING/DEBUGGING
Quoted 53 lines
target/i386/kvm/hyperv-proto.h +29
-0+/* * HV_CPUID_ENLIGHTMENT_INFO.EAX bits */ @@ -72,6 +81,11 @@#define HV_ENLIGHTENED_VMCS_RECOMMENDED (1u << 14)#define HV_NO_NONARCH_CORESHARING (1u << 18) +/* +* HV_CPUID_SYNDBG_PLATFORM_CAPABILITIES.EAX bits +*/ +#define HV_SYNDBG_CAP_ALLOW_KERNEL_DEBUGGING (1u << 1) +/* * Basic virtualized MSRs */ @@ -130,6 +144,18 @@#define HV_X64_MSR_STIMER3_CONFIG 0x400000B6#define HV_X64_MSR_STIMER3_COUNT 0x400000B7 +/* +* Hyper-V Synthetic debug options MSR +*/ +#define HV_X64_MSR_SYNDBG_CONTROL 0x400000F1 +#define HV_X64_MSR_SYNDBG_STATUS 0x400000F2 +#define HV_X64_MSR_SYNDBG_SEND_BUFFER 0x400000F3 +#define HV_X64_MSR_SYNDBG_RECV_BUFFER 0x400000F4 +#define HV_X64_MSR_SYNDBG_PENDING_BUFFER 0x400000F5 +#define HV_X64_MSR_SYNDBG_OPTIONS 0x400000FF + +#define HV_X64_SYNDBG_OPTION_USE_HCALLS BIT(2) +/* * Guest crash notification MSRs */ @@ -168,5 +194,16 @@#define HV_STIMER_COUNT 4 +/* +* Synthetic debugger control definitions +*/ +#define HV_SYNDBG_CONTROL_SEND (1u << 0) +#define HV_SYNDBG_CONTROL_RECV (1u << 1) +#define HV_SYNDBG_CONTROL_SEND_SIZE (ctl) ((ctl >> 16) & 0xffff) +#define HV_SYNDBG_STATUS_INVALID (0) +#define HV_SYNDBG_STATUS_SEND_SUCCESS (1u << 0) +#define HV_SYNDBG_STATUS_RECV_SUCCESS (1u << 2) +#define HV_SYNDBG_STATUS_RESET (1u << 3) +#define HV_SYNDBG_STATUS_SET_SIZE (st, sz) (st | (sz << 16))#endif
Re: [PATCH v1 3/4] hyperv: Add support to process syndbg commands
In reply to Jon DoronQuoted 23 lines · Jon Doron
SynDbg commands can come from two different flows:
1. Hypercalls, in this mode the data being sent is fully encapsulated network packets.
2. SynDbg specific MSRs, in this mode only the data that needs to be transfered is passed.Signed-off-by Jon Doron <[email protected]>--- docs/hyperv.txt | 15 +++ hw/hyperv/hyperv.c | 242 ++++++++++++++++++++++++++++++++++ include/hw/hyperv/hyperv.h | 58 ++++++++ target/i386/cpu.c | 2 + target/i386/cpu.h | 7 + target/i386/kvm/hyperv-stub.c | 6 + target/i386/kvm/hyperv.c | 52 +++++++- target/i386/kvm/kvm.c | 76 ++++++++++- 8 files changed, 450 insertions(+), 8 deletions(-)docs/hyperv.txt +0
-0
docs/hyperv.txt default (WS2016). · line 233
Quoted 9 lines
docs/hyperv.txt +6
-0@@ -225,6 +225,21 @@ default (WS2016). Note: hv-version-id-* are not enlightenments and thus don't enable Hyper-V identification when specified without any other enlightenments. +3.21. hv-syndbg +=============== +Enables Hyper-V synthetic debugger interface, this is a special interface used +by Windows Kernel debugger to send the packets through, rather than sending +them via serial/network . +Whe enabled, this enlightenment provides additional communication facilities
When
Quoted 17 lines
docs/hyperv.txt +9
-0+to the guest: SynDbg messages. +This new communication is used by Windows Kernel debugger rather than sending +packets via serial/network, adding significant performance boost over the other +comm channels. +This enlightenment requires a VMBus device (-device vmbus-bridge,irq=15) +and the follow enlightenments to work: +hv-relaxed,hv_time,hv-vapic,hv-vpindex,hv-synic,hv-runtime,hv-stimer + + 4. Supplementary features =========================hw/hyperv/hyperv.c +0
-0
hw/hyperv/hyperv.c uint16_t hyperv_hcall_signal_event(uint64_t param, bool fast) · line 735
Quoted 6 lines
hw/hyperv/hyperv.c +3
-0@@ -730,3 +730,245 @@ uint16_t hyperv_hcall_signal_event(uint64_t param, bool fast) }return HV_STATUS_INVALID_CONNECTION_ID ; } + +static HvSynDbgHandler hv_syndbg_handler; +static void *hv_syndbg_context;
Add a line here between field and function definition.
Quoted 589 lines
hw/hyperv/hyperv.c +239
-0+void hyperv_set_syndbg_handler (HvSynDbgHandler handler,void *context) +{ +assert (!hv_syndbg_handler); + hv_syndbg_handler = handler; + hv_syndbg_context = context; +} + +uint16_t hyperv_hcall_reset_dbg_session (uint64_t outgpa) +{ +uint16_t ret; +HvSynDbgMsg msg; +struct hyperv_reset_debug_session_output *reset_dbg_session =NULL ; +hwaddr len; + +if (!hv_syndbg_handler) { + ret =HV_STATUS_INVALID_HYPERCALL_CODE ; + goto cleanup; + } + + len =sizeof (*reset_dbg_session); + reset_dbg_session =cpu_physical_memory_map (outgpa, &len,1 ); +if (!reset_dbg_session || len <sizeof (*reset_dbg_session)) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + } + + msg.type =HV_SYNDBG_MSG_CONNECTION_INFO ; + ret =hv_syndbg_handler (hv_syndbg_context, &msg); +if (ret) { + goto cleanup; + } + + reset_dbg_session->host_ip = msg.u.connection_info.host_ip; + reset_dbg_session->host_port = msg.u.connection_info.host_port; +/* The following fields are only used as validation for KDVM */ +memset (&reset_dbg_session->host_mac,0 , +sizeof (reset_dbg_session->host_mac)); + reset_dbg_session->target_ip = msg.u.connection_info.host_ip; + reset_dbg_session->target_port = msg.u.connection_info.host_port; +memset (&reset_dbg_session->target_mac,0 , +sizeof (reset_dbg_session->target_mac)); +cleanup: +if (reset_dbg_session) { +cpu_physical_memory_unmap (reset_dbg_session, +sizeof (*reset_dbg_session),1 , len); + } + +return ret; +} + +uint16_t hyperv_hcall_retreive_dbg_data (uint64_t ingpa,uint64_t outgpa, +bool fast) +{ +uint16_t ret; +struct hyperv_retrieve_debug_data_input *debug_data_in =NULL ; +struct hyperv_retrieve_debug_data_output *debug_data_out =NULL ; +hwaddr in_len, out_len; +HvSynDbgMsg msg; + +if (fast || !hv_syndbg_handler) { + ret =HV_STATUS_INVALID_HYPERCALL_CODE ; + goto cleanup; + } + + in_len =sizeof (*debug_data_in); + debug_data_in =cpu_physical_memory_map (ingpa, &in_len,0 ); +if (!debug_data_in || in_len <sizeof (*debug_data_in)) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + } + + out_len =sizeof (*debug_data_out); + debug_data_out =cpu_physical_memory_map (outgpa, &out_len,1 ); +if (!debug_data_out || out_len <sizeof (*debug_data_out)) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + } + + msg.type =HV_SYNDBG_MSG_RECV ; + msg.u.recv.buf_gpa = outgpa +sizeof (*debug_data_out); + msg.u.recv.count =TARGET_PAGE_SIZE -sizeof (*debug_data_out); + msg.u.recv.options = debug_data_in->options; + msg.u.recv.timeout = debug_data_in->timeout; + msg.u.recv.is_raw = true; + ret =hv_syndbg_handler (hv_syndbg_context, &msg); +if (ret ==HV_STATUS_NO_DATA ) { + debug_data_out->retrieved_count =0 ; + debug_data_out->remaining_count = debug_data_in->count; + goto cleanup; + }else if (ret !=HV_STATUS_SUCCESS ) { + goto cleanup; + } + + debug_data_out->retrieved_count = msg.u.recv.retrieved_count; + debug_data_out->remaining_count = + debug_data_in->count - msg.u.recv.retrieved_count; +cleanup: +if (debug_data_out) { +cpu_physical_memory_unmap (debug_data_out,sizeof (*debug_data_out),1 , + out_len); + } + +if (debug_data_in) { +cpu_physical_memory_unmap (debug_data_in,sizeof (*debug_data_in),0 , + in_len); + } + +return ret; +} + +uint16_t hyperv_hcall_post_dbg_data (uint64_t ingpa,uint64_t outgpa,bool fast) +{ +uint16_t ret; +struct hyperv_post_debug_data_input *post_data_in =NULL ; +struct hyperv_post_debug_data_output *post_data_out =NULL ; +hwaddr in_len, out_len; +HvSynDbgMsg msg; + +if (fast || !hv_syndbg_handler) { + ret =HV_STATUS_INVALID_HYPERCALL_CODE ; + goto cleanup; + } + + in_len =sizeof (*post_data_in); + post_data_in =cpu_physical_memory_map (ingpa, &in_len,0 ); +if (!post_data_in || in_len <sizeof (*post_data_in)) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + } + +if (post_data_in->count >TARGET_PAGE_SIZE -sizeof (*post_data_in)) { + ret =HV_STATUS_INVALID_PARAMETER ; + goto cleanup; + } + + out_len =sizeof (*post_data_out); + post_data_out =cpu_physical_memory_map (outgpa, &out_len,1 ); +if (!post_data_out || out_len <sizeof (*post_data_out)) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + } + + msg.type =HV_SYNDBG_MSG_SEND ; + msg.u.send.buf_gpa = ingpa +sizeof (*post_data_in); + msg.u.send.count = post_data_in->count; + msg.u.send.is_raw = true; + ret =hv_syndbg_handler (hv_syndbg_context, &msg); +if (ret !=HV_STATUS_SUCCESS ) { + goto cleanup; + } + + post_data_out->pending_count = msg.u.send.pending_count; + ret = post_data_out->pending_count ?HV_STATUS_INSUFFICIENT_BUFFERS : +HV_STATUS_SUCCESS ; +cleanup: +if (post_data_out) { +cpu_physical_memory_unmap (post_data_out, +sizeof (*post_data_out),1 , out_len); + } + +if (post_data_in) { +cpu_physical_memory_unmap (post_data_in, +sizeof (*post_data_in),0 , in_len); + } + +return ret; +} + +uint32_t hyperv_syndbg_send (uint64_t ingpa,uint32_t count) +{ +HvSynDbgMsg msg; + +if (!hv_syndbg_handler) { +return HV_SYNDBG_STATUS_INVALID ; + } + + msg.type =HV_SYNDBG_MSG_SEND ; + msg.u.send.buf_gpa = ingpa; + msg.u.send.count = count; + msg.u.send.is_raw = false; +if (hv_syndbg_handler (hv_syndbg_context, &msg)) { +return HV_SYNDBG_STATUS_INVALID ; + } + +return HV_SYNDBG_STATUS_SEND_SUCCESS ; +} + +uint32_t hyperv_syndbg_recv (uint64_t ingpa,uint32_t count) +{ +uint16_t ret; +HvSynDbgMsg msg; + +if (!hv_syndbg_handler) { +return HV_SYNDBG_STATUS_INVALID ; + } + + msg.type =HV_SYNDBG_MSG_RECV ; + msg.u.recv.buf_gpa = ingpa; + msg.u.recv.count = count; + msg.u.recv.options =0 ; + msg.u.recv.timeout =0 ; + msg.u.recv.is_raw = false; + ret =hv_syndbg_handler (hv_syndbg_context, &msg); +if (ret !=HV_STATUS_SUCCESS ) { +return 0 ; + } + +return HV_SYNDBG_STATUS_SET_SIZE (HV_SYNDBG_STATUS_RECV_SUCCESS , + msg.u.recv.retrieved_count); +} + +void hyperv_syndbg_set_pending_page (uint64_t ingpa) +{ +HvSynDbgMsg msg; + +if (!hv_syndbg_handler) { +return ; + } + + msg.type =HV_SYNDBG_MSG_SET_PENDING_PAGE ; + msg.u.pending_page.buf_gpa = ingpa; +hv_syndbg_handler (hv_syndbg_context, &msg); +} + +uint64_t hyperv_syndbg_query_options (void ) +{ +HvSynDbgMsg msg; + +if (!hv_syndbg_handler) { +return 0 ; + } + + msg.type =HV_SYNDBG_MSG_QUERY_OPTIONS ; +if (hv_syndbg_handler (hv_syndbg_context, &msg) !=HV_STATUS_SUCCESS ) { +return 0 ; + } + +return msg.u.query_options.options; +}include/hw/hyperv/hyperv.h +58
-0@@ -83,4 +83,62 @@ void hyperv_synic_update(CPUState *cs, bool enable, hwaddr msg_page_addr, hwaddr event_page_addr);bool hyperv_is_synic_enabled (void ); +/* +* Process HVCALL_RESET_DEBUG_SESSION hypercall. +*/ +uint16_t hyperv_hcall_reset_dbg_session (uint64_t outgpa); +/* +* Process HVCALL_RETREIVE_DEBUG_DATA hypercall. +*/ +uint16_t hyperv_hcall_retreive_dbg_data (uint64_t ingpa,uint64_t outgpa, +bool fast); +/* +* Process HVCALL_POST_DEBUG_DATA hypercall. +*/ +uint16_t hyperv_hcall_post_dbg_data (uint64_t ingpa,uint64_t outgpa,bool fast); + +uint32_t hyperv_syndbg_send (uint64_t ingpa,uint32_t count); +uint32_t hyperv_syndbg_recv (uint64_t ingpa,uint32_t count); +void hyperv_syndbg_set_pending_page (uint64_t ingpa); +uint64_t hyperv_syndbg_query_options (void ); + +typedef enum HvSynthDbgMsgType { +HV_SYNDBG_MSG_CONNECTION_INFO , +HV_SYNDBG_MSG_SEND , +HV_SYNDBG_MSG_RECV , +HV_SYNDBG_MSG_SET_PENDING_PAGE , +HV_SYNDBG_MSG_QUERY_OPTIONS +}HvDbgSynthMsgType ; + +typedef struct HvSynDbgMsg { +HvDbgSynthMsgType type; +union { +struct { +uint32_t host_ip; +uint16_t host_port; + } connection_info; +struct { +uint64_t buf_gpa; +uint32_t count; +uint32_t pending_count; +bool is_raw; + } send; +struct { +uint64_t buf_gpa; +uint32_t count; +uint32_t options; +uint64_t timeout; +uint32_t retrieved_count; +bool is_raw; + } recv; +struct { +uint64_t buf_gpa; + } pending_page; +struct { +uint64_t options; + } query_options; + } u; +}HvSynDbgMsg ; +typedef uint16_t (*HvSynDbgHandler )(void *context,HvSynDbgMsg *msg); +void hyperv_set_syndbg_handler (HvSynDbgHandler handler,void *context);#endif target/i386/cpu.c +2
-0@@ -6841,6 +6841,8 @@ static Property x86_cpu_properties[] = { HYPERV_FEAT_AVIC, 0),DEFINE_PROP_ON_OFF_AUTO ("hv-no-nonarch-coresharing" ,X86CPU , hyperv_no_nonarch_cs,ON_OFF_AUTO_OFF ), +DEFINE_PROP_BIT64 ("hv-syndbg" ,X86CPU , hyperv_features, +HYPERV_FEAT_SYNDBG ,0 ),DEFINE_PROP_BOOL ("hv-passthrough" ,X86CPU , hyperv_passthrough, false), DEFINE_PROP_BOOL("hv-enforce-cpuid", X86CPU, hyperv_enforce_cpuid, false),target/i386/cpu.h +7
-0@@ -1060,6 +1060,7 @@ typedef uint64_t FeatureWordArray[FEATURE_WORDS];#define HYPERV_FEAT_IPI 13#define HYPERV_FEAT_STIMER_DIRECT 14#define HYPERV_FEAT_AVIC 15 +#define HYPERV_FEAT_SYNDBG 16#ifndef HYPERV_SPINLOCK_NEVER_NOTIFY #define HYPERV_SPINLOCK_NEVER_NOTIFY 0xFFFFFFFF@@ -1560,6 +1561,12 @@ typedef struct CPUX86State {uint64_t msr_hv_hypercall;uint64_t msr_hv_guest_os_id;uint64_t msr_hv_tsc; +uint64_t msr_hv_syndbg_control; +uint64_t msr_hv_syndbg_status; +uint64_t msr_hv_syndbg_send_page; +uint64_t msr_hv_syndbg_recv_page; +uint64_t msr_hv_syndbg_pending_page; +uint64_t msr_hv_syndbg_options;/* Per-VCPU HV MSRs */ uint64_t msr_hv_vapic;target/i386/kvm/hyperv-stub.c +6
-0@@ -27,6 +27,12 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit)return 0 ;case KVM_EXIT_HYPERV_HCALL : exit->u.hcall.result =HV_STATUS_INVALID_HYPERCALL_CODE ; +return 0 ; +case KVM_EXIT_HYPERV_SYNDBG : +if (!hyperv_feat_enabled (cpu,HYPERV_FEAT_SYNDBG )) { +return -1 ; + } +return 0 ;default :return -1 ;target/i386/kvm/hyperv.c +49
-3@@ -81,20 +81,66 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit)case KVM_EXIT_HYPERV_HCALL : {uint16_t code = exit->u.hcall.input &0xffff ;bool fast = exit->u.hcall.input &HV_HYPERCALL_FAST ; -uint64_t param = exit->u.hcall.params[0 ]; +uint64_t in_param = exit->u.hcall.params[0 ]; +uint64_t out_param = exit->u.hcall.params[1 ];switch (code) {case HV_POST_MESSAGE : - exit->u.hcall.result =hyperv_hcall_post_message (param, fast); + exit->u.hcall.result =hyperv_hcall_post_message (in_param, fast);break ;case HV_SIGNAL_EVENT : - exit->u.hcall.result =hyperv_hcall_signal_event (param, fast); + exit->u.hcall.result =hyperv_hcall_signal_event (in_param, fast); +break ; +case HV_POST_DEBUG_DATA : + exit->u.hcall.result = +hyperv_hcall_post_dbg_data (in_param, out_param, fast); +break ; +case HV_RETREIVE_DEBUG_DATA : + exit->u.hcall.result = +hyperv_hcall_retreive_dbg_data (in_param, out_param, fast); +break ; +case HV_RESET_DEBUG_SESSION : + exit->u.hcall.result = +hyperv_hcall_reset_dbg_session (out_param);break ;default : exit->u.hcall.result =HV_STATUS_INVALID_HYPERCALL_CODE ; }return 0 ; } + +case KVM_EXIT_HYPERV_SYNDBG : +if (!hyperv_feat_enabled (cpu,HYPERV_FEAT_SYNDBG )) { +return -1 ; + } + +switch (exit->u.syndbg.msr) { +case HV_X64_MSR_SYNDBG_CONTROL : { +uint64_t control = exit->u.syndbg.control; + env->msr_hv_syndbg_control = control; + env->msr_hv_syndbg_send_page = exit->u.syndbg.send_page; + env->msr_hv_syndbg_recv_page = exit->u.syndbg.recv_page; + exit->u.syndbg.status =HV_STATUS_SUCCESS ; +if (control &HV_SYNDBG_CONTROL_SEND ) { + exit->u.syndbg.status = +hyperv_syndbg_send (env->msr_hv_syndbg_send_page, +HV_SYNDBG_CONTROL_SEND_SIZE (control)); + }else if (control &HV_SYNDBG_CONTROL_RECV ) { + exit->u.syndbg.status = +hyperv_syndbg_recv (env->msr_hv_syndbg_recv_page, +TARGET_PAGE_SIZE ); + } +break ; + } +case HV_X64_MSR_SYNDBG_PENDING_BUFFER : + env->msr_hv_syndbg_pending_page = exit->u.syndbg.pending_page; +hyperv_syndbg_set_pending_page (env->msr_hv_syndbg_pending_page); +break ; +default : +return -1 ; + } + +return 0 ;default :return -1 ; }target/i386/kvm/kvm.c +71
-5@@ -102,6 +102,7 @@ static bool has_msr_hv_synic;static bool has_msr_hv_stimer;static bool has_msr_hv_frequencies;static bool has_msr_hv_reenlightenment; +static bool has_msr_hv_syndbg_options;static bool has_msr_xss;static bool has_msr_umwait;static bool has_msr_spec_ctrl;@@ -932,6 +933,14 @@ static struct { .bits = HV_DEPRECATING_AEOI_RECOMMENDED} } }, + [HYPERV_FEAT_SYNDBG ] = { + .desc ="Enable synthetic kernel debugger channel (hv-syndbg)" , + .flags = { + {.func =HV_CPUID_FEATURES , .reg =R_EDX , + .bits =HV_FEATURE_DEBUG_MSRS_AVAILABLE } + }, + .dependencies =BIT (HYPERV_FEAT_SYNIC ) |BIT (HYPERV_FEAT_RELAXED ) + }, }; static struct kvm_cpuid2 *try_get_hv_cpuid(CPUState *cs, int max,@@ -972,8 +981,8 @@ static struct kvm_cpuid2 *try_get_hv_cpuid(CPUState *cs, int max,static struct kvm_cpuid2 *get_supported_hv_cpuid (CPUState *cs) {struct kvm_cpuid2 *cpuid; -/* 0x40000000..0x40000005, 0x4000000A, 0x40000080..0x40000080 leaves */ -int max =10 ; +/* 0x40000000..0x40000005, 0x4000000A, 0x40000080..0x40000082 leaves */ +int max =11 ;int i;bool do_sys_ioctl;@@ -1086,6 +1095,12 @@ static struct kvm_cpuid2 *get_supported_hv_cpuid_legacy(CPUState *cs) entry_feat->eax |=HV_SYNTIMERS_AVAILABLE ; } +if (has_msr_hv_syndbg_options) { + entry_feat->edx |=HV_GUEST_DEBUGGING_AVAILABLE ; + entry_feat->edx |=HV_FEATURE_DEBUG_MSRS_AVAILABLE ; + entry_feat->ebx |=HV_PARTITION_DEUBGGING_ALLOWED ; + } +if (kvm_check_extension (cs->kvm_state,KVM_CAP_HYPERV_TLBFLUSH ) >0 ) { entry_recomm->eax |=HV_REMOTE_TLB_FLUSH_RECOMMENDED ;@@ -1337,12 +1352,22 @@ static int hyperv_fill_cpuids(CPUState *cs, {X86CPU *cpu =X86_CPU (cs);struct kvm_cpuid_entry2 *c; -uint32_t cpuid_i =0 ; +uint32_t signature[3 ]; +uint32_t cpuid_i =0 , max_cpuid_leaf =0 ; + + max_cpuid_leaf =HV_CPUID_IMPLEMENT_LIMITS ; +if (hyperv_feat_enabled (cpu,HYPERV_FEAT_EVMCS )) { + max_cpuid_leaf =MAX (max_cpuid_leaf,HV_CPUID_NESTED_FEATURES ); + } + +if (hyperv_feat_enabled (cpu,HYPERV_FEAT_SYNDBG )) { + max_cpuid_leaf = +MAX (max_cpuid_leaf,HV_CPUID_SYNDBG_PLATFORM_CAPABILITIES ); + } c = &cpuid_ent[cpuid_i++]; c->function =HV_CPUID_VENDOR_AND_MAX_FUNCTIONS ; - c->eax =hyperv_feat_enabled (cpu,HYPERV_FEAT_EVMCS ) ? -HV_CPUID_NESTED_FEATURES :HV_CPUID_IMPLEMENT_LIMITS ; + c->eax = max_cpuid_leaf; c->ebx = cpu->hyperv_vendor_id[0 ]; c->ecx = cpu->hyperv_vendor_id[1 ]; c->edx = cpu->hyperv_vendor_id[2 ];@@ -1421,6 +1446,33 @@ static int hyperv_fill_cpuids(CPUState *cs, c->eax = cpu->hyperv_nested[0 ]; } +if (hyperv_feat_enabled (cpu,HYPERV_FEAT_SYNDBG )) { + c = &cpuid_ent[cpuid_i++]; + c->function =HV_CPUID_SYNDBG_VENDOR_AND_MAX_FUNCTIONS ; + c->eax =hyperv_feat_enabled (cpu,HYPERV_FEAT_EVMCS ) ? +HV_CPUID_NESTED_FEATURES :HV_CPUID_IMPLEMENT_LIMITS ; +memcpy (signature,"Microsoft VS" ,12 ); + c->eax =0 ; + c->ebx = signature[0 ]; + c->ecx = signature[1 ]; + c->edx = signature[2 ]; + + c = &cpuid_ent[cpuid_i++]; + c->function =HV_CPUID_SYNDBG_INTERFACE ; +memcpy (signature,"VS#1\0\0\0\0\0\0\0\0" ,12 ); + c->eax = signature[0 ]; + c->ebx =0 ; + c->ecx =0 ; + c->edx =0 ; + + c = &cpuid_ent[cpuid_i++]; + c->function =HV_CPUID_SYNDBG_PLATFORM_CAPABILITIES ; + c->eax =HV_SYNDBG_CAP_ALLOW_KERNEL_DEBUGGING ; + c->ebx =0 ; + c->ecx =0 ; + c->edx =0 ; + } +return cpuid_i; }@@ -2215,6 +2267,9 @@ static int kvm_get_supported_msrs(KVMState *s)case HV_X64_MSR_REENLIGHTENMENT_CONTROL : has_msr_hv_reenlightenment = true;break ; +case HV_X64_MSR_SYNDBG_OPTIONS : + has_msr_hv_syndbg_options = true; +break ;case MSR_IA32_SPEC_CTRL : has_msr_spec_ctrl = true;break ;@@ -3132,6 +3187,11 @@ static int kvm_put_msrs(X86CPU *cpu, int level)kvm_msr_entry_add (cpu,HV_X64_MSR_TSC_EMULATION_STATUS , env->msr_hv_tsc_emulation_status); } +if (hyperv_feat_enabled (cpu,HYPERV_FEAT_SYNDBG ) && + has_msr_hv_syndbg_options) { +kvm_msr_entry_add (cpu,HV_X64_MSR_SYNDBG_OPTIONS , +hyperv_syndbg_query_options ()); + } }if (hyperv_feat_enabled (cpu,HYPERV_FEAT_VAPIC )) { kvm_msr_entry_add(cpu, HV_X64_MSR_APIC_ASSIST_PAGE,@@ -3565,6 +3625,9 @@ static int kvm_get_msrs(X86CPU *cpu)kvm_msr_entry_add (cpu,HV_X64_MSR_TSC_EMULATION_CONTROL ,0 );kvm_msr_entry_add (cpu,HV_X64_MSR_TSC_EMULATION_STATUS ,0 ); } +if (has_msr_hv_syndbg_options) { +kvm_msr_entry_add (cpu,HV_X64_MSR_SYNDBG_OPTIONS ,0 ); + }if (has_msr_hv_crash) {int j;@@ -3851,6 +3914,9 @@ static int kvm_get_msrs(X86CPU *cpu)case HV_X64_MSR_TSC_EMULATION_STATUS : env->msr_hv_tsc_emulation_status = msrs[i].data;break ; +case HV_X64_MSR_SYNDBG_OPTIONS : + env->msr_hv_syndbg_options = msrs[i].data; +break ;case MSR_MTRRdefType: env->mtrr_deftype = msrs[i].data;break ;
Re: [PATCH v1 4/4] hw: hyperv: Initial commit for Synthetic Debugging device
In reply to Jon DoronQuoted 54 lines
hw/hyperv/syndbg.c new file +53
-0+ +static uint16_t handle_recv_msg (HvSynDbg *syndbg,uint64_t outgpa, +uint32_t count,bool is_raw,uint32_t options, +uint64_t timeout,uint32_t *retrieved_count) +{ +uint16_t ret; +uint8_t data_buf[TARGET_PAGE_SIZE -UDP_PKT_HEADER_SIZE ]; +hwaddr out_len; +void *out_data =NULL ; +ssize_t recv_byte_count; + +/* TODO: Handle options and timeout */ + (void )options; + (void )timeout; + +if (!syndbg->has_data_pending) { + recv_byte_count =0 ; + }else { + recv_byte_count =qemu_recv (syndbg->socket, data_buf, +MIN (sizeof (data_buf), count),MSG_WAITALL ); +if (recv_byte_count ==-1 ) { + ret =HV_STATUS_INVALID_PARAMETER ; + goto cleanup; + } + } + +if (!recv_byte_count) { + *retrieved_count =0 ; + ret =HV_STATUS_NO_DATA ; + goto cleanup; + } + +set_pending_state (syndbg, false); + + out_len = recv_byte_count; +if (is_raw) { + out_len +=UDP_PKT_HEADER_SIZE ; + } + out_data =cpu_physical_memory_map (outgpa, &out_len,1 ); +if (!out_data) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + } + +if (is_raw && + !create_udp_pkt (syndbg, out_data, + recv_byte_count +UDP_PKT_HEADER_SIZE , + data_buf, recv_byte_count)) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + }else if (!is_raw) { +memcpy (out_data, data_buf, recv_byte_count); + }
hw/hyperv/syndbg.c line 248
Quoted 10 lines
hw/hyperv/syndbg.c new file +10
-0+ + *retrieved_count = recv_byte_count; +if (is_raw) { + *retrieved_count +=UDP_PKT_HEADER_SIZE ; + } + ret =HV_STATUS_SUCCESS ; +cleanup: +if (out_data) { +cpu_physical_memory_unmap (out_data, out_len,1 , out_len); + }
Same nitpick as done in patch 1, I think you can use more gotos labels instead of adding if statements.
Quoted 4 lines
hw/hyperv/syndbg.c new file +4
-0+ +return ret; +} +
Re: [PATCH v1 3/4] hyperv: Add support to process syndbg commands
In reply to Emanuele Giuseppe EspositoQuoted 29 lines · Emanuele Giuseppe Esposito
Quoted 26 lines · Jon Doron
SynDbg commands can come from two different flows:
1. Hypercalls, in this mode the data being sent is fully encapsulated network packets.
2. SynDbg specific MSRs, in this mode only the data that needs to be transfered is passed.Signed-off-by Jon Doron <[email protected]>--- docs/hyperv.txt | 15 +++ hw/hyperv/hyperv.c | 242 ++++++++++++++++++++++++++++++++++ include/hw/hyperv/hyperv.h | 58 ++++++++ target/i386/cpu.c | 2 + target/i386/cpu.h | 7 + target/i386/kvm/hyperv-stub.c | 6 + target/i386/kvm/hyperv.c | 52 +++++++- target/i386/kvm/kvm.c | 76 ++++++++++- 8 files changed, 450 insertions(+), 8 deletions(-)docs/hyperv.txt +0
-0@@ -225,6 +225,21 @@ default (WS2016). Note: hv-version-id-* are not enlightenments and thus don't enable Hyper-V identification when specified without any other enlightenments.
Quoted 9 lines
docs/hyperv.txt default (WS2016). · line 233
Quoted 6 lines
docs/hyperv.txt +6
-0+3.21. hv-syndbg +=============== +Enables Hyper-V synthetic debugger interface, this is a special interface used +by Windows Kernel debugger to send the packets through, rather than sending +them via serial/network . +Whe enabled, this enlightenment provides additional communication facilitiesWhen
Done
Quoted 12 lines
Quoted 12 lines
docs/hyperv.txt +9
-0+to the guest: SynDbg messages. +This new communication is used by Windows Kernel debugger rather than sending +packets via serial/network, adding significant performance boost over the other +comm channels. +This enlightenment requires a VMBus device (-device vmbus-bridge,irq=15) +and the follow enlightenments to work: +hv-relaxed,hv_time,hv-vapic,hv-vpindex,hv-synic,hv-runtime,hv-stimer + + 4. Supplementary features =========================
Quoted 14 lines
hw/hyperv/hyperv.c uint16_t hyperv_hcall_signal_event(uint64_t param, bool fast) · line 735
Quoted 11 lines
hw/hyperv/hyperv.c +3
-0@@ -730,3 +730,245 @@ uint16_t hyperv_hcall_signal_event(uint64_t param, bool fast) }return HV_STATUS_INVALID_CONNECTION_ID ; } + +static HvSynDbgHandler hv_syndbg_handler; +static void *hv_syndbg_context;Add a line here between field and function definition.
Done
Quoted 590 lines
Quoted 589 lines
hw/hyperv/hyperv.c +239
-0+void hyperv_set_syndbg_handler (HvSynDbgHandler handler,void *context) +{ +assert (!hv_syndbg_handler); + hv_syndbg_handler = handler; + hv_syndbg_context = context; +} + +uint16_t hyperv_hcall_reset_dbg_session (uint64_t outgpa) +{ +uint16_t ret; +HvSynDbgMsg msg; +struct hyperv_reset_debug_session_output *reset_dbg_session =NULL ; +hwaddr len; + +if (!hv_syndbg_handler) { + ret =HV_STATUS_INVALID_HYPERCALL_CODE ; + goto cleanup; + } + + len =sizeof (*reset_dbg_session); + reset_dbg_session =cpu_physical_memory_map (outgpa, &len,1 ); +if (!reset_dbg_session || len <sizeof (*reset_dbg_session)) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + } + + msg.type =HV_SYNDBG_MSG_CONNECTION_INFO ; + ret =hv_syndbg_handler (hv_syndbg_context, &msg); +if (ret) { + goto cleanup; + } + + reset_dbg_session->host_ip = msg.u.connection_info.host_ip; + reset_dbg_session->host_port = msg.u.connection_info.host_port; +/* The following fields are only used as validation for KDVM */ +memset (&reset_dbg_session->host_mac,0 , +sizeof (reset_dbg_session->host_mac)); + reset_dbg_session->target_ip = msg.u.connection_info.host_ip; + reset_dbg_session->target_port = msg.u.connection_info.host_port; +memset (&reset_dbg_session->target_mac,0 , +sizeof (reset_dbg_session->target_mac)); +cleanup: +if (reset_dbg_session) { +cpu_physical_memory_unmap (reset_dbg_session, +sizeof (*reset_dbg_session),1 , len); + } + +return ret; +} + +uint16_t hyperv_hcall_retreive_dbg_data (uint64_t ingpa,uint64_t outgpa, +bool fast) +{ +uint16_t ret; +struct hyperv_retrieve_debug_data_input *debug_data_in =NULL ; +struct hyperv_retrieve_debug_data_output *debug_data_out =NULL ; +hwaddr in_len, out_len; +HvSynDbgMsg msg; + +if (fast || !hv_syndbg_handler) { + ret =HV_STATUS_INVALID_HYPERCALL_CODE ; + goto cleanup; + } + + in_len =sizeof (*debug_data_in); + debug_data_in =cpu_physical_memory_map (ingpa, &in_len,0 ); +if (!debug_data_in || in_len <sizeof (*debug_data_in)) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + } + + out_len =sizeof (*debug_data_out); + debug_data_out =cpu_physical_memory_map (outgpa, &out_len,1 ); +if (!debug_data_out || out_len <sizeof (*debug_data_out)) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + } + + msg.type =HV_SYNDBG_MSG_RECV ; + msg.u.recv.buf_gpa = outgpa +sizeof (*debug_data_out); + msg.u.recv.count =TARGET_PAGE_SIZE -sizeof (*debug_data_out); + msg.u.recv.options = debug_data_in->options; + msg.u.recv.timeout = debug_data_in->timeout; + msg.u.recv.is_raw = true; + ret =hv_syndbg_handler (hv_syndbg_context, &msg); +if (ret ==HV_STATUS_NO_DATA ) { + debug_data_out->retrieved_count =0 ; + debug_data_out->remaining_count = debug_data_in->count; + goto cleanup; + }else if (ret !=HV_STATUS_SUCCESS ) { + goto cleanup; + } + + debug_data_out->retrieved_count = msg.u.recv.retrieved_count; + debug_data_out->remaining_count = + debug_data_in->count - msg.u.recv.retrieved_count; +cleanup: +if (debug_data_out) { +cpu_physical_memory_unmap (debug_data_out,sizeof (*debug_data_out),1 , + out_len); + } + +if (debug_data_in) { +cpu_physical_memory_unmap (debug_data_in,sizeof (*debug_data_in),0 , + in_len); + } + +return ret; +} + +uint16_t hyperv_hcall_post_dbg_data (uint64_t ingpa,uint64_t outgpa,bool fast) +{ +uint16_t ret; +struct hyperv_post_debug_data_input *post_data_in =NULL ; +struct hyperv_post_debug_data_output *post_data_out =NULL ; +hwaddr in_len, out_len; +HvSynDbgMsg msg; + +if (fast || !hv_syndbg_handler) { + ret =HV_STATUS_INVALID_HYPERCALL_CODE ; + goto cleanup; + } + + in_len =sizeof (*post_data_in); + post_data_in =cpu_physical_memory_map (ingpa, &in_len,0 ); +if (!post_data_in || in_len <sizeof (*post_data_in)) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + } + +if (post_data_in->count >TARGET_PAGE_SIZE -sizeof (*post_data_in)) { + ret =HV_STATUS_INVALID_PARAMETER ; + goto cleanup; + } + + out_len =sizeof (*post_data_out); + post_data_out =cpu_physical_memory_map (outgpa, &out_len,1 ); +if (!post_data_out || out_len <sizeof (*post_data_out)) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + } + + msg.type =HV_SYNDBG_MSG_SEND ; + msg.u.send.buf_gpa = ingpa +sizeof (*post_data_in); + msg.u.send.count = post_data_in->count; + msg.u.send.is_raw = true; + ret =hv_syndbg_handler (hv_syndbg_context, &msg); +if (ret !=HV_STATUS_SUCCESS ) { + goto cleanup; + } + + post_data_out->pending_count = msg.u.send.pending_count; + ret = post_data_out->pending_count ?HV_STATUS_INSUFFICIENT_BUFFERS : +HV_STATUS_SUCCESS ; +cleanup: +if (post_data_out) { +cpu_physical_memory_unmap (post_data_out, +sizeof (*post_data_out),1 , out_len); + } + +if (post_data_in) { +cpu_physical_memory_unmap (post_data_in, +sizeof (*post_data_in),0 , in_len); + } + +return ret; +} + +uint32_t hyperv_syndbg_send (uint64_t ingpa,uint32_t count) +{ +HvSynDbgMsg msg; + +if (!hv_syndbg_handler) { +return HV_SYNDBG_STATUS_INVALID ; + } + + msg.type =HV_SYNDBG_MSG_SEND ; + msg.u.send.buf_gpa = ingpa; + msg.u.send.count = count; + msg.u.send.is_raw = false; +if (hv_syndbg_handler (hv_syndbg_context, &msg)) { +return HV_SYNDBG_STATUS_INVALID ; + } + +return HV_SYNDBG_STATUS_SEND_SUCCESS ; +} + +uint32_t hyperv_syndbg_recv (uint64_t ingpa,uint32_t count) +{ +uint16_t ret; +HvSynDbgMsg msg; + +if (!hv_syndbg_handler) { +return HV_SYNDBG_STATUS_INVALID ; + } + + msg.type =HV_SYNDBG_MSG_RECV ; + msg.u.recv.buf_gpa = ingpa; + msg.u.recv.count = count; + msg.u.recv.options =0 ; + msg.u.recv.timeout =0 ; + msg.u.recv.is_raw = false; + ret =hv_syndbg_handler (hv_syndbg_context, &msg); +if (ret !=HV_STATUS_SUCCESS ) { +return 0 ; + } + +return HV_SYNDBG_STATUS_SET_SIZE (HV_SYNDBG_STATUS_RECV_SUCCESS , + msg.u.recv.retrieved_count); +} + +void hyperv_syndbg_set_pending_page (uint64_t ingpa) +{ +HvSynDbgMsg msg; + +if (!hv_syndbg_handler) { +return ; + } + + msg.type =HV_SYNDBG_MSG_SET_PENDING_PAGE ; + msg.u.pending_page.buf_gpa = ingpa; +hv_syndbg_handler (hv_syndbg_context, &msg); +} + +uint64_t hyperv_syndbg_query_options (void ) +{ +HvSynDbgMsg msg; + +if (!hv_syndbg_handler) { +return 0 ; + } + + msg.type =HV_SYNDBG_MSG_QUERY_OPTIONS ; +if (hv_syndbg_handler (hv_syndbg_context, &msg) !=HV_STATUS_SUCCESS ) { +return 0 ; + } + +return msg.u.query_options.options; +}include/hw/hyperv/hyperv.h +58
-0@@ -83,4 +83,62 @@ void hyperv_synic_update(CPUState *cs, bool enable, hwaddr msg_page_addr, hwaddr event_page_addr);bool hyperv_is_synic_enabled (void ); +/* +* Process HVCALL_RESET_DEBUG_SESSION hypercall. +*/ +uint16_t hyperv_hcall_reset_dbg_session (uint64_t outgpa); +/* +* Process HVCALL_RETREIVE_DEBUG_DATA hypercall. +*/ +uint16_t hyperv_hcall_retreive_dbg_data (uint64_t ingpa,uint64_t outgpa, +bool fast); +/* +* Process HVCALL_POST_DEBUG_DATA hypercall. +*/ +uint16_t hyperv_hcall_post_dbg_data (uint64_t ingpa,uint64_t outgpa,bool fast); + +uint32_t hyperv_syndbg_send (uint64_t ingpa,uint32_t count); +uint32_t hyperv_syndbg_recv (uint64_t ingpa,uint32_t count); +void hyperv_syndbg_set_pending_page (uint64_t ingpa); +uint64_t hyperv_syndbg_query_options (void ); + +typedef enum HvSynthDbgMsgType { +HV_SYNDBG_MSG_CONNECTION_INFO , +HV_SYNDBG_MSG_SEND , +HV_SYNDBG_MSG_RECV , +HV_SYNDBG_MSG_SET_PENDING_PAGE , +HV_SYNDBG_MSG_QUERY_OPTIONS +}HvDbgSynthMsgType ; + +typedef struct HvSynDbgMsg { +HvDbgSynthMsgType type; +union { +struct { +uint32_t host_ip; +uint16_t host_port; + } connection_info; +struct { +uint64_t buf_gpa; +uint32_t count; +uint32_t pending_count; +bool is_raw; + } send; +struct { +uint64_t buf_gpa; +uint32_t count; +uint32_t options; +uint64_t timeout; +uint32_t retrieved_count; +bool is_raw; + } recv; +struct { +uint64_t buf_gpa; + } pending_page; +struct { +uint64_t options; + } query_options; + } u; +}HvSynDbgMsg ; +typedef uint16_t (*HvSynDbgHandler )(void *context,HvSynDbgMsg *msg); +void hyperv_set_syndbg_handler (HvSynDbgHandler handler,void *context);#endif target/i386/cpu.c +2
-0@@ -6841,6 +6841,8 @@ static Property x86_cpu_properties[] = { HYPERV_FEAT_AVIC, 0),DEFINE_PROP_ON_OFF_AUTO ("hv-no-nonarch-coresharing" ,X86CPU , hyperv_no_nonarch_cs,ON_OFF_AUTO_OFF ), +DEFINE_PROP_BIT64 ("hv-syndbg" ,X86CPU , hyperv_features, +HYPERV_FEAT_SYNDBG ,0 ),DEFINE_PROP_BOOL ("hv-passthrough" ,X86CPU , hyperv_passthrough, false), DEFINE_PROP_BOOL("hv-enforce-cpuid", X86CPU, hyperv_enforce_cpuid, false),target/i386/cpu.h +7
-0@@ -1060,6 +1060,7 @@ typedef uint64_t FeatureWordArray[FEATURE_WORDS];#define HYPERV_FEAT_IPI 13#define HYPERV_FEAT_STIMER_DIRECT 14#define HYPERV_FEAT_AVIC 15 +#define HYPERV_FEAT_SYNDBG 16#ifndef HYPERV_SPINLOCK_NEVER_NOTIFY #define HYPERV_SPINLOCK_NEVER_NOTIFY 0xFFFFFFFF@@ -1560,6 +1561,12 @@ typedef struct CPUX86State {uint64_t msr_hv_hypercall;uint64_t msr_hv_guest_os_id;uint64_t msr_hv_tsc; +uint64_t msr_hv_syndbg_control; +uint64_t msr_hv_syndbg_status; +uint64_t msr_hv_syndbg_send_page; +uint64_t msr_hv_syndbg_recv_page; +uint64_t msr_hv_syndbg_pending_page; +uint64_t msr_hv_syndbg_options;/* Per-VCPU HV MSRs */ uint64_t msr_hv_vapic;target/i386/kvm/hyperv-stub.c +6
-0@@ -27,6 +27,12 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit)return 0 ;case KVM_EXIT_HYPERV_HCALL : exit->u.hcall.result =HV_STATUS_INVALID_HYPERCALL_CODE ; +return 0 ; +case KVM_EXIT_HYPERV_SYNDBG : +if (!hyperv_feat_enabled (cpu,HYPERV_FEAT_SYNDBG )) { +return -1 ; + } +return 0 ;default :return -1 ;target/i386/kvm/hyperv.c +49
-3@@ -81,20 +81,66 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit)case KVM_EXIT_HYPERV_HCALL : {uint16_t code = exit->u.hcall.input &0xffff ;bool fast = exit->u.hcall.input &HV_HYPERCALL_FAST ; -uint64_t param = exit->u.hcall.params[0 ]; +uint64_t in_param = exit->u.hcall.params[0 ]; +uint64_t out_param = exit->u.hcall.params[1 ];switch (code) {case HV_POST_MESSAGE : - exit->u.hcall.result =hyperv_hcall_post_message (param, fast); + exit->u.hcall.result =hyperv_hcall_post_message (in_param, fast);break ;case HV_SIGNAL_EVENT : - exit->u.hcall.result =hyperv_hcall_signal_event (param, fast); + exit->u.hcall.result =hyperv_hcall_signal_event (in_param, fast); +break ; +case HV_POST_DEBUG_DATA : + exit->u.hcall.result = +hyperv_hcall_post_dbg_data (in_param, out_param, fast); +break ; +case HV_RETREIVE_DEBUG_DATA : + exit->u.hcall.result = +hyperv_hcall_retreive_dbg_data (in_param, out_param, fast); +break ; +case HV_RESET_DEBUG_SESSION : + exit->u.hcall.result = +hyperv_hcall_reset_dbg_session (out_param);break ;default : exit->u.hcall.result =HV_STATUS_INVALID_HYPERCALL_CODE ; }return 0 ; } + +case KVM_EXIT_HYPERV_SYNDBG : +if (!hyperv_feat_enabled (cpu,HYPERV_FEAT_SYNDBG )) { +return -1 ; + } + +switch (exit->u.syndbg.msr) { +case HV_X64_MSR_SYNDBG_CONTROL : { +uint64_t control = exit->u.syndbg.control; + env->msr_hv_syndbg_control = control; + env->msr_hv_syndbg_send_page = exit->u.syndbg.send_page; + env->msr_hv_syndbg_recv_page = exit->u.syndbg.recv_page; + exit->u.syndbg.status =HV_STATUS_SUCCESS ; +if (control &HV_SYNDBG_CONTROL_SEND ) { + exit->u.syndbg.status = +hyperv_syndbg_send (env->msr_hv_syndbg_send_page, +HV_SYNDBG_CONTROL_SEND_SIZE (control)); + }else if (control &HV_SYNDBG_CONTROL_RECV ) { + exit->u.syndbg.status = +hyperv_syndbg_recv (env->msr_hv_syndbg_recv_page, +TARGET_PAGE_SIZE ); + } +break ; + } +case HV_X64_MSR_SYNDBG_PENDING_BUFFER : + env->msr_hv_syndbg_pending_page = exit->u.syndbg.pending_page; +hyperv_syndbg_set_pending_page (env->msr_hv_syndbg_pending_page); +break ; +default : +return -1 ; + } + +return 0 ;default :return -1 ; }target/i386/kvm/kvm.c +71
-5@@ -102,6 +102,7 @@ static bool has_msr_hv_synic;static bool has_msr_hv_stimer;static bool has_msr_hv_frequencies;static bool has_msr_hv_reenlightenment; +static bool has_msr_hv_syndbg_options;static bool has_msr_xss;static bool has_msr_umwait;static bool has_msr_spec_ctrl;@@ -932,6 +933,14 @@ static struct { .bits = HV_DEPRECATING_AEOI_RECOMMENDED} } }, + [HYPERV_FEAT_SYNDBG ] = { + .desc ="Enable synthetic kernel debugger channel (hv-syndbg)" , + .flags = { + {.func =HV_CPUID_FEATURES , .reg =R_EDX , + .bits =HV_FEATURE_DEBUG_MSRS_AVAILABLE } + }, + .dependencies =BIT (HYPERV_FEAT_SYNIC ) |BIT (HYPERV_FEAT_RELAXED ) + }, }; static struct kvm_cpuid2 *try_get_hv_cpuid(CPUState *cs, int max,@@ -972,8 +981,8 @@ static struct kvm_cpuid2 *try_get_hv_cpuid(CPUState *cs, int max,static struct kvm_cpuid2 *get_supported_hv_cpuid (CPUState *cs) {struct kvm_cpuid2 *cpuid; -/* 0x40000000..0x40000005, 0x4000000A, 0x40000080..0x40000080 leaves */ -int max =10 ; +/* 0x40000000..0x40000005, 0x4000000A, 0x40000080..0x40000082 leaves */ +int max =11 ;int i;bool do_sys_ioctl;@@ -1086,6 +1095,12 @@ static struct kvm_cpuid2 *get_supported_hv_cpuid_legacy(CPUState *cs) entry_feat->eax |=HV_SYNTIMERS_AVAILABLE ; } +if (has_msr_hv_syndbg_options) { + entry_feat->edx |=HV_GUEST_DEBUGGING_AVAILABLE ; + entry_feat->edx |=HV_FEATURE_DEBUG_MSRS_AVAILABLE ; + entry_feat->ebx |=HV_PARTITION_DEUBGGING_ALLOWED ; + } +if (kvm_check_extension (cs->kvm_state,KVM_CAP_HYPERV_TLBFLUSH ) >0 ) { entry_recomm->eax |=HV_REMOTE_TLB_FLUSH_RECOMMENDED ;@@ -1337,12 +1352,22 @@ static int hyperv_fill_cpuids(CPUState *cs, {X86CPU *cpu =X86_CPU (cs);struct kvm_cpuid_entry2 *c; -uint32_t cpuid_i =0 ; +uint32_t signature[3 ]; +uint32_t cpuid_i =0 , max_cpuid_leaf =0 ; + + max_cpuid_leaf =HV_CPUID_IMPLEMENT_LIMITS ; +if (hyperv_feat_enabled (cpu,HYPERV_FEAT_EVMCS )) { + max_cpuid_leaf =MAX (max_cpuid_leaf,HV_CPUID_NESTED_FEATURES ); + } + +if (hyperv_feat_enabled (cpu,HYPERV_FEAT_SYNDBG )) { + max_cpuid_leaf = +MAX (max_cpuid_leaf,HV_CPUID_SYNDBG_PLATFORM_CAPABILITIES ); + } c = &cpuid_ent[cpuid_i++]; c->function =HV_CPUID_VENDOR_AND_MAX_FUNCTIONS ; - c->eax =hyperv_feat_enabled (cpu,HYPERV_FEAT_EVMCS ) ? -HV_CPUID_NESTED_FEATURES :HV_CPUID_IMPLEMENT_LIMITS ; + c->eax = max_cpuid_leaf; c->ebx = cpu->hyperv_vendor_id[0 ]; c->ecx = cpu->hyperv_vendor_id[1 ]; c->edx = cpu->hyperv_vendor_id[2 ];@@ -1421,6 +1446,33 @@ static int hyperv_fill_cpuids(CPUState *cs, c->eax = cpu->hyperv_nested[0 ]; } +if (hyperv_feat_enabled (cpu,HYPERV_FEAT_SYNDBG )) { + c = &cpuid_ent[cpuid_i++]; + c->function =HV_CPUID_SYNDBG_VENDOR_AND_MAX_FUNCTIONS ; + c->eax =hyperv_feat_enabled (cpu,HYPERV_FEAT_EVMCS ) ? +HV_CPUID_NESTED_FEATURES :HV_CPUID_IMPLEMENT_LIMITS ; +memcpy (signature,"Microsoft VS" ,12 ); + c->eax =0 ; + c->ebx = signature[0 ]; + c->ecx = signature[1 ]; + c->edx = signature[2 ]; + + c = &cpuid_ent[cpuid_i++]; + c->function =HV_CPUID_SYNDBG_INTERFACE ; +memcpy (signature,"VS#1\0\0\0\0\0\0\0\0" ,12 ); + c->eax = signature[0 ]; + c->ebx =0 ; + c->ecx =0 ; + c->edx =0 ; + + c = &cpuid_ent[cpuid_i++]; + c->function =HV_CPUID_SYNDBG_PLATFORM_CAPABILITIES ; + c->eax =HV_SYNDBG_CAP_ALLOW_KERNEL_DEBUGGING ; + c->ebx =0 ; + c->ecx =0 ; + c->edx =0 ; + } +return cpuid_i; }@@ -2215,6 +2267,9 @@ static int kvm_get_supported_msrs(KVMState *s)case HV_X64_MSR_REENLIGHTENMENT_CONTROL : has_msr_hv_reenlightenment = true;break ; +case HV_X64_MSR_SYNDBG_OPTIONS : + has_msr_hv_syndbg_options = true; +break ;case MSR_IA32_SPEC_CTRL : has_msr_spec_ctrl = true;break ;@@ -3132,6 +3187,11 @@ static int kvm_put_msrs(X86CPU *cpu, int level)kvm_msr_entry_add (cpu,HV_X64_MSR_TSC_EMULATION_STATUS , env->msr_hv_tsc_emulation_status); } +if (hyperv_feat_enabled (cpu,HYPERV_FEAT_SYNDBG ) && + has_msr_hv_syndbg_options) { +kvm_msr_entry_add (cpu,HV_X64_MSR_SYNDBG_OPTIONS , +hyperv_syndbg_query_options ()); + } }if (hyperv_feat_enabled (cpu,HYPERV_FEAT_VAPIC )) { kvm_msr_entry_add(cpu, HV_X64_MSR_APIC_ASSIST_PAGE,@@ -3565,6 +3625,9 @@ static int kvm_get_msrs(X86CPU *cpu)kvm_msr_entry_add (cpu,HV_X64_MSR_TSC_EMULATION_CONTROL ,0 );kvm_msr_entry_add (cpu,HV_X64_MSR_TSC_EMULATION_STATUS ,0 ); } +if (has_msr_hv_syndbg_options) { +kvm_msr_entry_add (cpu,HV_X64_MSR_SYNDBG_OPTIONS ,0 ); + }if (has_msr_hv_crash) {int j;@@ -3851,6 +3914,9 @@ static int kvm_get_msrs(X86CPU *cpu)case HV_X64_MSR_TSC_EMULATION_STATUS : env->msr_hv_tsc_emulation_status = msrs[i].data;break ; +case HV_X64_MSR_SYNDBG_OPTIONS : + env->msr_hv_syndbg_options = msrs[i].data; +break ;case MSR_MTRRdefType: env->mtrr_deftype = msrs[i].data;break ;
Re: [PATCH v1 1/4] hyperv: SControl is optional to enable SynIc
In reply to Emanuele Giuseppe EspositoQuoted 6 lines · Emanuele Giuseppe Esposito
Quoted 3 lines · Jon Doron
SynIc can be enabled regardless of the SControl mechanisim which can register a GSI for a given SintRoute.
Quoted 8 lines
Quoted 6 lines
This behaviour can achived by setting enabling SIMP and then the guest will poll on the message slot.
Once there is another message pending the host will set the message slot with the pending flag.
When the guest polls from the message slot, incase the pending flag iss/incase/in case
Done
Quoted 4 lines
Quoted 2 lines
set it will write to the
HV_X64_MSR_EOMindicating it has cleared the slow and we can try and push our message again.what do you mean by "the slow"?
Just a typo to slot :) fixed
Quoted 77 lines
Quoted 77 lines
Signed-off-by Jon Doron <[email protected]>--- hw/hyperv/hyperv.c | 233 ++++++++++++++++++++++++------------- include/hw/hyperv/hyperv.h | 2 + 2 files changed, 153 insertions(+), 82 deletions(-)hw/hyperv/hyperv.c +50
-1@@ -27,18 +27,70 @@ struct SynICState {CPUState *cs; -bool enabled; +bool sctl_enabled;hwaddr msg_page_addr;hwaddr event_page_addr;MemoryRegion msg_page_mr;MemoryRegion event_page_mr;struct hyperv_message_page *msg_page;struct hyperv_event_flags_page *event_page; + +QemuMutex sint_routes_mutex; + QLIST_HEAD(, HvSintRoute) sint_routes; };#define TYPE_SYNIC "hyperv-synic"OBJECT_DECLARE_SIMPLE_TYPE (SynICState,SYNIC ) +/* +* KVM has its own message producers (SynIC timers). To guarantee +* serialization with both KVM vcpu and the guest cpu, the messages are first +* staged in an intermediate area and then posted to the SynIC message page in +* the vcpu thread. + */ +typedef struct HvSintStagedMessage { +/* message content staged by hyperv_post_msg */ +struct hyperv_message msg; +/* callback + data (r/o) to complete the processing in a BH */ +HvSintMsgCb cb; +void *cb_data; +/* message posting status filled by cpu_post_msg */ +int status; +/* passing the buck: */ +enum { +/* initial state */ +HV_STAGED_MSG_FREE , +/* +* hyperv_post_msg (e.g. in main loop) grabs the staged area (FREE -> +* BUSY), copies msg, and schedules cpu_post_msg on the assigned cpu +*/ +HV_STAGED_MSG_BUSY , +/* +* cpu_post_msg (vcpu thread) tries to copy staged msg to msg slot, +* notify the guest, records the status, marks the posting done (BUSY +* -> POSTED), and schedules sint_msg_bh BH +*/ +HV_STAGED_MSG_POSTED , +/* +* sint_msg_bh (BH) verifies that the posting is done, runs the +* callback, and starts over (POSTED -> FREE) +*/ + } state; +}HvSintStagedMessage ; + +struct HvSintRoute { +uint32_t sint; +SynICState *synic; +int gsi; +EventNotifier sint_set_notifier; +EventNotifier sint_ack_notifier; + +HvSintStagedMessage *staged_msg; + +unsigned refcount;
Quoted 8 lines
hw/hyperv/hyperv.c struct SynICState { · line 94
Quoted 4 lines
hw/hyperv/hyperv.c +3
-0+QLIST_ENTRY (HvSintRoute) link; +}; +static bool synic_enabled;Why did you move this struct above?
I think it was done purposefully to separate synic_* functions from the others below (sint_*).
Done
Quoted 112 lines
Quoted 112 lines
hw/hyperv/hyperv.c +8
-52bool hyperv_is_synic_enabled (void )@@ -51,11 +103,11 @@ static SynICState *get_synic(CPUState *cs)return SYNIC (object_resolve_path_component (OBJECT (cs),"synic" )); } -static void synic_update (SynICState *synic,bool enable, +static void synic_update (SynICState *synic,bool sctl_enable,hwaddr msg_page_addr,hwaddr event_page_addr) { - synic->enabled = enable; + synic->sctl_enabled = sctl_enable;if (synic->msg_page_addr != msg_page_addr) {if (synic->msg_page_addr) { memory_region_del_subregion(get_system_memory(),@@ -80,7 +132,7 @@ static void synic_update(SynICState *synic, bool enable, } } -void hyperv_synic_update (CPUState *cs,bool enable, +void hyperv_synic_update (CPUState *cs,bool sctl_enable,hwaddr msg_page_addr,hwaddr event_page_addr) {SynICState *synic =get_synic (cs);@@ -89,7 +141,7 @@ void hyperv_synic_update(CPUState *cs, bool enable,return ; } -synic_update (synic, enable, msg_page_addr, event_page_addr); +synic_update (synic, sctl_enable, msg_page_addr, event_page_addr); }static void synic_realize (DeviceState *dev,Error **errp)@@ -110,16 +162,20 @@ static void synic_realize(DeviceState *dev, Error **errp) sizeof(*synic->event_page), &error_abort); synic->msg_page =memory_region_get_ram_ptr (&synic->msg_page_mr); synic->event_page =memory_region_get_ram_ptr (&synic->event_page_mr); +qemu_mutex_init (&synic->sint_routes_mutex); +QLIST_INIT (&synic->sint_routes);g_free (msgp_name);g_free (eventp_name); } +static void synic_reset (DeviceState *dev) {SynICState *synic =SYNIC (dev);memset (synic->msg_page,0 ,sizeof (*synic->msg_page));memset (synic->event_page,0 ,sizeof (*synic->event_page));synic_update (synic, false,0 ,0 ); +assert (QLIST_EMPTY (&synic->sint_routes)); }static void synic_class_init (ObjectClass *klass,void *data)@@ -168,54 +224,6 @@ static void synic_register_types(void)type_init (synic_register_types) -/* -* KVM has its own message producers (SynIC timers). To guarantee -* serialization with both KVM vcpu and the guest cpu, the messages are first -* staged in an intermediate area and then posted to the SynIC message page in -* the vcpu thread. -*/ -typedef struct HvSintStagedMessage { -/* message content staged by hyperv_post_msg */ -struct hyperv_message msg; -/* callback + data (r/o) to complete the processing in a BH */ -HvSintMsgCb cb; -void *cb_data; -/* message posting status filled by cpu_post_msg */ -int status; -/* passing the buck: */ -enum { -/* initial state */ -HV_STAGED_MSG_FREE , -/* -* hyperv_post_msg (e.g. in main loop) grabs the staged area (FREE -> -* BUSY), copies msg, and schedules cpu_post_msg on the assigned cpu -*/ -HV_STAGED_MSG_BUSY , -/* -* cpu_post_msg (vcpu thread) tries to copy staged msg to msg slot, -* notify the guest, records the status, marks the posting done (BUSY -* -> POSTED), and schedules sint_msg_bh BH -*/ -HV_STAGED_MSG_POSTED , -/* -* sint_msg_bh (BH) verifies that the posting is done, runs the -* callback, and starts over (POSTED -> FREE) -*/ - } state; -} HvSintStagedMessage; - -struct HvSintRoute { -uint32_t sint; -SynICState *synic; -int gsi; -EventNotifier sint_set_notifier; -EventNotifier sint_ack_notifier; - -HvSintStagedMessage *staged_msg; - -unsigned refcount; -}; - static CPUState *hyperv_find_vcpu(uint32_t vp_index) {CPUState *cs =qemu_get_cpu (vp_index);@@ -259,7 +267,7 @@ static void cpu_post_msg(CPUState *cs, run_on_cpu_data data)
Quoted 8 lines
hw/hyperv/hyperv.c static void cpu_post_msg(CPUState *cs, run_on_cpu_data data) · line 270
Quoted 4 lines
hw/hyperv/hyperv.c +1
-1assert (staged_msg->state ==HV_STAGED_MSG_BUSY ); -if (!synic->enabled || !synic->msg_page_addr) { +if (!synic->msg_page_addr) {Not sure if this is important, but why don't you check for !synic->sctl_enabled anymore here? You do it below.
I cannot check for sctl_enabled, there is a mode in which SCTL is not set but the SynIC interface is still functioning simply with polling.
Quoted 39 lines
Quoted 39 lines
hw/hyperv/hyperv.c +7
-6staged_msg->status = -ENXIO ; goto posted; }@@ -343,7 +351,7 @@ int hyperv_set_event_flag(HvSintRoute *sint_route, unsigned eventno)if (eventno >HV_EVENT_FLAGS_COUNT ) {return -EINVAL ; } -if (!synic->enabled || !synic->event_page_addr) { +if (!synic->sctl_enabled || !synic->event_page_addr) {return -ENXIO ; }@@ -364,11 +372,13 @@ int hyperv_set_event_flag(HvSintRoute *sint_route, unsigned eventno)HvSintRoute *hyperv_sint_route_new (uint32_t vp_index,uint32_t sint,HvSintMsgCb cb,void *cb_data) { -HvSintRoute *sint_route; -EventNotifier *ack_notifier; +HvSintRoute *sint_route =NULL ; +EventNotifier *ack_notifier =NULL ;int r, gsi;CPUState *cs;SynICState *synic; +bool ack_event_initialized = false, sint_notifier_initialized = false, + irqfd_initialized = false; cs =hyperv_find_vcpu (vp_index);if (!cs) {@@ -381,57 +391,82 @@ HvSintRoute *hyperv_sint_route_new(uint32_t vp_index, uint32_t sint, } sint_route =g_new0 (HvSintRoute,1 ); - r =event_notifier_init (&sint_route->sint_set_notifier, false); -if (r) { - goto err; +if (!sint_route) { + goto cleanup_err; }
Quoted 4 lines
hw/hyperv/hyperv.c HvSintRoute *hyperv_sint_route_new(uint32_t vp_index, uint32_t sint, · line 398
Quoted 1 line
hw/hyperv/hyperv.c +1
-0+ sint_route->gsi =0 ;useless, as
g_new0zeroes all fields
Done
Quoted 95 lines
Quoted 80 lines
hw/hyperv/hyperv.c +41
-13+ sint_route->synic = synic; + sint_route->sint = sint; + sint_route->refcount =1 ; ack_notifier = cb ? &sint_route->sint_ack_notifier :NULL ;if (ack_notifier) { sint_route->staged_msg =g_new0 (HvSintStagedMessage,1 ); +if (!sint_route->staged_msg) { + goto cleanup_err; + } sint_route->staged_msg->cb = cb; sint_route->staged_msg->cb_data = cb_data; r =event_notifier_init (ack_notifier, false);if (r) { - goto err_sint_set_notifier; + goto cleanup_err; } -event_notifier_set_handler (ack_notifier, sint_ack_handler); + ack_event_initialized = true; + } + +/* See if we are done or we need to setup a GSI for this SintRoute */ +if (!synic->sctl_enabled) { + goto cleanup; } +/* We need to setup a GSI for this SintRoute */ + r =event_notifier_init (&sint_route->sint_set_notifier, false); +if (r) { + goto cleanup_err; + } + sint_notifier_initialized = true; + gsi =kvm_irqchip_add_hv_sint_route (kvm_state, vp_index, sint);if (gsi <0 ) { - goto err_gsi; + goto cleanup_err; } + irqfd_initialized = true; r =kvm_irqchip_add_irqfd_notifier_gsi (kvm_state, &sint_route->sint_set_notifier, ack_notifier, gsi);if (r) { - goto err_irqfd; + goto cleanup_err; } sint_route->gsi = gsi; - sint_route->synic = synic; - sint_route->sint = sint; - sint_route->refcount =1 ; - +cleanup: +qemu_mutex_lock (&synic->sint_routes_mutex); +QLIST_INSERT_HEAD_RCU (&synic->sint_routes, sint_route, link); +qemu_mutex_unlock (&synic->sint_routes_mutex);return sint_route; -err_irqfd: -kvm_irqchip_release_virq (kvm_state, gsi); -err_gsi: +cleanup_err: +if (irqfd_initialized) { +kvm_irqchip_release_virq (kvm_state, gsi); + } + +if (sint_notifier_initialized) { +event_notifier_cleanup (&sint_route->sint_set_notifier); + } +if (ack_notifier) { -event_notifier_set_handler (ack_notifier,NULL ); -event_notifier_cleanup (ack_notifier); +if (ack_event_initialized) { +event_notifier_set_handler (ack_notifier,NULL ); +event_notifier_cleanup (ack_notifier); + } +hw/hyperv/hyperv.c HvSintRoute *hyperv_sint_route_new(uint32_t vp_index, uint32_t sint, · line 471
Quoted 10 lines
hw/hyperv/hyperv.c +1
-4g_free (sint_route->staged_msg); } -err_sint_set_notifier: -event_notifier_cleanup (&sint_route->sint_set_notifier); -err: -g_free (sint_route); +g_free (sint_route);return NULL ; }It is good that you check that
sint_routeis not NULL, but I don't find it easy to read nor a common practice to have one single goto label and multiple booleans to distinguish various error cases.
Quoted 3 lines
I think you should do as it was done before, with a specific label for each type of error, and not always use
cleanup_err.
Done
Quoted 14 lines
Quoted 14 lines
hw/hyperv/hyperv.c +2
-0@@ -442,6 +477,8 @@ void hyperv_sint_route_ref(HvSintRoute *sint_route)void hyperv_sint_route_unref (HvSintRoute *sint_route) { +SynICState *synic; +if (!sint_route) {return ; }@@ -452,21 +489,33 @@ void hyperv_sint_route_unref(HvSintRoute *sint_route)return ; }
Quoted 12 lines
hw/hyperv/hyperv.c void hyperv_sint_route_unref(HvSintRoute *sint_route) · line 495
Quoted 8 lines
hw/hyperv/hyperv.c +4
-4-kvm_irqchip_remove_irqfd_notifier_gsi (kvm_state, - &sint_route->sint_set_notifier, - sint_route->gsi); -kvm_irqchip_release_virq (kvm_state, sint_route->gsi); + synic = sint_route->synic; +qemu_mutex_lock (&synic->sint_routes_mutex); +QLIST_REMOVE_RCU (sint_route, link); +qemu_mutex_unlock (&synic->sint_routes_mutex);Not really important, but you can use
WITH_QEMU_LOCK_GUARDinstead of doing lock/unlock.
Kept as is
Quoted 31 lines
Quoted 31 lines
hw/hyperv/hyperv.c +13
-1+ +if (sint_route->gsi) { +kvm_irqchip_remove_irqfd_notifier_gsi (kvm_state, + &sint_route->sint_set_notifier, + sint_route->gsi); +kvm_irqchip_release_virq (kvm_state, sint_route->gsi); +event_notifier_cleanup (&sint_route->sint_set_notifier); + } +if (sint_route->staged_msg) {event_notifier_set_handler (&sint_route->sint_ack_notifier,NULL );event_notifier_cleanup (&sint_route->sint_ack_notifier);g_free (sint_route->staged_msg); } -event_notifier_cleanup (&sint_route->sint_set_notifier);g_free (sint_route); }int hyperv_sint_route_set_sint (HvSintRoute *sint_route) { +if (!sint_route->gsi) { +return 0 ; + } +return event_notifier_set (&sint_route->sint_set_notifier); }@@ -529,6 +578,26 @@ int hyperv_set_msg_handler(uint32_t conn_id, HvMsgHandler handler, void *data)return ret; }
Quoted 12 lines
hw/hyperv/hyperv.c int hyperv_set_msg_handler(uint32_t conn_id, HvMsgHandler handler, void *data) · line 588
Quoted 8 lines
hw/hyperv/hyperv.c +8
-0+int hyperv_synic_eom (CPUState *cs) +{ +SynICState *synic =get_synic (cs); +HvSintRoute *sint_route; + +if (!synic) { +return -1 ; + }use here
QEMU_LOCK_GUARD(&synic->sint_routes_mutex);
instead of lock/unlock
Removed the entire function, now that I realize that I dont need it.
Quoted 19 lines
Quoted 19 lines
hw/hyperv/hyperv.c +10
-0+ +qemu_mutex_lock (&synic->sint_routes_mutex); + QLIST_FOREACH(sint_route, &synic->sint_routes, link) { +/* Try to complete every SintRoute */ +aio_bh_schedule_oneshot (qemu_get_aio_context (), sint_msg_bh, + sint_route); + } + qemu_mutex_unlock(&synic->sint_routes_mutex);> + return 0; +} +uint16_t hyperv_hcall_post_message (uint64_t param,bool fast) {uint16_t ret;include/hw/hyperv/hyperv.h +0
-0@@ -28,6 +28,8 @@ void hyperv_sint_route_unref(HvSintRoute *sint_route);
Quoted 7 lines
include/hw/hyperv/hyperv.h void hyperv_sint_route_unref(HvSintRoute *sint_route); · line 32
Quoted 4 lines
include/hw/hyperv/hyperv.h +2
-0int hyperv_sint_route_set_sint (HvSintRoute *sint_route); +int hyperv_synic_eom (CPUState *cs); +Documentation here? Where is this function used?
Removed the entire function.
Quoted 5 lines
Quoted 4 lines
include/hw/hyperv/hyperv.h +0
-0/* * Submit a message to be posted in vcpu context. If the submission succeeds, * the status of posting the message is reported via the callback associated
Re: [PATCH v1 4/4] hw: hyperv: Initial commit for Synthetic Debugging device
In reply to Emanuele Giuseppe EspositoQuoted 59 lines · Emanuele Giuseppe Esposito
Quoted 59 lines
hw/hyperv/syndbg.c new file +58
-0+ +static uint16_t handle_recv_msg (HvSynDbg *syndbg,uint64_t outgpa, +uint32_t count,bool is_raw,uint32_t options, +uint64_t timeout,uint32_t *retrieved_count) +{ +uint16_t ret; +uint8_t data_buf[TARGET_PAGE_SIZE -UDP_PKT_HEADER_SIZE ]; +hwaddr out_len; +void *out_data =NULL ; +ssize_t recv_byte_count; + +/* TODO: Handle options and timeout */ + (void )options; + (void )timeout; + +if (!syndbg->has_data_pending) { + recv_byte_count =0 ; + }else { + recv_byte_count =qemu_recv (syndbg->socket, data_buf, +MIN (sizeof (data_buf), count),MSG_WAITALL ); +if (recv_byte_count ==-1 ) { + ret =HV_STATUS_INVALID_PARAMETER ; + goto cleanup; + } + } + +if (!recv_byte_count) { + *retrieved_count =0 ; + ret =HV_STATUS_NO_DATA ; + goto cleanup; + } + +set_pending_state (syndbg, false); + + out_len = recv_byte_count; +if (is_raw) { + out_len +=UDP_PKT_HEADER_SIZE ; + } + out_data =cpu_physical_memory_map (outgpa, &out_len,1 ); +if (!out_data) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + } + +if (is_raw && + !create_udp_pkt (syndbg, out_data, + recv_byte_count +UDP_PKT_HEADER_SIZE , + data_buf, recv_byte_count)) { + ret =HV_STATUS_INSUFFICIENT_MEMORY ; + goto cleanup; + }else if (!is_raw) { +memcpy (out_data, data_buf, recv_byte_count); + } + + *retrieved_count = recv_byte_count; +if (is_raw) { + *retrieved_count +=UDP_PKT_HEADER_SIZE ; + }
Quoted 9 lines
hw/hyperv/syndbg.c line 248
Quoted 5 lines
hw/hyperv/syndbg.c new file +5
-0+ ret =HV_STATUS_SUCCESS ; +cleanup: +if (out_data) { +cpu_physical_memory_unmap (out_data, out_len,1 , out_len); + }Same nitpick as done in patch 1, I think you can use more gotos labels instead of adding if statements.
Done
Quoted 5 lines
Quoted 4 lines
hw/hyperv/syndbg.c new file +4
-0+ +return ret; +} +
Re: [PATCH v1 2/4] hyperv: Add definitions for syndbg
In reply to Emanuele Giuseppe EspositoQuoted 22 lines · Emanuele Giuseppe Esposito
Quoted 19 lines · Jon Doron
Add all required definitions for hyperv synthetic debugger interface.
Signed-off-by Jon Doron <[email protected]>--- include/hw/hyperv/hyperv-proto.h | 52 ++++++++++++++++++++++++++++++++ target/i386/kvm/hyperv-proto.h | 37 +++++++++++++++++++++++ 2 files changed, 89 insertions(+)include/hw/hyperv/hyperv-proto.h +2
-0@@ -24,12 +24,17 @@#define HV_STATUS_INVALID_PORT_ID 17#define HV_STATUS_INVALID_CONNECTION_ID 18#define HV_STATUS_INSUFFICIENT_BUFFERS 19 +#define HV_STATUS_NOT_ACKNOWLEDGED 20 +#define HV_STATUS_NO_DATA 27
Quoted 10 lines
include/hw/hyperv/hyperv-proto.h line 36
Quoted 7 lines
include/hw/hyperv/hyperv-proto.h +2
-0/* * Hypercall numbers */ #define HV_POST_MESSAGE 0x005c#define HV_SIGNAL_EVENT 0x005d +#define HV_POST_DEBUG_DATA 0x0069 +#define HV_RETREIVE_DEBUG_DATA 0x006as/RETREIVE/RETRIEVE?
Done
Quoted 35 lines
Quoted 34 lines
include/hw/hyperv/hyperv-proto.h +27
-0+#define HV_RESET_DEBUG_SESSION 0x006b#define HV_HYPERCALL_FAST (1u << 16)/* @@ -127,4 +132,51 @@ struct hyperv_event_flags_page {struct hyperv_event_flags slot[HV_SINT_COUNT ]; }; +/* +* Kernel debugger structures +*/ + +/* Options flags for hyperv_reset_debug_session */ +#define HV_DEBUG_PURGE_INCOMING_DATA 0x00000001 +#define HV_DEBUG_PURGE_OUTGOING_DATA 0x00000002 +struct hyperv_reset_debug_session_input { +uint32_t options; +} __attribute__ ((__packed__ )); + +struct hyperv_reset_debug_session_output { +uint32_t host_ip; +uint32_t target_ip; +uint16_t host_port; +uint16_t target_port; +uint8_t host_mac[6 ]; +uint8_t target_mac[6 ]; +} __attribute__ ((__packed__ )); + +/* Options for hyperv_post_debug_data */ +#define HV_DEBUG_POST_LOOP 0x00000001 + +struct hyperv_post_debug_data_input { +uint32_t count; +uint32_t options;
Quoted 4 lines
include/hw/hyperv/hyperv-proto.h struct hyperv_event_flags_page { · line 161
Quoted 1 line
include/hw/hyperv/hyperv-proto.h +1
-0+/*uint8_t data[HV_HYP_PAGE_SIZE - 2 * sizeof(uint32_t)];*/ What is this comment for?
It's a reference how the data really looks like.
Quoted 42 lines
Quoted 42 lines
include/hw/hyperv/hyperv-proto.h +20
-0+} __attribute__ ((__packed__)); + +struct hyperv_post_debug_data_output { +uint32_t pending_count; +} __attribute__ ((__packed__ )); + +/* Options for hyperv_retrieve_debug_data */ +#define HV_DEBUG_RETRIEVE_LOOP 0x00000001 +#define HV_DEBUG_RETRIEVE_TEST_ACTIVITY 0x00000002 + +struct hyperv_retrieve_debug_data_input { +uint32_t count; +uint32_t options; +uint64_t timeout; +} __attribute__ ((__packed__ )); + +struct hyperv_retrieve_debug_data_output { +uint32_t retrieved_count; +uint32_t remaining_count; +} __attribute__ ((__packed__ ));#endif target/i386/kvm/hyperv-proto.h +4
-0@@ -19,6 +19,9 @@#define HV_CPUID_ENLIGHTMENT_INFO 0x40000004#define HV_CPUID_IMPLEMENT_LIMITS 0x40000005#define HV_CPUID_NESTED_FEATURES 0x4000000A +#define HV_CPUID_SYNDBG_VENDOR_AND_MAX_FUNCTIONS 0x40000080 +#define HV_CPUID_SYNDBG_INTERFACE 0x40000081 +#define HV_CPUID_SYNDBG_PLATFORM_CAPABILITIES 0x40000082#define HV_CPUID_MIN 0x40000005#define HV_CPUID_MAX 0x4000ffff#define HV_HYPERVISOR_PRESENT_BIT 0x80000000@@ -55,8 +58,14 @@#define HV_GUEST_IDLE_STATE_AVAILABLE (1u << 5)#define HV_FREQUENCY_MSRS_AVAILABLE (1u << 8)#define HV_GUEST_CRASH_MSR_AVAILABLE (1u << 10) +#define HV_FEATURE_DEBUG_MSRS_AVAILABLE (1u << 11)#define HV_STIMER_DIRECT_MODE_AVAILABLE (1u << 19)
Quoted 5 lines
target/i386/kvm/hyperv-proto.h line 67
Quoted 4 lines
target/i386/kvm/hyperv-proto.h +4
-0+/* +* HV_CPUID_FEATURES.EBX bits +*/ +#define HV_PARTITION_DEUBGGING_ALLOWED (1u << 12)s/DEUBGGING/DEBUGGING
Done
Quoted 54 lines
Quoted 53 lines
target/i386/kvm/hyperv-proto.h +29
-0+/* * HV_CPUID_ENLIGHTMENT_INFO.EAX bits */ @@ -72,6 +81,11 @@#define HV_ENLIGHTENED_VMCS_RECOMMENDED (1u << 14)#define HV_NO_NONARCH_CORESHARING (1u << 18) +/* +* HV_CPUID_SYNDBG_PLATFORM_CAPABILITIES.EAX bits +*/ +#define HV_SYNDBG_CAP_ALLOW_KERNEL_DEBUGGING (1u << 1) +/* * Basic virtualized MSRs */ @@ -130,6 +144,18 @@#define HV_X64_MSR_STIMER3_CONFIG 0x400000B6#define HV_X64_MSR_STIMER3_COUNT 0x400000B7 +/* +* Hyper-V Synthetic debug options MSR +*/ +#define HV_X64_MSR_SYNDBG_CONTROL 0x400000F1 +#define HV_X64_MSR_SYNDBG_STATUS 0x400000F2 +#define HV_X64_MSR_SYNDBG_SEND_BUFFER 0x400000F3 +#define HV_X64_MSR_SYNDBG_RECV_BUFFER 0x400000F4 +#define HV_X64_MSR_SYNDBG_PENDING_BUFFER 0x400000F5 +#define HV_X64_MSR_SYNDBG_OPTIONS 0x400000FF + +#define HV_X64_SYNDBG_OPTION_USE_HCALLS BIT(2) +/* * Guest crash notification MSRs */ @@ -168,5 +194,16 @@#define HV_STIMER_COUNT 4 +/* +* Synthetic debugger control definitions +*/ +#define HV_SYNDBG_CONTROL_SEND (1u << 0) +#define HV_SYNDBG_CONTROL_RECV (1u << 1) +#define HV_SYNDBG_CONTROL_SEND_SIZE (ctl) ((ctl >> 16) & 0xffff) +#define HV_SYNDBG_STATUS_INVALID (0) +#define HV_SYNDBG_STATUS_SEND_SUCCESS (1u << 0) +#define HV_SYNDBG_STATUS_RECV_SUCCESS (1u << 2) +#define HV_SYNDBG_STATUS_RESET (1u << 3) +#define HV_SYNDBG_STATUS_SET_SIZE (st, sz) (st | (sz << 16))#endif