iio: adc: cpcap-adc: remove redundant assignment to variable cal_data_diff
Subsystems (2)
PATCH 1/1 iio: adc: cpcap-adc: remove redundant assignment to variable cal_data_diff
The variable cal_data_diff is being assigned a value that is never read, it is being re-assigned later on with a new value in both paths of an if statement. The assignment is redundant, so remove it.
Signed-off-by Colin Ian King <[email protected]>
--- drivers/iio/adc/cpcap-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/cpcap-adc.c +1 -1
@@ -474,7 +474,7 @@ static int cpcap_adc_calibrate_one(struct cpcap_adc *ddata,for (i =0 ; i <CPCAP_ADC_MAX_RETRIES ; i++) { calibration_data[0 ] =0 ; calibration_data[1 ] =0 ; - cal_data_diff =0 ; +cpcap_adc_setup_calibrate (ddata, channel); error =regmap_read (ddata->reg, calibration_register, &calibration_data[0 ]);
Signature · 1 line
2.34.1
Quoted 5 lines · On Mon, 7 Feb 2022 13:59:43 +0000 Colin Ian King <[email protected]>…
The variable
cal_data_diffis being assigned a value that is never read, it is being re-assigned later on with a new value in both paths of an if statement. The assignment is redundant, so remove it.Signed-off-by Colin Ian King <[email protected]>
Applied.
Thanks,
Jonathan
Quoted 17 lines
--- drivers/iio/adc/cpcap-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/adc/cpcap-adc.c +1
-1@@ -474,7 +474,7 @@ static int cpcap_adc_calibrate_one(struct cpcap_adc *ddata,for (i =0 ; i <CPCAP_ADC_MAX_RETRIES ; i++) { calibration_data[0 ] =0 ; calibration_data[1 ] =0 ; - cal_data_diff =0 ; +cpcap_adc_setup_calibrate (ddata, channel); error =regmap_read (ddata->reg, calibration_register, &calibration_data[0 ]);