Skip to contentSkip to conversation

DG2 platform definition and Tile 4 plane format support

PATCH Superseded Jeevan B 5 participants 23 messages Feb 7, 2022 – Feb 11, 2022 Library code

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Jeevan B

author
#0 lore raw

cover DG2 platform definition and Tile 4 plane format support

Added DG2 platform definition with PCI IDS.
Also introduce support for the new Tile4 format, which is 4K column-major tiles consisting of 64B row-major subtiles, with same base structure as Y Tile(16B OWords * 4)

Jeevan B (6):
igt/tests: Add support for Tile4(TileF) format to kms_rotation_crc igt/tests: Add support for Tile4(TileF) format to
tests/kms_plane_multiple
igt/tests: Add support for Tile4(TileF) format to
tests/kms_plane_lowres
igt/tests: Add support for Tile4(TileF) format to tests/kms_big_fb igt/tests: Add support for Tile4(TileF) format to
tests/kms_addfb_basic
tests/kms_plane_scaling: Adding Tile-4 support

Matt Roper (4):
lib/dg2: Add DG2 platform definition
lib/igt_draw: Add pixel math for tile-4
igt/tests: Add support for Tile4(TileF) format to testdisplay lib/igt_draw: Use XY_FAST_COLOR_BLT on DG2

Mika Kahola (4):
lib/intel_device_info: Add a flag to indicate tiling 4 support tests/kms_frontbuffer_tracking: Add support for 4 tiling tests/kms_draw_crc: Use 4 tiling when filling framebuffer tests/kms_plane_scaling: Use tiling 4 if platform has support for it

Priyanka Dandamudi (1):
lib/i915_pciids: PCI IDS for DG2

Stanislav Lisovskiy (2):
igt/lib: Add tile 4(F-tile) format support igt/tests: Add support for Tile4(TileF) format to kms_draw_crc

 include/drm-uapi/drm_fourcc.h         |  39 +++++
 include/drm-uapi/i915_drm.h           |   3 +-
 lib/gpu_cmds.c                        |   4 +-
 lib/i915_pciids.h                     |  19 +++
 lib/igt_draw.c                        | 223 ++++++++++++++++++++++----
 lib/igt_fb.c                          |  40 ++++-
 lib/intel_batchbuffer.c               |   8 +-
 lib/intel_batchbuffer.h               |   4 +-
 lib/intel_chipset.h                   |   5 +
 lib/intel_device_info.c               |   9 ++
 lib/intel_reg.h                       |   2 +
 tests/i915/kms_big_fb.c               |   1 +
 tests/i915/kms_draw_crc.c             |  20 ++-
 tests/i915/kms_frontbuffer_tracking.c |  22 ++-
 tests/kms_addfb_basic.c               |  44 ++++-
 tests/kms_plane_lowres.c              |   3 +
 tests/kms_plane_multiple.c            |   3 +
 tests/kms_plane_scaling.c             |  22 ++-
 tests/kms_rotation_crc.c              |   4 +
 tests/testdisplay.c                   |   6 +-
 20 files changed, 426 insertions(+), 55 deletions(-)
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 1/17 lib/i915_pciids: PCI IDS for DG2

From: Priyanka Dandamudi <[email protected]>

Adds PCI IDS for DG2.

Cc Adam Miszczak <[email protected]>
Cc Melkaveri, Arjun <[email protected]>
---
 lib/i915_pciids.h | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
lib/i915_pciids.h +19 -0
index 533890dc..b4230424 100644
@@ -681,4 +681,23 @@
 	INTEL_VGA_DEVICE(0xA788, info), \
 	INTEL_VGA_DEVICE(0xA789, info)
 
+/* DG2 */
+#define INTEL_DG2_G10_IDS(info) \
+        INTEL_VGA_DEVICE(0x5690, info), \
+        INTEL_VGA_DEVICE(0x5691, info), \
+        INTEL_VGA_DEVICE(0x5692, info), \
+
+#define INTEL_DG2_G11_IDS(info) \
+        INTEL_VGA_DEVICE(0x56A5, info), \
+        INTEL_VGA_DEVICE(0x56A6, info), \
+        INTEL_VGA_DEVICE(0x5693, info), \
+        INTEL_VGA_DEVICE(0x5694, info), \
+        INTEL_VGA_DEVICE(0x5695, info), \
+        INTEL_VGA_DEVICE(0x56B0, info), \
+        INTEL_VGA_DEVICE(0x56B1, info)
+
+#define INTEL_DG2_IDS(info) \
+        INTEL_DG2_G10_IDS(info) \
+        INTEL_DG2_G11_IDS(info)
+
 #endif /* _I915_PCIIDS_H */
Signature · 1 line
2.17.1
author
#3 lore raw

PATCH 2/17 lib/dg2: Add DG2 platform definition

In reply to Jeevan B

From: Matt Roper <[email protected]>

Added definition for DG2.

---
 lib/intel_chipset.h     | 2 ++
 lib/intel_device_info.c | 8 ++++++++
 2 files changed, 10 insertions(+)
lib/intel_chipset.h +2 -0
index 3527cbe5..9c2f1b31 100644
@@ -81,6 +81,7 @@ struct intel_device_info {
 	bool is_raptorlake_s : 1;
 	bool is_alderlake_p : 1;
 	bool is_alderlake_n : 1;
+	bool is_dg2 : 1;
 	const char *codename;
 };
 
@@ -186,6 +187,7 @@ void intel_check_pch(void);
 #define IS_RAPTORLAKE_S(devid)	(intel_get_device_info(devid)->is_raptorlake_s)
 #define IS_ALDERLAKE_P(devid)	(intel_get_device_info(devid)->is_alderlake_p)
 #define IS_ALDERLAKE_N(devid)	(intel_get_device_info(devid)->is_alderlake_n)
+#define IS_DG2(devid)          (intel_get_device_info(devid)->is_dg2)
 
 #define IS_GEN(devid, x)	(intel_get_device_info(devid)->graphics_ver == x)
 #define AT_LEAST_GEN(devid, x)	(intel_get_device_info(devid)->graphics_ver >= x)
lib/intel_device_info.c +8 -0
index 40942afe..05ba2d98 100644
@@ -417,6 +417,13 @@ static const struct intel_device_info intel_alderlake_n_info = {
 	.codename = "alderlake_n"
 };
 
+static const struct intel_device_info intel_dg2_info = {
+	.graphics_ver = 12,
+	.display_ver = 13,
+	.is_dg2 = true,
+	.codename = "dg2"
+};
+
 static const struct pci_id_match intel_device_match[] = {
 	INTEL_I810_IDS(&intel_i810_info),
 	INTEL_I815_IDS(&intel_i815_info),
@@ -511,6 +518,7 @@ static const struct pci_id_match intel_device_match[] = {
 	INTEL_RPLS_IDS(&intel_raptorlake_s_info),
 	INTEL_ADLP_IDS(&intel_alderlake_p_info),
 	INTEL_ADLN_IDS(&intel_alderlake_n_info),
+	INTEL_DG2_IDS(&intel_dg2_info),
 
 	INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info),
 };
Signature · 1 line
2.17.1
author
#5 lore raw

PATCH 3/17 lib/intel_device_info: Add a flag to indicate tiling 4 support

In reply to Jeevan B

From: Mika Kahola <[email protected]>

Add tiling 4 support flag for DG2 platform. This is similar that we have defined in kernel i915_pci.c intel_device_info() for DG2.

---
 lib/intel_chipset.h     | 3 +++
 lib/intel_device_info.c | 1 +
 2 files changed, 4 insertions(+)
lib/intel_chipset.h +3 -0
index 9c2f1b31..32066439 100644
@@ -40,6 +40,7 @@ struct intel_device_info {
 	unsigned graphics_ver;
 	unsigned display_ver;
 	unsigned gt; /* 0 if unknown */
+	bool has_4tile : 1;
 	bool is_mobile : 1;
 	bool is_whitney : 1;
 	bool is_almador : 1;
@@ -215,4 +216,6 @@ void intel_check_pch(void);
 				   IS_CHERRYVIEW(devid) || \
 				   IS_BROXTON(devid)))
 
+#define HAS_4TILE(devid)	(intel_get_device_info(devid)->has_4tile)
+
 #endif /* _INTEL_CHIPSET_H */
lib/intel_device_info.c +1 -0
index 05ba2d98..7b1535fd 100644
@@ -420,6 +420,7 @@ static const struct intel_device_info intel_alderlake_n_info = {
 static const struct intel_device_info intel_dg2_info = {
 	.graphics_ver = 12,
 	.display_ver = 13,
+	.has_4tile = true,
 	.is_dg2 = true,
 	.codename = "dg2"
 };
Signature · 1 line
2.17.1
author
#6 lore raw

PATCH 4/17 igt/lib: Add tile 4(F-tile) format support

In reply to Jeevan B

From: Stanislav Lisovskiy <[email protected]>

Introduce support for the new Tile4 format, which is 4K column-major tiles consisting of 64B row-major subtiles, with same base structure as Y Tile(16B OWords * 4)

---
 include/drm-uapi/drm_fourcc.h | 39 ++++++++++++++++++++++++++++++++++
 include/drm-uapi/i915_drm.h   |  3 ++-
 lib/gpu_cmds.c                |  4 ++--
 lib/igt_draw.c                |  7 +++++-
 lib/igt_fb.c                  | 40 ++++++++++++++++++++++++++++++-----
 lib/intel_batchbuffer.c       |  8 +++++--
 lib/intel_batchbuffer.h       |  4 ++--
 7 files changed, 92 insertions(+), 13 deletions(-)
include/drm-uapi/drm_fourcc.h +39 -0
index 91b6a0fd..4dc4e5a4 100644
@@ -559,6 +559,45 @@ extern "C" {
  */
 #define I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC fourcc_mod_code(INTEL, 8)
 
+/*
+ * Intel F-tiling(aka Tile4) layout
+ *
+ * This is a tiled layout using 4Kb tiles in row-major layout.
+ * Within the tile pixels are laid out in 64 byte units / sub-tiles in OWORD
+ * (16 bytes) chunks column-major..
+ */
+#define I915_FORMAT_MOD_4_TILED                 fourcc_mod_code(INTEL, 12)
+
+/*
+ * Intel color control surfaces (CCS) for DG2 render compression.
+ *
+ * DG2 uses a new compression format for render compression. The general
+ * layout is the same as I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS,
+ * but a new hashing/compression algorithm is used, so a fresh modifier must
+ * be associated with buffers of this type. Render compression uses 128 byte
+ * compression blocks.
+ */
+#define I915_FORMAT_MOD_4_TILED_DG2_RC_CCS              fourcc_mod_code(INTEL, 9)
+
+/*
+ * Intel color control surfaces (CCS) for DG2 media compression.
+ *
+ * DG2 uses a new compression format for media compression. The general
+ * layout is the same as I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS,
+ * but a new hashing/compression algorithm is used, so a fresh modifier must
+ * be associated with buffers of this type. Media compression uses 256 byte
+ * compression blocks.
+ */
+#define I915_FORMAT_MOD_4_TILED_DG2_MC_CCS              fourcc_mod_code(INTEL, 10)
+
+/*
+ * Intel color control surfaces (CCS) for DG2 clear color render compression.
+ *
+ * DG2 uses a unified compression format for clear color render compression.
+ * The general layout is a tiled layout using 4Kb tiles i.e. Tile4 layout.
+ */
+#define I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC           fourcc_mod_code(INTEL, 11)
+
 /*
  * Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized macroblocks
  *
include/drm-uapi/i915_drm.h +2 -1
index 9c9e1afa..75206fc3 100644
@@ -1522,13 +1522,14 @@ struct drm_i915_gem_caching {
 #define I915_TILING_NONE	0
 #define I915_TILING_X		1
 #define I915_TILING_Y		2
+#define I915_TILING_4		3
 /*
  * Do not add new tiling types here.  The I915_TILING_* values are for
  * de-tiling fence registers that no longer exist on modern platforms.  Although
  * the hardware may support new types of tiling in general (e.g., Tile4), we
  * do not need to add them to the uapi that is specific to now-defunct ioctls.
  */
-#define I915_TILING_LAST	I915_TILING_Y
+#define I915_TILING_LAST	I915_TILING_4
 
 #define I915_BIT_6_SWIZZLE_NONE		0
 #define I915_BIT_6_SWIZZLE_9		1
lib/gpu_cmds.c +2 -2
index a45a9048..c31b51f7 100644
@@ -156,7 +156,7 @@ gen8_fill_surface_state(struct intel_bb *ibb,
 
 	if (buf->tiling == I915_TILING_X)
 		ss->ss0.tiled_mode = 2;
-	else if (buf->tiling == I915_TILING_Y)
+	else if (buf->tiling == I915_TILING_Y || buf->tiling == I915_TILING_4)
 		ss->ss0.tiled_mode = 3;
 
 	address = intel_bb_offset_reloc(ibb, buf->handle,
@@ -211,7 +211,7 @@ gen11_fill_surface_state(struct intel_bb *ibb,
 
 	if (buf->tiling == I915_TILING_X)
 		ss->ss0.tiled_mode = 2;
-	else if (buf->tiling == I915_TILING_Y)
+	else if (buf->tiling == I915_TILING_Y || buf->tiling == I915_TILING_4)
 		ss->ss0.tiled_mode = 3;
 	else
 		ss->ss0.tiled_mode = 0;
lib/igt_draw.c +6 -1
index 2af27b11..0ca43deb 100644
@@ -271,7 +271,7 @@ static void switch_blt_tiling(struct intel_bb *ibb, uint32_t tiling, bool on)
 	uint32_t bcs_swctrl;
 
 	/* Default is X-tile */
-	if (tiling != I915_TILING_Y)
+	if (tiling != I915_TILING_Y && tiling != I915_TILING_4)
 		return;
 
 	igt_require(ibb->gen >= 6);
@@ -318,6 +318,7 @@ static void draw_rect_ptr_tiled(void *ptr, uint32_t stride, uint32_t tiling,
 							       swizzle, bpp);
 				break;
 			case I915_TILING_Y:
+			case I915_TILING_4:
 				pos = linear_x_y_to_ytiled_pos(x, y, stride,
 							       swizzle, bpp);
 				break;
@@ -350,6 +351,7 @@ static void draw_rect_mmap_cpu(int fd, struct buf_data *buf, struct rect *rect,
 		break;
 	case I915_TILING_X:
 	case I915_TILING_Y:
+	case I915_TILING_4:
 		draw_rect_ptr_tiled(ptr, buf->stride, tiling, swizzle, rect,
 				    color, buf->bpp);
 		break;
@@ -409,6 +411,7 @@ static void draw_rect_mmap_wc(int fd, struct buf_data *buf, struct rect *rect,
 		break;
 	case I915_TILING_X:
 	case I915_TILING_Y:
+	case I915_TILING_4:
 		draw_rect_ptr_tiled(ptr, buf->stride, tiling, swizzle, rect,
 				    color, buf->bpp);
 		break;
@@ -467,6 +470,7 @@ static void draw_rect_pwrite_tiled(int fd, struct buf_data *buf,
 						 swizzle, buf->bpp, &x, &y);
 			break;
 		case I915_TILING_Y:
+		case I915_TILING_4:
 			ytiled_pos_to_x_y_linear(tiled_pos, buf->stride,
 						 swizzle, buf->bpp, &x, &y);
 			break;
@@ -507,6 +511,7 @@ static void draw_rect_pwrite(int fd, struct buf_data *buf,
 		break;
 	case I915_TILING_X:
 	case I915_TILING_Y:
+	case I915_TILING_4:
 		draw_rect_pwrite_tiled(fd, buf, tiling, rect, color, swizzle);
 		break;
 	default:
lib/igt_fb.c +35 -5
index 1530b960..4fa357f8 100644
@@ -456,6 +456,10 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
 	case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS:
 	case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
 	case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
+	case I915_FORMAT_MOD_4_TILED:
+	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS:
+	case I915_FORMAT_MOD_4_TILED_DG2_MC_CCS:
+	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC:
 		igt_require_intel(fd);
 		if (intel_display_ver(intel_get_drm_devid(fd)) == 2) {
 			*width_ret = 128;
@@ -564,14 +568,17 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
 
 static bool is_gen12_mc_ccs_modifier(uint64_t modifier)
 {
-	return modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS;
+	return modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS ||
+		modifier == I915_FORMAT_MOD_4_TILED_DG2_MC_CCS;
 }
 
 static bool is_gen12_ccs_modifier(uint64_t modifier)
 {
 	return is_gen12_mc_ccs_modifier(modifier) ||
 		modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS ||
-		modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC;
+		modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ||
+		modifier == I915_FORMAT_MOD_4_TILED_DG2_RC_CCS ||
+		modifier == I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC;
 }
 
 static bool is_ccs_modifier(uint64_t modifier)
@@ -601,8 +608,15 @@ static bool is_gen12_ccs_plane(const struct igt_fb *fb, int plane)
 
 static bool is_gen12_ccs_cc_plane(const struct igt_fb *fb, int plane)
 {
-	return fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC &&
-	       plane == 2;
+	if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC &&
+	       plane == 2)
+		return true;
+
+	if (fb->modifier == I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC &&
+		plane == 1)
+		return true;
+
+	return false;
 }
 
 bool igt_fb_is_gen12_ccs_cc_plane(const struct igt_fb *fb, int plane)
@@ -688,7 +702,8 @@ static int fb_num_planes(const struct igt_fb *fb)
 	if (is_ccs_modifier(fb->modifier))
 		num_planes *= 2;
 
-	if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC)
+	if (fb->modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ||
+	    fb->modifier == I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC)
 		num_planes++;
 
 	return num_planes;
@@ -964,6 +979,11 @@ uint64_t igt_fb_mod_to_tiling(uint64_t modifier)
 	case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC:
 	case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
 		return I915_TILING_Y;
+	case I915_FORMAT_MOD_4_TILED:
+	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS:
+	case I915_FORMAT_MOD_4_TILED_DG2_MC_CCS:
+	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC:
+		return I915_TILING_4;
 	case I915_FORMAT_MOD_Yf_TILED:
 	case I915_FORMAT_MOD_Yf_TILED_CCS:
 		return I915_TILING_Yf;
@@ -991,6 +1011,8 @@ uint64_t igt_fb_tiling_to_mod(uint64_t tiling)
 		return I915_FORMAT_MOD_X_TILED;
 	case I915_TILING_Y:
 		return I915_FORMAT_MOD_Y_TILED;
+	case I915_TILING_4:
+		return I915_FORMAT_MOD_4_TILED;
 	case I915_TILING_Yf:
 		return I915_FORMAT_MOD_Yf_TILED;
 	default:
@@ -4398,6 +4420,14 @@ const char *igt_fb_modifier_name(uint64_t modifier)
 		return "Y-RC_CCS-CC";
 	case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS:
 		return "Y-MC_CCS";
+	case I915_FORMAT_MOD_4_TILED:
+		return "4";
+	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS:
+		return "4-RC_CCS";
+	case I915_FORMAT_MOD_4_TILED_DG2_MC_CCS:
+		return "4-MC_CCS";
+	case I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC:
+		return "4-RC_CCS-CC";
 	default:
 		return "?";
 	}
lib/intel_batchbuffer.c +6 -2
index e5666cd4..f02d0f3c 100644
@@ -617,6 +617,7 @@ static uint32_t fast_copy_dword0(unsigned int src_tiling,
 		dword0 |= XY_FAST_COPY_SRC_TILING_X;
 		break;
 	case I915_TILING_Y:
+	case I915_TILING_4:
 	case I915_TILING_Yf:
 		dword0 |= XY_FAST_COPY_SRC_TILING_Yb_Yf;
 		break;
@@ -633,6 +634,7 @@ static uint32_t fast_copy_dword0(unsigned int src_tiling,
 		dword0 |= XY_FAST_COPY_DST_TILING_X;
 		break;
 	case I915_TILING_Y:
+	case I915_TILING_4:
 	case I915_TILING_Yf:
 		dword0 |= XY_FAST_COPY_DST_TILING_Yb_Yf;
 		break;
@@ -653,9 +655,11 @@ static uint32_t fast_copy_dword1(unsigned int src_tiling,
 {
 	uint32_t dword1 = 0;
 
-	if (src_tiling == I915_TILING_Yf)
+	if (src_tiling == I915_TILING_Yf || src_tiling == I915_TILING_4)
+		/* Repurposed as Tile-4 on DG2 */
 		dword1 |= XY_FAST_COPY_SRC_TILING_Yf;
-	if (dst_tiling == I915_TILING_Yf)
+	if (dst_tiling == I915_TILING_Yf || dst_tiling == I915_TILING_4)
+		/* Repurposed as Tile-4 on DG2 */
 		dword1 |= XY_FAST_COPY_DST_TILING_Yf;
 
 	switch (bpp) {
lib/intel_batchbuffer.h +2 -2
index a488f9cf..4cf67296 100644
@@ -210,8 +210,8 @@ void intel_copy_bo(struct intel_batchbuffer *batch,
  *
  * They are to be used the the blitting routines below.
  */
-#define I915_TILING_Yf	3
-#define I915_TILING_Ys	4
+#define I915_TILING_Yf	(I915_TILING_LAST + 1)
+#define I915_TILING_Ys	(I915_TILING_LAST + 2)
 
 enum i915_compression {
 	I915_COMPRESSION_NONE,
Signature · 1 line
2.17.1
author
#7 lore raw

PATCH 5/17 lib/igt_draw: Add pixel math for tile-4

In reply to Jeevan B

From: Matt Roper <[email protected]>

We need to implement the tile-4 math to convert x,y coordinates to buffer offsets and vice versa for cases where we're using the CPU to tile/detile rather than a GPU engine (e.g., the mmap_cpu and pwrite subtests for kms_draw_crc).

The bspec description of tiling-4 is very confusing/misleading, but the implementation here does match the tile-4 content generated by GPU engines and recognized properly by the display controller.

Cc Stanislav Lisovskiy <[email protected]>
---
 lib/igt_draw.c | 113 ++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 111 insertions(+), 2 deletions(-)
lib/igt_draw.c +111 -2
index 0ca43deb..d78ecdf0 100644
@@ -226,6 +226,71 @@ static int linear_x_y_to_ytiled_pos(int x, int y, uint32_t stride, int swizzle,
 	return pos / pixel_size;
 }
 
+#define OW_SIZE 16			/* in bytes */
+#define TILE_4_SUBTILE_SIZE 64		/* in bytes */
+#define TILE_4_WIDTH 128		/* in bytes */
+#define TILE_4_HEIGHT 32		/* in pixels */
+#define TILE_4_SUBTILE_WIDTH  OW_SIZE	/* in bytes */
+#define TILE_4_SUBTILE_HEIGHT 4		/* in pixels */
+
+/*
+ * Subtile remapping for tile 4.  Note that map[a]==b implies map[b]==a
+ * so we can use the same table to tile and until.
+ */
+static const int tile4_subtile_map[] = {
+	0,  1,  2,  3,  8,  9, 10, 11,
+	4,  5,  6,  7, 12, 13, 14, 15,
+	16, 17, 18, 19, 24, 25, 26, 27,
+	20, 21, 22, 23, 28, 29, 30, 31,
+	32, 33, 34, 35, 40, 41, 42, 43,
+	36, 37, 38, 39, 44, 45, 46, 47,
+	48, 49, 50, 51, 56, 57, 58, 59,
+	52, 53, 54, 55, 60, 61, 62, 63
+};
+
+static int linear_x_y_to_4tiled_pos(int x, int y, uint32_t stride, int swizzle,
+				    int bpp)
+{
+	int tile_base_pos;
+	int tile_x, tile_y;
+	int subtile_col, subtile_row, subtile_num, new_subtile_num;
+	int pixel_size = bpp / 8;
+	int byte_x = x * pixel_size;
+	int pos;
+
+	/* Modern platforms that have 4-tiling don't use old bit 6 swizzling */
+	igt_assert_eq(swizzle, I915_BIT_6_SWIZZLE_NONE);
+
+	/*
+	* Where does the 4k tile start (in bytes)?  This is the same for Y and
+	* F so we can use the Y-tile algorithm to get to that point.
+	*/
+	tile_base_pos = (y / TILE_4_HEIGHT) * stride * TILE_4_HEIGHT +
+		4096 * (byte_x / TILE_4_WIDTH);
+
+	/* Find pixel within tile */
+	tile_x = (byte_x % TILE_4_WIDTH);
+	tile_y = y % TILE_4_HEIGHT;
+
+	/* And figure out the subtile within the 4k tile */
+	subtile_col = tile_x / TILE_4_SUBTILE_WIDTH;
+	subtile_row = tile_y / TILE_4_SUBTILE_HEIGHT;
+	subtile_num = subtile_row * 8 + subtile_col;
+
+	/* Swizzle the subtile number according to the bspec diagram */
+	new_subtile_num = tile4_subtile_map[subtile_num];
+
+	/* Calculate new position */
+	pos = tile_base_pos +
+		new_subtile_num * TILE_4_SUBTILE_SIZE +
+		(tile_y % TILE_4_SUBTILE_HEIGHT) * OW_SIZE +
+		tile_x % TILE_4_SUBTILE_WIDTH;
+	igt_assert(pos % pixel_size == 0);
+	pos /= pixel_size;
+
+	return pos;
+}
+
 static void xtiled_pos_to_x_y_linear(int tiled_pos, uint32_t stride,
 				     int swizzle, int bpp, int *x, int *y)
 {
@@ -253,6 +318,44 @@ static void ytiled_pos_to_x_y_linear(int tiled_pos, uint32_t stride,
 	*x /= pixel_size;
 }
 
+static void tile4_pos_to_x_y_linear(int tiled_pos, uint32_t stride,
+				    int swizzle, int bpp, int *x, int *y)
+{
+	int pixel_size = bpp / 8;
+	int tiles_per_line = stride / TILE_4_WIDTH;
+	int tile_num, tile_offset, tile_row, tile_col;
+	int tile_origin_x, tile_origin_y;
+	int subtile_num, subtile_offset, subtile_row, subtile_col;
+	int subtile_origin_x, subtile_origin_y;
+	int oword_num, byte_num;
+
+	/* Modern platforms that have 4-tiling don't use old bit 6 swizzling */
+	igt_assert_eq(swizzle, I915_BIT_6_SWIZZLE_NONE);
+
+	/* Calculate the x,y of the start of the 4k tile */
+	tile_num = tiled_pos / 4096;
+	tile_row = tile_num / tiles_per_line;
+	tile_col = tile_num % tiles_per_line;
+	tile_origin_x = tile_col * TILE_4_WIDTH;
+	tile_origin_y = tile_row * TILE_4_HEIGHT;
+
+	/* Now calculate the x,y offset of the start of the subtile */
+	tile_offset = tiled_pos % 4096;
+	subtile_num = tile4_subtile_map[tile_offset / TILE_4_SUBTILE_SIZE];
+	subtile_row = subtile_num / 8;
+	subtile_col = subtile_num % 8;
+	subtile_origin_x = subtile_col * TILE_4_SUBTILE_WIDTH;
+	subtile_origin_y = subtile_row * TILE_4_SUBTILE_HEIGHT;
+
+	/* Next the oword and byte within the subtile */
+	subtile_offset = tiled_pos % TILE_4_SUBTILE_SIZE;
+	oword_num = subtile_offset / OW_SIZE;
+	byte_num = subtile_offset % OW_SIZE;
+
+	*x = (tile_origin_x + subtile_origin_x + byte_num) / pixel_size;
+	*y = tile_origin_y + subtile_origin_y + oword_num;
+}
+
 static void set_pixel(void *_ptr, int index, uint32_t color, int bpp)
 {
 	if (bpp == 16) {
@@ -318,10 +421,13 @@ static void draw_rect_ptr_tiled(void *ptr, uint32_t stride, uint32_t tiling,
 							       swizzle, bpp);
 				break;
 			case I915_TILING_Y:
-			case I915_TILING_4:
 				pos = linear_x_y_to_ytiled_pos(x, y, stride,
 							       swizzle, bpp);
 				break;
+			case I915_TILING_4:
+				pos = linear_x_y_to_4tiled_pos(x, y, stride,
+							       swizzle, bpp);
+				break;
 			default:
 				igt_assert(false);
 			}
@@ -470,10 +576,13 @@ static void draw_rect_pwrite_tiled(int fd, struct buf_data *buf,
 						 swizzle, buf->bpp, &x, &y);
 			break;
 		case I915_TILING_Y:
-		case I915_TILING_4:
 			ytiled_pos_to_x_y_linear(tiled_pos, buf->stride,
 						 swizzle, buf->bpp, &x, &y);
 			break;
+		case I915_TILING_4:
+			tile4_pos_to_x_y_linear(tiled_pos, buf->stride,
+						swizzle, buf->bpp, &x, &y);
+			break;
 		default:
 			igt_assert(false);
 		}
Signature · 1 line
2.17.1
author
#8 lore raw

PATCH 6/17 igt/tests: Add support for Tile4(TileF) format to kms_draw_crc

In reply to Jeevan B

From: Stanislav Lisovskiy <[email protected]>

kms_draw_crc would be the first sample test to support new format.

---
 tests/i915/kms_draw_crc.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
tests/i915/kms_draw_crc.c +8 -7
index 82c368e1..6348e803 100644
@@ -41,25 +41,24 @@ drmModeConnectorPtr drm_connectors[MAX_CONNECTORS];
 struct buf_ops *bops;
 igt_pipe_crc_t *pipe_crc;
 
-#define N_FORMATS 3
-static const uint32_t formats[N_FORMATS] = {
+static const uint32_t formats[] = {
 	DRM_FORMAT_XRGB8888,
 	DRM_FORMAT_RGB565,
 	DRM_FORMAT_XRGB2101010,
 };
 
-#define N_MODIFIER_METHODS 3
-static const uint64_t modifiers[N_MODIFIER_METHODS] = {
+static const uint64_t modifiers[] = {
 	DRM_FORMAT_MOD_LINEAR,
 	I915_FORMAT_MOD_X_TILED,
 	I915_FORMAT_MOD_Y_TILED,
+	I915_FORMAT_MOD_4_TILED,
 };
 
 struct base_crc {
 	bool set;
 	igt_crc_t crc;
 };
-struct base_crc base_crcs[N_FORMATS];
+struct base_crc base_crcs[ARRAY_SIZE(formats)];
 
 struct modeset_params ms;
 
@@ -315,6 +314,8 @@ static const char *modifier_str(int modifier_index)
 		return "xtiled";
 	case I915_FORMAT_MOD_Y_TILED:
 		return "ytiled";
+	case I915_FORMAT_MOD_4_TILED:
+		return "4tiled";
 	default:
 		igt_assert(false);
 	}
@@ -328,9 +329,9 @@ igt_main
 	igt_fixture
 		setup_environment();
 
-	for (format_idx = 0; format_idx < N_FORMATS; format_idx++) {
+	for (format_idx = 0; format_idx < ARRAY_SIZE(formats); format_idx++) {
 	for (method = 0; method < IGT_DRAW_METHOD_COUNT; method++) {
-	for (modifier_idx = 0; modifier_idx < N_MODIFIER_METHODS; modifier_idx++) {
+	for (modifier_idx = 0; modifier_idx < ARRAY_SIZE(modifiers); modifier_idx++) {
 		igt_describe("This subtest verfies igt_draw library works "
 			     "with different modifiers, DRM_FORMATS, DRAW_METHODS.");
 		igt_subtest_f("draw-method-%s-%s-%s",
Signature · 1 line
2.17.1
author
#10 lore raw

PATCH 7/17 igt/tests: Add support for Tile4(TileF) format to kms_rotation_crc

In reply to Jeevan B

Adding subtest to test new tiling format.

---
 tests/kms_rotation_crc.c | 4 ++++
 1 file changed, 4 insertions(+)
tests/kms_rotation_crc.c +4 -0
index 3f716002..50869a08 100644
@@ -983,6 +983,8 @@ static const char *modifier_test_str(uint64_t modifier)
 		return "y-tiled";
 	case I915_FORMAT_MOD_Yf_TILED:
 		return "yf-tiled";
+	case I915_FORMAT_MOD_4_TILED:
+		return "4-tiled";
 	default:
 		igt_assert(0);
 	}
@@ -1041,6 +1043,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		{ I915_FORMAT_MOD_Yf_TILED, IGT_ROTATION_90 },
 		{ I915_FORMAT_MOD_Yf_TILED, IGT_ROTATION_180 },
 		{ I915_FORMAT_MOD_Yf_TILED, IGT_ROTATION_270 },
+		{ I915_FORMAT_MOD_4_TILED, IGT_ROTATION_0 },
+		{ I915_FORMAT_MOD_4_TILED, IGT_ROTATION_180 },
 		{ 0, 0 }
 	};
 
Signature · 1 line
2.17.1
author
#11 lore raw

PATCH 8/17 igt/tests: Add support for Tile4(TileF) format to tests/kms_plane_multiple

In reply to Jeevan B

Adding subtest to test new tiling format.

---
 tests/kms_plane_multiple.c | 3 +++
 1 file changed, 3 insertions(+)
tests/kms_plane_multiple.c +3 -0
index ebadc14b..1679f7ce 100644
@@ -398,6 +398,9 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)
 	igt_subtest_f("atomic-pipe-%s-tiling-yf", kmstest_pipe_name(pipe))
 		test_plane_position(data, pipe, I915_FORMAT_MOD_Yf_TILED);
 
+	igt_subtest_f("atomic-pipe-%s-tiling-4", kmstest_pipe_name(pipe))
+		test_plane_position(data, pipe, I915_FORMAT_MOD_4_TILED);
+
 	igt_subtest_f("atomic-pipe-%s-tiling-none", kmstest_pipe_name(pipe))
 		test_plane_position(data, pipe, DRM_FORMAT_MOD_LINEAR);
 }
Signature · 1 line
2.17.1
author
#12 lore raw

PATCH 9/17 igt/tests: Add support for Tile4(TileF) format to tests/kms_plane_lowres

In reply to Jeevan B

Adding subtest to test new tiling format.

---
 tests/kms_plane_lowres.c | 3 +++
 1 file changed, 3 insertions(+)
tests/kms_plane_lowres.c +3 -0
index 6c0fce86..3f3f77c8 100644
@@ -314,6 +314,9 @@ igt_main
 			     "high and low resolution with yf-tiling.");
 		igt_subtest_f("pipe-%s-tiling-yf", kmstest_pipe_name(pipe))
 			test_planes_on_pipe(&data, I915_FORMAT_MOD_Yf_TILED);
+
+		igt_subtest_f("pipe-%s-tiling-4", kmstest_pipe_name(pipe))
+			test_planes_on_pipe(&data, I915_FORMAT_MOD_4_TILED);
 	}
 
 	igt_fixture {
Signature · 1 line
2.17.1
author
#13 lore raw

PATCH 10/17 igt/tests: Add support for Tile4(TileF) format to tests/kms_big_fb

In reply to Jeevan B

Extending the test to support new Tiling format.

---
 tests/i915/kms_big_fb.c | 1 +
 1 file changed, 1 insertion(+)
tests/i915/kms_big_fb.c +1 -0
index 9ebf6155..8724d606 100644
@@ -784,6 +784,7 @@ static const struct {
 	{ I915_FORMAT_MOD_X_TILED, "x-tiled", },
 	{ I915_FORMAT_MOD_Y_TILED, "y-tiled", },
 	{ I915_FORMAT_MOD_Yf_TILED, "yf-tiled", },
+	{ I915_FORMAT_MOD_4_TILED, "4-tiled", },
 };
 
 static const struct {
Signature · 1 line
2.17.1
author
#14 lore raw

PATCH 11/17 igt/tests: Add support for Tile4(TileF) format to testdisplay

In reply to Jeevan B

From: Matt Roper <[email protected]>

testdisplay is a great test for manual testing/debug of Tile-4; we just need an extra parameter to enable that tiling format.

---
 tests/testdisplay.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
tests/testdisplay.c +5 -1
index 54327761..e9fbd260 100644
@@ -593,7 +593,7 @@ static void set_termio_mode(void)
 	tcsetattr(tio_fd, TCSANOW, &tio);
 }
 
-static char optstr[] = "3Aiaf:s:d:p:mrto:j:y";
+static char optstr[] = "3Aiaf:s:d:p:mrt4o:j:y";
 static struct option long_opts[] = {
 	{"yb", 0, 0, OPT_YB},
 	{"yf", 0, 0, OPT_YF},
@@ -612,6 +612,7 @@ static const char *help_str =
 	"  -t\tuse an X-tiled framebuffer\n"
 	"  -y, --yb\n"
 	"  \tuse a Y-tiled framebuffer\n"
+	"  -4\tuse an Tile-4 framebuffer\n"
 	"  --yf\tuse a Yf-tiled framebuffer\n"
 	"  -j\tdo dpms off, optional arg to select dpms level (1-3)\n"
 	"  -r\tprint a QR code on the screen whose content is \"pass\" for the automatic test\n"
@@ -680,6 +681,9 @@ static int opt_handler(int opt, int opt_index, void *data)
 	case OPT_YF:
 		modifier = I915_FORMAT_MOD_Yf_TILED;
 		break;
+	case '4':
+		modifier = I915_FORMAT_MOD_4_TILED;
+		break;
 	case 'r':
 		qr_code = 1;
 		break;
Signature · 1 line
2.17.1
author
#15 lore raw

PATCH 12/17 lib/igt_draw: Use XY_FAST_COLOR_BLT on DG2

In reply to Jeevan B

From: Matt Roper <[email protected]>

The XY_COLOR_BLT instruction used by igt_draw's blitter implementation doesn't support F-tile (plus we've heard informally from the hardware team that the instruction is deprecated in general). Switch to XY_FAST_COLOR_BLT to perform our solid fills on DG2. This instruction will also allow us to extend the igt_draw support to 64bit+ color depths in the future too if we have tests that start wanting to test that.

Note that we don't currently pass enough information down to this routine to pick an appropriate value for the smem vs lmem performance hint bit, but that doesn't impact the output generated.

---
 lib/igt_draw.c  | 107 ++++++++++++++++++++++++++++++++++++------------
 lib/intel_reg.h |   2 +
 2 files changed, 83 insertions(+), 26 deletions(-)
lib/igt_draw.c +81 -26
index d78ecdf0..056101b9 100644
@@ -666,36 +666,91 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
 	ibb = intel_bb_create(fd, PAGE_SIZE);
 	intel_bb_add_intel_buf(ibb, dst, true);
 
-	switch (buf->bpp) {
-	case 8:
-		blt_cmd_depth = 0;
-		break;
-	case 16: /* we're assuming 565 */
-		blt_cmd_depth = 1 << 24;
-		break;
-	case 32:
-		blt_cmd_depth = 3 << 24;
-		break;
-	default:
-		igt_assert(false);
-	}
+	if (IS_DG2(intel_get_drm_devid(fd))) {
+		int buf_height = buf->size / buf->stride;
+
+		switch (buf->bpp) {
+		case 8:
+			blt_cmd_depth = 0;
+			break;
+		case 16: /* we're assuming 565 */
+			blt_cmd_depth = 1 << 19;
+			break;
+		case 32:
+			blt_cmd_depth = 2 << 19;
+			break;
+		case 64:
+			/* Not used or supported yet */
+		default:
+			igt_assert(false);
+		}
+
+		switch (tiling) {
+		case I915_TILING_NONE:
+			blt_cmd_tiling = 0;
+			break;
+		case I915_TILING_X:
+			blt_cmd_tiling = 1 << 30;
+			break;
+		case I915_TILING_4:
+			blt_cmd_tiling = 2 << 30;
+			break;
+		default:
+			igt_assert(false);
+		}
+
+		pitch = tiling ? buf->stride / 4 : buf->stride;
+
+		intel_bb_out(ibb, XY_FAST_COLOR_BLT | blt_cmd_depth);
+		/* DG2 MOCS entry 2 is "UC - Non-Coherent; GO:Memory" */
+		intel_bb_out(ibb, blt_cmd_tiling | 2 << 21 | (pitch-1));
+		intel_bb_out(ibb, (rect->y << 16) | rect->x);
+		intel_bb_out(ibb, ((rect->y + rect->h) << 16) | (rect->x + rect->w));
+		intel_bb_emit_reloc_fenced(ibb, dst->handle, 0,
+					   I915_GEM_DOMAIN_RENDER, 0,
+					   dst->addr.offset);
+		intel_bb_out(ibb, 0);	/* TODO: Pass down enough info for target memory hint */
+		intel_bb_out(ibb, color);
+		intel_bb_out(ibb, 0);	/* 64 bit color */
+		intel_bb_out(ibb, 0);	/* 96 bit color */
+		intel_bb_out(ibb, 0);	/* 128 bit color */
+		intel_bb_out(ibb, 0);	/* clear address */
+		intel_bb_out(ibb, 0);	/* clear address */
+		intel_bb_out(ibb, (1 << 29) | ((pitch-1) << 14) | (buf_height-1));
+		intel_bb_out(ibb, 0);	/* mipmap levels / qpitch */
+		intel_bb_out(ibb, 0);	/* mipmap index / alignment */
+	} else {
+		switch (buf->bpp) {
+		case 8:
+			blt_cmd_depth = 0;
+			break;
+		case 16: /* we're assuming 565 */
+			blt_cmd_depth = 1 << 24;
+			break;
+		case 32:
+			blt_cmd_depth = 3 << 24;
+			break;
+		default:
+			igt_assert(false);
+		}
 
-	blt_cmd_len = (gen >= 8) ?  0x5 : 0x4;
-	blt_cmd_tiling = (tiling) ? XY_COLOR_BLT_TILED : 0;
-	pitch = (gen >= 4 && tiling) ? buf->stride / 4 : buf->stride;
+		blt_cmd_len = (gen >= 8) ?  0x5 : 0x4;
+		blt_cmd_tiling = (tiling) ? XY_COLOR_BLT_TILED : 0;
+		pitch = (gen >= 4 && tiling) ? buf->stride / 4 : buf->stride;
 
-	switch_blt_tiling(ibb, tiling, true);
+		switch_blt_tiling(ibb, tiling, true);
 
-	intel_bb_out(ibb, XY_COLOR_BLT_CMD_NOLEN | XY_COLOR_BLT_WRITE_ALPHA |
-		     XY_COLOR_BLT_WRITE_RGB | blt_cmd_tiling | blt_cmd_len);
-	intel_bb_out(ibb, blt_cmd_depth | (0xF0 << 16) | pitch);
-	intel_bb_out(ibb, (rect->y << 16) | rect->x);
-	intel_bb_out(ibb, ((rect->y + rect->h) << 16) | (rect->x + rect->w));
-	intel_bb_emit_reloc_fenced(ibb, dst->handle, 0, I915_GEM_DOMAIN_RENDER,
-				   0, dst->addr.offset);
-	intel_bb_out(ibb, color);
+		intel_bb_out(ibb, XY_COLOR_BLT_CMD_NOLEN | XY_COLOR_BLT_WRITE_ALPHA |
+			     XY_COLOR_BLT_WRITE_RGB | blt_cmd_tiling | blt_cmd_len);
+		intel_bb_out(ibb, blt_cmd_depth | (0xF0 << 16) | pitch);
+		intel_bb_out(ibb, (rect->y << 16) | rect->x);
+		intel_bb_out(ibb, ((rect->y + rect->h) << 16) | (rect->x + rect->w));
+		intel_bb_emit_reloc_fenced(ibb, dst->handle, 0, I915_GEM_DOMAIN_RENDER,
+					   0, dst->addr.offset);
+		intel_bb_out(ibb, color);
 
-	switch_blt_tiling(ibb, tiling, false);
+		switch_blt_tiling(ibb, tiling, false);
+	}
 
 	intel_bb_flush_blit(ibb);
 	intel_bb_destroy(ibb);
lib/intel_reg.h +2 -0
index 44b0d480..cb627288 100644
@@ -2557,6 +2557,8 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #define XY_MONO_SRC_BLT_WRITE_ALPHA	(1<<21)
 #define XY_MONO_SRC_BLT_WRITE_RGB	(1<<20)
 
+#define XY_FAST_COLOR_BLT		((0x2<<29)|(0x44<<22)|0xe)
+
 #define XY_FAST_COPY_BLT				((2<<29)|(0x42<<22)|0x8)
 /* dword 0 */
 #define   XY_FAST_COPY_SRC_TILING_LINEAR		(0 << 20)
Signature · 1 line
2.17.1
author
#16 lore raw

PATCH 13/17 igt/tests: Add support for Tile4(TileF) format to tests/kms_addfb_basic

In reply to Jeevan B

Adding subtest to test new tiling format

---
 tests/kms_addfb_basic.c | 44 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 43 insertions(+), 1 deletion(-)
tests/kms_addfb_basic.c +43 -1
index b7b3b0f2..2fc99eb4 100644
@@ -155,7 +155,6 @@ static void invalid_tests(int fd)
 		uint64_t size;
 
 		igt_require_intel(fd);
-		igt_require(gem_has_lmem(fd));
 		igt_calc_fb_size(fd, f.width, f.height,
 				DRM_FORMAT_XRGB8888, 0, &size, &stride);
 		handle = gem_create_in_memory_regions(fd, size, REGION_SMEM);
@@ -676,6 +675,47 @@ static void addfb25_ytile(int fd)
 	}
 }
 
+static void addfb25_4tile(int fd)
+{
+	struct drm_mode_fb_cmd2 f = {};
+	igt_display_t display;
+
+	igt_fixture {
+		igt_display_require(&display, fd);
+
+		gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024,
+				DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL);
+		igt_assert(gem_bo);
+
+		memset(&f, 0, sizeof(f));
+
+		f.width = 1024;
+		f.height = 1024;
+		f.pixel_format = DRM_FORMAT_XRGB8888;
+		f.pitches[0] = 1024*4;
+		f.flags = DRM_MODE_FB_MODIFIERS;
+		f.modifier[0] = DRM_FORMAT_MOD_LINEAR;
+
+		f.handles[0] = gem_bo;
+	}
+
+	igt_subtest("addfb25-4-tiled") {
+		igt_require_fb_modifiers(fd);
+
+		f.modifier[0] = I915_FORMAT_MOD_4_TILED;
+		igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) ==
+			   addfb_expected_ret(&display, &f));
+		if (!addfb_expected_ret(&display, &f))
+			igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f.fb_id) == 0);
+		f.fb_id = 0;
+	}
+
+	igt_fixture {
+		gem_close(fd, gem_bo);
+		igt_display_fini(&display);
+	}
+}
+
 static void prop_tests(int fd)
 {
 	struct drm_mode_fb_cmd2 f = {};
@@ -826,6 +866,8 @@ igt_main
 
 	addfb25_ytile(fd);
 
+	addfb25_4tile(fd);
+
 	tiling_tests(fd);
 
 	prop_tests(fd);
Signature · 1 line
2.17.1
author
#17 lore raw

PATCH 14/17 tests/kms_frontbuffer_tracking: Add support for 4 tiling

In reply to Jeevan B

From: Mika Kahola <[email protected]>

GEN12 uses 4 tiling instead of Y tiling. Let's add support for tiling 4.

---
 tests/i915/kms_frontbuffer_tracking.c | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)
tests/i915/kms_frontbuffer_tracking.c +20 -2
index 532bfbb9..3f4c7e1b 100644
@@ -136,6 +136,7 @@ struct test_mode {
 		TILING_LINEAR = 0,
 		TILING_X,
 		TILING_Y,
+		TILING_4,
 		TILING_COUNT,
 		TILING_DEFAULT = TILING_X,
 	} tiling;
@@ -462,6 +463,8 @@ static uint64_t tiling_to_modifier(enum tiling_type tiling)
 		return I915_FORMAT_MOD_X_TILED;
 	case TILING_Y:
 		return I915_FORMAT_MOD_Y_TILED;
+	case TILING_4:
+		return I915_FORMAT_MOD_4_TILED;
 	default:
 		igt_assert(false);
 	}
@@ -2232,6 +2235,8 @@ static bool tiling_is_valid(int feature_flags, enum tiling_type tiling)
 	case TILING_X:
 	case TILING_Y:
 		return true;
+	case TILING_4:
+		return AT_LEAST_GEN(devid, 12);
 	default:
 		igt_assert(false);
 		return false;
@@ -3208,6 +3213,8 @@ static int opt_handler(int option, int option_index, void *data)
 			opt.tiling = TILING_X;
 		else if (!strcmp(optarg, "y"))
 			opt.tiling = TILING_Y;
+		else if (!strcmp(optarg, "4"))
+			opt.tiling = TILING_4;
 		else if (!strcmp(optarg, "l")) {
 			opt.tiling = TILING_LINEAR;
 		} else {
@@ -3351,6 +3358,8 @@ static const char *tiling_str(enum tiling_type tiling)
 		return "x";
 	case TILING_Y:
 		return "y";
+	case TILING_4:
+		return "4";
 	default:
 		igt_assert(false);
 	}
@@ -3402,9 +3411,12 @@ struct option long_options[] = {
 igt_main_args("", long_options, help_str, opt_handler, NULL)
 {
 	struct test_mode t;
+	int devid;
 
-	igt_fixture
+	igt_fixture {
 		setup_environment();
+		devid = intel_get_drm_devid(drm.fd);
+	}
 
 	for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) {
 		if (!opt.show_hidden && t.feature == FEATURE_NONE)
@@ -3602,8 +3614,14 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 
 					/* Tiling Y is only supported on GEN9+ */
 					if (t.tiling == TILING_Y) {
-						int devid = intel_get_drm_devid(drm.fd);
 						igt_require(AT_LEAST_GEN(devid, 9));
+						igt_require(!intel_get_device_info(devid)->has_4tile);
+					}
+
+					/* Tiling 4 is only supported on GEN12+ */
+					if (t.tiling == TILING_4) {
+						igt_require(AT_LEAST_GEN(devid, 12));
+						igt_require(intel_get_device_info(devid)->has_4tile);
 					}
 
 					if (tiling_is_valid(t.feature, t.tiling))
Signature · 1 line
2.17.1
author
#18 lore raw

PATCH 15/17 tests/kms_draw_crc: Use 4 tiling when filling framebuffer

In reply to Jeevan B

From: Mika Kahola <[email protected]>

For platforms with 4 tiling, let's use 4 tiling instead of Y tiling.

---
 tests/i915/kms_draw_crc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
tests/i915/kms_draw_crc.c +4 -1
index 6348e803..d34cd46b 100644
@@ -223,6 +223,7 @@ static void fill_fb_subtest(void)
 	int rc;
 	struct igt_fb fb;
 	igt_crc_t base_crc, crc;
+	bool has_4tile = intel_get_device_info(intel_get_drm_devid(drm_fd))->has_4tile;
 
 	igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay,
 		      DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb);
@@ -245,7 +246,9 @@ static void fill_fb_subtest(void)
 	igt_assert_crc_equal(&crc, &base_crc);
 
 	if (intel_display_ver(intel_get_drm_devid(drm_fd)) >= 9) {
-		get_fill_crc(I915_FORMAT_MOD_Y_TILED, &crc);
+		get_fill_crc(has_4tile ?
+			     I915_FORMAT_MOD_4_TILED : I915_FORMAT_MOD_Y_TILED,
+			     &crc);
 		igt_assert_crc_equal(&crc, &base_crc);
 	}
 
Signature · 1 line
2.17.1
author
#19 lore raw

PATCH 16/17 tests/kms_plane_scaling: Adding Tile-4 support

In reply to Jeevan B

adding tile-4 changes for 2x-scaler-multi-pipe subtest to support on dg2

---
 tests/kms_plane_scaling.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
tests/kms_plane_scaling.c +9 -2
index 85db11ee..1ab7e5ce 100644
@@ -613,8 +613,15 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
 	igt_output_t *output1, *output2;
 	drmModeModeInfo *mode1, *mode2;
 	enum pipe pipe1, pipe2;
-	uint64_t modifier = is_i915_device(display->drm_fd) ?
-		I915_FORMAT_MOD_Y_TILED : DRM_FORMAT_MOD_LINEAR;
+	bool has_4tile = intel_get_device_info(intel_get_drm_devid(d->drm_fd))->has_4tile;
+	uint64_t modifier;
+
+	if (is_i915_device(display->drm_fd) && has_4tile)
+		modifier = I915_FORMAT_MOD_4_TILED;
+	else if (is_i915_device(display->drm_fd))
+		modifier = I915_FORMAT_MOD_Y_TILED;
+	else
+		modifier = DRM_FORMAT_MOD_LINEAR;
 
 	cleanup_crtc(d);
 
Signature · 1 line
2.17.1
author
#20 lore raw

PATCH 17/17 tests/kms_plane_scaling: Use tiling 4 if platform has support for it

In reply to Jeevan B

From: Mika Kahola <[email protected]>

Switch using tiling 4 if a platform has support for it. For DG2 tiling 4 is superseeds Y tiling.

---
 tests/kms_plane_scaling.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)
tests/kms_plane_scaling.c +11 -4
index 1ab7e5ce..4baa8855 100644
@@ -45,6 +45,7 @@ typedef struct {
 	igt_plane_t *plane3;
 	igt_plane_t *plane4;
 	bool extended;
+	bool has_4tile;
 } data_t;
 
 static int get_num_scalers(data_t* d, enum pipe pipe)
@@ -250,6 +251,9 @@ static void test_scaler_with_rotation_pipe(data_t *d, enum pipe pipe,
 	uint64_t modifier = is_i915_device(d->drm_fd) ?
 		I915_FORMAT_MOD_Y_TILED : DRM_FORMAT_MOD_LINEAR;
 
+	if (d->has_4tile)
+		modifier = I915_FORMAT_MOD_4_TILED;
+
 	igt_require(get_num_scalers(d, pipe) > 0);
 
 	igt_output_set_pipe(output, pipe);
@@ -285,7 +289,8 @@ static const uint64_t modifiers[] = {
 	DRM_FORMAT_MOD_LINEAR,
 	I915_FORMAT_MOD_X_TILED,
 	I915_FORMAT_MOD_Y_TILED,
-	I915_FORMAT_MOD_Yf_TILED
+	I915_FORMAT_MOD_Yf_TILED,
+	I915_FORMAT_MOD_4_TILED
 };
 
 static void test_scaler_with_pixel_format_pipe(data_t *d, enum pipe pipe, igt_output_t *output)
@@ -531,6 +536,7 @@ test_scaler_with_clipping_clamping_scenario(data_t *d, enum pipe pipe, igt_outpu
 	igt_pipe_t *pipe_obj = &d->display.pipes[pipe];
 	drmModeModeInfo *mode;
 	struct igt_vec tested_formats1;
+	uint64_t modifier = d->has_4tile ? I915_FORMAT_MOD_4_TILED : I915_FORMAT_MOD_Y_TILED;
 
 	igt_require(get_num_scalers(d, pipe) >= 2);
 
@@ -567,7 +573,7 @@ test_scaler_with_clipping_clamping_scenario(data_t *d, enum pipe pipe, igt_outpu
 
 			igt_create_pattern_fb(d->drm_fd,
 					      mode->hdisplay, mode->vdisplay, f2,
-					      I915_FORMAT_MOD_Y_TILED,
+					      modifier,
 					      &d->fb[2]);
 
 			__test_scaler_with_clipping_clamping_scenario(d, mode);
@@ -613,10 +619,9 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
 	igt_output_t *output1, *output2;
 	drmModeModeInfo *mode1, *mode2;
 	enum pipe pipe1, pipe2;
-	bool has_4tile = intel_get_device_info(intel_get_drm_devid(d->drm_fd))->has_4tile;
 	uint64_t modifier;
 
-	if (is_i915_device(display->drm_fd) && has_4tile)
+	if (is_i915_device(display->drm_fd) && d->has_4tile)
 		modifier = I915_FORMAT_MOD_4_TILED;
 	else if (is_i915_device(display->drm_fd))
 		modifier = I915_FORMAT_MOD_Y_TILED;
@@ -721,6 +726,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		data.devid = is_i915_device(data.drm_fd) ?
 			intel_get_drm_devid(data.drm_fd) : 0;
 		igt_require(data.display.is_atomic);
+		data.has_4tile = is_i915_device(data.drm_fd) &&
+				 intel_get_device_info(intel_get_drm_devid(data.drm_fd))->has_4tile;
 	}
 
 	igt_subtest_group {
Signature · 1 line
2.17.1
#21 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for DG2 platform definition and Tile 4 plane format support

In reply to Jeevan B
== Series Details ==

== Series Details ==

Series: DG2 platform definition and Tile 4 plane format support
URL : https://patchwork.freedesktop.org/series/99784/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11197 -> IGTPW_6599
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/index.html

Participating hosts (44 -> 41)
------------------------------

Additional (4): fi-kbl-soraka fi-kbl-guc fi-apl-guc fi-pnv-d510
Missing (7): fi-bxt-dsi shard-tglu fi-tgl-dsi fi-bsw-cyan fi-ilk-650 shard-rkl fi-bsw-nick

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6599:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_exec_suspend@basic-s3@smem:
- {fi-rkl-11600}: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/fi-rkl-11600/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-rkl-11600/igt@gem_exec_suspend@[email protected]

Known issues
------------

Here are the changes found in IGTPW_6599 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@debugfs_test@read_all_entries:
- fi-apl-guc: NOTRUN -> [DMESG-WARN][3] ([i915#1610])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-apl-guc/igt@debugfs_test@read_all_entries.html

* igt@fbdev@nullptr:
- fi-kbl-guc: NOTRUN -> [SKIP][4] ([fdo#109271]) +18 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-kbl-guc/igt@[email protected]

* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271]) +8 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-kbl-soraka/igt@gem_exec_fence@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-skl-6600u: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-skl-6600u/igt@[email protected]
- fi-pnv-d510: NOTRUN -> [SKIP][7] ([fdo#109271]) +57 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-pnv-d510/igt@[email protected]
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#2190])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-kbl-soraka/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- fi-kbl-guc: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#4613]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-kbl-guc/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-kbl-soraka: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-kbl-soraka/igt@[email protected]

* igt@gem_lmem_swapping@verify-random:
- fi-skl-6600u: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4613]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-skl-6600u/igt@[email protected]

* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][12] ([i915#1886] / [i915#2291])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

* igt@kms_busy@basic:
- fi-kbl-guc: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#1845])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-kbl-guc/igt@[email protected]

* igt@kms_chamelium@dp-edid-read:
- fi-kbl-soraka: NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111827]) +8 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-kbl-soraka/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-guc: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-kbl-guc/igt@[email protected]

* igt@kms_chamelium@vga-edid-read:
- fi-skl-6600u: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827]) +8 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-skl-6600u/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-skl-6600u: NOTRUN -> [SKIP][17] ([fdo#109271]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-skl-6600u/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-6600u: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#533])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-skl-6600u/igt@[email protected]
- fi-kbl-soraka: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#533])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-kbl-soraka/igt@[email protected]

* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: NOTRUN -> [FAIL][20] ([i915#4547])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-skl-6600u/igt@kms_psr@primary_page_flip.html

* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> [FAIL][21] ([i915#2426] / [i915#4312])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-apl-guc/igt@[email protected]
- fi-bdw-5557u: NOTRUN -> [FAIL][22] ([i915#2426] / [i915#4312])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/fi-bdw-5557u/igt@[email protected]

#### Warnings ####

* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [DMESG-FAIL][23] ([i915#4494] / [i915#4957]) -> [DMESG-FAIL][24] ([i915#4957])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/bat-dg1-5/igt@i915_selftest@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/bat-dg1-5/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4897]: https://gitlab.freedesktop.org/drm/intel/issues/4897
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6339 -> IGTPW_6599

CI-20190529: 20190529
CI_DRM_11197: 3d72770ba26d63ddb15d5495317d43292acdf974 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6599: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/index.html
IGT_6339: 9cd99d763440ae75d9981ce4e361d3deb5edb4e4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Testlist changes ==

+igt@kms_addfb_basic@addfb25-4-tiled +igt@kms_big_fb@4-tiled-8bpp-rotate-0 +igt@kms_big_fb@4-tiled-8bpp-rotate-90 +igt@kms_big_fb@4-tiled-8bpp-rotate-180 +igt@kms_big_fb@4-tiled-8bpp-rotate-270 +igt@kms_big_fb@4-tiled-16bpp-rotate-0 +igt@kms_big_fb@4-tiled-16bpp-rotate-90 +igt@kms_big_fb@4-tiled-16bpp-rotate-180 +igt@kms_big_fb@4-tiled-16bpp-rotate-270 +igt@kms_big_fb@4-tiled-32bpp-rotate-0 +igt@kms_big_fb@4-tiled-32bpp-rotate-90 +igt@kms_big_fb@4-tiled-32bpp-rotate-180 +igt@kms_big_fb@4-tiled-32bpp-rotate-270 +igt@kms_big_fb@4-tiled-64bpp-rotate-0 +igt@kms_big_fb@4-tiled-64bpp-rotate-90 +igt@kms_big_fb@4-tiled-64bpp-rotate-180 +igt@kms_big_fb@4-tiled-64bpp-rotate-270 +igt@kms_big_fb@4-tiled-addfb +igt@kms_big_fb@4-tiled-addfb-size-offset-overflow +igt@kms_big_fb@4-tiled-addfb-size-overflow +igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0 +igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip +igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip +igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip +igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180 +igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip +igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip +igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip +igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0 +igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip +igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip +igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip +igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180 +igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip +igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip +igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip +igt@kms_draw_crc@draw-method-rgb565-blt-4tiled +igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-4tiled +igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-4tiled +igt@kms_draw_crc@draw-method-rgb565-mmap-wc-4tiled +igt@kms_draw_crc@draw-method-rgb565-pwrite-4tiled +igt@kms_draw_crc@draw-method-rgb565-render-4tiled +igt@kms_draw_crc@draw-method-xrgb8888-blt-4tiled +igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-4tiled +igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-4tiled +igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-4tiled +igt@kms_draw_crc@draw-method-xrgb8888-pwrite-4tiled +igt@kms_draw_crc@draw-method-xrgb8888-render-4tiled +igt@kms_draw_crc@draw-method-xrgb2101010-blt-4tiled +igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-4tiled +igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-4tiled +igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-4tiled +igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-4tiled +igt@kms_draw_crc@draw-method-xrgb2101010-render-4tiled +igt@kms_frontbuffer_tracking@fbcdrrs-tiling-4 +igt@kms_frontbuffer_tracking@fbcpsrdrrs-tiling-4 +igt@kms_frontbuffer_tracking@fbcpsr-tiling-4 +igt@kms_frontbuffer_tracking@fbc-tiling-4 +igt@kms_plane_lowres@pipe-a-tiling-4 +igt@kms_plane_lowres@pipe-b-tiling-4 +igt@kms_plane_lowres@pipe-c-tiling-4 +igt@kms_plane_lowres@pipe-d-tiling-4 +igt@kms_plane_lowres@pipe-e-tiling-4 +igt@kms_plane_lowres@pipe-f-tiling-4 +igt@kms_plane_multiple@atomic-pipe-a-tiling-4 +igt@kms_plane_multiple@atomic-pipe-b-tiling-4 +igt@kms_plane_multiple@atomic-pipe-c-tiling-4 +igt@kms_plane_multiple@atomic-pipe-d-tiling-4 +igt@kms_plane_multiple@atomic-pipe-e-tiling-4 +igt@kms_plane_multiple@atomic-pipe-f-tiling-4 +igt@kms_rotation_crc@primary-4-tiled-reflect-x-0 +igt@kms_rotation_crc@primary-4-tiled-reflect-x-180

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/index.html

#22 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for DG2 platform definition and Tile 4 plane format support

In reply to Jeevan B
== Series Details ==

== Series Details ==

Series: DG2 platform definition and Tile 4 plane format support
URL : https://patchwork.freedesktop.org/series/99784/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11197_full -> IGTPW_6599_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6599_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6599_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/index.html

Participating hosts (12 -> 8)
------------------------------

Missing (4): pig-skl-6260u pig-kbl-iris shard-rkl pig-glk-j5005

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6599_full:

### IGT changes ###

#### Possible regressions ####

* {igt@kms_big_fb@4-tiled-32bpp-rotate-270} (NEW):
- shard-iclb: NOTRUN -> [SKIP][1] +39 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb6/igt@[email protected]

* {igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip} (NEW):
- {shard-tglu}: NOTRUN -> [SKIP][2] +22 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglu-6/igt@[email protected]

* {igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0} (NEW):
- shard-tglb: NOTRUN -> [SKIP][3] +43 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb8/igt@[email protected]

* {igt@kms_draw_crc@draw-method-rgb565-blt-4tiled} (NEW):
- shard-iclb: NOTRUN -> [FAIL][4] +16 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb1/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][5] +16 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-apl7/igt@[email protected]

* {igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-4tiled} (NEW):
- shard-glk: NOTRUN -> [FAIL][6] +17 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-glk4/igt@[email protected]

* {igt@kms_draw_crc@draw-method-rgb565-pwrite-4tiled} (NEW):
- {shard-tglu}: NOTRUN -> [FAIL][7] +11 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglu-5/igt@[email protected]

* {igt@kms_draw_crc@draw-method-xrgb2101010-blt-4tiled} (NEW):
- shard-tglb: NOTRUN -> [FAIL][8] +16 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb8/igt@[email protected]

* {igt@kms_draw_crc@draw-method-xrgb2101010-render-4tiled} (NEW):
- shard-snb: NOTRUN -> [FAIL][9] +16 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-snb5/igt@[email protected]

* {igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-4tiled} (NEW):
- shard-kbl: NOTRUN -> [FAIL][10] +17 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-kbl1/igt@[email protected]

* igt@sysfs_heartbeat_interval@nopreempt@bcs0:
- shard-kbl: [PASS][11] -> [INCOMPLETE][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-kbl6/igt@sysfs_heartbeat_interval@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-kbl3/igt@sysfs_heartbeat_interval@[email protected]

#### Warnings ####

* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-apl: [SKIP][13] ([fdo#109271]) -> [FAIL][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-apl2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-apl2/igt@[email protected]
- shard-tglb: [SKIP][15] ([i915#3826]) -> [FAIL][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-tglb1/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb2/igt@[email protected]
- shard-glk: [SKIP][17] ([fdo#109271]) -> [FAIL][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-glk1/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-glk3/igt@[email protected]
- shard-kbl: [SKIP][19] ([fdo#109271]) -> [FAIL][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-kbl1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-kbl6/igt@[email protected]
- shard-snb: [SKIP][21] ([fdo#109271]) -> [FAIL][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-snb2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-snb6/igt@[email protected]
- shard-iclb: [SKIP][23] ([i915#3826]) -> [FAIL][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-iclb5/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb5/igt@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_11197_full and IGTPW_6599_full:

### New IGT tests (66) ###

* igt@kms_addfb_basic@addfb25-4-tiled:
- Statuses : 7 pass(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@4-tiled-16bpp-rotate-0:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-16bpp-rotate-180:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-16bpp-rotate-270:
- Statuses :
- Exec time: [None] s

* igt@kms_big_fb@4-tiled-16bpp-rotate-90:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-32bpp-rotate-0:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-32bpp-rotate-180:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-32bpp-rotate-270:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-32bpp-rotate-90:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-64bpp-rotate-0:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-64bpp-rotate-180:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-64bpp-rotate-270:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-64bpp-rotate-90:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-8bpp-rotate-0:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-8bpp-rotate-180:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-8bpp-rotate-270:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-8bpp-rotate-90:
- Statuses : 4 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-addfb:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-addfb-size-offset-overflow:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-addfb-size-overflow:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- Statuses : 6 skip(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- Statuses : 6 skip(s)
- Exec time: [0.0, 0.00] s

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_draw_crc@draw-method-rgb565-blt-4tiled:
- Statuses : 6 fail(s)
- Exec time: [0.01, 0.03] s

* igt@kms_draw_crc@draw-method-rgb565-mmap-cpu-4tiled:
- Statuses : 7 fail(s)
- Exec time: [0.03, 0.24] s

* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-4tiled:
- Statuses : 5 fail(s)
- Exec time: [0.02, 0.22] s

* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-4tiled:
- Statuses : 6 fail(s)
- Exec time: [0.01, 0.10] s

* igt@kms_draw_crc@draw-method-rgb565-pwrite-4tiled:
- Statuses : 7 fail(s)
- Exec time: [0.01, 0.14] s

* igt@kms_draw_crc@draw-method-rgb565-render-4tiled:
- Statuses : 7 fail(s)
- Exec time: [0.03, 0.13] s

* igt@kms_draw_crc@draw-method-xrgb2101010-blt-4tiled:
- Statuses : 6 fail(s)
- Exec time: [0.03, 0.13] s

* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-4tiled:
- Statuses : 7 fail(s)
- Exec time: [0.01, 0.21] s

* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-4tiled:
- Statuses : 7 fail(s)
- Exec time: [0.01, 0.19] s

* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-4tiled:
- Statuses : 7 fail(s)
- Exec time: [0.01, 1.42] s

* igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-4tiled:
- Statuses : 6 fail(s)
- Exec time: [0.01, 0.13] s

* igt@kms_draw_crc@draw-method-xrgb2101010-render-4tiled:
- Statuses : 5 fail(s)
- Exec time: [0.01, 0.12] s

* igt@kms_draw_crc@draw-method-xrgb8888-blt-4tiled:
- Statuses : 7 fail(s)
- Exec time: [0.01, 0.13] s

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-4tiled:
- Statuses : 6 fail(s)
- Exec time: [0.01, 0.14] s

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-4tiled:
- Statuses : 7 fail(s)
- Exec time: [0.03, 0.14] s

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-4tiled:
- Statuses : 7 fail(s)
- Exec time: [0.02, 0.13] s

* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-4tiled:
- Statuses : 6 fail(s)
- Exec time: [0.04, 0.18] s

* igt@kms_draw_crc@draw-method-xrgb8888-render-4tiled:
- Statuses : 7 fail(s)
- Exec time: [0.02, 0.23] s

* igt@kms_frontbuffer_tracking@fbc-tiling-4:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_frontbuffer_tracking@fbcpsr-tiling-4:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_plane_lowres@pipe-a-tiling-4:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_plane_lowres@pipe-b-tiling-4:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_plane_lowres@pipe-c-tiling-4:
- Statuses : 4 skip(s)
- Exec time: [0.0] s

* igt@kms_plane_lowres@pipe-d-tiling-4:
- Statuses : 6 skip(s)
- Exec time: [0.0] s

* igt@kms_plane_multiple@atomic-pipe-a-tiling-4:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.00] s

* igt@kms_plane_multiple@atomic-pipe-b-tiling-4:
- Statuses : 5 skip(s)
- Exec time: [0.0, 0.00] s

* igt@kms_plane_multiple@atomic-pipe-c-tiling-4:
- Statuses : 7 skip(s)
- Exec time: [0.0, 0.00] s

* igt@kms_plane_multiple@atomic-pipe-d-tiling-4:
- Statuses : 7 skip(s)
- Exec time: [0.0] s

* igt@kms_rotation_crc@primary-4-tiled-reflect-x-0:
- Statuses : 6 skip(s)
- Exec time: [0.0, 0.10] s

* igt@kms_rotation_crc@primary-4-tiled-reflect-x-180:
- Statuses : 6 skip(s)
- Exec time: [0.0, 0.10] s

Known issues
------------

Here are the changes found in IGTPW_6599_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-apl: [PASS][25] -> [DMESG-WARN][26] ([i915#180]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-apl7/igt@gem_ctx_isolation@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-apl1/igt@gem_ctx_isolation@[email protected]

* igt@gem_eio@kms:
- shard-tglb: [PASS][27] -> [FAIL][28] ([i915#232])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-tglb7/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb3/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][29] -> [TIMEOUT][30] ([i915#2481] / [i915#3070])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-iclb5/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb8/igt@[email protected]

* igt@gem_exec_balancer@parallel:
- shard-iclb: [PASS][31] -> [SKIP][32] ([i915#4525])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-iclb1/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb7/igt@[email protected]

* igt@gem_exec_capture@pi@vcs1:
- shard-iclb: NOTRUN -> [INCOMPLETE][33] ([i915#3371])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb2/igt@gem_exec_capture@[email protected]

* igt@gem_exec_capture@pi@vecs0:
- shard-tglb: [PASS][34] -> [INCOMPLETE][35] ([i915#3371])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-tglb3/igt@gem_exec_capture@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb5/igt@gem_exec_capture@[email protected]

* igt@gem_exec_endless@dispatch@vcs1:
- shard-tglb: [PASS][36] -> [INCOMPLETE][37] ([i915#3778])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-tglb5/igt@gem_exec_endless@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb7/igt@gem_exec_endless@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-apl: [PASS][38] -> [FAIL][39] ([i915#2842])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-apl4/igt@gem_exec_fair@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-apl8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: NOTRUN -> [FAIL][40] ([i915#2842]) +5 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][41] -> [FAIL][42] ([i915#2842]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-kbl1/igt@gem_exec_fair@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][43] -> [FAIL][44] ([i915#2849])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-iclb1/igt@gem_exec_fair@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-queues-all:
- shard-glk: [PASS][45] -> [DMESG-WARN][46] ([i915#118]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-glk3/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-glk2/igt@[email protected]

* igt@gem_lmem_swapping@random:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#4613]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-apl7/igt@[email protected]

* igt@gem_lmem_swapping@smem-oom:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#4613]) +4 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-kbl6/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#4613])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-glk2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][50] ([i915#4613])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][51] ([i915#4613])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb2/igt@[email protected]

* igt@gem_mmap_gtt@coherency:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109292])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb8/igt@[email protected]

* igt@gem_pxp@create-valid-protected-context:
- shard-iclb: NOTRUN -> [SKIP][53] ([i915#4270]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb6/igt@[email protected]

* igt@gem_pxp@reject-modify-context-protection-off-3:
- shard-tglb: NOTRUN -> [SKIP][54] ([i915#4270]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb8/igt@[email protected]

* igt@gem_render_copy@linear-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][55] ([i915#768]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb4/igt@[email protected]

* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-kbl: NOTRUN -> [SKIP][56] ([fdo#109271]) +219 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-kbl7/igt@[email protected]

* igt@gem_userptr_blits@create-destroy-unsync:
- shard-tglb: NOTRUN -> [SKIP][57] ([i915#3297]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb7/igt@[email protected]

* igt@gem_userptr_blits@readonly-unsync:
- shard-iclb: NOTRUN -> [SKIP][58] ([i915#3297]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb6/igt@[email protected]

* igt@gem_userptr_blits@vma-merge:
- shard-iclb: NOTRUN -> [FAIL][59] ([i915#3318])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb1/igt@[email protected]

* igt@gen9_exec_parse@basic-rejected:
- shard-tglb: NOTRUN -> [SKIP][60] ([i915#2527] / [i915#2856]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb1/igt@[email protected]

* igt@gen9_exec_parse@bb-chained:
- shard-iclb: NOTRUN -> [SKIP][61] ([i915#2856]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb5/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-fence:
- shard-tglb: [PASS][62] -> [WARN][63] ([i915#2681] / [i915#2684])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-tglb6/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb7/igt@[email protected]
- shard-iclb: [PASS][64] -> [WARN][65] ([i915#1804] / [i915#2684])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-iclb8/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb7/igt@[email protected]

* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-tglb: NOTRUN -> [SKIP][66] ([fdo#109506] / [i915#2411])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb6/igt@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-tglb: NOTRUN -> [SKIP][67] ([fdo#111644] / [i915#1397] / [i915#2411])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#110892])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb6/igt@[email protected]

* igt@i915_suspend@forcewake:
- shard-snb: [PASS][69] -> [INCOMPLETE][70] ([i915#636])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11197/shard-snb6/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-snb4/igt@[email protected]

* {igt@kms_big_fb@4-tiled-8bpp-rotate-0} (NEW):
- shard-snb: NOTRUN -> [SKIP][71] ([fdo#109271]) +111 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-snb6/igt@[email protected]

* {igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip} (NEW):
- shard-glk: NOTRUN -> [SKIP][72] ([fdo#109271]) +88 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-glk3/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#3777]) +4 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-kbl3/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
- shard-apl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#3777]) +2 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-apl6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html

* igt@kms_big_fb@yf-tiled-32bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][75] ([fdo#111615]) +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb8/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271]) +151 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-apl1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][77] ([fdo#110723])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb5/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109278] / [i915#3886]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb5/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#3886])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-glk2/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][80] ([i915#3689] / [i915#3886])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb8/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#3886]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-apl8/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][82] ([i915#3689]) +3 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb6/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_ccs.html

* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#3886]) +4 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-kbl1/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-missing-ccs-buffer-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][84] ([fdo#111615] / [i915#3689]) +6 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb6/igt@kms_ccs@pipe-c-missing-ccs-buffer-yf_tiled_ccs.html

* igt@kms_chamelium@dp-hpd-storm-disable:
- shard-tglb: NOTRUN -> [SKIP][85] ([fdo#109284] / [fdo#111827]) +5 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb6/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-iclb: NOTRUN -> [SKIP][86] ([fdo#109284] / [fdo#111827]) +3 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb2/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][87] ([fdo#109271] / [fdo#111827]) +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-snb2/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][88] ([fdo#109271] / [fdo#111827]) +2 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-glk2/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-storm:
- shard-kbl: NOTRUN -> [SKIP][89] ([fdo#109271] / [fdo#111827]) +12 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-kbl4/igt@[email protected]

* igt@kms_color@pipe-d-ctm-0-5:
- shard-iclb: NOTRUN -> [SKIP][90] ([fdo#109278] / [i915#1149]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb3/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-max:
- shard-apl: NOTRUN -> [SKIP][91] ([fdo#109271] / [fdo#111827]) +8 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-apl6/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-limited-range:
- shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb6/igt@[email protected]

* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][93] ([i915#1319])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-apl2/igt@[email protected]

* igt@kms_content_protection@content_type_change:
- shard-tglb: NOTRUN -> [SKIP][94] ([i915#1063])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb6/igt@kms_content_protection@content_type_change.html

* igt@kms_cursor_crc@pipe-a-cursor-32x10-offscreen:
- shard-tglb: NOTRUN -> [SKIP][95] ([i915#3359]) +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb2/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][96] ([i915#3319]) +3 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen:
- shard-iclb: NOTRUN -> [SKIP][97] ([fdo#109278] / [fdo#109279])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb4/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-256x85-random:
- shard-iclb: NOTRUN -> [SKIP][98] ([fdo#109278]) +19 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb4/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][99] ([fdo#109279] / [i915#3359]) +3 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-tglb8/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109274] / [fdo#109278]) +2 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/shard-iclb2/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-tglb: [P

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6599/index.html

#2 lore raw

Re: [igt-dev] [PATCH i-g-t 01/17] lib/i915_pciids: PCI IDS for DG2

In reply to Jeevan B

lib/i915_pciids.h

Quoted 12 lines · Jeevan B

From: Priyanka Dandamudi <[email protected]>

Adds PCI IDS for DG2.

Cc Adam Miszczak <[email protected]>
Cc Melkaveri, Arjun <[email protected]>
---
 lib/i915_pciids.h | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
lib/i915_pciids.h +0 -0

This file is supposed to be copied from the kernel. The kernel doesn't have DG2 PCI ids yet, as was pointed out the last time this change was sent to the mailing list.

Signature · 1 line
Petri Latvala
Quoted 30 lines

index 533890dc..b4230424 100644

lib/i915_pciids.h +19 -0
@@ -681,4 +681,23 @@
 	INTEL_VGA_DEVICE(0xA788, info), \
 	INTEL_VGA_DEVICE(0xA789, info)
 
+/* DG2 */
+#define INTEL_DG2_G10_IDS(info) \
+        INTEL_VGA_DEVICE(0x5690, info), \
+        INTEL_VGA_DEVICE(0x5691, info), \
+        INTEL_VGA_DEVICE(0x5692, info), \
+
+#define INTEL_DG2_G11_IDS(info) \
+        INTEL_VGA_DEVICE(0x56A5, info), \
+        INTEL_VGA_DEVICE(0x56A6, info), \
+        INTEL_VGA_DEVICE(0x5693, info), \
+        INTEL_VGA_DEVICE(0x5694, info), \
+        INTEL_VGA_DEVICE(0x5695, info), \
+        INTEL_VGA_DEVICE(0x56B0, info), \
+        INTEL_VGA_DEVICE(0x56B1, info)
+
+#define INTEL_DG2_IDS(info) \
+        INTEL_DG2_G10_IDS(info) \
+        INTEL_DG2_G11_IDS(info)
+
 #endif /* _I915_PCIIDS_H */
Signature · 1 line
2.17.1
Reviewed-by on v1 2/17
#4 lore raw

Re: [igt-dev] [PATCH i-g-t 02/17] lib/dg2: Add DG2 platform definition

In reply to Jeevan B
Quoted 7 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Jeevan B
Sent: Monday, February 7, 2022 8:22 PM
To: [email protected]
Cc: [email protected]
Subject: [igt-dev] [PATCH i-g-t 02/17] lib/dg2: Add DG2 platform definition

Quoted 7 lines

From: Matt Roper <[email protected]>

Added definition for DG2.

Quoted 58 lines
---
 lib/intel_chipset.h     | 2 ++
 lib/intel_device_info.c | 8 ++++++++
 2 files changed, 10 insertions(+)
lib/intel_chipset.h index 3527cbe5..9c2f1b31 renamed from lib/intel_chipset.h +0 -0

100644

lib/intel_chipset.h +2 -0
@@ -81,6 +81,7 @@ struct intel_device_info {
 	bool is_raptorlake_s : 1;
 	bool is_alderlake_p : 1;
 	bool is_alderlake_n : 1;
+	bool is_dg2 : 1;
 	const char *codename;
 };
 
@@ -186,6 +187,7 @@ void intel_check_pch(void);
 #define IS_RAPTORLAKE_S(devid)	(intel_get_device_info(devid)-
 >is_raptorlake_s)
 #define IS_ALDERLAKE_P(devid)	(intel_get_device_info(devid)->is_alderlake_p)
 #define IS_ALDERLAKE_N(devid)	(intel_get_device_info(devid)-
 >is_alderlake_n)
+#define IS_DG2(devid)          (intel_get_device_info(devid)->is_dg2)
 

#define IS_GEN(devid, x) (intel_get_device_info(devid)->graphics_ver ==
x)
#define AT_LEAST_GEN(devid, x) (intel_get_device_info(devid)-

Quoted 1 line

graphics_ver >= x)

lib/intel_device_info.c index renamed from lib/intel_device_info.c +0 -0

40942afe..05ba2d98 100644

lib/intel_device_info.c +7 -0
@@ -417,6 +417,13 @@ static const struct intel_device_info
 intel_alderlake_n_info = {
 	.codename = "alderlake_n"
 };
 
+static const struct intel_device_info intel_dg2_info = {
+	.graphics_ver = 12,
+	.display_ver = 13,
+	.is_dg2 = true,
+	.codename = "dg2"
+};
+
 static const struct pci_id_match intel_device_match[] = {
 	INTEL_I810_IDS(&intel_i810_info),
lib/intel_device_info.c +1 -1
 	INTEL_I815_IDS(&intel_i815_info),
@@ -511,6 +518,7 @@ static const struct pci_id_match intel_device_match[] =
 {
 	INTEL_RPLS_IDS(&intel_raptorlake_s_info),
 	INTEL_ADLP_IDS(&intel_alderlake_p_info),
 	INTEL_ADLN_IDS(&intel_alderlake_n_info),
+	INTEL_DG2_IDS(&intel_dg2_info),
 
 	INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info),  };
--

2.17.1

#9 lore raw

Re: [igt-dev] [PATCH i-g-t 06/17] igt/tests: Add support for Tile4(TileF) format to kms_draw_crc

In reply to Jeevan B
Quoted 7 lines · Jeevan B

From: Stanislav Lisovskiy <[email protected]>

kms_draw_crc would be the first sample test to support new format.

Currently IGT tests are failing, because kernel doesn't support Tile 4 yet.
I guess it is good time to modify that test also, so that it tries to test Tile 4 only if it is supported.

Stan

Quoted 62 lines
---
 tests/i915/kms_draw_crc.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
tests/i915/kms_draw_crc.c +8 -7
index 82c368e1..6348e803 100644
@@ -41,25 +41,24 @@ drmModeConnectorPtr drm_connectors[MAX_CONNECTORS];
 struct buf_ops *bops;
 igt_pipe_crc_t *pipe_crc;
 
-#define N_FORMATS 3
-static const uint32_t formats[N_FORMATS] = {
+static const uint32_t formats[] = {
 	DRM_FORMAT_XRGB8888,
 	DRM_FORMAT_RGB565,
 	DRM_FORMAT_XRGB2101010,
 };
 
-#define N_MODIFIER_METHODS 3
-static const uint64_t modifiers[N_MODIFIER_METHODS] = {
+static const uint64_t modifiers[] = {
 	DRM_FORMAT_MOD_LINEAR,
 	I915_FORMAT_MOD_X_TILED,
 	I915_FORMAT_MOD_Y_TILED,
+	I915_FORMAT_MOD_4_TILED,
 };
 
 struct base_crc {
 	bool set;
 	igt_crc_t crc;
 };
-struct base_crc base_crcs[N_FORMATS];
+struct base_crc base_crcs[ARRAY_SIZE(formats)];
 
 struct modeset_params ms;
 
@@ -315,6 +314,8 @@ static const char *modifier_str(int modifier_index)
 		return "xtiled";
 	case I915_FORMAT_MOD_Y_TILED:
 		return "ytiled";
+	case I915_FORMAT_MOD_4_TILED:
+		return "4tiled";
 	default:
 		igt_assert(false);
 	}
@@ -328,9 +329,9 @@ igt_main
 	igt_fixture
 		setup_environment();
 
-	for (format_idx = 0; format_idx < N_FORMATS; format_idx++) {
+	for (format_idx = 0; format_idx < ARRAY_SIZE(formats); format_idx++) {
 	for (method = 0; method < IGT_DRAW_METHOD_COUNT; method++) {
-	for (modifier_idx = 0; modifier_idx < N_MODIFIER_METHODS; modifier_idx++) {
+	for (modifier_idx = 0; modifier_idx < ARRAY_SIZE(modifiers); modifier_idx++) {
 		igt_describe("This subtest verfies igt_draw library works "
 			     "with different modifiers, DRM_FORMATS, DRAW_METHODS.");
 		igt_subtest_f("draw-method-%s-%s-%s",
Signature · 1 line
2.17.1