Skip to contentSkip to conversation

MIPS: Malta: Enable BLK_DEV_INITRD

PATCH Applied Nathan Chancellor 3 participants 3 messages Feb 8, 2022 – Feb 9, 2022 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MIPS: Malta: Enable BLK_DEV_INITRD

This configuration is useful for boot testing malta_defconfig in QEMU with just a simple cpio initrd, instead of a full ext4 rootfs.

This results in an increase of ~164KB of vmlinux (with GCC 11.2.0):

$ diskus vmlinux.before
11.19 MB (11,194,368 bytes)
$ diskus vmlinux.after
11.36 MB (11,358,208 bytes)

This size increase comes from the fact that usr/Kconfig is sourced when CONFIG_BLK_DEV_INITRD is enabled, which defaults to supporting several decompression algorithms for compressed initrds. This seems like a reasonable tradeoff but these configurations could be disabled in the future if there are complaints about the size increase.

---
 arch/mips/configs/malta_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/mips/configs/malta_defconfig +1 -0
index 3321bb576944..3456ac8ded6c 100644
@@ -4,6 +4,7 @@ CONFIG_HIGH_RES_TIMERS=y
 CONFIG_LOG_BUF_SHIFT=15
 CONFIG_NAMESPACES=y
 CONFIG_RELAY=y
+CONFIG_BLK_DEV_INITRD=y
 CONFIG_EXPERT=y
 # CONFIG_COMPAT_BRK is not set
 CONFIG_SLAB=y

base-commit: dfd42facf1e4ada021b939b4e19c935dcdd55566

Signature · 1 line
2.35.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Nathan Chancellor

This configuration is useful for boot testing malta_defconfig in QEMU with just a simple cpio initrd, instead of a full ext4 rootfs.

This results in an increase of ~164KB of vmlinux (with GCC 11.2.0):

$ diskus vmlinux.before
11.19 MB (11,194,368 bytes)
$ diskus vmlinux.after
11.36 MB (11,358,208 bytes)
Quoted 7 lines

This size increase comes from the fact that usr/Kconfig is sourced when CONFIG_BLK_DEV_INITRD is enabled, which defaults to supporting several decompression algorithms for compressed initrds. This seems like a reasonable tradeoff but these configurations could be disabled in the future if there are complaints about the size increase.

I'm all for having a regular way to test all defconfigs. So, FWIW:

-Kees

Quoted 21 lines
---
 arch/mips/configs/malta_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/mips/configs/malta_defconfig +1 -0
index 3321bb576944..3456ac8ded6c 100644
@@ -4,6 +4,7 @@ CONFIG_HIGH_RES_TIMERS=y
 CONFIG_LOG_BUF_SHIFT=15
 CONFIG_NAMESPACES=y
 CONFIG_RELAY=y
+CONFIG_BLK_DEV_INITRD=y
 CONFIG_EXPERT=y
 # CONFIG_COMPAT_BRK is not set
 CONFIG_SLAB=y

base-commit: dfd42facf1e4ada021b939b4e19c935dcdd55566

Signature · 1 line
2.35.1
Signature · 1 line
Kees Cook
maintainer Applied
#2 lore raw
In reply to Nathan Chancellor
Quoted 17 lines · Nathan Chancellor

This configuration is useful for boot testing malta_defconfig in QEMU with just a simple cpio initrd, instead of a full ext4 rootfs.

This results in an increase of ~164KB of vmlinux (with GCC 11.2.0):

$ diskus vmlinux.before
11.19 MB (11,194,368 bytes)
$ diskus vmlinux.after
11.36 MB (11,358,208 bytes)

This size increase comes from the fact that usr/Kconfig is sourced when CONFIG_BLK_DEV_INITRD is enabled, which defaults to supporting several decompression algorithms for compressed initrds. This seems like a reasonable tradeoff but these configurations could be disabled in the future if there are complaints about the size increase.

Quoted 4 lines
---
 arch/mips/configs/malta_defconfig | 1 +
 1 file changed, 1 insertion(+)

applied to mips-next.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]