Skip to contentSkip to conversation

Staging: r8188eu: core: do not use assignment in if condition

PATCH New Leonardo Araujo 1 participant 1 message Feb 8, 2022 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: r8188eu: core: do not use assignment in if condition

This patch fixes the following checkpatch.pl warning:

ERROR: do not use assignment in if condition

---
 drivers/staging/r8188eu/core/rtw_cmd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/r8188eu/core/rtw_cmd.c +2 -1
index c7e8602d2097..d02632dc16c3 100644
@@ -1329,7 +1329,8 @@ static void c2h_wk_callback(struct work_struct *work)
 	evtpriv->c2h_wk_alive = true;
 
 	while (!rtw_cbuf_empty(evtpriv->c2h_queue)) {
-		if ((c2h_evt = (struct c2h_evt_hdr *)rtw_cbuf_pop(evtpriv->c2h_queue)) != NULL) {
+		c2h_evt = (struct c2h_evt_hdr *)rtw_cbuf_pop(evtpriv->c2h_queue);
+		if (c2h_evt) {
 			/* This C2H event is read, clear it */
 			rtw_write8(adapter, REG_C2HEVT_CLEAR, C2H_EVT_HOST_CLOSE);
 		} else {
Signature · 1 line
2.29.0