common/config: fix use of MODPROBE_RM_PATIENT_TIMEOUT_ARGS
PATCH 1/1 common/config: fix use of MODPROBE_RM_PATIENT_TIMEOUT_ARGS
When patient module removal support is detected on kmod (note that this is not yet even merged onto kmod yet but work in progress) the arguments required for it are not being set yet. This was a typo, fix this.
This issue was spotted using shellcheck from blktests when adding patient module removal support there. I'll post a patch next to let folks evaluate if we should embrace shellcheck on fstests as well.
--- common/config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/config +1 -1
@@ -280,7 +280,7 @@ else MODPROBE_PATIENT_RM_TIMEOUT_MS="$((MODPROBE_PATIENT_RM_TIMEOUT_SECONDS * 1000))" MODPROBE_RM_PATIENT_TIMEOUT_ARGS="-t $MODPROBE_PATIENT_RM_TIMEOUT_MS" fi - MODPROBE_REMOVE_PATIENT="modprobe -p $MODPROBE_RM_TIMEOUT_ARGS" + MODPROBE_REMOVE_PATIENT="modprobe -p $MODPROBE_RM_PATIENT_TIMEOUT_ARGS" fi export MODPROBE_REMOVE_PATIENT
Signature · 1 line
2.34.1
Quoted 11 lines · Luis Chamberlain
When patient module removal support is detected on kmod (note that this is not yet even merged onto kmod yet but work in progress) the arguments required for it are not being set yet. This was a typo, fix this.
This issue was spotted using shellcheck from blktests when adding patient module removal support there. I'll post a patch next to let folks evaluate if we should embrace shellcheck on fstests as well.
Signed-off-by Luis Chamberlain <[email protected]>
*Poke*
Luis