Skip to contentSkip to conversation

dt-bindings: timer: Convert faraday,fttmr010 to yaml

PATCH Superseded Corentin Labbe 2 participants 3 messages Feb 9, 2022

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 dt-bindings: timer: Convert faraday,fttmr010 to yaml

Converts timer/faraday,fttmr010.txt to yaml.

---
Changes since v1:
- added moxart example
- relaxed some contraints as driver only support one clock and one
interrupt (as used by moxa,moxart-timer)
Changes since v2:
- increased max size of interrupts
- fixed all issues reported by Rob https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

All aspeed-bmc-vegman*dts are expected to fail and will be fixed via:
https://patchwork.ozlabs.org/project/linux-aspeed/patch/[email protected]/

 .../bindings/timer/faraday,fttmr010.txt       |  38 ------
 .../bindings/timer/faraday,fttmr010.yaml      | 108 ++++++++++++++++++
 2 files changed, 108 insertions(+), 38 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/timer/faraday,fttmr010.txt
 create mode 100644 Documentation/devicetree/bindings/timer/faraday,fttmr010.yaml
Documentation/devicetree/bindings/timer/faraday,fttmr010.txt deleted +0 -38
deleted file mode 100644
index 3cb2f4c98d64..000000000000
@@ -1,38 +0,0 @@
-Faraday Technology timer
-
-This timer is a generic IP block from Faraday Technology, embedded in the
-Cortina Systems Gemini SoCs and other designs.
-
-Required properties:
-
-- compatible : Must be one of
-  "faraday,fttmr010"
-  "cortina,gemini-timer", "faraday,fttmr010"
-  "moxa,moxart-timer", "faraday,fttmr010"
-  "aspeed,ast2400-timer"
-  "aspeed,ast2500-timer"
-  "aspeed,ast2600-timer"
-
-- reg : Should contain registers location and length
-- interrupts : Should contain the three timer interrupts usually with
-  flags for falling edge
-
-Optionally required properties:
-
-- clocks : a clock to provide the tick rate for "faraday,fttmr010"
-- clock-names : should be "EXTCLK" and "PCLK" for the external tick timer
-  and peripheral clock respectively, for "faraday,fttmr010"
-- syscon : a phandle to the global Gemini system controller if the compatible
-  type is "cortina,gemini-timer"
-
-Example:
-
-timer@43000000 {
-	compatible = "faraday,fttmr010";
-	reg = <0x43000000 0x1000>;
-	interrupts = <14 IRQ_TYPE_EDGE_FALLING>, /* Timer 1 */
-		   <15 IRQ_TYPE_EDGE_FALLING>, /* Timer 2 */
-		   <16 IRQ_TYPE_EDGE_FALLING>; /* Timer 3 */
-	clocks = <&extclk>, <&pclk>;
-	clock-names = "EXTCLK", "PCLK";
-};
Documentation/devicetree/bindings/timer/faraday,fttmr010.yaml new file +108 -0

108 lines not on this page · raw message

Signature · 1 line
2.34.1
#1 lore raw
Quoted 1 line · Corentin Labbe

Converts timer/faraday,fttmr010.txt to yaml.

s/Converts/Convert/

Quoted 14 lines

---
Changes since v1:
- added moxart example
- relaxed some contraints as driver only support one clock and one
interrupt (as used by moxa,moxart-timer)
Changes since v2:
- increased max size of interrupts
- fixed all issues reported by Rob https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

All aspeed-bmc-vegman*dts are expected to fail and will be fixed via:
https://patchwork.ozlabs.org/project/linux-aspeed/patch/[email protected]/

(...)

Documentation/devicetree/bindings/timer/faraday,fttmr010.yaml line 62

Quoted 13 lines
Documentation/devicetree/bindings/timer/faraday,fttmr010.yaml new file +13 -0
+
+  syscon:
+    $ref: /schemas/types.yaml#/definitions/phandle
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+
+additionalProperties: true
+

This should be false (and was false in your v1).

Best regards,
Krzysztof

#2 lore raw
Quoted 22 lines · Krzysztof Kozlowski
Quoted 1 line · Corentin Labbe

Converts timer/faraday,fttmr010.txt to yaml.

s/Converts/Convert/

Quoted 14 lines

---
Changes since v1:
- added moxart example
- relaxed some contraints as driver only support one clock and one
interrupt (as used by moxa,moxart-timer)
Changes since v2:
- increased max size of interrupts
- fixed all issues reported by Rob https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

All aspeed-bmc-vegman*dts are expected to fail and will be fixed via:
https://patchwork.ozlabs.org/project/linux-aspeed/patch/[email protected]/

(...)

Quoted 15 lines

Documentation/devicetree/bindings/timer/faraday,fttmr010.yaml line 62

Quoted 13 lines
Documentation/devicetree/bindings/timer/faraday,fttmr010.yaml new file +13 -0
+
+  syscon:
+    $ref: /schemas/types.yaml#/definitions/phandle
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+
+additionalProperties: true
+

This should be false (and was false in your v1).

Oups, sorry
I forgot to remove it, it was my first try to fix vegman DT.
Anyway I also forgotten to remove some property in example which will be no longer in vegman.

I will send a V4
Thanks