Skip to contentSkip to conversation

Staging: r8188eu: core: Comparisons should place the constant on the right side of the test

PATCH In review Leonardo Araujo 2 participants 2 messages Feb 9, 2022 – Feb 10, 2022 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: r8188eu: core: Comparisons should place the constant on the right side of the test

This patch fixes the following checkpatch.pl warning:

WARNING: Comparisons should place the constant on the right side of the test

---
 drivers/staging/r8188eu/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/r8188eu/core/rtw_cmd.c +1 -1
index c7e8602d2097..a9a5453aa1cc 100644
@@ -188,7 +188,7 @@ u32 rtw_enqueue_cmd(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
 	cmd_obj->padapter = padapter;
 
 	res = rtw_cmd_filter(pcmdpriv, cmd_obj);
-	if (_FAIL == res) {
+	if (res == _FAIL) {
 		rtw_free_cmd_obj(cmd_obj);
 		goto exit;
 	}
Signature · 1 line
2.29.0
maintainer
#1 lore raw
Quoted 9 lines · Leonardo Araujo

This patch fixes the following checkpatch.pl warning:

WARNING: Comparisons should place the constant on the right side of the test

---
 drivers/staging/r8188eu/core/rtw_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Also you need to properly cc: the relevant maintainers, as get_maintainer.pl will show you.

I have dropped all of your pending patches from my queue. Please fix them up and send a patch series.

thanks,

greg k-h