btrfs: qgroup: Remove outdated TODO comments
PATCH 1/1 btrfs: qgroup: Remove outdated TODO comments
These comments are too old and outdated. It seems that it doesn't help. So we can remove those.
--- fs/btrfs/qgroup.c | 11 ----------- 1 file changed, 11 deletions(-)
fs/btrfs/qgroup.c +0 -11
@@ -25,17 +25,6 @@#include "sysfs.h" #include "tree-mod-log.h" -/* TODO XXX FIXME -* - subvol delete -> delete when ref goes to 0? delete limits also? -* - reorganize keys -* - compressed -* - sync -* - limit -* - caches for ulists -* - performance benchmarks -* - check all ioctl parameters -*/ -/* * Helpers to access qgroup reservation *
Signature · 1 line
2.25.1
Quoted 4 lines · Sidong Yang
These comments are too old and outdated. It seems that it doesn't help. So we can remove those.
Signed-off-by Sidong Yang <[email protected]>
Added to misc-next, thanks.
Quoted 13 lines · Sidong Yang
These comments are too old and outdated. It seems that it doesn't help. So we can remove those.
Signed-off-by Sidong Yang <[email protected]>--- fs/btrfs/qgroup.c | 11 ----------- 1 file changed, 11 deletions(-)fs/btrfs/qgroup.c +0
-0
fs/btrfs/qgroup.c line 29
Quoted 5 lines
fs/btrfs/qgroup.c +0
-2@@ -25,17 +25,6 @@#include "sysfs.h" #include "tree-mod-log.h" -/* TODO XXX FIXME -* - subvol delete -> delete when ref goes to 0? delete limits also?
This is still under concern AFAIK.
Currently if we delete a subvolume, its qgroup number will changed to 0 but not removed.
Thanks,
Qu
Quoted 12 lines
fs/btrfs/qgroup.c +0
-9-* - reorganize keys -* - compressed -* - sync -* - limit -* - caches for ulists -* - performance benchmarks -* - check all ioctl parameters -*/ -/* * Helpers to access qgroup reservation *
Quoted 19 lines · Qu Wenruo
Quoted 16 lines · Sidong Yang
These comments are too old and outdated. It seems that it doesn't help. So we can remove those.
Signed-off-by Sidong Yang <[email protected]>--- fs/btrfs/qgroup.c | 11 ----------- 1 file changed, 11 deletions(-)fs/btrfs/qgroup.c +0
-0@@ -25,17 +25,6 @@#include "sysfs.h" #include "tree-mod-log.h"
Quoted 7 lines
fs/btrfs/qgroup.c line 29
Quoted 2 lines
fs/btrfs/qgroup.c +0
-2-/* TODO XXX FIXME -* - subvol delete -> delete when ref goes to 0? delete limits also? This is still under concern AFAIK.
Currently if we delete a subvolume, its qgroup number will changed to 0 but not removed.
This issue is in btrfs-progs github issue list (#366). It has detailed description in there. So, I think it's okay to delete this.
Thanks,
Sidong
Quoted 16 lines
Thanks,
QuQuoted 12 lines
fs/btrfs/qgroup.c +0
-9-* - reorganize keys -* - compressed -* - sync -* - limit -* - caches for ulists -* - performance benchmarks -* - check all ioctl parameters -*/ -/* * Helpers to access qgroup reservation *
Qu Wenruo
Reviewed-byQuoted 25 lines · Sidong Yang
Quoted 24 lines · Qu Wenruo
Quoted 13 lines · Sidong Yang
These comments are too old and outdated. It seems that it doesn't help. So we can remove those.
Signed-off-by Sidong Yang <[email protected]>--- fs/btrfs/qgroup.c | 11 ----------- 1 file changed, 11 deletions(-)fs/btrfs/qgroup.c +0
-0fs/btrfs/qgroup.c line 29
Quoted 5 lines
fs/btrfs/qgroup.c +0
-2@@ -25,17 +25,6 @@#include "sysfs.h" #include "tree-mod-log.h" -/* TODO XXX FIXME -* - subvol delete -> delete when ref goes to 0? delete limits also? This is still under concern AFAIK.
Quoted 5 lines
Quoted 2 lines
Currently if we delete a subvolume, its qgroup number will changed to 0 but not removed.
This issue is in btrfs-progs github issue list (#366). It has detailed description in there. So, I think it's okay to delete this.
Oh, we have already migrated to a modern solution.
Then it looks good to me.
Thanks,
Qu
Quoted 19 lines
Thanks,
SidongQuoted 16 lines
Thanks,
QuQuoted 12 lines
fs/btrfs/qgroup.c +0
-9-* - reorganize keys -* - compressed -* - sync -* - limit -* - caches for ulists -* - performance benchmarks -* - check all ioctl parameters -*/ -/* * Helpers to access qgroup reservation *