kconfig: add fflush() before ferror() check
PATCH 1/1 kconfig: add fflush() before ferror() check
As David Laight pointed out, there is not much point in calling ferror() unless you call fflush() first.
Reported-by David Laight <[email protected]>
Signed-off-by Masahiro Yamada <[email protected]>
---
scripts/kconfig/confdata.c | 2 ++ 1 file changed, 2 insertions(+)
scripts/kconfig/confdata.c +2 -0
@@ -979,6 +979,7 @@ static int conf_write_autoconf_cmd(const char *autoconf_name)fprintf (out,"\n$(deps_config): ;\n" ); +fflush (out); ret =ferror (out);/* error check for all fprintf() calls */ fclose (out);if (ret)
@@ -1097,6 +1098,7 @@ static int __conf_write_autoconf(const char *filename,if ((sym->flags &SYMBOL_WRITE ) && sym->name)print_symbol (file, sym); +fflush (file);/* check possible errors in conf_write_heading() and print_symbol() */ ret =ferror (file);fclose (file);
Signature · 1 line
2.32.0
Quoted 7 lines · Masahiro Yamada
As David Laight pointed out, there is not much point in calling
ferror()unless you callfflush()first.Reported-by David Laight <[email protected]>Signed-off-by Masahiro Yamada <[email protected]>---
Applied to linux-kbuild.
Quoted 27 lines
scripts/kconfig/confdata.c | 2 ++ 1 file changed, 2 insertions(+)scripts/kconfig/confdata.c +2
-1@@ -979,6 +979,7 @@ static int conf_write_autoconf_cmd(const char *autoconf_name)fprintf (out,"\n$(deps_config): ;\n" ); +fflush (out); ret =ferror (out);/* error check for all fprintf() calls */ fclose (out);if (ret)@@ -1097,6 +1098,7 @@ static int __conf_write_autoconf(const char *filename,if ((sym->flags &SYMBOL_WRITE ) && sym->name)print_symbol (file, sym); +fflush (file);/* check possible errors in conf_write_heading() and print_symbol() */ ret =ferror (file);fclose (file); --2.32.0
Signature · 2 lines
Best Regards Masahiro Yamada