Skip to contentSkip to conversation

test-runner: fix valgrind after no radio change

PATCH Applied James Prestwood 2 participants 2 messages Feb 14, 2022

lore
Share & tools
lore

James Prestwood

author
#0 lore raw

PATCH 1/1 test-runner: fix valgrind after no radio change

The change adding support for starting IWD with no radios ended up breaking the valgrind option.

---
 tools/test-runner | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tools/test-runner +3 -1
index 17be0593..64407a41 100755
@@ -668,7 +668,7 @@ class Namespace:
 		self._bus = dbus.bus.BusConnection(address_or_type=self.dbus_address)
 
 	def start_iwd(self, config_dir = '/tmp', storage_dir = '/tmp/iwd'):
-		args = ['iwd', '-E']
+		args = []
 		iwd_radios = ','.join([r.name for r in self.radios if r.use == 'iwd'])
 
 		if self.args.valgrind:
@@ -676,6 +676,8 @@ class Namespace:
 					'--show-leak-kinds=all',
 					'--log-file=/tmp/valgrind.log.%p'])
 
+		args.extend(['iwd', '-E'])
+
 		if iwd_radios != '':
 			args.extend(['-p', iwd_radios])
 
Signature · 1 line
2.34.1
Applied
#1 lore raw

Hi James,

Quoted 6 lines · James Prestwood

The change adding support for starting IWD with no radios ended up breaking the valgrind option.

---
  tools/test-runner | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

Applied. I squashed this into the commit in question.

Regards,
-Denis