staging: wfx: check the return value of devm_kmalloc()
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 2/2 staging: wfx: check the return value of devm_kmalloc()
From: Xiaoke Wang <[email protected]>
devm_kmalloc() returns a pointer to allocated memory on success, NULL on failure. While there is a memory allocation of devm_kmalloc() without proper check. It is better to check the return value of it to prevent wrong memory access.
Signed-off-by Xiaoke Wang <[email protected]>
--- drivers/staging/wfx/main.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/staging/wfx/main.c +3 -0
@@ -294,6 +294,9 @@ struct wfx_dev *wfx_init_common(struct device *dev, hw->wiphy->n_iface_combinations =ARRAY_SIZE (wfx_iface_combinations); hw->wiphy->iface_combinations = wfx_iface_combinations; hw->wiphy->bands[NL80211_BAND_2GHZ ] =devm_kmalloc (dev,sizeof (wfx_band_2ghz),GFP_KERNEL ); +if (!hw->wiphy->bands[NL80211_BAND_2GHZ ]) + goto err; +// FIXME: also copy wfx_rates and wfx_2ghz_chantable memcpy (hw->wiphy->bands[NL80211_BAND_2GHZ ], &wfx_band_2ghz,sizeof (wfx_band_2ghz));