random: round-robin registers as ulong, not u32
Subsystems (2)
Jason A. Donenfeld
maintainerPATCH 1/1 random: round-robin registers as ulong, not u32
When the interrupt handler does not have a valid cycle counter, it calls get_reg() to read a register from the irq stack, in round-robin. Currently it does this assuming that registers are 32-bit. This is _probably_ the case, and probably all platforms without cycle counters are in fact 32-bit platforms. But maybe not, and either way, it's not quite correct. This commit fixes that to deal with unsigned long rather than u32.
Cc Dominik Brodowski <[email protected]>
Cc Theodore Ts'o <[email protected]>
Signed-off-by Jason A. Donenfeld <[email protected]>
--- drivers/char/random.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/char/random.c +3 -3
@@ -1261,15 +1261,15 @@ int random_online_cpu(unsigned int cpu) }#endif -static u32 get_reg (struct fast_pool *f,struct pt_regs *regs) +static unsigned long get_reg (struct fast_pool *f,struct pt_regs *regs) { -u32 *ptr = (u32 *)regs; +unsigned long *ptr = (unsigned long *)regs;unsigned int idx;if (regs ==NULL )return 0 ; idx =READ_ONCE (f->reg_idx); -if (idx >=sizeof (struct pt_regs ) /sizeof (u32)) +if (idx >=sizeof (struct pt_regs ) /sizeof (unsigned long )) idx =0 ; ptr += idx++;WRITE_ONCE (f->reg_idx, idx);
Signature · 1 line
2.35.1