Skip to contentSkip to conversation

firmware: stratix10-svc: add missing callback parameter on RSU

PATCH New Dinh Nguyen 1 participant 1 message Feb 23, 2022

Subsystems (3)
Stable branch FPGA manager framework Intel STRATIX10 firmware drivers
lore
Share & tools
lore

Dinh Nguyen

author maintainer
#0 lore raw

PATCH 1/1 firmware: stratix10-svc: add missing callback parameter on RSU

From: Ang Tien Sung <[email protected]>

Fix a bug whereby, the return response of parameter a1 from an SMC call is not properly set to the callback data during an INTEL_SIP_SMC_RSU_ERROR command.

Cc [email protected]
Fixes 6b50d882d38d ("firmware: add remote status update client support")
Link https://lore.kernel.org/lkml/[email protected] open here
Signed-off-by Ang Tien Sung <[email protected]>
Signed-off-by Dinh Nguyen <[email protected]>
---
 drivers/firmware/stratix10-svc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/stratix10-svc.c +1 -1
index 29c0a616b317..c4bf934e3553 100644
@@ -477,7 +477,7 @@ static int svc_normal_to_secure_thread(void *data)
 		case INTEL_SIP_SMC_RSU_ERROR:
 			pr_err("%s: STATUS_ERROR\n", __func__);
 			cbdata->status = BIT(SVC_STATUS_ERROR);
-			cbdata->kaddr1 = NULL;
+			cbdata->kaddr1 = &res.a1;
 			cbdata->kaddr2 = NULL;
 			cbdata->kaddr3 = NULL;
 			pdata->chan->scl->receive_cb(pdata->chan->scl, cbdata);
Signature · 1 line
2.25.1