Skip to contentSkip to conversation

scsi: megasas: clean up some inconsistent indenting

PATCH Superseded Yang Li 2 participants 2 messages Feb 24, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 scsi: megasas: clean up some inconsistent indenting

Eliminate the follow smatch warning:
drivers/scsi/megaraid/megaraid_sas_fusion.c:5104 megasas_reset_fusion()
warn: inconsistent indenting

---
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/megaraid/megaraid_sas_fusion.c +2 -2
index c72364864bf4..aab600ef4cd6 100644
@@ -5101,8 +5101,8 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
 				for (j = 0; j < MAX_LOGICAL_DRIVES_EXT; ++j) {
 					memset(fusion->stream_detect_by_ld[j],
 					0, sizeof(struct LD_STREAM_DETECT));
-				 fusion->stream_detect_by_ld[j]->mru_bit_map
-						= MR_STREAM_BITMAP;
+				fusion->stream_detect_by_ld[j]->mru_bit_map
+					= MR_STREAM_BITMAP;
 				}
 			}
 
Signature · 1 line
2.20.1.7.g153144c
#1 lore raw
Quoted 15 lines · Yang Li

Eliminate the follow smatch warning:
drivers/scsi/megaraid/megaraid_sas_fusion.c:5104 megasas_reset_fusion()
warn: inconsistent indenting

---
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/megaraid/megaraid_sas_fusion.c +0 -0
index c72364864bf4..aab600ef4cd6 100644

drivers/scsi/megaraid/megaraid_sas_fusion.c int megasas_reset_fusion(struct Scsi_Host *shost, int reason) · line 5103

Quoted 3 lines
drivers/scsi/megaraid/megaraid_sas_fusion.c +0 -0
@@ -5101,8 +5101,8 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason)
 				for (j = 0; j < MAX_LOGICAL_DRIVES_EXT; ++j) {
 					memset(fusion->stream_detect_by_ld[j],
 					0, sizeof(struct LD_STREAM_DETECT));

While at it, you could fix this weird indentation too.

drivers/scsi/megaraid/megaraid_sas_fusion.c int megasas_reset_fusion(struct Scsi_Host *shost, int reason) · line 5105

Quoted 4 lines
drivers/scsi/megaraid/megaraid_sas_fusion.c +2 -2
-				 fusion->stream_detect_by_ld[j]->mru_bit_map
-						= MR_STREAM_BITMAP;
+				fusion->stream_detect_by_ld[j]->mru_bit_map
+					= MR_STREAM_BITMAP;

Still inconsistent: missing one tab, no ?

drivers/scsi/megaraid/megaraid_sas_fusion.c int megasas_reset_fusion(struct Scsi_Host *shost, int reason) · line 5107

Quoted 2 lines
drivers/scsi/megaraid/megaraid_sas_fusion.c +0 -0
 				}
 			}

Given the depth of the indentation, this initialization loop could go into a little inline helper function.

Signature · 2 lines
Damien Le Moal
Western Digital Research