iio: accel: adxl367: Fix uninitialized variable handled
Subsystems (4)
PATCH 1/1 iio: accel: adxl367: Fix uninitialized variable handled
Variable handle is not initialized leading to potential garbage results with the or operations. Fix this by replacing the first or operation to an assignment to ensure handled is initialized correctly.
Fixes cbab791c5e2a ("iio: accel: add ADXL367 driver")
Signed-off-by Colin Ian King <[email protected]>
--- drivers/iio/accel/adxl367.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/accel/adxl367.c +1 -1
@@ -884,7 +884,7 @@ static irqreturn_t adxl367_irq_handler(int irq, void *private)if (ret)return IRQ_NONE ; - handled |=adxl367_push_event (indio_dev, status); + handled =adxl367_push_event (indio_dev, status); handled |=adxl367_push_fifo_data (indio_dev, status, fifo_entries);return handled ?IRQ_HANDLED :IRQ_NONE ;
Signature · 1 line
2.34.1
Jonathan Cameron
maintainerQuoted 7 lines · On Thu, 24 Feb 2022 21:51:49 +0000 Colin Ian King <[email protected]>…
Variable handle is not initialized leading to potential garbage results with the or operations. Fix this by replacing the first or operation to an assignment to ensure handled is initialized correctly.
Fixes cbab791c5e2a ("iio: accel: add ADXL367 driver")Signed-off-by Colin Ian King <[email protected]>
Hi Colin,
Nathan's patch hit my inbox first so I applied his but added an additional Reported-by: for you to reflect you also reported it via this patch.
Thanks
Jonathan
Quoted 17 lines
--- drivers/iio/accel/adxl367.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/iio/accel/adxl367.c +1
-1@@ -884,7 +884,7 @@ static irqreturn_t adxl367_irq_handler(int irq, void *private)if (ret)return IRQ_NONE ; - handled |=adxl367_push_event (indio_dev, status); + handled =adxl367_push_event (indio_dev, status); handled |=adxl367_push_fifo_data (indio_dev, status, fifo_entries);return handled ?IRQ_HANDLED :IRQ_NONE ;