firmware: google: Properly state IOMEM dependency
PATCH v2 1/1 firmware: google: Properly state IOMEM dependency
The Google Coreboot implementation requires IOMEM functions (memmremap, memunmap, devm_memremap), but does not specify this is its Kconfig. This results in build errors when HAS_IOMEM is not set, such as on some UML configurations:
/usr/bin/ld: drivers/firmware/google/coreboot_table.o: in function `coreboot_table_probe':
coreboot_table.c:(.text+0x311): undefined reference to memremap' /usr/bin/ld: coreboot_table.c:(.text+0x34e): undefined reference to memunmap' /usr/bin/ld: drivers/firmware/google/memconsole-coreboot.o: in function `memconsole_probe':
memconsole-coreboot.c:(.text+0x12d): undefined reference to memremap' /usr/bin/ld: memconsole-coreboot.c:(.text+0x17e): undefined reference to devm_memremap' /usr/bin/ld: memconsole-coreboot.c:(.text+0x191): undefined reference to memunmap' /usr/bin/ld: drivers/firmware/google/vpd.o: in function vpd_section_destroy.isra.0':
vpd.c:(.text+0x300): undefined reference to `memunmap'/usr/bin/ld: drivers/firmware/google/vpd.o: in function `vpd_section_init':
vpd.c:(.text+0x382): undefined reference to `memremap'/usr/bin/ld: vpd.c:(.text+0x459): undefined reference to memunmap' /usr/bin/ld: drivers/firmware/google/vpd.o: in function vpd_probe':
vpd.c:(.text+0x59d): undefined reference to `memremap'/usr/bin/ld: vpd.c:(.text+0x5d3): undefined reference to `memunmap'
collect2: error: ld returned 1 exit status
---
Changes since v1:
http://lists.infradead.org/pipermail/linux-um/2022-February/002266.html
- Fix to depend on HAS_IOMEM, not IOMEM
- Add Acked-By tags.
--- drivers/firmware/google/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/google/Kconfig +1 -1
@@ -21,7 +21,7 @@ config GOOGLE_SMI config GOOGLE_COREBOOT_TABLE tristate "Coreboot Table Access" - depends on ACPI || OF + depends on HAS_IOMEM && (ACPI || OF) help This option enables the coreboot_table module, which provides other firmware modules access to the coreboot table. The coreboot table
Signature · 7 lines
2.35.1.574.g5d30c73bfb-goog _______________________________________________ linux-um mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-um
Quoted 22 lines · David Gow
The Google Coreboot implementation requires IOMEM functions (memmremap, memunmap,
devm_memremap), but does not specify this is itsKconfig. This results in build errors whenHAS_IOMEMis not set, such as on some UML configurations:
/usr/bin/ld:drivers/firmware/google/coreboot_table.o: in function `coreboot_table_probe':
coreboot_table.c:(.text+0x311): undefined reference tomemremap' /usr/bin/ld: coreboot_table.c:(.text+0x34e): undefined reference tomemunmap'/usr/bin/ld:drivers/firmware/google/memconsole-coreboot.o: in function `memconsole_probe':
memconsole-coreboot.c:(.text+0x12d): undefined reference tomemremap' /usr/bin/ld: memconsole-coreboot.c:(.text+0x17e): undefined reference todevm_memremap'/usr/bin/ld: memconsole-coreboot.c:(.text+0x191): undefined reference tomemunmap' /usr/bin/ld: drivers/firmware/google/vpd.o: in functionvpd_section_destroy.isra.0':
vpd.c:(.text+0x300): undefined reference to `memunmap'/usr/bin/ld:drivers/firmware/google/vpd.o: in function `vpd_section_init':
vpd.c:(.text+0x382): undefined reference to `memremap'/usr/bin/ld: vpd.c:(.text+0x459): undefined reference tomemunmap' /usr/bin/ld: drivers/firmware/google/vpd.o: in functionvpd_probe':
vpd.c:(.text+0x59d): undefined reference to `memremap'/usr/bin/ld: vpd.c:(.text+0x5d3): undefined reference to `memunmap'
collect2: error: ld returned 1 exit status
Quoted 4 lines
Signed-off-by David Gow <[email protected]>Acked-by anton ivanov <[email protected]>Acked-by Julius Werner <[email protected]>---
What commit id does this fix?
thanks,
greg k-h
_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um
Quoted 29 lines · Greg Kroah-Hartman
Quoted 22 lines · David Gow
The Google Coreboot implementation requires IOMEM functions (memmremap, memunmap,
devm_memremap), but does not specify this is itsKconfig. This results in build errors whenHAS_IOMEMis not set, such as on some UML configurations:
/usr/bin/ld:drivers/firmware/google/coreboot_table.o: in function `coreboot_table_probe':
coreboot_table.c:(.text+0x311): undefined reference tomemremap' /usr/bin/ld: coreboot_table.c:(.text+0x34e): undefined reference tomemunmap'/usr/bin/ld:drivers/firmware/google/memconsole-coreboot.o: in function `memconsole_probe':
memconsole-coreboot.c:(.text+0x12d): undefined reference tomemremap' /usr/bin/ld: memconsole-coreboot.c:(.text+0x17e): undefined reference todevm_memremap'/usr/bin/ld: memconsole-coreboot.c:(.text+0x191): undefined reference tomemunmap' /usr/bin/ld: drivers/firmware/google/vpd.o: in functionvpd_section_destroy.isra.0':
vpd.c:(.text+0x300): undefined reference to `memunmap'/usr/bin/ld:drivers/firmware/google/vpd.o: in function `vpd_section_init':
vpd.c:(.text+0x382): undefined reference to `memremap'/usr/bin/ld: vpd.c:(.text+0x459): undefined reference tomemunmap' /usr/bin/ld: drivers/firmware/google/vpd.o: in functionvpd_probe':
vpd.c:(.text+0x59d): undefined reference to `memremap'/usr/bin/ld: vpd.c:(.text+0x5d3): undefined reference to `memunmap'
collect2: error: ld returned 1 exit statusQuoted 4 lines
Signed-off-by David Gow <[email protected]>Acked-by anton ivanov <[email protected]>Acked-by Julius Werner <[email protected]>---
Quoted 5 lines
What commit id does this fix?
thanks,
greg k-h
As best I can tell, this[1] is the most sensible answer:
bus core")
However, I think the first actual HAS_IOMEM-dependent calls were introduced earlier, in "firmware: google memconsole: Add coreboot support"[2], it just (a) never caused a problem under UML due to the ACPI requirement, and (b) this fix won't apply particularly cleanly to anything earlier than [1] anyway.
-- David
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a28aad66da8bd19b249670d003bb9a698bdda397
[2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d384d6f43d1ec3f1225ab0275fd592c5980bd830
_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um