Skip to contentSkip to conversation

ARM: am3517-evm: Remove more non-DM legacy ethernet reset code

PATCH In review Adam Ford 3 participants 3 messages Feb 26, 2022 – Mar 14, 2022

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 ARM: am3517-evm: Remove more non-DM legacy ethernet reset code

The ethernet controller is DM compliant, and the device tree defines it. There is no need to manually handle pulling the ethernet out of reset.

board/logicpd/am3517evm/am3517evm.c +0 -8
index f014165928..e787441c74 100644
@@ -117,17 +117,10 @@ static void am3517_evm_musb_init(void)
  */
 int misc_init_r(void)
 {
-	u32 reset;
-
 	omap_die_id_display();
 
 	am3517_evm_musb_init();
 
-	/* ensure that the Ethernet module is out of reset */
-	reset = readl(AM3517_IP_SW_RESET);
-	reset &= (~CPGMACSS_SW_RST);
-	writel(reset, AM3517_IP_SW_RESET);
-
 	return 0;
 }
 
@@ -142,7 +135,6 @@ void set_muxconf_regs(void)
 	MUX_AM3517EVM();
 }
 
-
 #if defined(CONFIG_USB_ETHER) && defined(CONFIG_USB_MUSB_GADGET)
 int board_eth_init(struct bd_info *bis)
 {
Signature · 1 line
2.34.1
Tested-by on v1 1/1
#1 lore raw
Quoted 38 lines · Adam Ford

The ethernet controller is DM compliant, and the device tree defines it. There is no need to manually handle pulling the ethernet out of reset.

board/logicpd/am3517evm/am3517evm.c +0 -9
index f014165928..e787441c74 100644
@@ -117,17 +117,10 @@ static void am3517_evm_musb_init(void)
  */
 int misc_init_r(void)
 {
-       u32 reset;
-
        omap_die_id_display();
 
        am3517_evm_musb_init();
 
-       /* ensure that the Ethernet module is out of reset */
-       reset = readl(AM3517_IP_SW_RESET);
-       reset &= (~CPGMACSS_SW_RST);
-       writel(reset, AM3517_IP_SW_RESET);
-
        return 0;
 }
 
@@ -142,7 +135,6 @@ void set_muxconf_regs(void)
        MUX_AM3517EVM();
 }
 
-
 #if defined(CONFIG_USB_ETHER) && defined(CONFIG_USB_MUSB_GADGET)
 int board_eth_init(struct bd_info *bis)
 {
--
Quoted 3 lines

2.34.1

Ethernet continues to work on AM3517 Zoom eXperimenter.