Skip to contentSkip to conversation

qfw: Do not include tables.h on arm

PATCH In review Alexander Graf 2 participants 2 messages Feb 27, 2022 – Mar 12, 2022 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qfw: Do not include tables.h on arm

asm/tables.h does not exist on ARM and I did not need it to make the code compile successfully. Let's not include it there.

---

Maybe someone with more insight into the qfw code could tell me if we can remove the include altogether? :)

---
 drivers/misc/qfw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/qfw.c +1 -1
index 677841aac5..754bc6a603 100644
@@ -15,7 +15,7 @@
 #include <dm.h>
 #include <misc.h>
 #include <tables_csum.h>
-#ifdef CONFIG_GENERATE_ACPI_TABLE
+#if defined(CONFIG_GENERATE_ACPI_TABLE) && !defined(CONFIG_ARM)
 #include <asm/tables.h>
 #endif
 
Signature · 1 line
2.32.0
#1 lore raw

Hi Alex,

Quoted 6 lines · Alexander Graf

asm/tables.h does not exist on ARM and I did not need it to make the code compile successfully. Let's not include it there.

Quoted 7 lines

---

Maybe someone with more insight into the qfw code could tell me if we can remove the include altogether? :)

---
 drivers/misc/qfw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I'd rather have an empty file than another #ifdef.

Regards,
Simon