mm-fix-use-after-free-bug-when-mm-mmap-is-reused-after-being-freed.patch removed from -mm tree
The patch titled
Subject: mm: fix use-after-free bug when mm->mmap is reused after being freed
has been removed from the -mm tree. Its filename was
mm-fix-use-after-free-bug-when-mm-mmap-is-reused-after-being-freed.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Suren Baghdasaryan <[email protected]>
Subject: mm: fix use-after-free bug when mm->mmap is reused after being freed
oom reaping (__oom_reap_task_mm) relies on a 2 way synchronization with exit_mmap. First it relies on the mmap_lock to exclude from unlock path[1], page tables tear down (free_pgtables) and vma destruction. This alone is not sufficient because mm->mmap is never reset. For historical reasons[2] the lock is taken there is also MMF_OOM_SKIP set for oom victims before.
The oom reaper only ever looks at oom victims so the whole scheme works properly but process_mrelease can opearate on any task (with fatal signals pending) which doesn't really imply oom victims. That means that the MMF_OOM_SKIP part of the synchronization doesn't work and it can see a task after the whole address space has been demolished and traverse an already released mm->mmap list. This leads to use after free as properly caught up by KASAN report.
Fix the issue by reseting mm->mmap so that MMF_OOM_SKIP synchronization is not needed anymore. The MMF_OOM_SKIP is not removed from exit_mmap yet but it acts mostly as an optimization now.
[1] 27ae357fa82b ("mm, oom: fix concurrent munlock and oom reaper unmap, v3")
[2] 212925802454 ("mm: oom: let oom_reap_task and exit_mmap run concurrently")
---
mm/mmap.c | 1 + 1 file changed, 1 insertion(+)
mm/mmap.c renamed from mm/mmap.c~mm-fix-use-after-free-bug-when-mm-mmap-is-reused-after-being-freed +1 -0
@@ -3186,6 +3186,7 @@ void exit_mmap(struct mm_struct *mm) vma =remove_vma (vma);cond_resched (); } + mm->mmap =NULL ;mmap_write_unlock (mm);vm_unacct_memory (nr_accounted); }
_
Patches currently in -mm which might be from [email protected] are
mm-refactor-vm_area_struct-anon_vma_name-usage-code.patch mm-refactor-vm_area_struct-anon_vma_name-usage-code-v3.patch mm-prevent-vm_area_struct-anon_name-refcount-saturation.patch mm-fix-use-after-free-when-anon-vma-name-is-used-after-vma-is-freed.patch mm-count-time-in-drain_all_pages-during-direct-reclaim-as-memory-pressure.patch