net/mlx5: fix flex item flow handle size
PATCH 1/1 net/mlx5: fix flex item flow handle size
Reduce flex item flow handle size from 32 bits to 8 bits for each flow.
The patch will save memory in setups with millions of flows.
Fixes a23e9b6e3ee9 ("net/mlx5: handle flex item in flows")
Signed-off-by Gregory Etelson <[email protected]>
--- drivers/net/mlx5/mlx5_flow.h | 2 +- drivers/net/mlx5/mlx5_flow_dv.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/mlx5/mlx5_flow.h +1 -1
@@ -700,7 +700,6 @@ struct mlx5_flow_handle { uint32_t split_flow_id:27; /**< Sub flow unique match flow id. */ uint32_t is_meter_flow_id:1; /**< Indicate if flow_id is for meter. */ uint32_t fate_action:3; /**< Fate action type. */ -uint32_t flex_item;/**< referenced Flex Item bitmask. */ union {uint32_t rix_hrxq;/**< Hash Rx queue object index. */ uint32_t rix_jump;/**< Index to the jump action resource. */
@@ -716,6 +715,7 @@ struct mlx5_flow_handle {#if defined(HAVE_IBV_FLOW_DV_SUPPORT ) || !defined(HAVE_INFINIBAND_VERBS_H )struct mlx5_flow_handle_dv dvh;#endif +uint8_t flex_item;/**< referenced Flex Item bitmask. */ } __rte_packed;/*
drivers/net/mlx5/mlx5_flow_dv.c +2 -2
@@ -10276,7 +10276,7 @@ flow_dv_translate_item_flex(struct rte_eth_dev *dev, void *matcher, void *key,/* Don't count both inner and outer flex items in one rule. */ if (mlx5_flex_acquire_index (dev, spec->handle, true) != index)MLX5_ASSERT (false); - dev_flow->handle->flex_item |=RTE_BIT32 (index); + dev_flow->handle->flex_item |= (uint8_t )RTE_BIT32 (index); }mlx5_flex_flow_translate_item (dev, matcher, key, item, is_inner); }
@@ -14627,7 +14627,7 @@ flow_dv_destroy(struct rte_eth_dev *dev, struct rte_flow *flow)int index =rte_bsf32 (dev_handle->flex_item);mlx5_flex_release_index (dev, index); - dev_handle->flex_item &= ~RTE_BIT32 (index); + dev_handle->flex_item &= ~(uint8_t )RTE_BIT32 (index); }if (dev_handle->dvh.matcher)flow_dv_matcher_release (dev, dev_handle);
Signature · 1 line
2.34.1
Hi
Quoted 9 lines
-----Original Message-----
From: Gregory Etelson <[email protected]>
Sent: Monday, February 28, 2022 12:01 PM
To: [email protected]
Cc: Gregory Etelson <[email protected]>; Matan Azrad <[email protected]>; Raslan Darawsheh <[email protected]>; [email protected]; Slava Ovsiienko <[email protected]>
Subject: [PATCH] net/mlx5: fix flex item flow handle size
Quoted 8 lines
Reduce flex item flow handle size from 32 bits to 8 bits for each flow. The patch will save memory in setups with millions of flows.
Fixes a23e9b6e3ee9 ("net/mlx5: handle flex item in flows")Signed-off-by Gregory Etelson <[email protected]>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh