Skip to contentSkip to conversation

SoC: polarfire: fix build warning

PATCH In review Arnd Bergmann 3 participants 4 messages Feb 28, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SoC: polarfire: fix build warning

From: Arnd Bergmann <[email protected]>

The newly added driver causes a build warning because of a missing prototype:

drivers/soc/microchip/mpfs-sys-controller.c:76:6: warning: no previous prototype for function 'mpfs_sys_controller_put' [-Wmissing-prototypes]

Fixes d0054a470c33 ("soc: add microchip polarfire soc system controller")

---
I've applied this to the arm/drivers branch as a fixup

 include/soc/microchip/mpfs.h | 2 ++
 1 file changed, 2 insertions(+)
include/soc/microchip/mpfs.h +2 -0
index 6466515262bd..969b5239521e 100644
@@ -38,6 +38,8 @@ int mpfs_blocking_transaction(struct mpfs_sys_controller *mpfs_client, struct mp
 
 struct mpfs_sys_controller *mpfs_sys_controller_get(struct device *dev);
 
+void mpfs_sys_controller_put(void *data);
+
 #endif /* if IS_ENABLED(CONFIG_POLARFIRE_SOC_SYS_CTRL) */
 
 #endif /* __SOC_MPFS_H__ */
Signature · 1 line
2.29.2
#1 lore raw

I had sent a fix for the build warning on saturday morning - but I guess you missed it.

Thanks for fixing it anyway :)
Conor.

Quoted 30 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The newly added driver causes a build warning because of a missing prototype:

drivers/soc/microchip/mpfs-sys-controller.c:76:6: warning: no previous prototype for function 'mpfs_sys_controller_put' [-Wmissing-prototypes]

Fixes d0054a470c33 ("soc: add microchip polarfire soc system controller")

---
I've applied this to the arm/drivers branch as a fixup

  include/soc/microchip/mpfs.h | 2 ++
  1 file changed, 2 insertions(+)
include/soc/microchip/mpfs.h +2 -0
index 6466515262bd..969b5239521e 100644
@@ -38,6 +38,8 @@ int mpfs_blocking_transaction(struct mpfs_sys_controller *mpfs_client, struct mp
 
  struct mpfs_sys_controller *mpfs_sys_controller_get(struct device *dev);
 
+void mpfs_sys_controller_put(void *data);
+
  #endif /* if IS_ENABLED(CONFIG_POLARFIRE_SOC_SYS_CTRL) */
 
  #endif /* __SOC_MPFS_H__ */
#2 lore raw
Quoted 5 lines · Conor Dooley

I had sent a fix for the build warning on saturday morning - but I guess you missed it.

Thanks for fixing it anyway :)

Thank you for your quick reply. I had indeed missed that fix. You did the right thing here by sending it to Nicolas, but he hasn't had a chance to forward it to [email protected] yet, so it was not visible in patchwork.

As it turns out, your patch is correct and mine was wrong anyway, so I have now replaced my patch with yours.

Nicolas, I hope that doesn't cause you extra work. If you have picked it up into your tree, you can drop it again from there.

Arnd

#3 lore raw
Quoted 13 lines · Arnd Bergmann

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 5 lines · Conor Dooley

I had sent a fix for the build warning on saturday morning - but I guess you missed it.

Thanks for fixing it anyway :)

Thank you for your quick reply. I had indeed missed that fix. You did the right thing here by sending it to Nicolas, but he hasn't had a chance to forward it to [email protected] yet, so it was not visible in patchwork.

Quoted 5 lines

As it turns out, your patch is correct and mine was wrong anyway, so I have now replaced my patch with yours.

Nicolas, I hope that doesn't cause you extra work. If you have picked it up into your tree, you can drop it again from there.

No problem on my side: I was planning to add it to another PR to you but it's far easier if you already took it directly.

Thanks Arnd, best regards,
Nicolas

Signature · 1 line
Nicolas Ferre