Skip to contentSkip to conversation

libical: Pass TOOLCHAIN_OPTIONS via CFLAGS

PATCH In review Khem Raj 3 participants 5 messages Mar 1, 2022 – Mar 4, 2022

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 libical: Pass TOOLCHAIN_OPTIONS via CFLAGS

This ensures that right sysroot is used during build, otherwise we see warnings in build about using wrong sysroot and it fails explicitly with clang

x86_64-yoe-linux-ld: warning: library search path "/usr/lib/gcc/x86_6 4-pc-linux-gnu/11.2.0/../../../../lib64" is unsafe for cross-compilation

x86_64-yoe-linux-ld: cannot find /usr/lib/clang/14.0.0/lib/linux/libc lang_rt.builtins-x86_64.a: No such file or directory

---
 meta/recipes-support/libical/libical_3.0.14.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/libical/libical_3.0.14.bb +2 -0
index 717eb11e125..879ad8ed595 100644
@@ -18,6 +18,8 @@ UPSTREAM_CHECK_URI = "https://github.com/libical/libical/releases"
 
 inherit cmake pkgconfig gobject-introspection vala
 
+CFLAGS += "${TOOLCHAIN_OPTIONS}"
+
 DEPENDS += "libical-native"
 
 PACKAGECONFIG ??= "icu glib"
Signature · 1 line
2.35.1
#1 lore raw
Quoted 20 lines · Khem Raj

This ensures that right sysroot is used during build, otherwise we see warnings in build about using wrong sysroot and it fails explicitly with clang

x86_64-yoe-linux-ld: warning: library search path "/usr/lib/gcc/x86_6 4-pc-linux-gnu/11.2.0/../../../../lib64" is unsafe for cross-compilation

x86_64-yoe-linux-ld: cannot find /usr/lib/clang/14.0.0/lib/linux/libc lang_rt.builtins-x86_64.a: No such file or directory

---
 meta/recipes-support/libical/libical_3.0.14.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/libical/libical_3.0.14.bb +0 -0
index 717eb11e125..879ad8ed595 100644

meta/recipes-support/libical/libical_3.0.14.bb UPSTREAM_CHECK_URI = "https://github.com/libical/libical/releases" · line 25

Quoted 8 lines
meta/recipes-support/libical/libical_3.0.14.bb +2 -0
@@ -18,6 +18,8 @@ UPSTREAM_CHECK_URI = "https://github.com/libical/libical/releases"
 
 inherit cmake pkgconfig gobject-introspection vala
 
+CFLAGS += "${TOOLCHAIN_OPTIONS}"
+
 DEPENDS += "libical-native"
 
 PACKAGECONFIG ??= "icu glib"

I gave this (and the cmake patch) a go and whilst it mostly worked, it doesn't work on arm (qemuarm or beaglebone):

https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/4855
https://autobuilder.yoctoproject.org/typhoon/#/builders/106/builds/3774
https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/4829
https://autobuilder.yoctoproject.org/typhoon/#/builders/110/builds/3715
https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/4825

Any ideas?

Cheers,

Richard

author
#2 lore raw
Quoted 35 lines · Richard Purdie
Quoted 20 lines · Khem Raj

This ensures that right sysroot is used during build, otherwise we see warnings in build about using wrong sysroot and it fails explicitly with clang

x86_64-yoe-linux-ld: warning: library search path "/usr/lib/gcc/x86_6 4-pc-linux-gnu/11.2.0/../../../../lib64" is unsafe for cross-compilation

x86_64-yoe-linux-ld: cannot find /usr/lib/clang/14.0.0/lib/linux/libc lang_rt.builtins-x86_64.a: No such file or directory

---
 meta/recipes-support/libical/libical_3.0.14.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/libical/libical_3.0.14.bb +0 -0
index 717eb11e125..879ad8ed595 100644

meta/recipes-support/libical/libical_3.0.14.bb UPSTREAM_CHECK_URI = "https://github.com/libical/libical/releases" · line 25

Quoted 8 lines
meta/recipes-support/libical/libical_3.0.14.bb +2 -0
@@ -18,6 +18,8 @@ UPSTREAM_CHECK_URI = "https://github.com/libical/libical/releases"
 
 inherit cmake pkgconfig gobject-introspection vala
 
+CFLAGS += "${TOOLCHAIN_OPTIONS}"
+
 DEPENDS += "libical-native"
 
 PACKAGECONFIG ??= "icu glib"

I gave this (and the cmake patch) a go and whilst it mostly worked, it doesn't work on arm (qemuarm or beaglebone):

Quoted 7 lines

https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/4855
https://autobuilder.yoctoproject.org/typhoon/#/builders/106/builds/3774
https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/4829
https://autobuilder.yoctoproject.org/typhoon/#/builders/110/builds/3715
https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/4825

Any ideas?

I think we need to check why CC is being passed here from env explicitly when invoking g-ir-scanner-wrapper, which is bare compiler without TOOLCHAIN_OPTIONS and this cmd seems to not respect CFLAGS

| [95/112] cd /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/src/libical
&& /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/recipe-sysroot-native/usr/bin/cmake
-E env "CC='/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/recipe-sysroot-native/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-gcc'" /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/recipe-sysroot/usr/bin/g-ir-scanner-wrapper --c-include=libical/ical.h --pkg-export libical
--identifier-prefix=ical
-I/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/libical-3.0.14/src/libical /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/src/libical/ical.h
--namespace=ICal --nsversion=3.0 --no-libtool --library=ical
--include=GObject-2.0
-L/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/lib
--output /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/src/libical/ICal-3.0.gir
--accept-unprefixed

I will take a look later today.

btw. is this the only failure left ?

Quoted 5 lines

Cheers,

Richard

#3 lore raw
Quoted 64 lines · Khem Raj
Quoted 35 lines · Richard Purdie
Quoted 20 lines · Khem Raj

This ensures that right sysroot is used during build, otherwise we see warnings in build about using wrong sysroot and it fails explicitly with clang

x86_64-yoe-linux-ld: warning: library search path "/usr/lib/gcc/x86_6 4-pc-linux-gnu/11.2.0/../../../../lib64" is unsafe for cross-compilation

x86_64-yoe-linux-ld: cannot find /usr/lib/clang/14.0.0/lib/linux/libc lang_rt.builtins-x86_64.a: No such file or directory

---
 meta/recipes-support/libical/libical_3.0.14.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-support/libical/libical_3.0.14.bb +0 -0
index 717eb11e125..879ad8ed595 100644

meta/recipes-support/libical/libical_3.0.14.bb UPSTREAM_CHECK_URI = "https://github.com/libical/libical/releases" · line 25

Quoted 8 lines
meta/recipes-support/libical/libical_3.0.14.bb +2 -0
@@ -18,6 +18,8 @@ UPSTREAM_CHECK_URI = "https://github.com/libical/libical/releases"
 
 inherit cmake pkgconfig gobject-introspection vala
 
+CFLAGS += "${TOOLCHAIN_OPTIONS}"
+
 DEPENDS += "libical-native"
 
 PACKAGECONFIG ??= "icu glib"

I gave this (and the cmake patch) a go and whilst it mostly worked, it doesn't work on arm (qemuarm or beaglebone):

Quoted 7 lines

https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/4855
https://autobuilder.yoctoproject.org/typhoon/#/builders/106/builds/3774
https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/4829
https://autobuilder.yoctoproject.org/typhoon/#/builders/110/builds/3715
https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/4825

Any ideas?

I think we need to check why CC is being passed here from env explicitly when invoking g-ir-scanner-wrapper, which is bare compiler without TOOLCHAIN_OPTIONS and this cmd seems to not respect CFLAGS

Quoted 1 line

[95/112] cd /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/src/libical

&& /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/recipe-sysroot-native/usr/bin/cmake
-E env "CC='/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/recipe-sysroot-native/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-gcc'" /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/recipe-sysroot/usr/bin/g-ir-scanner-wrapper --c-include=libical/ical.h --pkg-export libical
--identifier-prefix=ical
-I/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/libical-3.0.14/src/libical /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/src/libical/ical.h
--namespace=ICal --nsversion=3.0 --no-libtool --library=ical
--include=GObject-2.0
-L/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/lib
--output /home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/src/libical/ICal-3.0.gir
--accept-unprefixed

Quoted 1 line

I will take a look later today.

Thanks, I'll be asleep shortly I hope! :)

Quoted 3 lines

btw. is this the only failure left ?

For that patch in core, yes, I think so.

Cheers,

Richard

Quoted 1 line
#4 lore raw

Richard Purdie <[email protected]> escreveu no dia quinta, 3/03/2022 à(s) 23:15:

Quoted 42 lines · Khem Raj
Quoted 5 lines
Quoted 3 lines · Richard Purdie
Quoted 1 line · Khem Raj

This ensures that right sysroot is used during build, otherwise we

see

Quoted 1 line
Quoted 1 line
Quoted 1 line

warnings in build about using wrong sysroot and it fails explicitly

with

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

clang

x86_64-yoe-linux-ld: warning: library search path "/usr/lib/gcc/x86_6 4-pc-linux-gnu/11.2.0/../../../../lib64" is unsafe for

cross-compilation

Quoted 10 lines
Quoted 10 lines

Review

Quoted 10 lines

x86_64-yoe-linux-ld: cannot find /usr/lib/clang/14.0.0/lib/linux/libc lang_rt.builtins-x86_64.a: No such file or directory

---
 meta/recipes-support/libical/libical_3.0.14.bb | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/meta/recipes-support/libical/libical_3.0.14.bb

Quoted 4 lines
Quoted 4 lines

meta/recipes-support/libical/libical_3.0.14.bb UPSTREAM_CHECK_URI = "

Quoted 4 lines

index 717eb11e125..879ad8ed595 100644

meta/recipes-support/libical/libical_3.0.14.bb +0 -0
@@ -18,6 +18,8 @@ UPSTREAM_CHECK_URI = "

https://github.com/libical/libical/releases"

Quoted 11 lines
Quoted 11 lines

meta/recipes-support/libical/libical_3.0.14.bb UPSTREAM_CHECK_URI = "https://github.com/libical/libical/releases" · line 25

Quoted 8 lines
meta/recipes-support/libical/libical_3.0.14.bb +2 -0
 inherit cmake pkgconfig gobject-introspection vala
 
+CFLAGS += "${TOOLCHAIN_OPTIONS}"
+
 DEPENDS += "libical-native"
 
 PACKAGECONFIG ??= "icu glib"

I gave this (and the cmake patch) a go and whilst it mostly worked, it

doesn't

Quoted 17 lines
Quoted 4 lines
Quoted 4 lines

work on arm (qemuarm or beaglebone):

https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/4855

https://autobuilder.yoctoproject.org/typhoon/#/builders/106/builds/3774

Quoted 2 lines
Quoted 2 lines

https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/4829

https://autobuilder.yoctoproject.org/typhoon/#/builders/110/builds/3715

Quoted 8 lines
Quoted 3 lines

https://autobuilder.yoctoproject.org/typhoon/#/builders/47/builds/4825

Any ideas?

I think we need to check why CC is being passed here from env explicitly when invoking g-ir-scanner-wrapper, which is bare compiler without TOOLCHAIN_OPTIONS and this cmd seems to not respect CFLAGS

I will take a look in the weekend.

Jose

Quoted 40 lines
Quoted 2 lines
Quoted 2 lines

[95/112] cd

/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/src/libical

Quoted 1 line

&&

/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/recipe-sysroot-native/usr/bin/cmake

Quoted 1 line

-E env

"CC='/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/recipe-sysroot-native/usr/bin/arm-poky-linux-gnueabi/arm-poky-linux-gnueabi-gcc'"

Quoted 1 line

/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/recipe-sysroot/usr/bin/g-ir-scanner-wrapper

Quoted 3 lines

--c-include=libical/ical.h --pkg-export libical
--identifier-prefix=ical

-I/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/libical-3.0.14/src/libical

Quoted 1 line

/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/src/libical/ical.h

Quoted 3 lines

--namespace=ICal --nsversion=3.0 --no-libtool --library=ical --include=GObject-2.0

-L/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/lib

Quoted 1 line

--output

/home/pokybuild/yocto-worker/beaglebone/build/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/libical/3.0.14-r0/build/src/libical/ICal-3.0.gir

Quoted 3 lines

--accept-unprefixed

I will take a look later today.

Thanks, I'll be asleep shortly I hope! :)

Quoted 3 lines

btw. is this the only failure left ?

For that patch in core, yes, I think so.

Cheers,

Richard

Quoted 1 line
Signature · 3 lines
Best regards,

José Quaresma