Skip to contentSkip to conversation

drm/amdgpu/discovery: add a comment about ip_discovery firmware

PATCH New Alex Deucher 1 participant 1 message Mar 1, 2022

Subsystems (2)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amdgpu/discovery: add a comment about ip_discovery firmware

The firmware is optional and only used as a fallback when the IP discovery table is not available (e.g., during asic bring up). Once the chip goes into production, the table will always be available on the part itself.

Unfortunately, there is no way to mark a firmware as optional.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +7 -0
index e4fcbb385a62..31d86d083968 100644
@@ -67,6 +67,13 @@
 #include "smuio_v11_0_6.h"
 #include "smuio_v13_0.h"
 
+/* This firmware is optional, but there is no way to
+ * specify a firmware file as optional.  It is only
+ * used as a fallback when the IP discovery table
+ * is not available for some reason (e.g., during
+ * bring up).  Once the product is in production
+ * the IP discovery table is shipped on the part itself.
+ */
 #define FIRMWARE_IP_DISCOVERY "amdgpu/ip_discovery.bin"
 MODULE_FIRMWARE(FIRMWARE_IP_DISCOVERY);
 
Signature · 1 line
2.35.1