Skip to contentSkip to conversation

gpu/cuda: missing slash in libcuda.so path

PATCH In review [email protected] 3 participants 5 messages Mar 1, 2022 – Mar 8, 2022 DRM drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu/cuda: missing slash in libcuda.so path

From: Elena Agostini <[email protected]>

---
 drivers/gpu/cuda/cuda.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/cuda/cuda.c +1 -1
index 2f8c4684ce..8505d39d64 100644
@@ -169,7 +169,7 @@ cuda_loader(void)
 	if (getenv("CUDA_PATH_L") == NULL)
 		snprintf(cuda_path, 1024, "%s", "libcuda.so");
 	else
-		snprintf(cuda_path, 1024, "%s%s", getenv("CUDA_PATH_L"), "libcuda.so");
+		snprintf(cuda_path, 1024, "%s/%s", getenv("CUDA_PATH_L"), "libcuda.so");
 
 	cudalib = dlopen(cuda_path, RTLD_LAZY);
 	if (cudalib == NULL) {
Signature · 1 line
2.17.1
#2 lore raw

Hi Elena,

Quoted 13 lines · Thomas Monjalon

01/03/2022 20:42, [email protected]:

Quoted 3 lines

From: Elena Agostini <[email protected]>

Applied with this title and commit log:

gpu/cuda: fix dependency loading path

A slash was missing in libcuda.so path for dlopen.

This seems like a good candidate for backport to LTS, so I added it to the queue for 21.11.1.

Please let me know if you do *not* want it backported 21.11.1.

thanks,
Kevin.

#3 lore raw

Yes please

Thanks
EA

From: Kevin Traynor <[email protected]>
Date: Tuesday, 8 March 2022 at 15:24
To: Elena Agostini <[email protected]>
Cc: [email protected] <[email protected]>, NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>
Subject: Re: [PATCH] gpu/cuda: missing slash in libcuda.so path
External email: Use caution opening links or attachments

Hi Elena,

Quoted 13 lines · Thomas Monjalon

01/03/2022 20:42, [email protected]:

Quoted 3 lines

From: Elena Agostini <[email protected]>

Applied with this title and commit log:

gpu/cuda: fix dependency loading path

A slash was missing in libcuda.so path for dlopen.

This seems like a good candidate for backport to LTS, so I added it to the queue for 21.11.1.

Please let me know if you do *not* want it backported 21.11.1.

thanks,
Kevin.

#4 lore raw

08/03/2022 15:24, Elena Agostini:

Quoted 24 lines

Yes please

Thanks
EA

From: Kevin Traynor <[email protected]>

Hi Elena,

Quoted 13 lines · Thomas Monjalon

01/03/2022 20:42, [email protected]:

Quoted 3 lines

From: Elena Agostini <[email protected]>

Applied with this title and commit log:

gpu/cuda: fix dependency loading path

A slash was missing in libcuda.so path for dlopen.

Quoted 7 lines

This seems like a good candidate for backport to LTS, so I added it to the queue for 21.11.1.

Please let me know if you do *not* want it backported 21.11.1.

thanks,
Kevin.

I forgot the Fixes: line and Cc: [email protected]

Elena, please remind to add such lines next time,
it makes the process more automatic.