Skip to contentSkip to conversation

dt-bindings: display/msm: Drop bogus interrupt flags cell on MDSS nodes

PATCH In review Rob Herring 2 participants 2 messages Mar 1, 2022

Subsystems (5)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: display/msm: Drop bogus interrupt flags cell on MDSS nodes

The MDSS interrupt provider is a single cell, so specifying interrupt flags on the consumers is incorrect.

---
 .../devicetree/bindings/display/msm/dpu-msm8998.yaml          | 4 ++--
 .../devicetree/bindings/display/msm/dpu-qcm2290.yaml          | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml +2 -2
index 167bc48748d7..2df64afb76e6 100644
@@ -155,7 +155,7 @@ examples:
     #include <dt-bindings/interrupt-controller/arm-gic.h>
     #include <dt-bindings/power/qcom-rpmpd.h>
 
-    display-subsystem@c900000 {
+    mdss: display-subsystem@c900000 {
         compatible = "qcom,msm8998-mdss";
         reg = <0x0c900000 0x1000>;
         reg-names = "mdss";
@@ -192,7 +192,7 @@ examples:
             clock-names = "iface", "bus", "mnoc", "core", "vsync";
 
             interrupt-parent = <&mdss>;
-            interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
+            interrupts = <0>;
             operating-points-v2 = <&mdp_opp_table>;
             power-domains = <&rpmpd MSM8998_VDDMX>;
 
Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml +1 -1
index 8766b13f0c46..28617bc1d2ff 100644
@@ -197,7 +197,7 @@ examples:
                 power-domains = <&rpmpd QCM2290_VDDCX>;
 
                 interrupt-parent = <&mdss>;
-                interrupts = <0 IRQ_TYPE_NONE>;
+                interrupts = <0>;
 
                 ports {
                         #address-cells = <1>;
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Rob Herring

The MDSS interrupt provider is a single cell, so specifying interrupt flags on the consumers is incorrect.

Quoted 43 lines
---
 .../devicetree/bindings/display/msm/dpu-msm8998.yaml          | 4 ++--
 .../devicetree/bindings/display/msm/dpu-qcm2290.yaml          | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml +2 -2
index 167bc48748d7..2df64afb76e6 100644
@@ -155,7 +155,7 @@ examples:
     #include <dt-bindings/interrupt-controller/arm-gic.h>
     #include <dt-bindings/power/qcom-rpmpd.h>
 
-    display-subsystem@c900000 {
+    mdss: display-subsystem@c900000 {
         compatible = "qcom,msm8998-mdss";
         reg = <0x0c900000 0x1000>;
         reg-names = "mdss";
@@ -192,7 +192,7 @@ examples:
             clock-names = "iface", "bus", "mnoc", "core", "vsync";
 
             interrupt-parent = <&mdss>;
-            interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
+            interrupts = <0>;
             operating-points-v2 = <&mdp_opp_table>;
             power-domains = <&rpmpd MSM8998_VDDMX>;
 
Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml +1 -2
index 8766b13f0c46..28617bc1d2ff 100644
@@ -197,7 +197,7 @@ examples:
                 power-domains = <&rpmpd QCM2290_VDDCX>;
 
                 interrupt-parent = <&mdss>;
-                interrupts = <0 IRQ_TYPE_NONE>;
+                interrupts = <0>;
 
                 ports {
                         #address-cells = <1>;
--

2.32.0

Signature · 2 lines
With best wishes
Dmitry