Skip to contentSkip to conversation

python3-pyscaffold: fix wheel build and license

PATCH Superseded Justin Bronder 3 participants 3 messages Mar 1, 2022 – Mar 2, 2022

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 python3-pyscaffold: fix wheel build and license

Without python3-setuptools-scm-native, the version on the generated wheel is 0.0.0, not ${PV} as expected which causes pip_install_wheel_do_install to fail to find the wheel.

Consulting the LICENSE.txt distributed with the source, the template files under pyscaffold.templates, which are installed as part of this recipe, are licensed as BSD-0-Clause

---
 .../recipes-devtools/python/python3-pyscaffold_4.1.4.bb     | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
meta-python/recipes-devtools/python/python3-pyscaffold_4.1.4.bb +4 -2
index 7e5599e4aa..f58fc5e9aa 100644
@@ -5,8 +5,8 @@ used to create template Projects."
 
 HOMEPAGE = "https://github.com/pyscaffold/pyscaffold"
 SECTION = "devel/python"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://PKG-INFO;beginline=8;endline=8;md5=8227180126797a0148f94f483f3e1489"
+LICENSE = "BSD-0-Clause & MIT"
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=14a49c74a1d91829908ac756c07e6b91"
 
 inherit pypi setuptools3
 
@@ -16,6 +16,8 @@ SRC_URI[sha256sum] = "46a2bbdf255ba2efc6c56ae1428249b61d56c4a3e54ef3db0d05fa9779
 
 BBCLASSEXTEND = "native nativesdk"
 
+DEPENDS += "python3-setuptools-scm-native"
+
 RDEPENDS:${PN} += " \
 	python3-email \
 	python3-compression \
Signature · 1 line
2.35.1
#1 lore raw
Quoted 28 lines

-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Justin Bronder
Sent: den 1 mars 2022 23:16
To: [email protected]
Subject: [oe] [meta-python][PATCH] python3-pyscaffold: fix wheel build and license

Without python3-setuptools-scm-native, the version on the generated wheel is 0.0.0, not ${PV} as expected which causes pip_install_wheel_do_install to fail to find the wheel.

Consulting the LICENSE.txt distributed with the source, the template files under pyscaffold.templates, which are installed as part of this recipe, are licensed as BSD-0-Clause

---
 .../recipes-devtools/python/python3-pyscaffold_4.1.4.bb     | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

pyscaffold_4.1.4.bb b/meta-python/recipes-devtools/python/python3- pyscaffold_4.1.4.bb
index 7e5599e4aa..f58fc5e9aa 100644

meta-python/recipes-devtools/python/python3-pyscaffold_4.1.4.bb used to create template Projects." · line 8

Quoted 6 lines
meta-python/recipes-devtools/python/python3-pyscaffold_4.1.4.bb +1 -2
@@ -5,8 +5,8 @@ used to create template Projects."
 
 HOMEPAGE = "https://github.com/pyscaffold/pyscaffold"
 SECTION = "devel/python"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://PKG-INFO;beginline=8;endline=8;md5=8227180126797a0148f94f483f3e1489"
+LICENSE = "BSD-0-Clause & MIT"

The official SPDX identifier is (weirdly enough) "0BSD".

meta-python/recipes-devtools/python/python3-pyscaffold_4.1.4.bb SRC_URI[sha256sum] = "46a2bbdf255ba2efc6c56ae1428249b61d56c4a3e54ef3db0d05fa9779 · line 19

Quoted 9 lines
meta-python/recipes-devtools/python/python3-pyscaffold_4.1.4.bb +2 -0
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=14a49c74a1d91829908ac756c07e6b91"
 
 inherit pypi setuptools3
 
@@ -16,6 +16,8 @@ SRC_URI[sha256sum] = "46a2bbdf255ba2efc6c56ae1428249b61d56c4a3e54ef3db0d05fa9779
 
 BBCLASSEXTEND = "native nativesdk"
 
+DEPENDS += "python3-setuptools-scm-native"

Build dependencies typically go near the start of the recipe, i.e., between LIC_FILES_CHKSUM and inherit.

Quoted 6 lines
meta-python/recipes-devtools/python/python3-pyscaffold_4.1.4.bb +1 -1
+
 RDEPENDS:${PN} += " \
 	python3-email \
 	python3-compression \
--

2.35.1

//Peter

#2 lore raw
Quoted 30 lines · Peter Kjellerstedt
Quoted 30 lines

-----Original Message-----
From: [email protected] <openembedded- [email protected]> On Behalf Of Justin Bronder
Sent: den 1 mars 2022 23:16
To: [email protected]
Subject: [oe] [meta-python][PATCH] python3-pyscaffold: fix wheel build and license

Without python3-setuptools-scm-native, the version on the generated wheel is 0.0.0, not ${PV} as expected which causes pip_install_wheel_do_install to fail to find the wheel.

Consulting the LICENSE.txt distributed with the source, the template files under pyscaffold.templates, which are installed as part of this recipe, are licensed as BSD-0-Clause

---
 .../recipes-devtools/python/python3-pyscaffold_4.1.4.bb     | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

pyscaffold_4.1.4.bb b/meta-python/recipes-devtools/python/python3- pyscaffold_4.1.4.bb
index 7e5599e4aa..f58fc5e9aa 100644

meta-python/recipes-devtools/python/python3-pyscaffold_4.1.4.bb +0 -0
@@ -5,8 +5,8 @@ used to create template Projects."
 
Quoted 7 lines

meta-python/recipes-devtools/python/python3-pyscaffold_4.1.4.bb used to create template Projects." · line 8

Quoted 5 lines
meta-python/recipes-devtools/python/python3-pyscaffold_4.1.4.bb +1 -2
 HOMEPAGE = "https://github.com/pyscaffold/pyscaffold"
 SECTION = "devel/python"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://PKG-INFO;beginline=8;endline=8;md5=8227180126797a0148f94f483f3e1489"
+LICENSE = "BSD-0-Clause & MIT"

The official SPDX identifier is (weirdly enough) "0BSD".

Right, we need to run the conversion script on meta-openembedded layers but perhaps after python/wheel stuff
settles out. Its better to address it here atleast for this recipe.

Quoted 5 lines
Quoted 5 lines
meta-python/recipes-devtools/python/python3-pyscaffold_4.1.4.bb +1 -0
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=14a49c74a1d91829908ac756c07e6b91"
 
 inherit pypi setuptools3
 
Quoted 8 lines

meta-python/recipes-devtools/python/python3-pyscaffold_4.1.4.bb SRC_URI[sha256sum] = "46a2bbdf255ba2efc6c56ae1428249b61d56c4a3e54ef3db0d05fa9779 · line 19

Quoted 5 lines
meta-python/recipes-devtools/python/python3-pyscaffold_4.1.4.bb +1 -0
@@ -16,6 +16,8 @@ SRC_URI[sha256sum] = "46a2bbdf255ba2efc6c56ae1428249b61d56c4a3e54ef3db0d05fa9779
 
 BBCLASSEXTEND = "native nativesdk"
 
+DEPENDS += "python3-setuptools-scm-native"

Build dependencies typically go near the start of the recipe, i.e., between LIC_FILES_CHKSUM and inherit.

yeah oe-stylize helps a bit with these kind of issues.

Quoted 19 lines
Quoted 7 lines
meta-python/recipes-devtools/python/python3-pyscaffold_4.1.4.bb +1 -1
+
 RDEPENDS:${PN} += " \
      python3-email \
      python3-compression \
--

2.35.1

//Peter

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#95689): https://lists.openembedded.org/g/openembedded-devel/message/95689
Mute This Topic: https://lists.openembedded.org/mt/89489231/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-