Skip to contentSkip to conversation

goldfish_pipe: Use platform_get_irq() to get the interrupt

PATCH New sujiaxun 1 participant 1 message Mar 2, 2022

lore
Share & tools
lore

sujiaxun

author
#0 lore raw

PATCH 1/1 goldfish_pipe: Use platform_get_irq() to get the interrupt

platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static allocation of IRQ resources in DT core code, this causes an issue when using hierarchical interrupt domains using "interrupts" property in the node as this bypassed the hierarchical setup and messed up the irq chaining.

In preparation for removal of static setup of IRQ resource from DT core code use platform_get_irq().

---
 drivers/platform/goldfish/goldfish_pipe.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/platform/goldfish/goldfish_pipe.c +2 -4
index b67539f9848c..0256f76dfe5d 100644
@@ -896,12 +896,10 @@ static int goldfish_pipe_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-	if (!r)
+	dev->irq = platform_get_irq(pdev, 0);
+	if (dev->irq < 0)
 		return -EINVAL;
 
-	dev->irq = r->start;
-
 	/*
 	 * Exchange the versions with the host device
 	 *

--
2.20.1