vm- and vma cleanups
Subsystems (3)
v2 cover vm- and vma cleanups
The first patch of the series addresses a vm open count bug by removing the vm open count.
The second patch removes the vma refcount that is no longer needed; the vma is kept a live by taking the vm refcount and object lock.
Finally the last patch removes some unnecessary code. There should be no functional changes.
Thomas Hellström (3):
drm/i915: Remove the vm open count
drm/i915: Remove the vma refcount
drm/i915/gem: Remove some unnecessary code
drivers/gpu/drm/i915/display/intel_dpt.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_context.c | 29 ++----- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 ++ .../gpu/drm/i915/gem/selftests/mock_context.c | 5 +- drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 30 +++---- drivers/gpu/drm/i915/gt/intel_gtt.c | 54 ++++++++---- drivers/gpu/drm/i915/gt/intel_gtt.h | 56 ++++-------- drivers/gpu/drm/i915/gt/selftest_execlists.c | 86 +++++++++---------- drivers/gpu/drm/i915/i915_gem.c | 55 ++++++------ drivers/gpu/drm/i915/i915_vma.c | 69 +++++++++------ drivers/gpu/drm/i915/i915_vma.h | 14 --- drivers/gpu/drm/i915/i915_vma_resource.c | 2 +- drivers/gpu/drm/i915/i915_vma_resource.h | 6 ++ drivers/gpu/drm/i915/i915_vma_types.h | 8 +- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +- 16 files changed, 216 insertions(+), 212 deletions(-)
Signature · 1 line
2.34.1
PATCH v2 1/3 drm/i915: Remove the vm open count
vms are not getting properly closed. Rather than fixing that, Remove the vm open count and instead rely on the vm refcount.
The vm open count existed solely to break the strong references the vmas had on the vms. Now instead make those references weak and ensure vmas are destroyed when the vm is destroyed.
Unfortunately if the vm destructor and the object destructor both wants to destroy a vma, that may lead to a race in that the vm destructor just unbinds the vma and leaves the actual vma destruction to the object destructor. However in order for the object destructor to ensure the vma is unbound it needs to grab the vm mutex. In order to keep the vm mutex alive until the object destructor is done with it, somewhat hackishly grab a vm_resv refcount that is released late in the vma destruction process, when the vm mutex is no longer needed.
v2: Address review-comments from Niranjana
- Clarify that the struct i915_address_space::skip_pte_rewrite is a hack and should ideally be replaced in an upcoming patch.
- Remove an unneeded continue in clear_vm_list and update comment.
--- drivers/gpu/drm/i915/display/intel_dpt.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_context.c | 29 ++----- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 ++ .../gpu/drm/i915/gem/selftests/mock_context.c | 5 +- drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 30 +++---- drivers/gpu/drm/i915/gt/intel_gtt.c | 54 ++++++++---- drivers/gpu/drm/i915/gt/intel_gtt.h | 56 ++++-------- drivers/gpu/drm/i915/gt/selftest_execlists.c | 86 +++++++++---------- drivers/gpu/drm/i915/i915_gem.c | 6 +- drivers/gpu/drm/i915/i915_vma.c | 55 ++++++++---- drivers/gpu/drm/i915/i915_vma_resource.c | 2 +- drivers/gpu/drm/i915/i915_vma_resource.h | 6 ++ drivers/gpu/drm/i915/i915_vma_types.h | 7 ++ drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +- 15 files changed, 186 insertions(+), 164 deletions(-)
drivers/gpu/drm/i915/display/intel_dpt.c +1 -1
@@ -300,5 +300,5 @@ void intel_dpt_destroy(struct i915_address_space *vm) {struct i915_dpt *dpt =i915_vm_to_dpt (vm); -i915_vm_close (&dpt->vm); +i915_vm_put (&dpt->vm); }
drivers/gpu/drm/i915/gem/i915_gem_context.c +6 -23
@@ -1456,8 +1456,6 @@ static void set_closed_name(struct i915_gem_context *ctx)static void context_close (struct i915_gem_context *ctx) { -struct i915_address_space *vm; -/* Flush any concurrent set_engines() */ mutex_lock (&ctx->engines_mutex);unpin_engines (__context_engines_static (ctx));
@@ -1469,19 +1467,6 @@ static void context_close(struct i915_gem_context *ctx)set_closed_name (ctx); - vm = ctx->vm; -if (vm) { -/* i915_vm_close drops the final reference, which is a bit too -* early and could result in surprises with concurrent -* operations racing with thist ctx close. Keep a full reference -* until the end. -*/ -i915_vm_get (vm); -i915_vm_close (vm); - } - - ctx->file_priv =ERR_PTR (-EBADF ); -/* * The LUT uses the VMA as a backpointer to unref the object, * so we need to clear the LUT before we close all the VMA (inside
@@ -1489,6 +1474,8 @@ static void context_close(struct i915_gem_context *ctx)*/ lut_close (ctx); + ctx->file_priv =ERR_PTR (-EBADF ); +spin_lock (&ctx->i915->gem.contexts.lock);list_del (&ctx->link);spin_unlock (&ctx->i915->gem.contexts.lock);
@@ -1587,12 +1574,8 @@ i915_gem_create_context(struct drm_i915_private *i915, } vm = &ppgtt->vm; } -if (vm) { - ctx->vm =i915_vm_open (vm); - -/* i915_vm_open() takes a reference */ -i915_vm_put (vm); - } +if (vm) + ctx->vm = vm;mutex_init (&ctx->engines_mutex);if (pc->num_user_engines >=0 ) {
@@ -1642,7 +1625,7 @@ i915_gem_create_context(struct drm_i915_private *i915,free_engines (e); err_vm:if (ctx->vm) -i915_vm_close (ctx->vm); +i915_vm_put (ctx->vm); err_ctx:kfree (ctx);return ERR_PTR (err);
@@ -1826,7 +1809,7 @@ static int get_ppgtt(struct drm_i915_file_private *file_priv,if (err)return err; -i915_vm_open (vm); +i915_vm_get (vm);GEM_BUG_ON (id ==0 );/* reserved for invalid/unassigned ppgtt */ args->value = id;
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +6 -0
@@ -2702,6 +2702,11 @@ eb_select_engine(struct i915_execbuffer *eb)if (err) goto err; +if (!i915_vm_tryget (ce->vm)) { + err = -ENOENT ; + goto err; + } + eb->context = ce; eb->gt = ce->engine->gt;
@@ -2725,6 +2730,7 @@ eb_put_engine(struct i915_execbuffer *eb) {struct intel_context *child; +i915_vm_put (eb->context->vm);intel_gt_pm_put (eb->gt);for_each_child (eb->context, child)intel_context_put (child);
drivers/gpu/drm/i915/gem/selftests/mock_context.c +2 -3
@@ -42,8 +42,7 @@ mock_context(struct drm_i915_private *i915,if (!ppgtt) goto err_free; - ctx->vm =i915_vm_open (&ppgtt->vm); -i915_vm_put (&ppgtt->vm); + ctx->vm = &ppgtt->vm; }mutex_init (&ctx->engines_mutex);
@@ -59,7 +58,7 @@ mock_context(struct drm_i915_private *i915, err_vm:if (ctx->vm) -i915_vm_close (ctx->vm); +i915_vm_put (ctx->vm); err_free:kfree (ctx);return NULL ;
drivers/gpu/drm/i915/gt/gen6_ppgtt.c +1 -1
@@ -322,7 +322,7 @@ int gen6_ppgtt_pin(struct i915_ppgtt *base, struct i915_gem_ww_ctx *ww)struct gen6_ppgtt *ppgtt =to_gen6_ppgtt (base);int err; -GEM_BUG_ON (!atomic_read (&ppgtt->base.vm.open)); +GEM_BUG_ON (!kref_read (&ppgtt->base.vm.ref));/* * Workaround the limited maximum vma->pin_count and the aliasing_ppgtt
drivers/gpu/drm/i915/gt/intel_ggtt.c +13 -17
@@ -126,7 +126,7 @@ static bool needs_idle_maps(struct drm_i915_private *i915)void i915_ggtt_suspend_vm (struct i915_address_space *vm) {struct i915_vma *vma, *vn; -int open; +int save_skip_rewrite;drm_WARN_ON (&vm->i915->drm, !vm->is_ggtt && !vm->is_dpt);
@@ -135,8 +135,12 @@ void i915_ggtt_suspend_vm(struct i915_address_space *vm)mutex_lock (&vm->mutex); -/* Skip rewriting PTE on VMA unbind. */ - open =atomic_xchg (&vm->open,0 ); +/* +* Skip rewriting PTE on VMA unbind. +* FIXME: Use an argument to i915_vma_unbind() instead? +*/ + save_skip_rewrite = vm->skip_pte_rewrite; + vm->skip_pte_rewrite = true;list_for_each_entry_safe (vma, vn, &vm->bound_list, vm_link) {struct drm_i915_gem_object *obj = vma->obj;
@@ -154,16 +158,14 @@ void i915_ggtt_suspend_vm(struct i915_address_space *vm)*/ i915_gem_object_get (obj); -atomic_set (&vm->open, open);mutex_unlock (&vm->mutex);i915_gem_object_lock (obj,NULL ); - open =i915_vma_unbind (vma); +GEM_WARN_ON (i915_vma_unbind (vma));i915_gem_object_unlock (obj); - -GEM_WARN_ON (open); -i915_gem_object_put (obj); + + vm->skip_pte_rewrite = save_skip_rewrite; goto retry; }
@@ -179,7 +181,7 @@ void i915_ggtt_suspend_vm(struct i915_address_space *vm) vm->clear_range (vm,0 , vm->total); -atomic_set (&vm->open, open); + vm->skip_pte_rewrite = save_skip_rewrite;mutex_unlock (&vm->mutex); }
@@ -773,13 +775,13 @@ static void ggtt_cleanup_hw(struct i915_ggtt *ggtt) {struct i915_vma *vma, *vn; -atomic_set (&ggtt->vm.open,0 ); -flush_workqueue (ggtt->vm.i915->wq);i915_gem_drain_freed_objects (ggtt->vm.i915);mutex_lock (&ggtt->vm.mutex); + ggtt->vm.skip_pte_rewrite = true; +list_for_each_entry_safe (vma, vn, &ggtt->vm.bound_list, vm_link) {struct drm_i915_gem_object *obj = vma->obj;bool trylock;
@@ -1307,16 +1309,12 @@ bool i915_ggtt_resume_vm(struct i915_address_space *vm) {struct i915_vma *vma;bool write_domain_objs = false; -int open;drm_WARN_ON (&vm->i915->drm, !vm->is_ggtt && !vm->is_dpt);/* First fill our portion of the GTT with scratch pages */ vm->clear_range (vm,0 , vm->total); -/* Skip rewriting PTE on VMA unbind. */ - open =atomic_xchg (&vm->open,0 ); -/* clflush objects bound into the GGTT and rebind them. */ list_for_each_entry (vma, &vm->bound_list, vm_link) {struct drm_i915_gem_object *obj = vma->obj;
@@ -1333,8 +1331,6 @@ bool i915_ggtt_resume_vm(struct i915_address_space *vm) } } -atomic_set (&vm->open, open); -return write_domain_objs; }
drivers/gpu/drm/i915/gt/intel_gtt.c +39 -15
110 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_gtt.h +19 -37
86 lines not on this page · raw message
drivers/gpu/drm/i915/gt/selftest_execlists.c +43 -43
243 lines not on this page · raw message
drivers/gpu/drm/i915/i915_gem.c +2 -4
@@ -142,8 +142,6 @@ int i915_gem_object_unbind(struct drm_i915_gem_object *obj,while (!ret && (vma =list_first_entry_or_null (&obj->vma.list, struct i915_vma, obj_link))) { -struct i915_address_space *vm = vma->vm; -list_move_tail (&vma->obj_link, &still_in_list);if (!i915_vma_is_bound (vma,I915_VMA_BIND_MASK ))continue ;
@@ -154,7 +152,7 @@ int i915_gem_object_unbind(struct drm_i915_gem_object *obj, } ret = -EAGAIN ; -if (!i915_vm_tryopen (vm)) +if (!i915_vm_tryget (vma->vm))break ;/* Prevent vma being freed by i915_vma_parked as we unbind */
@@ -186,7 +184,7 @@ int i915_gem_object_unbind(struct drm_i915_gem_object *obj,__i915_vma_put (vma); } -i915_vm_close (vm); +i915_vm_put (vma->vm);spin_lock (&obj->vma.lock); }list_splice_init (&still_in_list, &obj->vma.list);
drivers/gpu/drm/i915/i915_vma.c +38 -17
181 lines not on this page · raw message
drivers/gpu/drm/i915/i915_vma_resource.c +1 -1
@@ -178,7 +178,7 @@ static void i915_vma_resource_unbind_work(struct work_struct *work)bool lockdep_cookie; lockdep_cookie =dma_fence_begin_signalling (); -if (likely (atomic_read (&vm->open))) +if (likely (!vma_res->skip_pte_rewrite)) vma_res->ops->unbind_vma (vm, vma_res);dma_fence_end_signalling (lockdep_cookie);
drivers/gpu/drm/i915/i915_vma_resource.h +6 -0
@@ -62,6 +62,11 @@ struct i915_page_sizes {* deferred to a work item awaiting unsignaled fences. This is a hack. * (dma_fence_work uses a fence flag for this, but this seems slightly * cleaner). +* @needs_wakeref: Whether a wakeref is needed during unbind. Since we can't +* take a wakeref in the dma-fence signalling critical path, it needs to be +* taken when the unbind is scheduled. +* @skip_pte_rewrite: During ggtt suspend and vm takedown pte rewriting +* needs to be skipped for unbind. * * The lifetime of a struct i915_vma_resource is from a binding request to * the actual possible asynchronous unbind has completed.
@@ -113,6 +118,7 @@ struct i915_vma_resource { bool allocated:1; bool immediate_unbind:1; bool needs_wakeref:1; + bool skip_pte_rewrite:1; }; bool i915_vma_resource_hold(struct i915_vma_resource *vma_res,
drivers/gpu/drm/i915/i915_vma_types.h +7 -0
@@ -271,6 +271,13 @@ struct i915_vma {#define I915_VMA_PAGES_ACTIVE (BIT(24) | 1)atomic_t pages_count;/* number of active binds to the pages */ +/** +* Whether we hold a reference on the vm dma_resv lock to temporarily +* block vm freeing until the vma is destroyed. +* Protected by the vm mutex. +*/ +bool vm_ddestroy; +/** * Support different GGTT views into the same object. * This means there can be multiple VMA mappings per object and per VM.
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +2 -2
@@ -1205,7 +1205,7 @@ static int exercise_ppgtt(struct drm_i915_private *dev_priv, goto out_free; }GEM_BUG_ON (offset_in_page (ppgtt->vm.total)); -GEM_BUG_ON (!atomic_read (&ppgtt->vm.open)); +assert_vm_alive (&ppgtt->vm); err =func (&ppgtt->vm,0 , ppgtt->vm.total, end_time);
@@ -1438,7 +1438,7 @@ static void track_vma_bind(struct i915_vma *vma) vma->resource->bi.pages = vma->pages;mutex_lock (&vma->vm->mutex); -list_add_tail (&vma->vm_link, &vma->vm->bound_list); +list_move_tail (&vma->vm_link, &vma->vm->bound_list);mutex_unlock (&vma->vm->mutex); }
Signature · 1 line
2.34.1
PATCH v2 2/3 drm/i915: Remove the vma refcount
In reply to Thomas HellströmNow that i915_vma_parked() is taking the object lock on vma destruction, and the only user of the vma refcount, i915_gem_object_unbind() also takes the object lock, remove the vma refcount.
--- drivers/gpu/drm/i915/i915_gem.c | 17 +++++++++++++---- drivers/gpu/drm/i915/i915_vma.c | 14 +++----------- drivers/gpu/drm/i915/i915_vma.h | 14 -------------- drivers/gpu/drm/i915/i915_vma_types.h | 1 - 4 files changed, 16 insertions(+), 30 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +13 -4
@@ -151,14 +151,25 @@ int i915_gem_object_unbind(struct drm_i915_gem_object *obj,break ; } +/* +* Requiring the vm destructor to take the object lock +* before destroying a vma would help us eliminate the +* i915_vm_tryget() here, AND thus also the barrier stuff +* at the end. That's an easy fix, but sleeping locks in +* a kthread should generally be avoided. +*/ ret = -EAGAIN ;if (!i915_vm_tryget (vma->vm))break ; -/* Prevent vma being freed by i915_vma_parked as we unbind */ - vma =__i915_vma_get (vma);spin_unlock (&obj->vma.lock); +/* +* Since i915_vma_parked() takes the object lock +* before vma destruction, it won't race us here, +* and destroy the vma from under us. +*/ +if (vma) {bool vm_trylock = !!(flags &I915_GEM_OBJECT_UNBIND_VM_TRYLOCK ); ret = -EBUSY ;
@@ -180,8 +191,6 @@ int i915_gem_object_unbind(struct drm_i915_gem_object *obj, ret =i915_vma_unbind (vma); } } - -__i915_vma_put (vma); }i915_vm_put (vma->vm);
drivers/gpu/drm/i915/i915_vma.c +3 -11
@@ -122,7 +122,6 @@ vma_create(struct drm_i915_gem_object *obj,if (vma ==NULL )return ERR_PTR (-ENOMEM ); -kref_init (&vma->ref); vma->ops = &vm->vma_ops; vma->obj = obj; vma->size = obj->base.size;
@@ -1628,15 +1627,6 @@ void i915_vma_reopen(struct i915_vma *vma)__i915_vma_remove_closed (vma); } -void i915_vma_release (struct kref *ref) -{ -struct i915_vma *vma =container_of (ref,typeof (*vma), ref); - -i915_active_fini (&vma->active); -GEM_WARN_ON (vma->resource); -i915_vma_free (vma); -} -static void force_unbind (struct i915_vma *vma) {if (!drm_mm_node_allocated (&vma->node))
@@ -1665,7 +1655,9 @@ static void release_references(struct i915_vma *vma, bool vm_ddestroy)if (vm_ddestroy)i915_vm_resv_put (vma->vm); -__i915_vma_put (vma); +i915_active_fini (&vma->active); +GEM_WARN_ON (vma->resource); +i915_vma_free (vma); }/**
drivers/gpu/drm/i915/i915_vma.h +0 -14
@@ -222,20 +222,6 @@ void i915_vma_unlink_ctx(struct i915_vma *vma);void i915_vma_close (struct i915_vma *vma);void i915_vma_reopen (struct i915_vma *vma); -static inline struct i915_vma *__i915_vma_get (struct i915_vma *vma) -{ -if (kref_get_unless_zero (&vma->ref)) -return vma; - -return NULL ; -} - -void i915_vma_release (struct kref *ref); -static inline void __i915_vma_put (struct i915_vma *vma) -{ -kref_put (&vma->ref, i915_vma_release); -} -void i915_vma_destroy_locked (struct i915_vma *vma);void i915_vma_destroy (struct i915_vma *vma);
drivers/gpu/drm/i915/i915_vma_types.h +0 -1
@@ -211,7 +211,6 @@ struct i915_vma {* handles (but same file) for execbuf, i.e. the number of aliases * that exist in the ctx->handle_vmas LUT for this vma. */ -struct kref ref;atomic_t open_count;atomic_t flags;/**
Signature · 1 line
2.34.1
PATCH v2 3/3 drm/i915/gem: Remove some unnecessary code
In reply to Thomas HellströmThe test for vma should always return true, and when assigning -EBUSY to ret, the variable should already have that value.
--- drivers/gpu/drm/i915/i915_gem.c | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +14 -18
@@ -118,6 +118,7 @@ int i915_gem_object_unbind(struct drm_i915_gem_object *obj, unsigned long flags) {struct intel_runtime_pm *rpm = &to_i915 (obj->base.dev)->runtime_pm; +bool vm_trylock = !!(flags &I915_GEM_OBJECT_UNBIND_VM_TRYLOCK );LIST_HEAD (still_in_list);intel_wakeref_t wakeref;struct i915_vma *vma;
@@ -170,26 +171,21 @@ int i915_gem_object_unbind(struct drm_i915_gem_object *obj,* and destroy the vma from under us. */ -if (vma) { -bool vm_trylock = !!(flags &I915_GEM_OBJECT_UNBIND_VM_TRYLOCK ); - ret = -EBUSY ; -if (flags &I915_GEM_OBJECT_UNBIND_ASYNC ) { -assert_object_held (vma->obj); - ret =i915_vma_unbind_async (vma, vm_trylock); - } + ret = -EBUSY ; +if (flags &I915_GEM_OBJECT_UNBIND_ASYNC ) { +assert_object_held (vma->obj); + ret =i915_vma_unbind_async (vma, vm_trylock); + } -if (ret == -EBUSY && (flags &I915_GEM_OBJECT_UNBIND_ACTIVE || - !i915_vma_is_active (vma))) { -if (vm_trylock) { -if (mutex_trylock (&vma->vm->mutex)) { - ret =__i915_vma_unbind (vma); -mutex_unlock (&vma->vm->mutex); - }else { - ret = -EBUSY ; - } - }else { - ret =i915_vma_unbind (vma); +if (ret == -EBUSY && (flags &I915_GEM_OBJECT_UNBIND_ACTIVE || + !i915_vma_is_active (vma))) { +if (vm_trylock) { +if (mutex_trylock (&vma->vm->mutex)) { + ret =__i915_vma_unbind (vma); +mutex_unlock (&vma->vm->mutex); } + }else { + ret =i915_vma_unbind (vma); } }
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for vm- and vma cleanups
In reply to Thomas Hellström== Series Details ==
== Series Details ==
Series: vm- and vma cleanups
URL : https://patchwork.freedesktop.org/series/100945/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 67a198829865 drm/i915: Remove the vm open count -:26: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #26: - Clarify that the struct i915_address_space::skip_pte_rewrite is a hack and
total: 0 errors, 1 warnings, 0 checks, 901 lines checked 0a77c40b2518 drm/i915: Remove the vma refcount dc594b31f5d2 drm/i915/gem: Remove some unnecessary code
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for vm- and vma cleanups
In reply to Thomas Hellström== Series Details ==
== Series Details ==
Series: vm- and vma cleanups
URL : https://patchwork.freedesktop.org/series/100945/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for vm- and vma cleanups
In reply to Thomas Hellström== Series Details ==
== Series Details ==
Series: vm- and vma cleanups
URL : https://patchwork.freedesktop.org/series/100945/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11308 -> Patchwork_22462
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/index.html
Participating hosts (51 -> 43)
------------------------------
Additional (1): bat-adlp-4
Missing (9): fi-cml-u2 fi-bdw-samus shard-tglu fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 shard-rkl shard-dg1 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_22462 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: [PASS][1] -> [INCOMPLETE][2] ([i915#4547])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/fi-skl-6600u/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/fi-skl-6600u/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- bat-adlp-4: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/bat-adlp-4/igt@[email protected]
* igt@gem_tiled_pread_basic:
- bat-adlp-4: NOTRUN -> [SKIP][4] ([i915#3282])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/bat-adlp-4/igt@gem_tiled_pread_basic.html
* igt@i915_selftest@live@gem:
- fi-blb-e6850: [PASS][5] -> [DMESG-FAIL][6] ([i915#4528])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/fi-blb-e6850/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/fi-blb-e6850/igt@i915_selftest@[email protected]
* igt@i915_selftest@live@hangcheck:
- fi-bdw-5557u: NOTRUN -> [INCOMPLETE][7] ([i915#3921])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/fi-bdw-5557u/igt@i915_selftest@[email protected]
* igt@kms_chamelium@vga-edid-read:
- fi-bdw-5557u: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/fi-bdw-5557u/igt@[email protected]
* igt@kms_chamelium@vga-hpd-fast:
- bat-adlp-4: NOTRUN -> [SKIP][9] ([fdo#111827]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/bat-adlp-4/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- bat-adlp-4: NOTRUN -> [SKIP][10] ([i915#4103]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/bat-adlp-4/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- bat-adlp-4: NOTRUN -> [SKIP][11] ([fdo#109285])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/bat-adlp-4/igt@[email protected]
* igt@kms_psr@cursor_plane_move:
- fi-bdw-5557u: NOTRUN -> [SKIP][12] ([fdo#109271]) +13 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/fi-bdw-5557u/igt@kms_psr@cursor_plane_move.html
* igt@prime_vgem@basic-fence-read:
- bat-adlp-4: NOTRUN -> [SKIP][13] ([i915#3291] / [i915#3708]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/bat-adlp-4/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- bat-adlp-4: NOTRUN -> [SKIP][14] ([i915#3301] / [i915#3708])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/bat-adlp-4/igt@[email protected]
* igt@runner@aborted:
- fi-blb-e6850: NOTRUN -> [FAIL][15] ([fdo#109271] / [i915#2403] / [i915#4312])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/fi-blb-e6850/igt@[email protected]
#### Possible fixes ####
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- {bat-adlp-6}: [DMESG-WARN][16] ([i915#3576]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/bat-adlp-6/igt@kms_flip@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/bat-adlp-6/igt@kms_flip@[email protected]
#### Warnings ####
* igt@runner@aborted:
- fi-skl-6600u: [FAIL][18] ([i915#4312]) -> [FAIL][19] ([i915#2722] / [i915#4312])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/fi-skl-6600u/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/fi-skl-6600u/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5068]: https://gitlab.freedesktop.org/drm/intel/issues/5068
[i915#5127]: https://gitlab.freedesktop.org/drm/intel/issues/5127
Build changes
-------------
* Linux: CI_DRM_11308 -> Patchwork_22462
CI-20190529: 20190529
CI_DRM_11308: e1345b708d76052ef668aaba362ef8ad81ed0b9b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6361: 2372a4beb6a33c5f0799a4a8ccbb93794f52dbca @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22462: dc594b31f5d255a9fb14fb082a5573de4c52cd61 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
dc594b31f5d2 drm/i915/gem: Remove some unnecessary code 0a77c40b2518 drm/i915: Remove the vma refcount 67a198829865 drm/i915: Remove the vm open count
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for vm- and vma cleanups
In reply to Thomas Hellström== Series Details ==
== Series Details ==
Series: vm- and vma cleanups
URL : https://patchwork.freedesktop.org/series/100945/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11308_full -> Patchwork_22462_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22462_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@kms_cursor_legacy@pipe-a-single-move:
- {shard-rkl}: ([PASS][1], [PASS][2]) -> [INCOMPLETE][3]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-rkl-4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-rkl-2/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-rkl-5/igt@[email protected]
* {igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-25@pipe-a-edp-1-downscale-with-pixel-format}:
- shard-iclb: NOTRUN -> [SKIP][4] +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb6/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-25@pipe-a-edp-1-downscale-with-pixel-format.html
* {igt@kms_plane_scaling@downscale-with-rotation-factor-0-75@pipe-b-hdmi-a-3-downscale-with-rotation}:
- {shard-dg1}: NOTRUN -> [SKIP][5] +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-dg1-18/igt@kms_plane_scaling@downscale-with-rotation-factor-0-75@pipe-b-hdmi-a-3-downscale-with-rotation.html
* {igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale}:
- shard-iclb: [PASS][6] -> [SKIP][7] +5 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-iclb6/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale.html
* {igt@kms_plane_scaling@scaler-with-rotation-unity-scaling}:
- {shard-rkl}: NOTRUN -> [SKIP][8] +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-rkl-1/igt@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_11308_full and Patchwork_22462_full:
### New IGT tests (1) ###
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-75@pipe-d-edp-1-planes-upscale-downscale:
- Statuses : 1 pass(s)
- Exec time: [1.28] s
Known issues
------------
Here are the changes found in Patchwork_22462_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-glk: ([PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33]) -> ([PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [FAIL][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57], [PASS][58]) ([i915#4392])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk9/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk9/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk9/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk8/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk8/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk8/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk7/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk7/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk7/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk6/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk6/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk5/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk5/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk5/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk4/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk4/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk4/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk3/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk3/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk2/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk2/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk2/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk1/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk1/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk1/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk5/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk5/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk7/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk5/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk4/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk4/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk7/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk4/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk3/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk3/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk3/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk8/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk2/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk8/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk2/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk8/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk9/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk2/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk9/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk1/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk6/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk1/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk9/boot.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk6/boot.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk6/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-apl: [PASS][59] -> [DMESG-WARN][60] ([i915#180]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-apl3/igt@gem_ctx_isolation@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-apl4/igt@gem_ctx_isolation@[email protected]
* igt@gem_ctx_param@set-priority-not-supported:
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109314])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb6/igt@[email protected]
* igt@gem_exec_balancer@parallel-bb-first:
- shard-tglb: NOTRUN -> [DMESG-WARN][62] ([i915#5076])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-tglb5/igt@[email protected]
* igt@gem_exec_capture@pi@bcs0:
- shard-iclb: [PASS][63] -> [INCOMPLETE][64] ([i915#3371])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-iclb7/igt@gem_exec_capture@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb1/igt@gem_exec_capture@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][65] ([i915#2846])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl9/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][66] -> [FAIL][67] ([i915#2842])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-iclb4/igt@gem_exec_fair@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb2/igt@gem_exec_fair@[email protected]
- shard-glk: [PASS][68] -> [FAIL][69] ([i915#2842])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk5/igt@gem_exec_fair@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vecs0:
- shard-iclb: NOTRUN -> [FAIL][70] ([i915#2842]) +3 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [PASS][71] -> [FAIL][72] ([i915#2842])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-kbl7/igt@gem_exec_fair@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-kbl1/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@basic:
- shard-iclb: NOTRUN -> [SKIP][73] ([i915#4613]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb6/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-skl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#4613]) +2 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl1/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-glk: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#4613])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk9/igt@[email protected]
* igt@gem_pread@exhaustion:
- shard-skl: NOTRUN -> [WARN][76] ([i915#2658])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl1/igt@[email protected]
* igt@gem_pxp@create-regular-context-1:
- shard-iclb: NOTRUN -> [SKIP][77] ([i915#4270]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb5/igt@[email protected]
* igt@gem_pxp@create-regular-context-2:
- shard-tglb: NOTRUN -> [SKIP][78] ([i915#4270])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-tglb5/igt@[email protected]
* igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs:
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#768]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb5/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-skl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#3323])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl9/igt@[email protected]
* igt@gem_userptr_blits@input-checking:
- shard-kbl: NOTRUN -> [DMESG-WARN][81] ([i915#4991])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-kbl7/igt@[email protected]
* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-iclb: NOTRUN -> [SKIP][82] ([i915#3297]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb6/igt@[email protected]
* igt@gen7_exec_parse@batch-without-end:
- shard-iclb: NOTRUN -> [SKIP][83] ([fdo#109289]) +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb5/igt@[email protected]
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][84] -> [DMESG-WARN][85] ([i915#1436] / [i915#716])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-glk9/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk6/igt@[email protected]
* igt@gen9_exec_parse@batch-zero-length:
- shard-iclb: NOTRUN -> [SKIP][86] ([i915#2856])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb5/igt@[email protected]
* igt@gen9_exec_parse@shadow-peek:
- shard-tglb: NOTRUN -> [SKIP][87] ([i915#2527] / [i915#2856]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-tglb8/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-skl: NOTRUN -> [FAIL][88] ([i915#454])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl1/igt@[email protected]
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109293] / [fdo#109506])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb6/igt@[email protected]
* igt@i915_pm_sseu@full-enable:
- shard-iclb: NOTRUN -> [SKIP][90] ([i915#4387])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb5/igt@[email protected]
* igt@i915_suspend@debugfs-reader:
- shard-skl: [PASS][91] -> [INCOMPLETE][92] ([i915#4939]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-skl10/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl4/igt@[email protected]
* igt@kms_async_flips@crc:
- shard-skl: NOTRUN -> [FAIL][93] ([i915#4272])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl9/igt@[email protected]
* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-tglb: NOTRUN -> [SKIP][94] ([i915#404])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-tglb5/igt@[email protected]
* igt@kms_big_fb@linear-8bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#110725] / [fdo#111614]) +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb5/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][96] ([i915#3743])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl1/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-apl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#3777]) +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-apl3/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#3777]) +2 similar issues
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl1/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][99] ([fdo#111615])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-tglb5/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#110723]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb6/igt@[email protected]
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#3886]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-kbl4/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][102] ([i915#3689])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-tglb5/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][103] ([fdo#111615] / [i915#3689]) +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-tglb5/igt@kms_ccs@pipe-b-crc-primary-rotation-180-yf_tiled_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][104] ([fdo#109278] / [i915#3886]) +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb5/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#3886]) +3 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-apl1/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#3886]) +3 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl1/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-kbl: NOTRUN -> [SKIP][107] ([fdo#109271] / [fdo#111827]) +4 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-kbl7/igt@[email protected]
* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-apl: NOTRUN -> [SKIP][108] ([fdo#109271] / [fdo#111827]) +2 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-apl3/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-iclb: NOTRUN -> [SKIP][109] ([fdo#109284] / [fdo#111827]) +7 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb5/igt@[email protected]
* igt@kms_color_chamelium@pipe-b-ctm-limited-range:
- shard-skl: NOTRUN -> [SKIP][110] ([fdo#109271] / [fdo#111827]) +10 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl1/igt@[email protected]
* igt@kms_color_chamelium@pipe-b-ctm-red-to-blue:
- shard-glk: NOTRUN -> [SKIP][111] ([fdo#109271] / [fdo#111827])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-glk9/igt@[email protected]
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][112] ([i915#1319]) +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-apl3/igt@[email protected]
* igt@kms_content_protection@type1:
- shard-iclb: NOTRUN -> [SKIP][113] ([fdo#109300] / [fdo#111066])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][114] ([fdo#109279] / [i915#3359]) +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-tglb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-max-size-onscreen:
- shard-kbl: NOTRUN -> [SKIP][115] ([fdo#109271]) +48 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-kbl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-512x170-sliding:
- shard-iclb: NOTRUN -> [SKIP][116] ([fdo#109278] / [fdo#109279]) +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][117] ([i915#180])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-kbl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-256x85-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][118] ([fdo#109278]) +26 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb5/igt@[email protected]
* igt@kms_cursor_legacy@cursora-vs-flipb-atomic:
- shard-tglb: NOTRUN -> [SKIP][119] ([fdo#109274] / [fdo#111825]) +2 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-tglb5/igt@[email protected]
* igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
- shard-iclb: NOTRUN -> [SKIP][120] ([fdo#109274] / [fdo#109278]) +2 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb6/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: NOTRUN -> [FAIL][121] ([i915#2346])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl8/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][122] -> [FAIL][123] ([i915#2346] / [i915#533])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@pipe-d-torture-move:
- shard-skl: NOTRUN -> [SKIP][124] ([fdo#109271]) +107 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl9/igt@[email protected]
* igt@kms_flip@2x-flip-vs-panning-vs-hang:
- shard-iclb: NOTRUN -> [SKIP][125] ([fdo#109274]) +4 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb6/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [PASS][126] -> [FAIL][127] ([i915#79])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-skl6/igt@kms_flip@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl8/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: NOTRUN -> [DMESG-WARN][128] ([i915#180]) +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-apl1/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-kbl: [PASS][129] -> [DMESG-WARN][130] ([i915#180]) +1 similar issue
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-kbl1/igt@kms_flip@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-kbl6/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling:
- shard-skl: NOTRUN -> [INCOMPLETE][131] ([i915#3701])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl9/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
- shard-iclb: [PASS][132] -> [SKIP][133] ([i915#3701])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-iclb4/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][134] ([fdo#109280] / [fdo#111825]) +3 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][135] ([fdo#109280]) +22 similar issues
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb6/igt@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][136] -> [FAIL][137] ([i915#1188])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-skl9/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl10/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][138] ([fdo#109271] / [i915#533])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-apl3/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: NOTRUN -> [FAIL][139] ([fdo#108145] / [i915#265])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-apl3/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][140] ([fdo#108145] / [i915#265])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-kbl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][141] ([fdo#108145] / [i915#265]) +2 similar issues
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][142] -> [FAIL][143] ([fdo#108145] / [i915#265]) +1 similar issue
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11308/shard-skl8/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl9/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: NOTRUN -> [SKIP][144] ([i915#3536]) +1 similar issue
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb5/igt@[email protected]
* igt@kms_plane_lowres@pipe-b-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][145] ([fdo#111615] / [fdo#112054])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-tglb5/igt@[email protected]
* igt@kms_plane_lowres@pipe-c-tiling-none:
- shard-tglb: NOTRUN -> [SKIP][146] ([i915#3536]) +1 similar issue
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-tglb5/igt@[email protected]
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-skl: NOTRUN -> [SKIP][147] ([fdo#109271] / [i915#658])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-skl9/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][148] ([fdo#109271] / [i915#658])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-apl3/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-iclb: NOTRUN -> [SKIP][149] ([fdo#111068] / [i915#658])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-iclb5/igt@[email protected]
* igt@kms_psr@basic:
- shard-apl: NOTRUN -> [SKIP][150] ([fdo#109271]) +47 similar issues
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/shard-apl1/igt@[email protected]
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [PASS][151] -> [SKIP][152] ([fdo#109441])
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22462/index.html
Re: [PATCH v2 3/3] drm/i915/gem: Remove some unnecessary code
In reply to Thomas HellströmQuoted 49 lines · Thomas Hellström
The test for vma should always return true, and when assigning
-EBUSYto ret, the variable should already have that value.Signed-off-by Thomas Hellström <[email protected]>---
drivers/gpu/drm/i915/i915_gem.c| 32 ++++++++++++++------------------1 file changed, 14 insertions(+), 18 deletions(-)drivers/gpu/drm/i915/i915_gem.c +7
-18@@ -118,6 +118,7 @@ int i915_gem_object_unbind(struct drm_i915_gem_object *obj, unsigned long flags) {struct intel_runtime_pm *rpm = &to_i915 (obj->base.dev)->runtime_pm; +bool vm_trylock = !!(flags &I915_GEM_OBJECT_UNBIND_VM_TRYLOCK );LIST_HEAD (still_in_list);intel_wakeref_t wakeref;struct i915_vma *vma;@@ -170,26 +171,21 @@ int i915_gem_object_unbind(struct drm_i915_gem_object *obj,* and destroy the vma from under us. */ -if (vma) { -bool vm_trylock = !!(flags &I915_GEM_OBJECT_UNBIND_VM_TRYLOCK ); - ret = -EBUSY ; -if (flags &I915_GEM_OBJECT_UNBIND_ASYNC ) { -assert_object_held (vma->obj); - ret =i915_vma_unbind_async (vma, vm_trylock); - } + ret = -EBUSY ; +if (flags &I915_GEM_OBJECT_UNBIND_ASYNC ) { +assert_object_held (vma->obj); + ret =i915_vma_unbind_async (vma, vm_trylock); + } -if (ret == -EBUSY && (flags &I915_GEM_OBJECT_UNBIND_ACTIVE || - !i915_vma_is_active (vma))) { -if (vm_trylock) { -if (mutex_trylock (&vma->vm->mutex)) { - ret =__i915_vma_unbind (vma); -mutex_unlock (&vma->vm->mutex); - }else { - ret = -EBUSY ; - } - }else { - ret =i915_vma_unbind (vma); + if (ret == -EBUSY && (flags & I915_GEM_OBJECT_UNBIND_ACTIVE ||
drivers/gpu/drm/i915/i915_gem.c int i915_gem_object_unbind(struct drm_i915_gem_object *obj, · line 190
Quoted 10 lines
drivers/gpu/drm/i915/i915_gem.c +7
-0+ !i915_vma_is_active(vma))) { +if (vm_trylock) { +if (mutex_trylock (&vma->vm->mutex)) { + ret =__i915_vma_unbind (vma); +mutex_unlock (&vma->vm->mutex); } + }else { + ret =i915_vma_unbind (vma); } }
Looks good to me.
Quoted 4 lines
Signature · 2 lines
-- 2.34.1
Re: [PATCH v2 1/3] drm/i915: Remove the vm open count
In reply to Thomas HellströmQuoted 25 lines · Thomas Hellström
vms are not getting properly closed. Rather than fixing that, Remove the vm open count and instead rely on the vm refcount.
The vm open count existed solely to break the strong references the vmas had on the vms. Now instead make those references weak and ensure vmas are destroyed when the vm is destroyed.
Unfortunately if the vm destructor and the object destructor both wants to destroy a vma, that may lead to a race in that the vm destructor just unbinds the vma and leaves the actual vma destruction to the object destructor. However in order for the object destructor to ensure the vma is unbound it needs to grab the vm mutex. In order to keep the vm mutex alive until the object destructor is done with it, somewhat hackishly grab a
vm_resvrefcount that is released late in the vma destruction process, when the vm mutex is no longer needed.v2: Address review-comments from Niranjana
- Clarify that the structi915_address_space::skip_pte_rewriteis a hack and should ideally be replaced in an upcoming patch.
- Remove an unneeded continue inclear_vm_listand update comment.Co-developed-by Niranjana Vishwanathapura <[email protected]>Signed-off-by Niranjana Vishwanathapura <[email protected]>Signed-off-by Thomas Hellström <[email protected]>---
Quoted 17 lines
drivers/gpu/drm/i915/display/intel_dpt.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_context.c | 29 ++----- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 6 ++ .../gpu/drm/i915/gem/selftests/mock_context.c | 5 +- drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 30 +++---- drivers/gpu/drm/i915/gt/intel_gtt.c | 54 ++++++++---- drivers/gpu/drm/i915/gt/intel_gtt.h | 56 ++++-------- drivers/gpu/drm/i915/gt/selftest_execlists.c | 86 +++++++++---------- drivers/gpu/drm/i915/i915_gem.c | 6 +- drivers/gpu/drm/i915/i915_vma.c | 55 ++++++++---- drivers/gpu/drm/i915/i915_vma_resource.c | 2 +- drivers/gpu/drm/i915/i915_vma_resource.h | 6 ++ drivers/gpu/drm/i915/i915_vma_types.h | 7 ++ drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +- 15 files changed, 186 insertions(+), 164 deletions(-)
Looks good to me.
Re: [PATCH v2 2/3] drm/i915: Remove the vma refcount
In reply to Thomas HellströmQuoted 45 lines · Thomas Hellström
Now that
i915_vma_parked()is taking the object lock on vma destruction, and the only user of the vma refcount,i915_gem_object_unbind()also takes the object lock, remove the vma refcount.Signed-off-by Thomas Hellström <[email protected]>---
drivers/gpu/drm/i915/i915_gem.c | 17 +++++++++++++---- drivers/gpu/drm/i915/i915_vma.c | 14 +++----------- drivers/gpu/drm/i915/i915_vma.h | 14 -------------- drivers/gpu/drm/i915/i915_vma_types.h | 1 - 4 files changed, 16 insertions(+), 30 deletions(-)drivers/gpu/drm/i915/i915_gem.c +13
-2@@ -151,14 +151,25 @@ int i915_gem_object_unbind(struct drm_i915_gem_object *obj,break ; } +/* +* Requiring the vm destructor to take the object lock +* before destroying a vma would help us eliminate the +* i915_vm_tryget() here, AND thus also the barrier stuff +* at the end. That's an easy fix, but sleeping locks in +* a kthread should generally be avoided. +*/ ret = -EAGAIN ;if (!i915_vm_tryget (vma->vm))break ; -/* Prevent vma being freed by i915_vma_parked as we unbind */ - vma =__i915_vma_get (vma);spin_unlock (&obj->vma.lock); +/* +* Since i915_vma_parked() takes the object lock +* before vma destruction, it won't race us here, +* and destroy the vma from under us. +*/ +if (vma) {bool vm_trylock = !!(flags &I915_GEM_OBJECT_UNBIND_VM_TRYLOCK ); ret = -EBUSY ;
drivers/gpu/drm/i915/i915_gem.c int i915_gem_object_unbind(struct drm_i915_gem_object *obj, · line 196
Quoted 8 lines
drivers/gpu/drm/i915/i915_gem.c +0
-2@@ -180,8 +191,6 @@ int i915_gem_object_unbind(struct drm_i915_gem_object *obj, ret =i915_vma_unbind (vma); } } - -__i915_vma_put (vma); }i915_vm_put (vma->vm);
One issue still left in i915_gem_object_unbind is that it temporarily removes vmas from the obj->vma.list and adds back later as vma needs to be unbind outside the obj->vma.lock spinlock. This is an issue for other places where we iterate over the obj->vma.list. i915_debugfs_describe_obj is one such case (upcoming vm_bind will be another) that iterates over this list.
What is the plan here? Do we need to take object lock while iterating over the list?
But this just something I noticed and not related to this patch. This patch looks good to me.
Quoted 79 lines
drivers/gpu/drm/i915/i915_vma.c +3
-11@@ -122,7 +122,6 @@ vma_create(struct drm_i915_gem_object *obj,if (vma ==NULL )return ERR_PTR (-ENOMEM ); -kref_init (&vma->ref); vma->ops = &vm->vma_ops; vma->obj = obj; vma->size = obj->base.size;@@ -1628,15 +1627,6 @@ void i915_vma_reopen(struct i915_vma *vma)__i915_vma_remove_closed (vma); } -void i915_vma_release (struct kref *ref) -{ -struct i915_vma *vma =container_of (ref,typeof (*vma), ref); - -i915_active_fini (&vma->active); -GEM_WARN_ON (vma->resource); -i915_vma_free (vma); -} -static void force_unbind (struct i915_vma *vma) {if (!drm_mm_node_allocated (&vma->node))@@ -1665,7 +1655,9 @@ static void release_references(struct i915_vma *vma, bool vm_ddestroy)if (vm_ddestroy)i915_vm_resv_put (vma->vm); -__i915_vma_put (vma); +i915_active_fini (&vma->active); +GEM_WARN_ON (vma->resource); +i915_vma_free (vma); }/** drivers/gpu/drm/i915/i915_vma.h +0
-14@@ -222,20 +222,6 @@ void i915_vma_unlink_ctx(struct i915_vma *vma);void i915_vma_close (struct i915_vma *vma);void i915_vma_reopen (struct i915_vma *vma); -static inline struct i915_vma *__i915_vma_get (struct i915_vma *vma) -{ -if (kref_get_unless_zero (&vma->ref)) -return vma; - -return NULL ; -} - -void i915_vma_release (struct kref *ref); -static inline void __i915_vma_put (struct i915_vma *vma) -{ -kref_put (&vma->ref, i915_vma_release); -} -void i915_vma_destroy_locked (struct i915_vma *vma);void i915_vma_destroy (struct i915_vma *vma);drivers/gpu/drm/i915/i915_vma_types.h +0
-1@@ -211,7 +211,6 @@ struct i915_vma {* handles (but same file) for execbuf, i.e. the number of aliases * that exist in the ctx->handle_vmas LUT for this vma. */ -struct kref ref;atomic_t open_count;atomic_t flags;/** Signature · 1 line
2.34.1
Re: [PATCH v2 2/3] drm/i915: Remove the vma refcount
Quoted 63 lines · Niranjana Vishwanathapura
Quoted 62 lines · Thomas Hellström
Now that
i915_vma_parked()is taking the object lock on vma destruction,
and the only user of the vma refcount,i915_gem_object_unbind()also takes the object lock, remove the vma refcount.Signed-off-by Thomas Hellström <[email protected]>---
drivers/gpu/drm/i915/i915_gem.c | 17 +++++++++++++---- drivers/gpu/drm/i915/i915_vma.c | 14 +++----------- drivers/gpu/drm/i915/i915_vma.h | 14 -------------- drivers/gpu/drm/i915/i915_vma_types.h | 1 - 4 files changed, 16 insertions(+), 30 deletions(-)drivers/gpu/drm/i915/i915_gem.c +2
-0@@ -151,14 +151,25 @@ int i915_gem_object_unbind(struct drm_i915_gem_object *obj, break; } + /* +* Requiring the vm destructor to take the object lock
+ * before destroying a vma would help us eliminate the
+ *i915_vm_tryget()here, AND thus also the barrier stuff
+ * at the end. That's an easy fix, but sleeping locks in
+ * a kthread should generally be avoided. + */
ret =-EAGAIN;
if (!i915_vm_tryget(vma->vm))
break;- /* Prevent vma being freed by
i915_vma_parkedas we unbind */
- vma =__i915_vma_get(vma);spin_unlock(&obj->vma.lock);+ /*
+ * Sincei915_vma_parked()takes the object lock + * before vma destruction, it won't race us here, + * and destroy the vma from under us.
+ */
+
if (vma) {
boolvm_trylock= !!(flags &I915_GEM_OBJECT_UNBIND_VM_TRYLOCK);
ret =-EBUSY;drivers/gpu/drm/i915/i915_gem.c +0
-2@@ -180,8 +191,6 @@ int i915_gem_object_unbind(structdrm_i915_gem_object *obj, ret = i915_vma_unbind(vma); } } - - __i915_vma_put(vma); }
Quoted 14 lines
Quoted 1 line
i915_vm_put(vma->vm);
One issue still left in
i915_gem_object_unbindis that it temporarily removes
vmas from theobj->vma.listand adds back later as vma needs to be unbind outside
theobj->vma.lockspinlock. This is an issue for other places where we iterate
over theobj->vma.list.i915_debugfs_describe_objis one such case (upcomingvm_bindwill be another) that iterates over this list. What is the plan here? Do we need to take object lock while iterating over the
list?
Yeah, I guess that's an option if that's at all possible (we might need to iterate over the list in the mmu notifier, for example).
The other option is to
*) get rid of the GGTT / PPGTT sorting of vmas in the list, *) being able to determine per vma *before we unlock* if we need to unlock the list spinlock to take action,
*) re-add all vmas we've previously iterated over at the *tail* of the list before unlocking the list lock.
Then a termination criterion for iterating would be that we reached the end of the list without unlocking. Otherwise we need to restart iteration after unlocking.
This would typically give us O(2N) complexity for the iteration. If we re-add at the *head* of the list, we'd see O(N²), but to be able to re- add previous vmas to the tail of the list requires us to get rid of the sorting.
Quoted 6 lines
But this just something I noticed and not related to this patch. This patch looks good to me.
Reviewed-by: Niranjana Vishwanathapura <[email protected]>
Thanks for reviewing. I noticed there is some documentation needing updating as well, so I'll send out a v3 without functional changes.
/Thomas
Quoted 88 lines
Quoted 88 lines
drivers/gpu/drm/i915/i915_vma.c +0
-10@@ -122,7 +122,6 @@ vma_create(struct drm_i915_gem_object *obj, if (vma == NULL) return ERR_PTR(-ENOMEM); - kref_init(&vma->ref); vma->ops = &vm->vma_ops; vma->obj = obj; vma->size = obj->base.size;@@ -1628,15 +1627,6 @@ void i915_vma_reopen(struct i915_vma *vma) __i915_vma_remove_closed(vma); } -void i915_vma_release (struct kref *ref) -{ - struct i915_vma *vma = container_of(ref, typeof(*vma), ref); - - i915_active_fini(&vma->active); - GEM_WARN_ON(vma->resource); - i915_vma_free(vma); -} -static void force_unbind (struct i915_vma *vma) {if (!drm_mm_node_allocated(&vma->node))
drivers/gpu/drm/i915/i915_vma.c +3
-1@@ -1665,7 +1655,9 @@ static void release_references(struct i915_vma *vma, bool vm_ddestroy) if (vm_ddestroy) i915_vm_resv_put(vma->vm); - __i915_vma_put(vma); + i915_active_fini(&vma->active); + GEM_WARN_ON(vma->resource); + i915_vma_free(vma); }/**
drivers/gpu/drm/i915/i915_vma.h +0
-14@@ -222,20 +222,6 @@ void i915_vma_unlink_ctx(struct i915_vma *vma);void i915_vma_close (struct i915_vma *vma);void i915_vma_reopen (struct i915_vma *vma); -static inline struct i915_vma *__i915_vma_get (struct i915_vma *vma) -{ - if (kref_get_unless_zero(&vma->ref)) - return vma; - - return NULL; -} - -void i915_vma_release (struct kref *ref); -static inline void __i915_vma_put (struct i915_vma *vma) -{ - kref_put(&vma->ref, i915_vma_release); -} -void i915_vma_destroy_locked (struct i915_vma *vma);void
i915_vma_destroy(struct i915_vma *vma);drivers/gpu/drm/i915/i915_vma_types.h +0
-0@@ -211,7 +211,6 @@ struct i915_vma { * handles (but same file) for execbuf, i.e. the number ofaliases
* that exist in thectx->handle_vmasLUT for this vma. */
- struct kref ref;
atomic_topen_count;
atomic_t flags;
/**Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Remove the vm open count
In reply to Thomas HellströmQuoted 17 lines · Thomas Hellström
vms are not getting properly closed. Rather than fixing that, Remove the vm open count and instead rely on the vm refcount.
The vm open count existed solely to break the strong references the vmas had on the vms. Now instead make those references weak and ensure vmas are destroyed when the vm is destroyed.
Unfortunately if the vm destructor and the object destructor both wants to destroy a vma, that may lead to a race in that the vm destructor just unbinds the vma and leaves the actual vma destruction to the object destructor. However in order for the object destructor to ensure the vma is unbound it needs to grab the vm mutex. In order to keep the vm mutex alive until the object destructor is done with it, somewhat hackishly grab a
vm_resvrefcount that is released late in the vma destruction process, when the vm mutex is no longer needed.
Quoted 8 lines
v2: Address review-comments from Niranjana
- Clarify that the structi915_address_space::skip_pte_rewriteis a hack and should ideally be replaced in an upcoming patch.
- Remove an unneeded continue inclear_vm_listand update comment.Co-developed-by Niranjana Vishwanathapura <[email protected]>Signed-off-by Niranjana Vishwanathapura <[email protected]>Signed-off-by Thomas Hellström <[email protected]>