Skip to contentSkip to conversation

i40e: little endian only valid checksums

PATCH In review [email protected] 2 participants 2 messages Mar 2, 2022 – Mar 8, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i40e: little endian only valid checksums

From: Tom Rix <[email protected]>

The calculation of the checksum can fail.
So move converting the checksum to little endian
to inside the return status check.

---
 drivers/net/ethernet/intel/i40e/i40e_nvm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_nvm.c +3 -2
index fe6dca846028f..3a38bf8bcde7e 100644
@@ -682,10 +682,11 @@ i40e_status i40e_update_nvm_checksum(struct i40e_hw *hw)
 	__le16 le_sum;
 
 	ret_code = i40e_calc_nvm_checksum(hw, &checksum);
-	le_sum = cpu_to_le16(checksum);
-	if (!ret_code)
+	if (!ret_code) {
+		le_sum = cpu_to_le16(checksum);
 		ret_code = i40e_write_nvm_aq(hw, 0x00, I40E_SR_SW_CHECKSUM_WORD,
 					     1, &le_sum, true);
+	}
 
 	return ret_code;
 }
Signature · 1 line
2.26.3
Tested-by on v1 1/1
#1 lore raw
Quoted 14 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of trix at redhat.com
Sent: Wednesday, March 2, 2022 6:27 PM
To: Brandeburg, Jesse <[email protected]>; Nguyen, Anthony L <[email protected]>; davem at davemloft.net; kuba at kernel.org
Cc: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org; linux- kernel at vger.kernel.org; Tom Rix <[email protected]>
Subject: [Intel-wired-lan] [PATCH] i40e: little endian only valid checksums

From: Tom Rix <[email protected]>

Quoted 9 lines

The calculation of the checksum can fail.
So move converting the checksum to little endian
to inside the return status check.

---
 drivers/net/ethernet/intel/i40e/i40e_nvm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)