rk808: Convert bindings to yaml
Subsystems (3)
v4 cover rk808: Convert bindings to yaml
From: Chris Morgan <[email protected]>
Convert the rk808 bindings into yaml format. In order to accomplish this some bindings for the rk809 had to be updated to remove non-existent vcc inputs. Additionally, some bindings for the rk805 needed to be updated to add a now-mandatory #clock-cells value.
Changes from V3:
- yamllint, dt_binding_check, and dtbs_check now returns no errors for arm and arm64.
- Updated rk809 bindings for the rk3399-pinebook-pro and the rk3399-roc-pc to remove regulator inputs vcc13 and vcc14. These are not valid regulators and appear to be holdovers from the original rk3399 schematic.
- Updated rk805 bindings for the rv1108-elgin-r1, rv1108-evb, and rk3328-a1 to add a now mandatory #clock-cells parameter.
- Made clock-output-names for rk805, rk809, and rk817 a max of 2 if the #clock-cells is 1, and a max of 1 if the #clock-cells is 0. Even though these PMICs only support a single clock output enforcing this in the schema would require us to modify the driver.
Changes from V2:
- Dropped language about battery. I'm keeping the commits entirely separate.
- Added vddio-supply for rk809 and rk818, since after examining the datasheet I can confirm such a supply exists.
Changes from V1:
- Removed generic descriptions.
- Added maxItems to clock-output-names. Max items is 2 per the driver.
- Added unevaluatedProperties as false to regulators.
- Correct i2c node.
- Added note about the battery.
Chris Morgan (3):
arm64: dts: rockchip: Remove vcc13 and vcc14 for rk808
dts: rockchip: Add #clock-cells value for rk805
dt-bindings: mfd: rk808: Convert bindings to yaml
.../devicetree/bindings/mfd/rk808.txt | 465 ------------------ .../bindings/mfd/rockchip,rk805.yaml | 219 +++++++++ .../bindings/mfd/rockchip,rk808.yaml | 257 ++++++++++ .../bindings/mfd/rockchip,rk809.yaml | 284 +++++++++++ .../bindings/mfd/rockchip,rk817.yaml | 330 +++++++++++++ .../bindings/mfd/rockchip,rk818.yaml | 282 +++++++++++ arch/arm/boot/dts/rv1108-elgin-r1.dts | 1 + arch/arm/boot/dts/rv1108-evb.dts | 1 + arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 1 + .../boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 - .../boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 - 11 files changed, 1375 insertions(+), 469 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/rk808.txt create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml
Signature · 7 lines
2.25.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v4 1/3 arm64: dts: rockchip: Remove vcc13 and vcc14 for rk808
From: Chris Morgan <[email protected]>
The Rockchip rk808 Power Management IC does not have a vcc13 or a vcc14. The schematics for at least the Pinebook Pro suggest this is actually vcc1 and vcc2, and may be an artifact from the reference design schematic).
--- arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 -- arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 -- 2 files changed, 4 deletions(-)
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +0 -2
@@ -472,8 +472,6 @@ rk808: pmic@1b { vcc10-supply = <&vcc_sysin>; vcc11-supply = <&vcc_sysin>; vcc12-supply = <&vcc3v3_sys>; - vcc13-supply = <&vcc_sysin>; - vcc14-supply = <&vcc_sysin>; regulators { /* rk3399 center logic supply */
arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi +0 -2
@@ -310,8 +310,6 @@ rk808: pmic@1b { vcc10-supply = <&vcc3v3_sys>; vcc11-supply = <&vcc3v3_sys>; vcc12-supply = <&vcc3v3_sys>; - vcc13-supply = <&vcc3v3_sys>; - vcc14-supply = <&vcc3v3_sys>; vddio-supply = <&vcc_3v0>; regulators {
Signature · 7 lines
2.25.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 1/3 v4] arm64: dts: rockchip: Remove vcc13 and vcc14 for rk808
Quoted 6 lines · Chris Morgan
From: Chris Morgan <[email protected]>
The Rockchip rk808 Power Management IC does not have a vcc13 or a vcc14. The schematics for at least the Pinebook Pro suggest this is actually vcc1 and vcc2, and may be an artifact from the reference design schematic).
Quoted 32 lines
Signed-off-by Chris Morgan <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 -- arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 2 -- 2 files changed, 4 deletions(-)arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +0
-2@@ -472,8 +472,6 @@ rk808: pmic@1b { vcc10-supply = <&vcc_sysin>; vcc11-supply = <&vcc_sysin>; vcc12-supply = <&vcc3v3_sys>; - vcc13-supply = <&vcc_sysin>; - vcc14-supply = <&vcc_sysin>; regulators { /* rk3399 center logic supply */arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi +0
-2@@ -310,8 +310,6 @@ rk808: pmic@1b { vcc10-supply = <&vcc3v3_sys>; vcc11-supply = <&vcc3v3_sys>; vcc12-supply = <&vcc3v3_sys>; - vcc13-supply = <&vcc3v3_sys>; - vcc14-supply = <&vcc3v3_sys>; vddio-supply = <&vcc_3v0>; regulators {
PATCH v4 2/3 dts: rockchip: Add #clock-cells value for rk805
In reply to Chris MorganFrom: Chris Morgan <[email protected]>
Based on a brief discussion on the mailing list it was determined that clock-cells should be a required parameter in the event that a consumer of the clock gets added in an overlay.
--- arch/arm/boot/dts/rv1108-elgin-r1.dts | 1 + arch/arm/boot/dts/rv1108-evb.dts | 1 + arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 1 + 3 files changed, 3 insertions(+)
arch/arm/boot/dts/rv1108-elgin-r1.dts +1 -0
@@ -72,6 +72,7 @@ rk805: pmic@18 { interrupt-parent = <&gpio0>; interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>; rockchip,system-power-controller; + #clock-cells = <0>; vcc1-supply = <&vcc_sys>; vcc2-supply = <&vcc_sys>;
arch/arm/boot/dts/rv1108-evb.dts +1 -0
@@ -85,6 +85,7 @@ rk805: pmic@18 { interrupt-parent = <&gpio0>; interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>; rockchip,system-power-controller; + #clock-cells = <0>; vcc1-supply = <&vcc_sys>; vcc2-supply = <&vcc_sys>;
arch/arm64/boot/dts/rockchip/rk3328-a1.dts +1 -0
@@ -160,6 +160,7 @@ pmic@18 { pinctrl-0 = <&pmic_int_l>; rockchip,system-power-controller; wakeup-source; + #clock-cells = <0>; vcc1-supply = <&vcc_sys>; vcc2-supply = <&vcc_sys>;
Signature · 7 lines
2.25.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH 2/3 v4] dts: rockchip: Add #clock-cells value for rk805
Quoted 5 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Based on a brief discussion on the mailing list it was determined that clock-cells should be a required parameter in the event that a consumer of the clock gets added in an overlay.
Quoted 43 lines
Signed-off-by Chris Morgan <[email protected]>--- arch/arm/boot/dts/rv1108-elgin-r1.dts | 1 + arch/arm/boot/dts/rv1108-evb.dts | 1 + arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 1 + 3 files changed, 3 insertions(+)arch/arm/boot/dts/rv1108-elgin-r1.dts +1
-0@@ -72,6 +72,7 @@ rk805: pmic@18 { interrupt-parent = <&gpio0>; interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>; rockchip,system-power-controller; + #clock-cells = <0>; vcc1-supply = <&vcc_sys>; vcc2-supply = <&vcc_sys>;arch/arm/boot/dts/rv1108-evb.dts +1
-0@@ -85,6 +85,7 @@ rk805: pmic@18 { interrupt-parent = <&gpio0>; interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>; rockchip,system-power-controller; + #clock-cells = <0>; vcc1-supply = <&vcc_sys>; vcc2-supply = <&vcc_sys>;arch/arm64/boot/dts/rockchip/rk3328-a1.dts +1
-0@@ -160,6 +160,7 @@ pmic@18 { pinctrl-0 = <&pmic_int_l>; rockchip,system-power-controller; wakeup-source; + #clock-cells = <0>; vcc1-supply = <&vcc_sys>; vcc2-supply = <&vcc_sys>;
PATCH v4 3/3 dt-bindings: mfd: rk808: Convert bindings to yaml
In reply to Chris MorganFrom: Chris Morgan <[email protected]>
Convert the rk808 bindings into yaml format. clock-output-names varies in maxItems depending on whether or not the clock-cells is 0 or 1. For the rk805, rk809, and rk817. This preserves behavior with the existing driver handling setting the clock for these specific PMICs. When this driver is corrected and the devicetrees updated this logic can be removed (since the rk805, rk808, and rk817 only have one actual clock).
--- .../devicetree/bindings/mfd/rk808.txt | 465 ------------------ .../bindings/mfd/rockchip,rk805.yaml | 219 +++++++++ .../bindings/mfd/rockchip,rk808.yaml | 257 ++++++++++ .../bindings/mfd/rockchip,rk809.yaml | 284 +++++++++++ .../bindings/mfd/rockchip,rk817.yaml | 330 +++++++++++++ .../bindings/mfd/rockchip,rk818.yaml | 282 +++++++++++ 6 files changed, 1372 insertions(+), 465 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/rk808.txt create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml
Documentation/devicetree/bindings/mfd/rk808.txt deleted +0 -465
@@ -1,465 +0,0 @@ -RK8XX Power Management Integrated Circuit - -The rk8xx family current members: -rk805 -rk808 -rk809 -rk817 -rk818 - -Required properties: -- compatible: "rockchip,rk805" -- compatible: "rockchip,rk808" -- compatible: "rockchip,rk809" -- compatible: "rockchip,rk817" -- compatible: "rockchip,rk818" -- reg: I2C slave address -- interrupts: the interrupt outputs of the controller. -- #clock-cells: from common clock binding; shall be set to 1 (multiple clock - outputs). See <dt-bindings/clock/rockchip,rk808.h> for clock IDs. - -Optional properties: -- clock-output-names: From common clock binding to override the - default output clock name -- rockchip,system-power-controller: Telling whether or not this pmic is controlling - the system power. -- wakeup-source: Device can be used as a wakeup source. - -Optional RK805 properties: -- vcc1-supply: The input supply for DCDC_REG1 -- vcc2-supply: The input supply for DCDC_REG2 -- vcc3-supply: The input supply for DCDC_REG3 -- vcc4-supply: The input supply for DCDC_REG4 -- vcc5-supply: The input supply for LDO_REG1 and LDO_REG2 -- vcc6-supply: The input supply for LDO_REG3 - -Optional RK808 properties: -- vcc1-supply: The input supply for DCDC_REG1 -- vcc2-supply: The input supply for DCDC_REG2 -- vcc3-supply: The input supply for DCDC_REG3 -- vcc4-supply: The input supply for DCDC_REG4 -- vcc6-supply: The input supply for LDO_REG1 and LDO_REG2 -- vcc7-supply: The input supply for LDO_REG3 and LDO_REG7 -- vcc8-supply: The input supply for SWITCH_REG1 -- vcc9-supply: The input supply for LDO_REG4 and LDO_REG5 -- vcc10-supply: The input supply for LDO_REG6 -- vcc11-supply: The input supply for LDO_REG8 -- vcc12-supply: The input supply for SWITCH_REG2 -- dvs-gpios: buck1/2 can be controlled by gpio dvs, this is GPIO specifiers - for 2 host gpio's used for dvs. The format of the gpio specifier depends in - the gpio controller. If DVS GPIOs aren't present, voltage changes will happen - very quickly with no slow ramp time. - -Optional shared RK809 and RK817 properties: -- vcc1-supply: The input supply for DCDC_REG1 -- vcc2-supply: The input supply for DCDC_REG2 -- vcc3-supply: The input supply for DCDC_REG3 -- vcc4-supply: The input supply for DCDC_REG4 -- vcc5-supply: The input supply for LDO_REG1, LDO_REG2, LDO_REG3 -- vcc6-supply: The input supply for LDO_REG4, LDO_REG5, LDO_REG6 -- vcc7-supply: The input supply for LDO_REG7, LDO_REG8, LDO_REG9 - -Optional RK809 properties: -- vcc8-supply: The input supply for SWITCH_REG1 -- vcc9-supply: The input supply for DCDC_REG5, SWITCH_REG2 - -Optional RK817 properties: -- clocks: The input clock for the audio codec -- clock-names: The clock name for the codec clock. Should be "mclk". -- #sound-dai-cells: Needed for the interpretation of sound dais. Should be 0. - -- vcc8-supply: The input supply for BOOST -- vcc9-supply: The input supply for OTG_SWITCH -- codec: The child node for the codec to hold additional properties. - If no additional properties are required for the codec, this - node can be omitted. - -- rockchip,mic-in-differential: Telling if the microphone uses differential - mode. Should be under the codec child node. - -Optional RK818 properties: -- vcc1-supply: The input supply for DCDC_REG1 -- vcc2-supply: The input supply for DCDC_REG2 -- vcc3-supply: The input supply for DCDC_REG3 -- vcc4-supply: The input supply for DCDC_REG4 -- boost-supply: The input supply for DCDC_BOOST -- vcc6-supply: The input supply for LDO_REG1 and LDO_REG2 -- vcc7-supply: The input supply for LDO_REG3, LDO_REG5 and LDO_REG7 -- vcc8-supply: The input supply for LDO_REG4, LDO_REG6 and LDO_REG8 -- vcc9-supply: The input supply for LDO_REG9 and SWITCH_REG -- h_5v-supply: The input supply for HDMI_SWITCH -- usb-supply: The input supply for OTG_SWITCH - -Regulators: All the regulators of RK8XX to be instantiated shall be -listed in a child node named 'regulators'. Each regulator is represented -by a child node of the 'regulators' node. - - regulator-name { - /* standard regulator bindings here */ - }; - -Following regulators of the RK805 PMIC regulators are supported. Note that -the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO -number as described in RK805 datasheet. - - - DCDC_REGn - - valid values for n are 1 to 4. - - LDO_REGn - - valid values for n are 1 to 3 - -Following regulators of the RK808 PMIC block are supported. Note that -the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO -number as described in RK808 datasheet. - - - DCDC_REGn - - valid values for n are 1 to 4. - - LDO_REGn - - valid values for n are 1 to 8. - - SWITCH_REGn - - valid values for n are 1 to 2 - -Following regulators of the RK809 and RK817 PMIC blocks are supported. Note that -the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO -number as described in RK809 and RK817 datasheets. - - - DCDC_REGn - - valid values for n are 1 to 5 for RK809. - - valid values for n are 1 to 4 for RK817. - - LDO_REGn - - valid values for n are 1 to 9 for RK809. - - valid values for n are 1 to 9 for RK817. - - SWITCH_REGn - - valid values for n are 1 to 2 for RK809. - - BOOST for RK817 - - OTG_SWITCH for RK817 - -Following regulators of the RK818 PMIC block are supported. Note that -the 'n' in regulator name, as in DCDC_REGn or LDOn, represents the DCDC or LDO -number as described in RK818 datasheet. - - - DCDC_REGn - - valid values for n are 1 to 4. - - LDO_REGn - - valid values for n are 1 to 9. - - SWITCH_REG - - HDMI_SWITCH - - OTG_SWITCH - -It is necessary to configure three pins for both the RK809 and RK817, the three -pins are "gpio_ts" "gpio_gt" "gpio_slp". - The gpio_gt and gpio_ts pins support the gpio function. - The gpio_slp pin is for controlling the pmic states, as below: - - reset - - power down - - sleep - -Standard regulator bindings are used inside regulator subnodes. Check - Documentation/devicetree/bindings/regulator/regulator.txt -for more details - -Example: - rk808: pmic@1b { - compatible = "rockchip,rk808"; - clock-output-names = "xin32k", "rk808-clkout2"; - interrupt-parent = <&gpio0>; - interrupts = <4 IRQ_TYPE_LEVEL_LOW>; - pinctrl-names = "default"; - pinctrl-0 = <&pmic_int &dvs_1 &dvs_2>; - dvs-gpios = <&gpio7 11 GPIO_ACTIVE_HIGH>, - <&gpio7 15 GPIO_ACTIVE_HIGH>; - reg = <0x1b>; - rockchip,system-power-controller; - wakeup-source; - #clock-cells = <1>; - - vcc8-supply = <&vcc_18>; - vcc9-supply = <&vcc_io>; - vcc10-supply = <&vcc_io>; - vcc12-supply = <&vcc_io>; - vddio-supply = <&vccio_pmu>; - - regulators { - vdd_cpu: DCDC_REG1 { - regulator-always-on; - regulator-boot-on; - regulator-min-microvolt = <750000>; - regulator-max-microvolt = <1300000>; - regulator-name = "vdd_arm"; - }; - - vdd_gpu: DCDC_REG2 { - regulator-always-on; - regulator-boot-on; - regulator-min-microvolt = <850000>; - regulator-max-microvolt = <1250000>; - regulator-name = "vdd_gpu"; - }; - - vcc_ddr: DCDC_REG3 { - regulator-always-on; - regulator-boot-on; - regulator-name = "vcc_ddr"; - }; - - vcc_io: DCDC_REG4 { - regulator-always-on; - regulator-boot-on; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - regulator-name = "vcc_io"; - }; - - vccio_pmu: LDO_REG1 { - regulator-always-on; - regulator-boot-on; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - regulator-name = "vccio_pmu"; - }; - - vcc_tp: LDO_REG2 { - regulator-always-on; - regulator-boot-on; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - regulator-name = "vcc_tp"; - }; - - vdd_10: LDO_REG3 { - regulator-always-on; - regulator-boot-on; - regulator-min-microvolt = <1000000>; - regulator-max-microvolt = <1000000>; - regulator-name = "vdd_10"; - }; - - vcc18_lcd: LDO_REG4 { - regulator-always-on; - regulator-boot-on; - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <1800000>; - regulator-name = "vcc18_lcd"; - }; - - vccio_sd: LDO_REG5 { - regulator-always-on; - regulator-boot-on; - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <3300000>; - regulator-name = "vccio_sd"; - }; - - vdd10_lcd: LDO_REG6 { - regulator-always-on; - regulator-boot-on; - regulator-min-microvolt = <1000000>; - regulator-max-microvolt = <1000000>; - regulator-name = "vdd10_lcd"; - }; - - vcc_18: LDO_REG7 { - regulator-always-on; - regulator-boot-on; - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <1800000>; - regulator-name = "vcc_18"; - }; - - vcca_codec: LDO_REG8 { - regulator-always-on; - regulator-boot-on; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - regulator-name = "vcca_codec"; - }; - - vcc_wl: SWITCH_REG1 { - regulator-always-on; - regulator-boot-on; - regulator-name = "vcc_wl"; - }; - - vcc_lcd: SWITCH_REG2 { - regulator-always-on; - regulator-boot-on; - regulator-name = "vcc_lcd"; - }; - }; - }; - - rk817: pmic@20 { - compatible = "rockchip,rk817"; - reg = <0x20>; - interrupt-parent = <&gpio0>; - interrupts = <RK_PB2 IRQ_TYPE_LEVEL_LOW>; - clock-output-names = "rk808-clkout1", "xin32k"; - clock-names = "mclk"; - clocks = <&cru SCLK_I2S1_OUT>; - pinctrl-names = "default"; - pinctrl-0 = <&pmic_int>, <&i2s1_2ch_mclk>; - wakeup-source; - #clock-cells = <1>; - #sound-dai-cells = <0>; - - vcc1-supply = <&vccsys>; - vcc2-supply = <&vccsys>; - vcc3-supply = <&vccsys>; - vcc4-supply = <&vccsys>; - vcc5-supply = <&vccsys>; - vcc6-supply = <&vccsys>; - vcc7-supply = <&vccsys>; - - regulators { - vdd_logic: DCDC_REG1 { - regulator-name = "vdd_logic"; - regulator-min-microvolt = <950000>; - regulator-max-microvolt = <1150000>; - regulator-ramp-delay = <6001>; - regulator-always-on; - regulator-boot-on; - - regulator-state-mem { - regulator-on-in-suspend; - regulator-suspend-microvolt = <950000>; - }; - }; - - vdd_arm: DCDC_REG2 { - regulator-name = "vdd_arm"; - regulator-min-microvolt = <950000>; - regulator-max-microvolt = <1350000>; - regulator-ramp-delay = <6001>; - regulator-always-on; - regulator-boot-on; - - regulator-state-mem { - regulator-off-in-suspend; - regulator-suspend-microvolt = <950000>; - }; - }; - - vcc_ddr: DCDC_REG3 { - regulator-name = "vcc_ddr"; - regulator-always-on; - regulator-boot-on; - - regulator-state-mem { - regulator-on-in-suspend; - }; - }; - - vcc_3v3: DCDC_REG4 { - regulator-name = "vcc_3v3"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - regulator-always-on; - regulator-boot-on; - - regulator-state-mem { - regulator-off-in-suspend; - regulator-suspend-microvolt = <3300000>; - }; - }; - - vcc_1v8: LDO_REG2 { - regulator-name = "vcc_1v8"; - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <1800000>; - regulator-always-on; - regulator-boot-on; - - regulator-state-mem { - regulator-on-in-suspend; - regulator-suspend-microvolt = <1800000>; - }; - }; - - vdd_1v0: LDO_REG3 { - regulator-name = "vdd_1v0"; - regulator-min-microvolt = <1000000>; - regulator-max-microvolt = <1000000>; - regulator-always-on; - regulator-boot-on; - - regulator-state-mem { - regulator-on-in-suspend; - regulator-suspend-microvolt = <1000000>; - }; - }; - - vcc3v3_pmu: LDO_REG4 { - regulator-name = "vcc3v3_pmu"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - regulator-always-on; - regulator-boot-on; - - regulator-state-mem { - regulator-on-in-suspend; - regulator-suspend-microvolt = <3300000>; - }; - }; - - vccio_sd: LDO_REG5 { - regulator-name = "vccio_sd"; - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <3300000>; - regulator-always-on; - regulator-boot-on; - - regulator-state-mem { - regulator-on-in-suspend; - regulator-suspend-microvolt = <3300000>; - }; - }; - - vcc_sd: LDO_REG6 { - regulator-name = "vcc_sd"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - regulator-boot-on; - - regulator-state-mem { - regulator-on-in-suspend; - regulator-suspend-microvolt = <3300000>; - }; - }; - - vcc_bl: LDO_REG7 { - regulator-name = "vcc_bl"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - - regulator-state-mem { - regulator-off-in-suspend; - regulator-suspend-microvolt = <3300000>; - }; - }; - - vcc_lcd: LDO_REG8 { - regulator-name = "vcc_lcd"; - regulator-min-microvolt = <2800000>; - regulator-max-microvolt = <2800000>; - - regulator-state-mem { - regulator-off-in-suspend; - regulator-suspend-microvolt = <2800000>; - }; - }; - - vcc_cam: LDO_REG9 { - regulator-name = "vcc_cam"; - regulator-min-microvolt = <3000000>; - regulator-max-microvolt = <3000000>; - - regulator-state-mem { - regulator-off-in-suspend; - regulator-suspend-microvolt = <3000000>; - }; - }; - }; - - rk817_codec: codec { - rockchip,mic-in-differential; - }; - };
Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml new file +219 -0
219 lines not on this page · raw message
Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml new file +257 -0
257 lines not on this page · raw message
Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml new file +284 -0
284 lines not on this page · raw message
Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml new file +330 -0
330 lines not on this page · raw message
Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml new file +282 -0
282 lines not on this page · raw message
Signature · 7 lines
2.25.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Rob Herring
maintainerRe: [PATCH 3/3 v4] dt-bindings: mfd: rk808: Convert bindings to yaml
Quoted 10 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Convert the rk808 bindings into yaml format. clock-output-names varies in maxItems depending on whether or not the clock-cells is 0 or 1. For the rk805, rk809, and rk817. This preserves behavior with the existing driver handling setting the clock for these specific PMICs. When this driver is corrected and the devicetrees updated this logic can be removed (since the rk805, rk808, and rk817 only have one actual clock).
Signed-off-by Chris Morgan <[email protected]>
Quoted 15 lines
--- .../devicetree/bindings/mfd/rk808.txt | 465 ------------------ .../bindings/mfd/rockchip,rk805.yaml | 219 +++++++++ .../bindings/mfd/rockchip,rk808.yaml | 257 ++++++++++ .../bindings/mfd/rockchip,rk809.yaml | 284 +++++++++++ .../bindings/mfd/rockchip,rk817.yaml | 330 +++++++++++++ .../bindings/mfd/rockchip,rk818.yaml | 282 +++++++++++ 6 files changed, 1372 insertions(+), 465 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/rk808.txt create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/rockchip,rk818.example.dt.yaml: pmic@1c: regulators: Unevaluated properties are not allowed ('DCDC_BOOST' was unexpected)
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml
doc reference errors (make refcheckdocs):Documentation/devicetree/bindings/pinctrl/pinctrl-rk805.txt: Documentation/devicetree/bindings/mfd/rk808.txt
See https://patchwork.ozlabs.org/patch/1600127
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
Re: [PATCH 3/3 v4] dt-bindings: mfd: rk808: Convert bindings to yaml
Quoted 44 lines · Rob Herring
Quoted 10 lines · Chris Morgan
From: Chris Morgan <[email protected]>
Convert the rk808 bindings into yaml format. clock-output-names varies in maxItems depending on whether or not the clock-cells is 0 or 1. For the rk805, rk809, and rk817. This preserves behavior with the existing driver handling setting the clock for these specific PMICs. When this driver is corrected and the devicetrees updated this logic can be removed (since the rk805, rk808, and rk817 only have one actual clock).
Signed-off-by Chris Morgan <[email protected]>Quoted 15 lines
--- .../devicetree/bindings/mfd/rk808.txt | 465 ------------------ .../bindings/mfd/rockchip,rk805.yaml | 219 +++++++++ .../bindings/mfd/rockchip,rk808.yaml | 257 ++++++++++ .../bindings/mfd/rockchip,rk809.yaml | 284 +++++++++++ .../bindings/mfd/rockchip,rk817.yaml | 330 +++++++++++++ .../bindings/mfd/rockchip,rk818.yaml | 282 +++++++++++ 6 files changed, 1372 insertions(+), 465 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/rk808.txt create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk818.yamlMy bot found errors running 'make DT_CHECKER_FLAGS=-m
dt_binding_check' on your patch (DT_CHECKER_FLAGSis new in v5.13):yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/rockchip,rk818.example.dt.yaml: pmic@1c: regulators: Unevaluated properties are not allowed ('DCDC_BOOST' was unexpected)
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/rockchip,rk818.yamldoc reference errors (make refcheckdocs):
Documentation/devicetree/bindings/pinctrl/pinctrl-rk805.txt:Documentation/devicetree/bindings/mfd/rk808.txtSee https://patchwork.ozlabs.org/patch/1600127
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
Quoted 8 lines
If you already ran 'make
dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:pip3 install dtschema --upgrade
Please check and re-submit.
My apologies, but yes I did in fact have an older version of the dtschema. I upgraded and it warned me of this issue, which I will fix and resubmit. Sorry.
Chris