Skip to contentSkip to conversation

scsi: aacraid: add missing manage_lock on management_fib_count

PATCH New Niels Dossche 1 participant 1 message Mar 3, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 scsi: aacraid: add missing manage_lock on management_fib_count

All other places modify the management_fib_count under the manage_lock. Avoid a possible race condition by also applying that lock in aac_src_intr_message.

---
Changes in v3:
- Improve commit message.

Changes in v2:
- Fix whitespace.

 drivers/scsi/aacraid/src.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/scsi/aacraid/src.c +2 -0
index 11ef58204e96..ca73439587ed 100644
@@ -91,7 +91,9 @@ static irqreturn_t aac_src_intr_message(int irq, void *dev_id)
 					dev->sync_fib);
 			spin_lock_irqsave(&dev->sync_fib->event_lock, sflags);
 			if (dev->sync_fib->flags & FIB_CONTEXT_FLAG_WAIT) {
+				spin_lock(&dev->manage_lock);
 				dev->management_fib_count--;
+				spin_unlock(&dev->manage_lock);
 				complete(&dev->sync_fib->event_wait);
 			}
 			spin_unlock_irqrestore(&dev->sync_fib->event_lock,
Signature · 1 line
2.35.1