KVM: arm64: Only open the interrupt window on exit due to an interrupt
Marc Zyngier
maintainerPATCH 1/1 KVM: arm64: Only open the interrupt window on exit due to an interrupt
Now that we properly account for interrupts taken whilst the guest was running, it becomes obvious that there is no need to open this accounting window if we didn't exit because of an interrupt.
This saves a number of system register accesses and other barriers if we exited for any other reason (such as a trap, for example).
--- arch/arm64/kvm/arm.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
arch/arm64/kvm/arm.c +5 -3
@@ -887,9 +887,11 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu)* context synchronization event) is necessary to ensure that * pending interrupts are taken. */ -local_irq_enable (); -isb (); -local_irq_disable (); +if (ARM_EXCEPTION_CODE (ret) ==ARM_EXCEPTION_IRQ ) { +local_irq_enable (); +isb (); +local_irq_disable (); + }guest_timing_exit_irqoff ();
Signature · 6 lines
2.34.1 _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
Quoted 8 lines · Marc Zyngier
Now that we properly account for interrupts taken whilst the guest was running, it becomes obvious that there is no need to open this accounting window if we didn't exit because of an interrupt.
This saves a number of system register accesses and other barriers if we exited for any other reason (such as a trap, for example).
Signed-off-by Marc Zyngier <[email protected]>
Mark.
Quoted 26 lines
--- arch/arm64/kvm/arm.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)arch/arm64/kvm/arm.c +5
-3@@ -887,9 +887,11 @@ int kvm_arch_vcpu_ioctl_run(struct kvm_vcpu *vcpu)* context synchronization event) is necessary to ensure that * pending interrupts are taken. */ -local_irq_enable (); -isb (); -local_irq_disable (); +if (ARM_EXCEPTION_CODE (ret) ==ARM_EXCEPTION_IRQ ) { +local_irq_enable (); +isb (); +local_irq_disable (); + }guest_timing_exit_irqoff ();Signature · 1 line
2.34.1
_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm