Skip to contentSkip to conversation

*** Add SCM and mailbox support on MSM8976 ***

PATCH Superseded Adam Skladowski 3 participants 8 messages Mar 5, 2022 – Apr 13, 2022

Subsystems (3)

v1 of 2 Superseded 2 of 4 applied Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover *** Add SCM and mailbox support on MSM8976 ***

This patch series adds support for SCM and mailbox as found on the QCOM MSM8976 platform.

Adam Skladowski (4):
dt-bindings: mailbox: Add compatible for the MSM8976
mailbox: qcom-apcs-ipc: Add compatible for MSM8976 SoC
dt-bindings: firmware: qcom-scm: Document msm8976 bindings
firmware: qcom_scm: Add compatible for MSM8976 SoC

 Documentation/devicetree/bindings/firmware/qcom,scm.txt       | 3 ++-
 .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml    | 1 +
 drivers/firmware/qcom_scm.c                                   | 4 ++++
 drivers/mailbox/qcom-apcs-ipc-mailbox.c                       | 1 +
 4 files changed, 8 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/4 dt-bindings: mailbox: Add compatible for the MSM8976

Add the mailbox compatible for the MSM8976 SoC.

---
 .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml       | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +1 -0
index 01e9d9155c836..3b5ba7ecc19d9 100644
@@ -21,6 +21,7 @@ properties:
       - qcom,msm8916-apcs-kpss-global
       - qcom,msm8939-apcs-kpss-global
       - qcom,msm8953-apcs-kpss-global
+      - qcom,msm8976-apcs-kpss-global
       - qcom,msm8994-apcs-kpss-global
       - qcom,msm8996-apcs-hmss-global
       - qcom,msm8998-apcs-hmss-global
Signature · 1 line
2.25.1
Acked-by on v1 1/4
#2 lore raw

Re: [PATCH 1/4] dt-bindings: mailbox: Add compatible for the MSM8976

Quoted 1 line · Adam Skladowski

Add the mailbox compatible for the MSM8976 SoC.

Missing empty line. With this fixed:

P.S. Please avoid some unusual formatting/bold in commit title (*** of cover letter). The subject should be informative and simple.

Quoted 10 lines
---
 .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml       | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +0 -0
index 01e9d9155c836..3b5ba7ecc19d9 100644

Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml properties: · line 27

Quoted 7 lines
Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +1 -0
@@ -21,6 +21,7 @@ properties:
       - qcom,msm8916-apcs-kpss-global
       - qcom,msm8939-apcs-kpss-global
       - qcom,msm8953-apcs-kpss-global
+      - qcom,msm8976-apcs-kpss-global
       - qcom,msm8994-apcs-kpss-global
       - qcom,msm8996-apcs-hmss-global
       - qcom,msm8998-apcs-hmss-global

Best regards,
Krzysztof

#3 lore raw

PATCH 2/4 mailbox: qcom-apcs-ipc: Add compatible for MSM8976 SoC

In reply to Adam Skladowski

MSM8976 APCS block is similar to one found in MSM8994.

---
 drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mailbox/qcom-apcs-ipc-mailbox.c +1 -0
index 9325d2abc745b..80a54d81412e3 100644
@@ -146,6 +146,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = {
 	{ .compatible = "qcom,msm8916-apcs-kpss-global", .data = &msm8916_apcs_data },
 	{ .compatible = "qcom,msm8939-apcs-kpss-global", .data = &msm8916_apcs_data },
 	{ .compatible = "qcom,msm8953-apcs-kpss-global", .data = &msm8994_apcs_data },
+	{ .compatible = "qcom,msm8976-apcs-kpss-global", .data = &msm8994_apcs_data },
 	{ .compatible = "qcom,msm8994-apcs-kpss-global", .data = &msm8994_apcs_data },
 	{ .compatible = "qcom,msm8996-apcs-hmss-global", .data = &msm8996_apcs_data },
 	{ .compatible = "qcom,msm8998-apcs-hmss-global", .data = &msm8994_apcs_data },
Signature · 1 line
2.25.1
#4 lore raw

PATCH 3/4 dt-bindings: firmware: qcom-scm: Document msm8976 bindings

In reply to Adam Skladowski

SCM driver on MSM8976 requires 3 clocks.

---
 Documentation/devicetree/bindings/firmware/qcom,scm.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/firmware/qcom,scm.txt +2 -1
index b1cd4ad1889ae..0f4e5ab264779 100644
@@ -19,6 +19,7 @@ Required properties:
  * "qcom,scm-msm8953"
  * "qcom,scm-msm8960"
  * "qcom,scm-msm8974"
+ * "qcom,scm-msm8976"
  * "qcom,scm-msm8994"
  * "qcom,scm-msm8996"
  * "qcom,scm-msm8998"
@@ -37,7 +38,7 @@ Required properties:
  * core clock required for "qcom,scm-apq8064", "qcom,scm-msm8660" and
    "qcom,scm-msm8960"
  * core, iface and bus clocks required for "qcom,scm-apq8084",
-   "qcom,scm-msm8916", "qcom,scm-msm8953" and "qcom,scm-msm8974"
+   "qcom,scm-msm8916", "qcom,scm-msm8953", "qcom,scm-msm8974" and "qcom,scm-msm8976"
 - clock-names: Must contain "core" for the core clock, "iface" for the interface
   clock and "bus" for the bus clock per the requirements of the compatible.
 - qcom,dload-mode: phandle to the TCSR hardware block and offset of the
Signature · 1 line
2.25.1
Acked-by on v1 3/4
#5 lore raw

Re: [PATCH 3/4] dt-bindings: firmware: qcom-scm: Document msm8976 bindings

Quoted 6 lines · Adam Skladowski

SCM driver on MSM8976 requires 3 clocks.

---
 Documentation/devicetree/bindings/firmware/qcom,scm.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Same as in other patches - missing blank line before SoB.

With that fixed:

Best regards,
Krzysztof

#6 lore raw

PATCH 4/4 firmware: qcom_scm: Add compatible for MSM8976 SoC

In reply to Adam Skladowski

Add compatible for SCM on MSM8976.

---
 drivers/firmware/qcom_scm.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/firmware/qcom_scm.c +4 -0
index 491bbf70c94a2..3163660fa8e29 100644
@@ -1379,6 +1379,10 @@ static const struct of_device_id qcom_scm_dt_match[] = {
 							     SCM_HAS_IFACE_CLK |
 							     SCM_HAS_BUS_CLK)
 	},
+	{ .compatible = "qcom,scm-msm8976", .data = (void *)(SCM_HAS_CORE_CLK |
+							     SCM_HAS_IFACE_CLK |
+							     SCM_HAS_BUS_CLK)
+	},
 	{ .compatible = "qcom,scm-msm8994" },
 	{ .compatible = "qcom,scm-msm8996" },
 	{ .compatible = "qcom,scm" },
Signature · 1 line
2.25.1
#7 lore raw
In reply to Adam Skladowski
This series was applied to qcom/linux.git (for-next) by Bjorn Andersson <[email protected]>:

Hello:

This series was applied to qcom/linux.git (for-next) by Bjorn Andersson <[email protected]>:

Quoted 11 lines · On Sat, 5 Mar 2022 17:49:01 +0100 you wrote:

This patch series adds support for SCM and mailbox as found on the QCOM MSM8976 platform.

Adam Skladowski (4):
dt-bindings: mailbox: Add compatible for the MSM8976
mailbox: qcom-apcs-ipc: Add compatible for MSM8976 SoC
dt-bindings: firmware: qcom-scm: Document msm8976 bindings
firmware: qcom_scm: Add compatible for MSM8976 SoC

[...]

Here is the summary with links:
- [1/4] dt-bindings: mailbox: Add compatible for the MSM8976 (no matching commit)
- [2/4] mailbox: qcom-apcs-ipc: Add compatible for MSM8976 SoC (no matching commit)
- [3/4] dt-bindings: firmware: qcom-scm: Document msm8976 bindings

    https://git.kernel.org/qcom/c/a175c6faaa36
  - [4/4] firmware: qcom_scm: Add compatible for MSM8976 SoC
    https://git.kernel.org/qcom/c/34128350b838

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html